---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56724/#review167559
---
On March 2, 2017, 10:17 p.m., Jeff Hagelberg wrote:
>
> -
: https://reviews.apache.org/r/56724/diff/5-6/
Testing
---
- Tested with java 7, java 8
- Ran full Atlas build with and without ibm-graph maven profile enabled
- No regressions
Thanks,
Jeff Hagelberg
org/r/56289/#comment238783>
typo: backend
- Jeff Hagelberg
On Feb. 24, 2017, 7:26 p.m., Neeru Gupta wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
> On Feb. 4, 2017, 6:39 p.m., Suma Shivaprasad wrote:
> > Ship It!
How will this work for composite references? At least in V0 (I guess we can
call it that), objects referenced via a composite reference need to be inlined.
- Jeff
---
ping these because of the version of Titan. It has
nothing to do with tinkerpop, right?
- Jeff Hagelberg
On Feb. 23, 2017, 8:12 p.m., Neeru Gupta wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
ding the message to just refer to the test that is throwing
the exception, ie "This test requires Gremlin2. Skipping test."
- Jeff Hagelberg
On Feb. 23, 2017, 8:12 p.m., Neeru Gupta wrote:
>
> ---
> This i
hbase
tests. Running full test suite on Linux.
Thanks,
Jeff Hagelberg
nerated e-mail. To reply, visit:
https://reviews.apache.org/r/56963/#review166467
---
On Feb. 23, 2017, 1:51 a.m., Jeff Hagelberg wrote:
>
> ---
> This is an automaticall
ffda9849e9632bff6764aed70c76a2f50f493d0d
Diff: https://reviews.apache.org/r/56963/diff/
Testing
---
Ran repository tests, everything passed on Windows except the expected hbase
tests. Running full test suite on Linux.
Thanks,
Jeff Hagelberg
/
Testing
---
- Tested with java 7, java 8
- Ran full Atlas build with and without ibm-graph maven profile enabled
- No regressions
Thanks,
Jeff Hagelberg
://reviews.apache.org/r/56724/diff/
Testing
---
- Tested with java 7, java 8
- Ran full Atlas build with and without ibm-graph maven profile enabled
- No regressions
Thanks,
Jeff Hagelberg
profile enabled
- No regressions
Thanks,
Jeff Hagelberg
/web/resources/TaxonomyServiceTest.java
<https://reviews.apache.org/r/56825/#comment237991>
Minor comment - now the transactionInitialized variable is unused and can
be removed.
- Jeff Hagelberg
On Feb. 19, 2017, 7:26 p.m., Apoorv Naik
-
webapp/src/test/java/org/apache/atlas/web/resources/TaxonomyServiceTest.java
45df9c7c6d55826c551e8b54e52b22be3a63bac0
Diff: https://reviews.apache.org/r/56856/diff/
Testing
---
TaxonomyServiceTest now passes.
Thanks,
Jeff Hagelberg
/TaxonomyServiceTest.java
45df9c7c6d55826c551e8b54e52b22be3a63bac0
Diff: https://reviews.apache.org/r/56856/diff/
Testing
---
TaxonomyServiceTest now passes.
Thanks,
Jeff Hagelberg
ter to throw a SkipException here. This way, the test will be
correctly reported as being skipped rather than passing.
- Jeff Hagelberg
On Feb. 17, 2017, 4 p.m., Neeru Gupta wrote:
>
> ---
> This is an automatically generated e-mail. To
from the war file. That is because now that is being treated as
a test dependency, which it is not. This caused the webapp tests to fail with
titan0 for me with these changes.
- Jeff Hagelberg
On Feb. 17, 2017, 4 p.m., Neeru
phdb-titan1:jar:0.8-incubating-SNAPSHOT:test
- Jeff Hagelberg
On Feb. 14, 2017, 8:38 p.m., Neeru Gupta wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visi
d my comment about the
classloader applies here as well. Can the logic be moved to some utility
method? It seems like the only thing different is the names of the properties
being used and the default value.
- Jeff Hagelberg
On Feb. 9, 2017, 12:47 a.m.,
titan1 dependency cannot be resolved.
- Jeff Hagelberg
On Feb. 10, 2017, 12:08 p.m., Neeru Gupta wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
demand
getGraphInstance();
atlasGraphInstance;
}
Generally, the Titan1GraphDatabase class should have the same basic
logic that is in Titan0GraphDatabase, but using the Titan1 classes. There
should be a single instance of Titan1Graph that is created in
Titan1GraphDatabase.getG
g from Titan. These changes fix that.
Thanks,
Jeff Hagelberg
> On Feb. 8, 2017, 3:07 p.m., Jeff Hagelberg wrote:
> > This looks good.
If you are ready for this to be committed, please upload the patch to the JIRA
and change the state of the JIRA to patch available.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56324/#review164690
---
Ship it!
This looks good.
- Jeff Hagelberg
On Feb. 8, 2017
ber of other tests that were failing sporatically
with a NullPointerException coming from Titan. These changes fix that.
Thanks,
Jeff Hagelberg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56380/#review164599
---
Ship it!
Just a few minor comments.
- Jeff Hagelberg
On Feb
ent236366>
Should this be an enumeration? I think that Jackson supports enumerations.
intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java (line 476)
<https://reviews.apache.org/r/56380/#comment236365>
It looks like this these comments are now obsolete.
3762f5569d3
webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java
9c0ccf66671ec09524b34b29bb563959db0659ef
webapp/src/test/java/org/apache/atlas/examples/QuickStartV2IT.java
952813917cd7a519bc3e6e2ae7f30c988ad9db91
webapp/src/test/java/org/apache/atlas/util/RestUtilsTest.java PRE-CREATION
webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java
18bbc3bc3e26c66885b652d9d4efdc538c31f0cc
webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java
9724c4c4bb2dc6c209cdf643d0eb4eb4856eb981
webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java
29a6d4913e3742ea54cbd4d23ca8ba439c48b23a
Diff: https://reviews.apache.org/r/56283/diff/
Testing
---
Ran full build, no regressions found
Thanks,
Jeff Hagelberg
3762f5569d3
webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java
9c0ccf66671ec09524b34b29bb563959db0659ef
webapp/src/test/java/org/apache/atlas/examples/QuickStartV2IT.java
952813917cd7a519bc3e6e2ae7f30c988ad9db91
webapp/src/test/java/org/apache/atlas/util/RestUtilsTest.java PRE-CREATION
webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java
18bbc3bc3e26c66885b652d9d4efdc538c31f0cc
webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java
9724c4c4bb2dc6c209cdf643d0eb4eb4856eb981
webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java
29a6d4913e3742ea54cbd4d23ca8ba439c48b23a
Diff: https://reviews.apache.org/r/56283/diff/
Testing
---
Ran full build, no regressions found
Thanks,
Jeff Hagelberg
va/org/apache/atlas/util/RestUtilsTest.java PRE-CREATION
webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java
18bbc3bc3e26c66885b652d9d4efdc538c31f0cc
webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java
9724c4c4bb2dc6c209cdf643d0eb4eb4856eb981
webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java
29a6d4913e3742ea54cbd4d23ca8ba439c48b23a
Diff: https://reviews.apache.org/r/56283/diff/
Testing
---
Ran full build, no regressions found
Thanks,
Jeff Hagelberg
3762f5569d3
webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java
9c0ccf66671ec09524b34b29bb563959db0659ef
webapp/src/test/java/org/apache/atlas/examples/QuickStartV2IT.java
952813917cd7a519bc3e6e2ae7f30c988ad9db91
webapp/src/test/java/org/apache/atlas/util/RestUtilsTest.java PRE-CREATION
webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java
18bbc3bc3e26c66885b652d9d4efdc538c31f0cc
webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java
9724c4c4bb2dc6c209cdf643d0eb4eb4856eb981
webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java
29a6d4913e3742ea54cbd4d23ca8ba439c48b23a
Diff: https://reviews.apache.org/r/56283/diff/
Testing
---
Ran full build, no regressions found
Thanks,
Jeff Hagelberg
is is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56283/#review164386
-------
On Feb. 7, 2017, 4:17 a.m., Jeff Hagelberg wrote:
>
> ---
> Thi
est/java/org/apache/atlas/util/RestUtilsTest.java PRE-CREATION
webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java
18bbc3bc3e26c66885b652d9d4efdc538c31f0cc
webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java
9724c4c4bb2dc6c209cdf643d0eb4eb4856eb981
webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java
29a6d4913e3742ea54cbd4d23ca8ba439c48b23a
Diff: https://reviews.apache.org/r/56283/diff/
Testing
---
Ran full build, no regressions found
Thanks,
Jeff Hagelberg
c9
webapp/src/test/java/org/apache/atlas/util/RestUtilsTest.java PRE-CREATION
webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java
18bbc3bc3e26c66885b652d9d4efdc538c31f0cc
webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java
9724c4c4bb2dc6c209cdf643d0eb4eb4856eb981
webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java
d9bffe963d421f77e25ee5ec2cc51b496281eec7
Diff: https://reviews.apache.org/r/56283/diff/
Testing
---
Ran full build, no regressions found
Thanks,
Jeff Hagelberg
t/EntitiesREST.java
510776722ea859d8d7d33d3bf22e76f989138457
webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java
aa209f98ed8151736f173a52f3e62c0eb55254c9
webapp/src/test/java/org/apache/atlas/util/RestUtilsTest.java PRE-CREATION
webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java
18bbc3bc3e26c66885b652d9d4efdc538c31f0cc
webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java
9724c4c4bb2dc6c209cdf643d0eb4eb4856eb981
webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java
d9bffe963d421f77e25ee5ec2cc51b496281eec7
Diff: https://reviews.apache.org/r/56283/diff/
Testing
---
Ran full build, no regressions found
Thanks,
Jeff Hagelberg
.java
aa209f98ed8151736f173a52f3e62c0eb55254c9
webapp/src/test/java/org/apache/atlas/util/RestUtilsTest.java PRE-CREATION
webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java
18bbc3bc3e26c66885b652d9d4efdc538c31f0cc
webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java
9724c4c4bb2dc6c209cdf643d0eb4eb4856eb981
webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java
d9bffe963d421f77e25ee5ec2cc51b496281eec7
Diff: https://reviews.apache.org/r/56283/diff/
Testing
---
Ran full build, no regressions found
Thanks,
Jeff Hagelberg
UtilsTest.java PRE-CREATION
webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java
18bbc3bc3e26c66885b652d9d4efdc538c31f0cc
webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java
9724c4c4bb2dc6c209cdf643d0eb4eb4856eb981
webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java
d9bffe963d421f77e25ee5ec2cc51b496281eec7
Diff: https://reviews.apache.org/r/56283/diff/
Testing
---
Ran full build, no regressions found
Thanks,
Jeff Hagelberg
---
Ran entire Atlas build, no regressions found.
Thanks,
Jeff Hagelberg
3537519f4d46eaba655f14e61dd4ae
shaded/hbase-server-shaded/pom.xml d8b04b00fc067cf4b85031f0f902f25da539f0f1
Diff: https://reviews.apache.org/r/54680/diff/
Testing
---
Ran full Atlas build, no regresssions found.
Thanks,
Jeff Hagelberg
f25da539f0f1
Diff: https://reviews.apache.org/r/54680/diff/
Testing
---
Ran full Atlas build, no regresssions found.
Thanks,
Jeff Hagelberg
> On Feb. 1, 2017, 10:42 a.m., Vimal Sharma wrote:
> > The cache size can grow large if the number of registered entities is high.
> > It would be good to have a cache eviction policy just like it was done for
> > DSL Query caching in ATLAS-1387
>
> Jeff Hagelbe
03ef4fe02f9b4eba273297ea954f00c9181f1f02
server-api/src/main/java/org/apache/atlas/RequestContext.java
651a71dc238a3adaac9504a77ba439785fa07ca8
Diff: https://reviews.apache.org/r/56102/diff/
Testing
---
Ran full build, no regresssions found.
Thanks,
Jeff Hagelberg
it this afternoon.
- Jeff Hagelberg
On Jan. 31, 2017, 10:54 p.m., Jeff Hagelberg wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
> On Feb. 1, 2017, 10:42 a.m., Vimal Sharma wrote:
> > The cache size can grow large if the number of registered entities is high.
> > It would be good to have a cache eviction policy just like it was done for
> > DSL Query caching in ATLAS-1387
>
> Jeff Hagelbe
VM runs out of memory.
- Jeff
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56102/#review163800
---
On Jan. 30, 2017, 10:42 p.m.,
a/org/apache/atlas/query/GremlinQuery.scala
> f7ba71a444ed327a03c061520646c868c0ba4814
>
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
> f2ca6a8fb1573755d16497236358358a07881e9c
>
> repository/src/test/java/org/apache/atlas/repository/graph/AbstractGremlinQueryOptimizerTest.java
> PRE-CREATION
>
> repository/src/test/java/org/apache/atlas/repository/graph/Gremlin2QueryOptimizerTest.java
> PRE-CREATION
>
> repository/src/test/java/org/apache/atlas/repository/graph/Gremlin3QueryOptimizerTest.java
> PRE-CREATION
>
> repository/src/test/java/org/apache/atlas/repository/graph/TestIntSequence.java
> PRE-CREATION
> repository/src/test/scala/org/apache/atlas/query/GremlinTest.scala
> 22717ff7433958142dbf126a9bd6e72bc9151d12
>
> Diff: https://reviews.apache.org/r/54680/diff/
>
>
> Testing
> ---
>
> Ran full Atlas build, no regresssions found.
>
>
> Thanks,
>
> Jeff Hagelberg
>
>
Sequence.java
PRE-CREATION
repository/src/test/scala/org/apache/atlas/query/GremlinTest.scala
22717ff7433958142dbf126a9bd6e72bc9151d12
Diff: https://reviews.apache.org/r/54680/diff/
Testing
---
Ran full Atlas build, no regresssions found.
Thanks,
Jeff Hagelberg
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56126/#review163671
---
On Jan. 31, 2017, 8:22 p.m., Jeff Hagelberg wrote:
>
> -
Atlas build, no regressions found.
Thanks,
Jeff Hagelberg
st/java/org/apache/atlas/util/CompiledQueryCacheKeyTest.java
c926f4d7d793ef095b20853277f3ba979483e039
repository/src/test/scala/org/apache/atlas/query/GremlinTest.scala
22717ff7433958142dbf126a9bd6e72bc9151d12
Diff: https://reviews.apache.org/r/54680/diff/
Testing
---
Ran full Atlas build, no regresssions found.
Thanks,
Jeff Hagelberg
place, since its scope is limited to a single request.
- Jeff
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56102/#review163592
-----
6f4d7d793ef095b20853277f3ba979483e039
repository/src/test/scala/org/apache/atlas/query/GremlinTest.scala
22717ff7433958142dbf126a9bd6e72bc9151d12
Diff: https://reviews.apache.org/r/54680/diff/
Testing
---
Ran full Atlas build, no regresssions found.
Thanks,
Jeff Hagelberg
cala
22717ff7433958142dbf126a9bd6e72bc9151d12
Diff: https://reviews.apache.org/r/54680/diff/
Testing
---
Ran full Atlas build, no regresssions found.
Thanks,
Jeff Hagelberg
cala
22717ff7433958142dbf126a9bd6e72bc9151d12
Diff: https://reviews.apache.org/r/54680/diff/
Testing
---
Ran full Atlas build, no regresssions found.
Thanks,
Jeff Hagelberg
ing that for review very soon.
- Jeff
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55443/#review163547
---
On Jan. 29, 2017, 12:18 a.m., Jeff Hagelberg wrote:
>
> -
he/atlas/repository/graph/TestIntSequence.java
PRE-CREATION
repository/src/test/scala/org/apache/atlas/query/GremlinTest.scala
22717ff7433958142dbf126a9bd6e72bc9151d12
Diff: https://reviews.apache.org/r/54680/diff/
Testing (updated)
---
Ran full Atlas build, no regresssions found.
Thanks,
Jeff Hagelberg
he/atlas/repository/graph/TestIntSequence.java
PRE-CREATION
repository/src/test/scala/org/apache/atlas/query/GremlinTest.scala
22717ff7433958142dbf126a9bd6e72bc9151d12
Diff: https://reviews.apache.org/r/54680/diff/
Testing
---
Ran repository and webapp tests, no regressions found.
Thanks,
Jeff Hagelberg
-
Ran repository and webapp tests, no regressions found.
Thanks,
Jeff Hagelberg
-
Ran repository and webapp tests, no regressions found.
Thanks,
Jeff Hagelberg
he/atlas/repository/graph/TestIntSequence.java
PRE-CREATION
repository/src/test/scala/org/apache/atlas/query/GremlinTest.scala
22717ff7433958142dbf126a9bd6e72bc9151d12
Diff: https://reviews.apache.org/r/54680/diff/
Testing
---
Ran repository and webapp tests, no regressions found.
Thanks,
Jeff Hagelberg
he/atlas/repository/graph/TestIntSequence.java
PRE-CREATION
repository/src/test/scala/org/apache/atlas/query/GremlinTest.scala
22717ff7433958142dbf126a9bd6e72bc9151d12
Diff: https://reviews.apache.org/r/54680/diff/
Testing
---
Ran repository and webapp tests, no regressions found.
Thanks,
Jeff Hagelberg
680/diff/
Testing
---
Ran repository and webapp tests, no regressions found.
Thanks,
Jeff Hagelberg
/CompiledQueryCacheKeyTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/55443/diff/
Testing
---
Ran all atlas tests, no regressions found. There were some tests that failed
both with and without these changes.
Thanks,
Jeff Hagelberg
repository/src/test/java/org/apache/atlas/util/CompiledQueryCacheKeyTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/55443/diff/
Testing
---
Ran all atlas tests, no regressions found. There were some tests that failed
both with and without these changes.
Thanks,
Jeff Hagelberg
maxCapacity;
> > }
> > }
> >
> > More details at:
> > http://docs.oracle.com/javase/7/docs/api/java/util/LinkedHashMap.html#removeEldestEntry(java.util.Map.Entry)
>
> Jeff Hagelberg wrote:
> I've changed the implementation of LruMap to
eff
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55443/#review163176
---
On Jan. 27, 2017, 5:44 p.m., Jeff Hagelb
found. There were some tests that failed
both with and without these changes.
Thanks,
Jeff Hagelberg
Diff: https://reviews.apache.org/r/55443/diff/
Testing
---
Ran all atlas tests, no regressions found. There were some tests that failed
both with and without these changes.
Thanks,
Jeff Hagelberg
b004cb52cc996763dbc4c24cd80ab545c5749358
Diff: https://reviews.apache.org/r/51092/diff/
Testing
---
Ran complete build on linux, all tests passed
Thanks,
Jeff Hagelberg
these changes.
Thanks,
Jeff Hagelberg
/resources/AdminResourceTest.java
eb2b2f6db2e7df5ca1255df7fcd87c62fbffd6e2
Diff: https://reviews.apache.org/r/55443/diff/
Testing
---
Ran all atlas tests, no regressions found. There were some tests that failed
both with and without these changes.
Thanks,
Jeff Hagelberg
: https://reviews.apache.org/r/51092/diff/
Testing
---
Ran complete build on linux, all tests passed
Thanks,
Jeff Hagelberg
: https://reviews.apache.org/r/51092/diff/
Testing
---
Ran complete build on linux, all tests passed
Thanks,
Jeff Hagelberg
files soon.
- Jeff Hagelberg
On Jan. 24, 2017, 11:22 p.m., Jeff Hagelberg wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
inconsistent with the exception message below. Once of
> > these needs to be corrected.
Good point. The original code was like that as well. I'll change the message.
- Jeff
---
This is an automatically generated e-
y at this lower level code, could help improve
> > performance.
> >
> > One approach could be to use Map<String, AtlasVertex> as the return
> > type from this method. This approach could eliminate the need for
> > NonExistentVertexHandl
build on linux, all tests passed
Thanks,
Jeff Hagelberg
:66 » AtlasService Metadata
ser...
EntityDiscoveryJerseyResourceIT.testSearchDSLLimits:87 » AtlasService
Metadata...
EntityDiscoveryJerseyResourceIT.testSearchUsingDSL:128 » AtlasService Metadata..
EntityV2JerseyResourceIT.testEntityDeduping:119 expe
/
Testing
---
Ran complete build on linux, all tests passed
Thanks,
Jeff Hagelberg
74338fd7aee2d81f54f59b0be15bd249852fbd0b
webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java
b004cb52cc996763dbc4c24cd80ab545c5749358
Diff: https://reviews.apache.org/r/51092/diff/
Testing
---
Ran complete build on linux, all tests passed
Thanks,
Jeff Hagelberg
ock.
That's a good point about the write lock, I'll fix it.
- Jeff
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55443/#review162676
------
/CompiledQueryCacheKeyTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/55443/diff/
Testing
---
Ran all atlas tests, no regressions found. There were some tests that failed
both with and without these changes.
Thanks,
Jeff Hagelberg
a7dc13db72fb4ff268312c106df1b6c41f46962f
Diff: https://reviews.apache.org/r/51092/diff/
Testing
---
Ran complete build on linux, all tests passed
Thanks,
Jeff Hagelberg
: https://reviews.apache.org/r/55443/diff/
Testing
---
Ran all atlas tests, no regressions found. There were some tests that failed
both with and without these changes.
Thanks,
Jeff Hagelberg
/BaseResourceIT.java
dcb126454b9efc0b50f6835e6dd1371f3e16d359
Diff: https://reviews.apache.org/r/55436/diff/
Testing
---
All Atlas tests run, no regressions found. There were some tests that failed
both with and without these changes.
Thanks,
Jeff Hagelberg
/BaseResourceIT.java
dcb126454b9efc0b50f6835e6dd1371f3e16d359
Diff: https://reviews.apache.org/r/55436/diff/
Testing
---
All Atlas tests run, no regressions found. There were some tests that failed
both with and without these changes.
Thanks,
Jeff Hagelberg
cters should be fine. Didn't understand the change
>
> Jeff Hagelberg wrote:
> This was causing intermittent test failures in at least the following two
> tests:
> testUpdate(org.apache.atlas.web.resources.TypesJerseyResourceIT) Time
> elapsed: 0.031 sec <<&l
cters should be fine. Didn't understand the change
>
> Jeff Hagelberg wrote:
> This was causing intermittent test failures in at least the following two
> tests:
> testUpdate(org.apache.atlas.web.resources.TypesJerseyResourceIT) Time
> elapsed: 0.031 sec <<&l
,
Jeff Hagelberg
8f2ea35d
repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala
a61ff982915684b72fe7067eea2fc2ac75d31baf
repository/src/test/java/org/apache/atlas/repository/graph/GremlinQueryOptimizerTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/54680/diff/
Testing
---
Ran repository and webapp tests, no regressions found.
Thanks,
Jeff Hagelberg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53653/#review157862
---
Ship it!
Ship It!
- Jeff Hagelberg
On Dec. 2, 2016, 4:52
> On Nov. 11, 2016, 3:01 p.m., Jeff Hagelberg wrote:
> > repository/src/main/java/org/apache/atlas/gremlin/Gremlin3ExpressionFactory.java,
> > line 278
> > <https://reviews.apache.org/r/53653/diff/1/?file=1560627#file1560627line278>
> >
> > General c
Please remove the added whitespace.
repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
<https://reviews.apache.org/r/53653/#comment225788>
Please explain why this test case is being removed.
- Jeff Hagelberg
On Nov. 11, 2016, 2:34
/GraphPersistenceStrategies.scala
3ccc53f8f1d3c9b45e93e02c815652df1def4548
repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala
447622b29e7bfd2a9bb1322fc0322b1eabac2ea8
Diff: https://reviews.apache.org/r/53133/diff/
Testing
---
Ran entire Atlas build, no issues found.
Thanks,
Jeff
/diff/
Testing
---
Built entire Atlas project, ran all unit/integration tests. No issues found.
Thanks,
Jeff Hagelberg
/
Testing
---
Built entire Atlas project, ran all unit/integration tests. No issues found.
Thanks,
Jeff Hagelberg
t; can rename this to clear instead of removeTestGraph?
> > Also initializeTestGraph can be removed for now?
>
> Jeff Hagelberg wrote:
> I suppose we could remove it. I was trying to make the interfaces as
> close as possible to what we have in our fork, and this m
s an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47810/#review150231
---
On Oct. 4, 2016, 1:28 a.m., Jeff Hagelberg wrote:
>
> ---
> This
project, ran all unit/integration tests. No issues found.
Thanks,
Jeff Hagelberg
webapp/src/test/java/org/apache/atlas/web/listeners/TestGuiceServletConfig.java
08bb125241012b6a1c1852efc6443cc7a4ebecc3
Diff: https://reviews.apache.org/r/47810/diff/
Testing
---
Built entire Atlas project, ran all unit/integration tests. No issues found.
Thanks,
Jeff Hagelberg
1 - 100 of 159 matches
Mail list logo
