Re: [VOTE] Avro release 1.6.2 (rc 1)

2012-02-14 Thread Scott Carey
- test_avro_values (Failed) Errors while running CTest On Tue, Feb 14, 2012 at 1:24 PM, Scott Carey sc...@richrelevance.comwrote: +1 Checksums match. Src tarball builds and tests pass. Integrated my applications with the test maven repo, they compile and pass tests with the new version

[jira] [Commented] (AVRO-1022) Error in validate name

2012-02-13 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207282#comment-13207282 ] Scott Carey commented on AVRO-1022: --- As late as possible also makes transitive

[jira] [Commented] (AVRO-1022) Error in validate name

2012-02-12 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206546#comment-13206546 ] Scott Carey commented on AVRO-1022: --- I see the wisdom in restricting names to be a simple

[jira] [Commented] (AVRO-1021) Fix a few name-related imperfections in Avro spec

2012-02-08 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13203813#comment-13203813 ] Scott Carey commented on AVRO-1021: --- bq. I don't think any implementation currently

[jira] [Updated] (AVRO-1007) Insufficient validation in generated specific record builder implementations

2012-02-08 Thread Scott Carey (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Carey updated AVRO-1007: -- Attachment: AVRO-1007-v4.patch This patch (v4) rebases the (v3) version to apply clean to trunk @rev

[jira] [Commented] (AVRO-1022) Error in validate name

2012-02-08 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13203831#comment-13203831 ] Scott Carey commented on AVRO-1022: --- I am fine with making the spec match what we

[jira] [Updated] (AVRO-995) Java: Update Dependencies for 1.6.2

2012-02-08 Thread Scott Carey (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Carey updated AVRO-995: - Resolution: Fixed Status: Resolved (was: Patch Available) Committed @revision 1242039

[jira] [Commented] (AVRO-1007) Insufficient validation in generated specific record builder implementations

2012-02-08 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13203869#comment-13203869 ] Scott Carey commented on AVRO-1007: --- +1 to Doug's last patch. Tests fail without the one

[jira] [Commented] (AVRO-1007) Insufficient validation in generated specific record builder implementations

2012-02-08 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13203873#comment-13203873 ] Scott Carey commented on AVRO-1007: --- Race condition: My last +1 was to the version prior

[jira] [Commented] (AVRO-1007) Insufficient validation in generated specific record builder implementations

2012-02-08 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13203883#comment-13203883 ] Scott Carey commented on AVRO-1007: --- Should this work if any of the union branches

[jira] [Commented] (AVRO-1007) Insufficient validation in generated specific record builder implementations

2012-02-08 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13203889#comment-13203889 ] Scott Carey commented on AVRO-1007: --- Slight clarification: The schema above has worked

Re: [jira] [Commented] (AVRO-1007) Insufficient validation in generated specific record builder implementations

2012-02-08 Thread Scott Carey
? Please remove me. --- On Wed, 2/8/12, Scott Carey (Commented) (JIRA) j...@apache.org wrote: From: Scott Carey (Commented) (JIRA) j...@apache.org Subject: [jira] [Commented] (AVRO-1007) Insufficient validation in generated specific record builder implementations To: dev@avro.apache.org Date: Wednesday

[jira] [Updated] (AVRO-1012) Improve avro-service-archetype: POM and IT changes

2012-02-08 Thread Scott Carey (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Carey updated AVRO-1012: -- Resolution: Fixed Status: Resolved (was: Patch Available) Committed @revision 1242069 Thanks

[jira] [Commented] (AVRO-1007) Insufficient validation in generated specific record builder implementations

2012-02-08 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13203991#comment-13203991 ] Scott Carey commented on AVRO-1007: --- I am not sure I see how this makes the Builder API

[jira] [Commented] (AVRO-1007) Insufficient validation in generated specific record builder implementations

2012-02-08 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204021#comment-13204021 ] Scott Carey commented on AVRO-1007: --- With this patch, the below tests are not consistent

[jira] [Commented] (AVRO-1024) Allow users to subclass JsonEncoder

2012-02-08 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204099#comment-13204099 ] Scott Carey commented on AVRO-1024: --- A different option from allowing modification

[jira] [Commented] (AVRO-1007) Insufficient validation in generated specific record builder implementations

2012-02-08 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204120#comment-13204120 ] Scott Carey commented on AVRO-1007: --- This approach works for me and the code is clear

[jira] [Commented] (AVRO-1011) Improve POM structure

2012-02-07 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13202582#comment-13202582 ] Scott Carey commented on AVRO-1011: --- I tend to place all of my dependency literals in one

[jira] [Issue Comment Edited] (AVRO-1011) Improve POM structure

2012-02-07 Thread Scott Carey (Issue Comment Edited) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13202582#comment-13202582 ] Scott Carey edited comment on AVRO-1011 at 2/7/12 6:13 PM: --- I

[jira] [Commented] (AVRO-1011) Improve POM structure

2012-02-07 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13202593#comment-13202593 ] Scott Carey commented on AVRO-1011: --- I will attach a patch that adds back in the removal

[jira] [Updated] (AVRO-1011) Improve POM structure

2012-02-07 Thread Scott Carey (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Carey updated AVRO-1011: -- Resolution: Fixed Fix Version/s: 1.6.2 Status: Resolved (was: Patch Available

[jira] [Commented] (AVRO-1020) Builder API fails to substitute default values for enum types

2012-02-07 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13202673#comment-13202673 ] Scott Carey commented on AVRO-1020: --- +1 Looks good, tests pass

[jira] [Commented] (AVRO-1012) Improve avro-service-archetype: POM and IT changes

2012-02-07 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13202717#comment-13202717 ] Scott Carey commented on AVRO-1012: --- I noticed that the build creates a file

[jira] [Updated] (AVRO-1018) Java: add eclipse generated files to svn ignore for protobuf, thrift, and archetype modules

2012-02-07 Thread Scott Carey (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Carey updated AVRO-1018: -- Resolution: Fixed Status: Resolved (was: Patch Available) Committed @ revision 1241700

[jira] [Commented] (AVRO-1006) Fingerprints for Avro Schemas

2012-02-07 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13203181#comment-13203181 ] Scott Carey commented on AVRO-1006: --- More notes: * Schema equivalence has a few

[jira] [Commented] (AVRO-1006) Fingerprints for Avro Schemas

2012-02-07 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13203237#comment-13203237 ] Scott Carey commented on AVRO-1006: --- {quote} I think we can fix the parser. I have been

[jira] [Commented] (AVRO-1006) Fingerprints for Avro Schemas

2012-02-07 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13203256#comment-13203256 ] Scott Carey commented on AVRO-1006: --- {quote} While representing the canonical schema

[jira] [Commented] (AVRO-1006) Fingerprints for Avro Schemas

2012-02-07 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13203284#comment-13203284 ] Scott Carey commented on AVRO-1006: --- {quote} A three string array can be encoded in Avro

[jira] [Updated] (AVRO-995) Java: Update Dependencies for 1.6.2

2012-02-07 Thread Scott Carey (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Carey updated AVRO-995: - Attachment: AVRO-995.2.patch This latest patch updates all plugin versions in the build, and updates

[jira] [Commented] (AVRO-995) Java: Update Dependencies for 1.6.2

2012-02-07 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13203301#comment-13203301 ] Scott Carey commented on AVRO-995: -- I will commit this tomorrow if there are no objections

[jira] [Updated] (AVRO-1012) Improve avro-service-archetype: POM and IT changes

2012-02-07 Thread Scott Carey (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Carey updated AVRO-1012: -- Attachment: AVRO-1012.3.patch This patch additionally moves the pom.xml filtering into the generate

[jira] [Commented] (AVRO-1021) Fix a few name-related imperfections in Avro spec

2012-02-07 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13203326#comment-13203326 ] Scott Carey commented on AVRO-1021: --- * There is a minor typo: wdepth-first

[jira] [Commented] (AVRO-1022) Error in validate name

2012-02-07 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13203328#comment-13203328 ] Scott Carey commented on AVRO-1022: --- This looks correct. We should add a unit test

[jira] [Commented] (AVRO-996) Java: SpecificRecord builder pattern object copy fails with unions in some cases

2012-02-06 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13201487#comment-13201487 ] Scott Carey commented on AVRO-996: -- +1 looks good! Java: SpecificRecord

[jira] [Commented] (AVRO-1017) org.apache.avro.generic.GenericData.resolveUnion does not deal correctly with a union of two records with (different) namespace definitions

2012-02-06 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13201797#comment-13201797 ] Scott Carey commented on AVRO-1017: --- Avro should be able to have a union of two different

[jira] [Commented] (AVRO-995) Java: Update Dependencies for 1.6.2

2012-02-06 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13201833#comment-13201833 ] Scott Carey commented on AVRO-995: -- Re: Jetty -- We shouldn't upgrade a major version

[jira] [Commented] (AVRO-1016) Expose aliases on Schema.Field

2012-02-06 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13201911#comment-13201911 ] Scott Carey commented on AVRO-1016: --- I agree, it is out of scope to go as far

[jira] [Commented] (AVRO-1011) Improve POM structure

2012-02-06 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13201934#comment-13201934 ] Scott Carey commented on AVRO-1011: --- Overall this looks good. Some things

[jira] [Commented] (AVRO-1012) Improve avro-service-archetype: POM and IT changes

2012-02-06 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13201948#comment-13201948 ] Scott Carey commented on AVRO-1012: --- Looks good. Is there any way to consolidate

[jira] [Created] (AVRO-1018) Java: add eclipse generated files to svn ignore for protobuf, thrift, and archetype modules

2012-02-06 Thread Scott Carey (Created) (JIRA)
Project: Avro Issue Type: Improvement Affects Versions: 1.6.1 Reporter: Scott Carey Assignee: Scott Carey Priority: Trivial Fix For: 1.6.2 svn:ignore is not set for eclipse project files on the projects introduced in 1.6.0

[jira] [Updated] (AVRO-1018) Java: add eclipse generated files to svn ignore for protobuf, thrift, and archetype modules

2012-02-06 Thread Scott Carey (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Carey updated AVRO-1018: -- Attachment: AVRO-1018.patch a patch that adds svn:ignore for eclipse configuration folders. (.settings

[jira] [Commented] (AVRO-1007) Insufficient validation in generated specific record builder implementations

2012-02-06 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13202043#comment-13202043 ] Scott Carey commented on AVRO-1007: --- This looks good. Do we want to make this sort

[jira] [Commented] (AVRO-1010) Improve Javadoc for CodecFactory, AvroJob and AvroOutputFormat mostly concerning compression

2012-02-06 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13202045#comment-13202045 ] Scott Carey commented on AVRO-1010: --- +1, looks good. Improve Javadoc

[jira] [Commented] (AVRO-995) Java: Update Dependencies for 1.6.2

2012-01-23 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13191866#comment-13191866 ] Scott Carey commented on AVRO-995: -- At minimum, we should upgrade Jackson from 1.8.6

[jira] [Commented] (AVRO-995) Java: Update Dependencies for 1.6.2

2012-01-23 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13191868#comment-13191868 ] Scott Carey commented on AVRO-995: -- Additionally, I will not be able to commit

[jira] [Commented] (AVRO-996) Java: SpecificRecord builder pattern object copy fails with unions in some cases

2012-01-23 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13191869#comment-13191869 ] Scott Carey commented on AVRO-996: -- I would like to see this bug fixed for 1.6.2+ but I

[jira] [Commented] (AVRO-997) Union of enum and null cannot be serialized

2012-01-19 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13189311#comment-13189311 ] Scott Carey commented on AVRO-997: -- Ah, I missed that test. In that case

[jira] [Commented] (AVRO-989) Java: Improve Builder performance in Specific API

2012-01-19 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13189642#comment-13189642 ] Scott Carey commented on AVRO-989: -- I may have some time to test it tomorrow. If I can't

[jira] [Commented] (AVRO-998) The Avro tools-jar isn't going to work in the classpath of most projects, since it has all of the dependencies inside

2012-01-18 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13188793#comment-13188793 ] Scott Carey commented on AVRO-998: -- Avro builds two versions of the tools jar: avro-tools

[jira] [Resolved] (AVRO-998) The Avro tools-jar isn't going to work in the classpath of most projects, since it has all of the dependencies inside

2012-01-18 Thread Scott Carey (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Carey resolved AVRO-998. -- Resolution: Not A Problem avro-tools jar with 'nodeps' classifier meets this requirement

[jira] [Commented] (AVRO-997) Union of enum and null cannot be serialized

2012-01-18 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13188873#comment-13188873 ] Scott Carey commented on AVRO-997: -- The following works in Avro 1.6.1, not sure about Avro

[jira] [Commented] (AVRO-997) Union of enum and null cannot be serialized

2012-01-18 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13188894#comment-13188894 ] Scott Carey commented on AVRO-997: -- If that is the case, then this is a bug

[jira] [Commented] (AVRO-997) Union of enum and null cannot be serialized

2012-01-18 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13188896#comment-13188896 ] Scott Carey commented on AVRO-997: -- As a work-around, you may be able to wrap the Enum

[jira] [Commented] (AVRO-991) Allow combining multiple Avro files within a stream. (no files on disk)

2012-01-16 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13187335#comment-13187335 ] Scott Carey commented on AVRO-991: -- {quote} A file starts with ASCII 'O'. Interpreted

[jira] [Issue Comment Edited] (AVRO-991) Allow combining multiple Avro files within a stream. (no files on disk)

2012-01-16 Thread Scott Carey (Issue Comment Edited) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13187338#comment-13187338 ] Scott Carey edited comment on AVRO-991 at 1/17/12 12:34 AM

[jira] [Commented] (AVRO-991) Allow combining multiple Avro files within a stream. (no files on disk)

2012-01-16 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13187338#comment-13187338 ] Scott Carey commented on AVRO-991: -- TO help out Tom's md5 issue, we could support user

[jira] [Commented] (AVRO-991) Allow combining multiple Avro files within a stream. (no files on disk)

2012-01-16 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13187351#comment-13187351 ] Scott Carey commented on AVRO-991: -- {quote} For the record, the thinking behind the varied

[jira] [Commented] (AVRO-993) Add methods back to GenericDatumReader that were removed in AVRO-839

2012-01-16 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13187354#comment-13187354 ] Scott Carey commented on AVRO-993: -- Looks good. My only nit is to have the javadoc link

[jira] [Commented] (AVRO-994) TestFileSpanStorage.testTonsOfSpans() fails on my slow VM

2012-01-16 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13187356#comment-13187356 ] Scott Carey commented on AVRO-994: -- +1

[jira] [Commented] (AVRO-989) Java: Improve Builder performance in Specific API

2012-01-16 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13187366#comment-13187366 ] Scott Carey commented on AVRO-989: -- Overall looks good, but there is a test failure

[jira] [Created] (AVRO-995) Java: Update Dependencies for 1.6.2

2012-01-16 Thread Scott Carey (Created) (JIRA)
Java: Update Dependencies for 1.6.2 --- Key: AVRO-995 URL: https://issues.apache.org/jira/browse/AVRO-995 Project: Avro Issue Type: Improvement Reporter: Scott Carey Assignee: Scott

[jira] [Updated] (AVRO-995) Java: Update Dependencies for 1.6.2

2012-01-16 Thread Scott Carey (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Carey updated AVRO-995: - Attachment: AVRO-995.patch Java: Update Dependencies for 1.6.2

[jira] [Commented] (AVRO-993) Add methods back to GenericDatumReader that were removed in AVRO-839

2012-01-16 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13187449#comment-13187449 ] Scott Carey commented on AVRO-993: -- Looks good. +1 Add methods back

[jira] [Created] (AVRO-996) Java: SpecificRecord builder pattern object copy fails with unions in some cases

2012-01-16 Thread Scott Carey (Created) (JIRA)
Issue Type: Bug Components: java Affects Versions: 1.6.1, 1.6.0 Reporter: Scott Carey Priority: Critical Fix For: 1.6.2, 1.7.0 I have a union of multiple records that fails to copy correctly with the MySpecificRecord.newBuilder(recordToCopy

[jira] [Updated] (AVRO-996) Java: SpecificRecord builder pattern object copy fails with unions in some cases

2012-01-16 Thread Scott Carey (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Carey updated AVRO-996: - Attachment: AVRO-996.bug.patch contains a new context.avdl with a record containing a union of records

[jira] [Commented] (AVRO-839) Implement builder pattern in generated record classes that sets default values when omitted

2012-01-10 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13183556#comment-13183556 ] Scott Carey commented on AVRO-839: -- I'm not convinced we need to do this. But here

New Avro committers: Miki Tebeka, Dona Alvarez, James Baldassari, and Tom White

2012-01-05 Thread Scott Carey
The Avro PMC has voted to add four new committers: Miki Tebeka, Dona Alvarez, James Baldassari, and Tom White Congratulations! Miki Tebeka, Dona Alvarez, and James Baldassari need to file an Individual Contributor License Agreement (ICLA) with Apache. Instructions are at:

[jira] [Commented] (AVRO-987) Make Avro OSGi ready

2012-01-05 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13180661#comment-13180661 ] Scott Carey commented on AVRO-987: -- Quick comments: * The code changes visible look good

[jira] [Commented] (AVRO-985) Remove byte-by-byte copying in RecordBuilderBase.defaultValue for non-complex types

2012-01-05 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13180913#comment-13180913 ] Scott Carey commented on AVRO-985: -- This is a big performance problem, We could use some

[jira] [Created] (AVRO-988) Java: Add public, private, and public-deprecated options for SpecificCompiler output

2012-01-05 Thread Scott Carey (Created) (JIRA)
: Avro Issue Type: Improvement Affects Versions: 1.6.1 Reporter: Scott Carey The specific compiler produces deprecation warnings in both client code and the specific generated classes themselves. The field visibility should be configurable by the user. I propose

[jira] [Updated] (AVRO-988) Java: Add public, private, and public-deprecated options for SpecificCompiler output

2012-01-05 Thread Scott Carey (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Carey updated AVRO-988: - Component/s: java Java: Add public, private, and public-deprecated options for SpecificCompiler

[jira] [Created] (AVRO-989) Java: Improve Builder performance in Specific API

2012-01-05 Thread Scott Carey (Created) (JIRA)
Reporter: Scott Carey The Specific API generates Builder objects for each record. This builder uses a boolean[] to store flags for each field to indicate whether the field is set or not. This is not space efficient, a boolean[] takes 16 bytes plus one byte per field, rounded up

[jira] [Commented] (AVRO-982) NettyTransceiver: can hang on connection interruption

2011-12-16 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13171308#comment-13171308 ] Scott Carey commented on AVRO-982: -- +1 Simple fix, great test

[jira] [Commented] (AVRO-977) Velocity templates generate deprecated java code

2011-12-13 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13168659#comment-13168659 ] Scott Carey commented on AVRO-977: -- Thanks! Velocity templates generate

[jira] [Commented] (AVRO-963) Allow compiler's template directory to be overridden in Maven plugins

2011-12-13 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13168662#comment-13168662 ] Scott Carey commented on AVRO-963: -- This is great! I'll be using it soon

[jira] [Created] (AVRO-958) C: Add Deflate compression codec support

2011-11-22 Thread Scott Carey (Created) (JIRA)
C: Add Deflate compression codec support - Key: AVRO-958 URL: https://issues.apache.org/jira/browse/AVRO-958 Project: Avro Issue Type: New Feature Reporter: Scott Carey Fix

Re: [avro] Codec deflate (#5)

2011-11-22 Thread Scott Carey
Contributions need to be attached as a patch to a JIRA ticket, we cannot pull them from github. This is for legal reasons w.r.t. licensing. You must give the Apache Foundation permission to redistribute your work (you own the copyright) under the Apache license. I have created a JIRA ticket

Re: [avro] Codec deflate (#5)

2011-11-22 Thread Scott Carey
Oh, I'm completely blind! On 11/22/11 12:13 PM, Douglas Creager dcrea...@dcreager.net wrote: Contributions need to be attached as a patch to a JIRA ticket, we cannot pull them from github. This is for legal reasons w.r.t. licensing. You must give the Apache Foundation permission to

[jira] [Resolved] (AVRO-958) C: Add Deflate compression codec support

2011-11-22 Thread Scott Carey (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Carey resolved AVRO-958. -- Resolution: Duplicate C: Add Deflate compression codec support

[jira] [Closed] (AVRO-958) C: Add Deflate compression codec support

2011-11-22 Thread Scott Carey (Closed) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Carey closed AVRO-958. C: Add Deflate compression codec support - Key

[jira] [Commented] (AVRO-951) Records with field named data collide with new builder code from specific compiler

2011-11-04 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13144220#comment-13144220 ] Scott Carey commented on AVRO-951: -- I think we can bend the version rules for this as long

[jira] [Commented] (AVRO-946) GenericData.resolveUnion() performance improvement

2011-11-01 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141582#comment-13141582 ] Scott Carey commented on AVRO-946: -- There are a few other cases where we have dealt

[jira] [Updated] (AVRO-935) Update Java dependencies for 1.6.0

2011-10-23 Thread Scott Carey (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Carey updated AVRO-935: - Attachment: AVRO-935.2.patch New patch, prevents surefire from failing tests when none are found. Also

[jira] [Commented] (AVRO-935) Update Java dependencies for 1.6.0

2011-10-23 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13133779#comment-13133779 ] Scott Carey commented on AVRO-935: -- committed in revision 1188005. Update

[jira] [Updated] (AVRO-935) Update Java dependencies for 1.6.0

2011-10-23 Thread Scott Carey (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Carey updated AVRO-935: - Resolution: Fixed Status: Resolved (was: Patch Available) Update Java dependencies for 1.6.0

[jira] [Commented] (AVRO-935) Update Java dependencies for 1.6.0

2011-10-21 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13133205#comment-13133205 ] Scott Carey commented on AVRO-935: -- I will have some time Sunday evening. If you need

[jira] [Commented] (AVRO-935) Update Java dependencies for 1.6.0

2011-10-18 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13130076#comment-13130076 ] Scott Carey commented on AVRO-935: -- Works for me, though it won't get past the compiler

Re: release 1.6.0 soon?

2011-10-17 Thread Scott Carey
, Scott Carey wrote: We should consider updating our dependencies where appropriate. * We can use a newer Apache parent project version. Maven versions report: [INFO] The following dependencies in Dependency Management have newer versions: [INFO] net.sf.jopt-simple:jopt-simple

[jira] [Created] (AVRO-935) Update Java dependencies for 1.6.0

2011-10-17 Thread Scott Carey (Created) (JIRA)
Update Java dependencies for 1.6.0 -- Key: AVRO-935 URL: https://issues.apache.org/jira/browse/AVRO-935 Project: Avro Issue Type: Improvement Components: java Reporter: Scott Carey

[jira] [Commented] (AVRO-935) Update Java dependencies for 1.6.0

2011-10-17 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13129253#comment-13129253 ] Scott Carey commented on AVRO-935: -- A few of the less obvious changes may need discussion

[jira] [Updated] (AVRO-935) Update Java dependencies for 1.6.0

2011-10-17 Thread Scott Carey (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Carey updated AVRO-935: - Status: Patch Available (was: Open) Update Java dependencies for 1.6.0

[jira] [Updated] (AVRO-935) Update Java dependencies for 1.6.0

2011-10-17 Thread Scott Carey (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Carey updated AVRO-935: - Attachment: AVRO-935.patch Patch that updates Avro Java's dependency and plugin versions. Also makes

[jira] [Commented] (AVRO-467) CMake: Complete CMake build system and remove autotools build system

2011-10-16 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13128518#comment-13128518 ] Scott Carey commented on AVRO-467: -- OK, the patch is applied. My mistake. The INSTALL

[jira] [Commented] (AVRO-467) CMake: Complete CMake build system and remove autotools build system

2011-10-15 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13128323#comment-13128323 ] Scott Carey commented on AVRO-467: -- I'd test the above patch if I knew how to apply

Re: release 1.6.0 soon?

2011-10-15 Thread Scott Carey
We should consider updating our dependencies where appropriate. * We can use a newer Apache parent project version. Maven versions report: [INFO] The following dependencies in Dependency Management have newer versions: [INFO] net.sf.jopt-simple:jopt-simple .. 3.2 -

[jira] [Commented] (AVRO-878) TestWordCount.testProjection is broken

2011-10-11 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13125567#comment-13125567 ] Scott Carey commented on AVRO-878: -- We should at some point test and be confident Java 7

Re: [jira] [Commented] (AVRO-803) Java generated Avro classes make using Avro painful and surprising

2011-10-11 Thread Scott Carey
On 10/11/11 10:53 AM, Doug Cutting cutt...@apache.org wrote: On 10/10/2011 02:51 PM, Scott Carey wrote: Does it work with stringTypeUtf8/stringType ? (Sorry, I've been unable to test many patches recently). Yes. I'm not a big fan of what our docs will say: never use the default

[jira] [Commented] (AVRO-803) Java generated Avro classes make using Avro painful and surprising

2011-10-11 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13125569#comment-13125569 ] Scott Carey commented on AVRO-803: -- I'm fine with this. Any discussion about changing

Re: [jira] [Commented] (AVRO-803) Java generated Avro classes make using Avro painful and surprising

2011-10-10 Thread Scott Carey
Does it work with stringTypeUtf8/stringType ? (Sorry, I've been unable to test many patches recently). I'm not a big fan of what our docs will say: never use the default of CharSequence, its broken. But I can live with that. On 10/10/11 10:07 AM, Doug Cutting (Commented) (JIRA)

[jira] [Commented] (AVRO-911) remove object reuse from Java APIs

2011-10-06 Thread Scott Carey (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122209#comment-13122209 ] Scott Carey commented on AVRO-911: -- For a record that is filled with primitives, re-use

<    1   2   3   4   5   6   7   >