Re: [DISCUSS] Switch to gitbox

2017-10-09 Thread Pei HE
+1 On Tue, Oct 10, 2017 at 6:31 AM, Kenneth Knowles wrote: > Sounds like wild agreement - JB will you be the one to proceed with the > process? > > On Mon, Oct 9, 2017 at 3:24 PM, Thomas Weise wrote: > > > +1 > > > > It will enable proper work with PRs in the github interface (like > > requesti

Build failed in Jenkins: beam_Release_NightlySnapshot #557

2017-10-09 Thread Apache Jenkins Server
See Changes: [aljoscha.krettek] [BEAM-3027] Correctly set output type on SourceId-stripper [klk] Allow precommits to coexist with phrase triggering [klk] Restore Python precommit [klk] Enable phrase

Re: Update on 2.2.0 release

2017-10-09 Thread Reuven Lax
I've now cut a release branch for 2.2.0. On Mon, Oct 9, 2017 at 2:01 AM, Jean-Baptiste Onofré wrote: > It sounds good to me. > > Regards > JB > > > On 10/09/2017 12:38 AM, Reuven Lax wrote: > >> At this point it's taken over three weeks to resolve release-blocking >> issues, and there are still

Re: [DISCUSS] Switch to gitbox

2017-10-09 Thread Kenneth Knowles
Sounds like wild agreement - JB will you be the one to proceed with the process? On Mon, Oct 9, 2017 at 3:24 PM, Thomas Weise wrote: > +1 > > It will enable proper work with PRs in the github interface (like > requesting reviewers, merging and closing inactive PRs, after github and > ASF IDs are

Re: [DISCUSS] Switch to gitbox

2017-10-09 Thread Thomas Weise
+1 It will enable proper work with PRs in the github interface (like requesting reviewers, merging and closing inactive PRs, after github and ASF IDs are linked) On Mon, Oct 9, 2017 at 2:52 PM, Ismaël Mejía wrote: > +1 > > On Oct 9, 2017 6:52 PM, "Thomas Groh" wrote: > > > +1. > > > > I do lo

Re: [DISCUSS] Switch to gitbox

2017-10-09 Thread Ismaël Mejía
+1 On Oct 9, 2017 6:52 PM, "Thomas Groh" wrote: > +1. > > I do love myself a forcing function for passing tests. > > On Mon, Oct 9, 2017 at 7:51 AM, Aljoscha Krettek > wrote: > > > +1 > > > > > On 6. Oct 2017, at 18:57, Kenneth Knowles > > wrote: > > > > > > Sounds great. If I recall correctly

Re: clean compile test-compile takes 8 minutes, almost 100% is findbugs

2017-10-09 Thread Kenneth Knowles
Two possibilities: (1) follow through on implementation to make the default checks just compile and unit tests, with -D allchecks add findbugs, checkstyle, etc, with longer checks run by Jenkins and during merge (2) bind findbugs to the test or verify phases, which make more sense anyhow I suppor

clean compile test-compile takes 8 minutes, almost 100% is findbugs

2017-10-09 Thread Eugene Kirpichov
I typically run the following command to sanity-check a PR: $ mvn clean compile test-compile -am -amd -Prelease -fae -pl 'sdks/java/core' This command takes 8 minutes (and 4 minutes with -T 1C) and I think it shouldn't take that long. I used the wonderful maven profiling tool https://github.com/

Re: [DISCUSS] Switch to gitbox

2017-10-09 Thread Thomas Groh
+1. I do love myself a forcing function for passing tests. On Mon, Oct 9, 2017 at 7:51 AM, Aljoscha Krettek wrote: > +1 > > > On 6. Oct 2017, at 18:57, Kenneth Knowles > wrote: > > > > Sounds great. If I recall correctly, it means we could also us > assignment / > > review requests to pass pul

Re: [DISCUSS] Dealing with differing Scala versions in Runner dependencies

2017-10-09 Thread Kenneth Knowles
+1 to the goal, and replying inline on details. On Mon, Oct 9, 2017 at 8:06 AM, Aljoscha Krettek wrote: > > - We want to update the Flink dependencies to _2.11 dependencies because > 2.10 is quite outdated - This doesn't work well because some modules (examples, for example) > depend on all R

[DISCUSS] Dealing with differing Scala versions in Runner dependencies

2017-10-09 Thread Aljoscha Krettek
Hi, We currently have a PR that is blocked because of Scala 2.10/2.11 issues: https://github.com/apache/beam/pull/3881. Short version is: - We want to update the Flink dependencies to _2.11 dependencies because 2.10 is quite outdated - This doesn't work well because some modules (examples,

Re: [DISCUSS] Switch to gitbox

2017-10-09 Thread Aljoscha Krettek
+1 > On 6. Oct 2017, at 18:57, Kenneth Knowles wrote: > > Sounds great. If I recall correctly, it means we could also us assignment / > review requests to pass pull requests around, instead of "R: foo" comments. > > On Fri, Oct 6, 2017 at 9:30 AM, Tyler Akidau > wrote: > >> +1 >> >> On Fri,

Build failed in Jenkins: beam_Release_NightlySnapshot #556

2017-10-09 Thread Apache Jenkins Server
See -- [...truncated 2.99 MB...] at org.codehaus.mojo.exec.ExecMojo.executeCommandLine(ExecMojo.java:711) at org.codehaus.mojo.exec.ExecMojo.execute(ExecMojo.j