Re: [VOTE] Release 2.1.0, release candidate #2

+1 to releasing now and working on a fix for a follow-up release. > On 8. Aug 2017, at 06:52, Jean-Baptiste Onofré wrote: > > Hi Kenn, > > As said, I just gave an extra couple of days to Stas and I to try to fix the > issue. However, we didn't fix it yet, and I'm still

Re: [VOTE] Release 2.1.0, release candidate #2

Hi Kenn, As said, I just gave an extra couple of days to Stas and I to try to fix the issue. However, we didn't fix it yet, and I'm still struggling to find the exact cause as we have different tests failures. So, I will cut RC3 as it is and we will fix the tests issue for 2.2.0 that we can

Re: [VOTE] Release 2.1.0, release candidate #2

I agree with Eugene's proposal. Suppose it takes days to grok and fix CreateStreamTest. If we compare delaying 2.1.0 versus releasing it immediately and starting 2.2.0: - Users get 2.1.0 ASAP and then 2.2.0 in days - Users get 2.1.0 in days The now-failing tests were flaky, and we have

Re: [VOTE] Release 2.1.0, release candidate #2

If https://issues.apache.org/jira/browse/BEAM-2671 is a 2.1.0 blocker then https://issues.apache.org/jira/browse/BEAM-1868 also should be, because it's a failure of another method in the same test and I suppose it indicates brokenness to the same extent. Or both shouldn't. Given the progress so

Re: [VOTE] Release 2.1.0, release candidate #2

Another quick update. Aviem updated the Jira as he and his team wants to take a look. I'm also doing a new bisect on my side. I've given an extra day to move forward. If we don't have clear statement tonight, then, I will cut the RC3 tonight or tomorrow morning (my time). Regards JB On

Re: [VOTE] Release 2.1.0, release candidate #2

Hi Eugene, Agree and thanks to have updated the Jira. I'm cutting the RC3. Thanks ! Regards JB On 08/05/2017 02:37 AM, Eugene Kirpichov wrote: I did some more investigation on that JIRA https://issues.apache.org/jira/browse/BEAM-2671 and my conclusion is: We need to postpone that JIRA to

Re: [VOTE] Release 2.1.0, release candidate #2

I did some more investigation on that JIRA https://issues.apache.org/jira/browse/BEAM-2671 and my conclusion is: We need to postpone that JIRA to 2.2.0 and finalize release 2.1.0 as-is. The TL;DR of my investigation is that: - We have some confidence that Spark runner in 2.1.0 generally works

Re: [VOTE] Release 2.1.0, release candidate #2

Another quick update. Regarding BEAM-2671, I asked help from Stas and Aviem on this one. It's our high priority as it's the main blocking issue before cutting RC3. At some point, if we are not able to move fast on this one, I would propose to cut RC3 as it is. Regards JB On 08/02/2017 08:52

Re: [VOTE] Release 2.1.0, release candidate #2

Hi, Thanks Eugene for the sumup. BEAM-2708 is now fixed. The last blocking issue for RC3 is BEAM-2671. I spent time today on this one, investigating the different issues. Agree that help from Aviem and Kenn would help for sure. Aviem already started to kindly take a look on the Jira today.

Re: [VOTE] Release 2.1.0, release candidate #2

Hi guys, We have three open issues for the 2.1.0 that we need to fix before I will be able to cut RC3: https://issues.apache.org/jira/projects/BEAM/versions/12340528 I'm working on BEAM-2671. Any help is welcome for the two other Jiras (BEAM-2587 and BEAM-2670). Thanks ! Regards JB On

Re: [CANCEL][VOTE] Release 2.1.0, release candidate #2

I created PR/3627 for cherry picking a fix for BEAM-2636. On Mon, Jul 24, 2017 at 8:20 AM Ismaël Mejía wrote: > Not a blocker but maybe it is worth considering the fix for > https://issues.apache.org/jira/browse/BEAM-2587 too. > > I also was bitten by this issue and I could

Re: [CANCEL][VOTE] Release 2.1.0, release candidate #2

Not a blocker but maybe it is worth considering the fix for https://issues.apache.org/jira/browse/BEAM-2587 too. I also was bitten by this issue and I could only get it to work by doing a 'pip install --user grpcio-tools' (not sure if this is a proper solution but it works for me), however when I

Re: [CANCEL][VOTE] Release 2.1.0, release candidate #2

I opened a PR against the release-2.1.0 branch: https://github.com/apache/beam/pull/3625 This should not fail any tests since it was recently reviewed and merged for the master. Best, Aljoscha > On 24. Jul 2017, at 14:09, Jean-Baptiste Onofré

Re: [CANCEL][VOTE] Release 2.1.0, release candidate #2

+1 Definitely good to have it for RC3. Regards JB On 07/24/2017 02:05 PM, Aljoscha Krettek wrote: When we're cutting a new RC anyways we could also include the fixes for https://issues.apache.org/jira/browse/BEAM-2571 . It's an actual bug in

Re: [CANCEL][VOTE] Release 2.1.0, release candidate #2

When we're cutting a new RC anyways we could also include the fixes for https://issues.apache.org/jira/browse/BEAM-2571 . It's an actual bug in the Flink Runner and the fix for that is a set of three fixes that should be easy to cherry-pick on

Re: [CANCEL][VOTE] Release 2.1.0, release candidate #2

We also have two tests failing in Spark runner as detailed by the following two tickets: https://issues.apache.org/jira/browse/BEAM-2670 https://issues.apache.org/jira/browse/BEAM-2671 On Mon, Jul 24, 2017 at 11:44 AM Jean-Baptiste Onofré wrote: > Hi all, > > due to

[CANCEL][VOTE] Release 2.1.0, release candidate #2

Hi all, due to https://issues.apache.org/jira/browse/BEAM-2662, I cancel this vote. We also have a build issue with the Spark runner that I would like to fix for RC3: https://builds.apache.org/view/Beam/job/beam_PostCommit_Java_ValidatesRunner_Spark/2446/ So, we are going to work on the

Re: [VOTE] Release 2.1.0, release candidate #2

Great initiative Kenn ! I will take a look. Regards JB On 07/24/2017 07:57 AM, Kenneth Knowles wrote: Nice catch. Per our discussion on RC2 and now this, I started a spreadsheet for release criteria. Template: https://s.apache.org/beam-release-validation Copy for this release:

Re: [VOTE] Release 2.1.0, release candidate #2

Nice catch. Per our discussion on RC2 and now this, I started a spreadsheet for release criteria. Template: https://s.apache.org/beam-release-validation Copy for this release: https://s.apache.org/beam-2.1.0-release-validation I just directly took the validation criteria for the 2.0.0 and put

Re: [VOTE] Release 2.1.0, release candidate #2

Hi Luke, good catch. I tested with "my" beam-samples but not with quickstart. I would consider as blocker. Let's wait for feedback from others. Depending of this feedback, I will cancel RC2 and prepare a RC3 with the PR cherry-picked. Thanks, Regards JB On 07/23/2017 10:27 PM, Lukasz Cwik

Re: [VOTE] Release 2.1.0, release candidate #2

I was going through the release, and noticed that during validation of the quickstart when using Java. The steps for using Spark were not working for me. It seems as though the version of spark-streaming_2.10 is missing from the generated archetype pom.xml. Filed

Re: [VOTE] Release 2.1.0, release candidate #2

Gently reminder, the vote is still open. Here's my +1 (binding). Regards JB On 07/18/2017 06:30 PM, Jean-Baptiste Onofré wrote: Hi everyone, Please review and vote on the release candidate #2 for the version 2.1.0, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release

Re: [VOTE] Release 2.1.0, release candidate #2

Is seem to have pip 9.0.1: ~ $ pip --version pip 9.0.1 from /usr/local/lib/python2.7/site-packages (python 2.7) > On 20. Jul 2017, at 18:07, Ahmet Altay wrote: > > Aljoscha, your issues sounds like > https://issues.apache.org/jira/browse/BEAM-2587. It is possible

Re: [VOTE] Release 2.1.0, release candidate #2

Hmm, interestingly it succeeds when I use mvn clean package -DskipTests Only when trying to run the tests will this fail with the output I posted earlier. I also made sure I have setuptools, pip, and nox. Best, Aljoscha > On 20. Jul 2017, at 13:07, Jean-Baptiste Onofré

Re: [VOTE] Release 2.1.0, release candidate #2

Thanks Kenn for the info, +1 that this should be included in a release verification guide. On Thu, Jul 20, 2017 at 2:07 PM Jean-Baptiste Onofré wrote: > Hi Aljoscha > > Do you have all python requirements installed on your machine ? > > Especially, pip, setuptools, tox, ... ?

Re: [VOTE] Release 2.1.0, release candidate #2

Hi Aljoscha Do you have all python requirements installed on your machine ? Especially, pip, setuptools, tox, ... ? It sounds like a missing Python requirement on your machine to me. Regards JB On 07/20/2017 10:36 AM, Aljoscha Krettek wrote: + 0.8 I tried running "mvn package” on my

Re: [VOTE] Release 2.1.0, release candidate #2

+ 0.8 I tried running "mvn package” on my machine build it fails. This is the log output: https://gist.github.com/aljoscha/dc194303bede8bc635e2d8b691bb58f8 . It fails when trying to build the Python part. Unfortunately I know

Re: [VOTE] Release 2.1.0, release candidate #2

+1 to the RC Relating to Aviem's question, I think we need a release verification guide, at the least as a section of the Release Guide. But if we follow through on the prior thread of having a validation matrix with manual steps people sign up for, that is even better, and saves repeated work.

Re: [VOTE] Release 2.1.0, release candidate #2

I don't understand as all jars are on the Nexus staging repository. The zip are also on staging repository. Regards JB On Jul 19, 2017, 18:47, at 18:47, Aviem Zur wrote: >@JB > >Hi, yes I saw that link, however those appear to be just the sources, >not >jars. >Do we have

Re: [VOTE] Release 2.1.0, release candidate #2

@JB Hi, yes I saw that link, however those appear to be just the sources, not jars. Do we have built RC jars us to validate which are then deployed as is to dist (renamed to remove -RC and so forth) or do we each compile these manually and are assured that the sources in the dist are the actual

Re: [VOTE] Release 2.1.0, release candidate #2

Yes, +1 on RC2. On Wed, Jul 19, 2017 at 5:10 AM, Jean-Baptiste Onofré wrote: > Hi Aviem, > > as mentioned in the first e-mail: > > - Distributions are available here: > https://dist.apache.org/repos/dist/dev/beam/2.1.0/ > > - Artifacts are on the staging repository: >

Re: [VOTE] Release 2.1.0, release candidate #2

Have the jars for RC2 been uploaded somewhere? On Wed, Jul 19, 2017 at 10:19 AM Jean-Baptiste Onofré wrote: > So, I guess you are voting +1 on RC2, correct (just for the tracking) ? > > Thanks, > Regards > JB > > On 07/19/2017 08:00 AM, Ahmet Altay wrote: > > Thank you JB. >

Re: [VOTE] Release 2.1.0, release candidate #2

So, I guess you are voting +1 on RC2, correct (just for the tracking) ? Thanks, Regards JB On 07/19/2017 08:00 AM, Ahmet Altay wrote: Thank you JB. I validated python wordcount and mobile gaming examples on Linux. Found one issue (https://issues.apache.org/jira/browse/BEAM-2636). This does

Re: [VOTE] Release 2.1.0, release candidate #2

Thank you JB. I validated python wordcount and mobile gaming examples on Linux. Found one issue (https://issues.apache.org/jira/browse/BEAM-2636). This does not need to be a blocking issue for RC2, but if we end up having a RC3 we should consider fixing this issue. Ahmet On Tue, Jul 18, 2017 at

Re: [VOTE] Release 2.1.0, release candidate #2

Thanks Kenn. SQL DSL should be ready in the next version 2.2.0, and agree to have an overall row "Add SQL DSL" instead of listing all the detailed tasks. On Tue, Jul 18, 2017 at 3:54 PM, Kenneth Knowles wrote: > Done. > > Since it is all on a feature branch and the

Re: [VOTE] Release 2.1.0, release candidate #2

Done. Since it is all on a feature branch and the release notes when it goes to master will include "Add SQL DSL" I did not associate the little bits with a release. On Tue, Jul 18, 2017 at 2:51 PM, Mingmin Xu wrote: > The tasks of SQL should not be labeled as 2.1.0, I've

Re: [VOTE] Release 2.1.0, release candidate #2

The tasks of SQL should not be labeled as 2.1.0, I've updated some with 2.2.0, fail to change the 'closed' ones. Can anyone with the permission update these tasks

Re: [VOTE] Release 2.1.0, release candidate #2

Yeah, indeed, the issue like BEAM-2171 should not have "Fix Version" set to 2.1.0. Regards JB On 07/18/2017 06:52 PM, James wrote: Just noticed that some of the DSL_SQL issues are included in this release? e.g. The first one: BEAM-2171, this is not expected,right? On Wed, 19 Jul 2017 at 12:30

Re: [VOTE] Release 2.1.0, release candidate #2

Just noticed that some of the DSL_SQL issues are included in this release? e.g. The first one: BEAM-2171, this is not expected,right? On Wed, 19 Jul 2017 at 12:30 AM Jean-Baptiste Onofré wrote: > Hi everyone, > > Please review and vote on the release candidate #2 for the

[VOTE] Release 2.1.0, release candidate #2

Hi everyone, Please review and vote on the release candidate #2 for the version 2.1.0, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The complete staging area is available for your review, which includes: * JIRA release notes