On Mon, Nov 9, 2020 at 3:32 PM Valentyn Tymofieiev
wrote:
> I actually added a commit on that PR and it still didn't work:
> https://github.com/apache/beam/pull/13242/commits/b9a872b039b5ff27b2678365ec777b64acb18a0e
> .
> I'll try to clone the PR and trigger the seed job as a workaround.
>
The
I actually added a commit on that PR and it still didn't work:
https://github.com/apache/beam/pull/13242/commits/b9a872b039b5ff27b2678365ec777b64acb18a0e
.
I'll try to clone the PR and trigger the seed job as a workaround.
On Mon, Nov 9, 2020 at 10:46 AM Udi Meiri wrote:
> Yeah, I've had that
Yeah, I've had that issue recently:
https://github.com/apache/beam/pull/13213 (seed job did not trigger)
I've personally never seen where this is configured, but it sounds like it.
What happens if you edit a file in the PR? It should make you a co-author.
On Mon, Nov 9, 2020 at 3:36 AM Kamil
Has anyone noticed problems with running "run seed job" by committers when
the author of the Pull Request is NOT a committer? For example:
https://github.com/apache/beam/pull/13242. Neither I nor Valentyn could
trigger the job. Does it mean that it's an author's username that really
matters, not a
I made my membership public and now the phrase works. (page:
https://github.com/orgs/apache/people?query=udim)
On Fri, Jul 24, 2020 at 1:04 PM Kenneth Knowles wrote:
>
>
> On Thu, Jul 23, 2020 at 1:11 PM Damian Gadomski <
> damian.gadom...@polidea.com> wrote:
>
>> Yes, I thought that
On Thu, Jul 23, 2020 at 1:11 PM Damian Gadomski
wrote:
> Yes, I thought that whitelisting apache organization will do the trick,
> but apparently, it doesn't. Actually, it makes sense as we want to allow
> only beam committers and not all apache committers. I don't know the
> implications of
Oh, with our new Jenkins that's not an issue - I have admin access there,
the issue is with checking old CI configuration, GitHub, infra stuff, etc.
FYI, all PMC members as well have admin access to the new CI and can
install plugins.
This 'fetching committers during seed job' solution should not
I have the same issue with Jenkins privileges. There's usually no insight
to test triggering logic.
For instance I happen to know that tests won't be started right now because
Infra is restarting Jenkins to install a plugin, but that's only because I
opened the ticket.
I think fetching the list
Yes, I thought that whitelisting apache organization will do the trick, but
apparently, it doesn't. Actually, it makes sense as we want to allow only
beam committers and not all apache committers. I don't know the
implications of membership in the apache github organization, but you for
instance
Thanks Damian! I saw that the config also has this:
orgWhitelist(['apache'])
Shouldn't that be enough to allow all Apache committers?
I traced the code for the membership check here:
Hi,
You are right, the current behavior is wrong, I'm currently working to fix
it asap. Our intention was to disable that only for non-committers.
As a workaround, as a committer, you could manually add yourself (your
GitHub username) to the whitelist of the SeedJob configuration:
+Damian Gadomski , it might be related to this
change: https://github.com/apache/beam/pull/12319.
/cc +Tyson Hamilton
On Wed, Jul 22, 2020 at 1:17 PM Udi Meiri wrote:
> HI,
> I'm trying to test a groovy change but I can't seem to trigger the seed
> job. It worked yesterday so I'm not sure
HI,
I'm trying to test a groovy change but I can't seem to trigger the seed
job. It worked yesterday so I'm not sure what changed.
https://github.com/apache/beam/pull/12326
smime.p7s
Description: S/MIME Cryptographic Signature
13 matches
Mail list logo
