Re: Timer support in Flink

2019-06-06 Thread Reza Rokni
I changed the font size and the wording a little, its in this PR: https://github.com/apache/beam/pull/8773 I started to mess around with moving it around to better position etc.. But then I quickly remembered why no one lets me near web pages css etc... :-) Anyone else want to enhance that PR ple

Re: Timer support in Flink

2019-06-04 Thread Robert Bradshaw
One issue with the fully expanded version is that it's so large it's hard to read. I think it would be useful to make the ~ entries (at least) clickable or with hover tool tips. It would be nice to be able to expand columns individually as well. On Tue, Jun 4, 2019 at 7:20 AM Melissa Pashniak wr

Re: Timer support in Flink

2019-06-03 Thread Melissa Pashniak
Yeah, people's eyes likely jump to the big "What is being computed?" header first and skip the small font "expand details" (that's what my eyes did anyway!) Even just moving the expand/collapse to be AFTER the header of the table (or down to the next line) and making the font bigger might help a l

Re: Timer support in Flink

2019-06-03 Thread Maximilian Michels
Good point. I think I discovered the detailed view when I made changes to the source code. Classic tunnel-vision problem :) On 30.05.19 12:57, Reza Rokni wrote: :-) https://issues.apache.org/jira/browse/BEAM-7456 On Thu, 30 May 2019 at 18:41, Alex Van Boxel > wrote:

Re: Timer support in Flink

2019-05-30 Thread Reza Rokni
:-) https://issues.apache.org/jira/browse/BEAM-7456 On Thu, 30 May 2019 at 18:41, Alex Van Boxel wrote: > Oh... you can expand the matrix. Never saw that, this could indeed be > better. So it isn't you. > > _/ > _/ Alex Van Boxel > > > On Thu, May 30, 2019 at 12:24 PM Reza Rokni wrote: > >> P

Re: Timer support in Flink

2019-05-30 Thread Alex Van Boxel
Oh... you can expand the matrix. Never saw that, this could indeed be better. So it isn't you. _/ _/ Alex Van Boxel On Thu, May 30, 2019 at 12:24 PM Reza Rokni wrote: > PS, until it was just pointed out to me by Max, I had missed the (expand > details) clickable link in the capability matrix.

Re: Timer support in Flink

2019-05-30 Thread Reza Rokni
PS, until it was just pointed out to me by Max, I had missed the (expand details) clickable link in the capability matrix. Probably just me, but do others think it's also easy to miss? If yes I will raise a Jira for it On Wed, 29 May 2019 at 19:52, Reza Rokni wrote: > Thanx Max! > > Reza >

Re: Timer support in Flink

2019-05-29 Thread Reza Rokni
Thanx Max! Reza On Wed, 29 May 2019, 16:38 Maximilian Michels, wrote: > Hi Reza, > > The detailed view of the capability matrix states: "The Flink Runner > supports timers in non-merging windows." > > That is still the case. Other than that, timers should be working fine. > > > It makes very he

Re: Timer support in Flink

2019-05-29 Thread Maximilian Michels
Hi Reza, The detailed view of the capability matrix states: "The Flink Runner supports timers in non-merging windows." That is still the case. Other than that, timers should be working fine. It makes very heavy use of Event.Time timers and has to do some manual DoFn cache work to get around