Re: [DISCUSS] Proposal to Backport `dbStorage_readAheadCacheBatchBytesSize` to BookKeeper 4.16.x

2024-06-27 Thread ZhangJian He
+1, I revisit this pr, it's quite simple and default disabled. Thanks ZhangJian He Twitter: shoothzj Wechat: shoothzj On Fri, Jun 28, 2024 at 12:01 AM Matteo Merli wrote: > > Sounds good to me. This won't add any new risk. > -- > Matteo Merli > > > > On Thu,

[ANNOUNCE] Apache BookKeeper 4.17.1 released

2024-06-26 Thread ZhangJian He
The Apache BookKeeper team is proud to announce Apache BookKeeper version 4.17.1. Apache BookKeeper is a scalable, fault-tolerant, and low-latency storage service optimized for real-time workloads. It has been used for a fundamental service to build reliable services. It is also the log segment st

[ANNOUNCE] Apache BookKeeper 4.16.6 released

2024-06-26 Thread ZhangJian He
The Apache BookKeeper team is proud to announce Apache BookKeeper version 4.16.6. Apache BookKeeper is a scalable, fault-tolerant, and low-latency storage service optimized for real-time workloads. It has been used for a fundamental service to build reliable services. It is also the log segment st

Re: [VOTE] Release 4.17.1, release candidate #0

2024-06-22 Thread ZhangJian He
The vote is now closed, and the release was approved with 3 binding votes. I will continue with the following steps. Votes: - Enrico Olivelli (binding) - Andrey Yegorov (binding) - ZhangJian He (binding) - ZhiHeng Zhang Thank you all for verifying and voting! Thanks ZhangJian He Twitter

Re: [VOTE] Release 4.16.6, release candidate #0

2024-06-22 Thread ZhangJian He
The vote is now closed, and the release was approved with 3 binding votes. I will continue with the following steps. Votes: - Enrico Olivelli (binding) - Andrey Yegorov (binding) - ZhangJian He (binding) - ZhiHeng Zhang Thank you all for verifying and voting! Thanks ZhangJian He Twitter

[VOTE] Release 4.17.1, release candidate #0

2024-06-14 Thread ZhangJian He
ree/v4.17.1-rc0 Thanks ZhangJian He Twitter: shoothzj Wechat: shoothzj

Re: [DISCUSS] BookKeeper 4.17.1 release

2024-06-14 Thread ZhangJian He
CI is passed https://github.com/apache/bookkeeper/actions/runs/9498865602. I'll start preparing for the RC as soon as I can. Thanks ZhangJian He Twitter: shoothzj Wechat: shoothzj On Tue, Jun 11, 2024 at 3:49 PM Hang Chen wrote: > +1 > > Thanks, > Hang > > ZhangJian He

[discuss] Delete 4.16.5-rc0 binary&src from dev svn

2024-06-14 Thread ZhangJian He
When I am trying to release 4.16.6, I found 4.16.5-rc0's binary is still in the dev svn. I think it's better to remove it? Am I right? Thanks ZhangJian He Twitter: shoothzj Wechat: shoothzj

[VOTE] Release 4.16.6, release candidate #0

2024-06-14 Thread ZhangJian He
ree/v4.16.6-rc0 Thanks ZhangJian He Twitter: shoothzj Wechat: shoothzj

Re: [DISCUSS] BookKeeper 4.16.6 release

2024-06-13 Thread ZhangJian He
n as I can. Thanks ZhangJian He Twitter: shoothzj Wechat: shoothzj On Fri, Jun 7, 2024 at 4:18 PM ZhangJian He wrote: > +1 for downgrade to 4.1.100.Final > > Thanks > ZhangJian He > Twitter: shoothzj > Wechat: shoothzj > > > On Fri, Jun 7, 2024 at 4:18 PM zhiheng123 <9

Re: [DISCUSS] BookKeeper 4.17.1 release

2024-06-10 Thread ZhangJian He
I have done cherry-pick, no pr in https://github.com/apache/bookkeeper/pulls?q=is%3Apr+label%3Arelease%2F4.17.1+is%3Amerged+-label%3Acherry-picked%2Fbranch-4.17 . I'll start preparing for the RC as soon as I can. Thanks ZhangJian He Twitter: shoothzj Wechat: shoothzj On Thu, Jun 6, 2024

Re: [DISCUSS] BookKeeper 4.16.6 release

2024-06-07 Thread ZhangJian He
+1 for downgrade to 4.1.100.Final Thanks ZhangJian He Twitter: shoothzj Wechat: shoothzj On Fri, Jun 7, 2024 at 4:18 PM zhiheng123 <903292...@qq.com.invalid> wrote: > I found that this exception was caused by the upgrade of netty. If you > revert netty to 4.1.100.Final, the use

Re: [DISCUSS] BookKeeper 4.17.1 release

2024-06-05 Thread ZhangJian He
anch-4.17 <https://github.com/apache/bookkeeper/actions/workflows/bk-ci.yml?query=branch%3Abranch-4.17> Although branch-4.17 CI works well, I still think it's worth cherry-picking. It actually solves a problem. Thanks ZhangJian He Twitter: shoothzj Wechat: shoothzj On Thu, Jun 6, 202

Re: [DISCUSS] Proposal for Updated JVM Support Strategy in Apache BookKeeper CI

2024-06-02 Thread ZhangJian He
ping Thanks ZhangJian He Twitter: shoothzj Wechat: shoothzj On Mon, May 27, 2024 at 9:17 AM ZhangJian He wrote: > Hi, BookKeepers, I want to propose and clarify a new CI strategy based on > our former practices. > > ## Current CI Jobs > > - **PR Validation Tests**: Current

Re: [DISCUSS] BookKeeper 4.17.1 release

2024-06-02 Thread ZhangJian He
ping Thanks ZhangJian He Twitter: shoothzj Wechat: shoothzj On Sat, May 25, 2024 at 10:47 AM ZhangJian He wrote: > Hi all, > > BookKeeper 4.17.0 was released one months ago, and I would > like to discuss the starting 4.17.1 release to include some critical > security and bug

Re: [DISCUSS] BookKeeper 4.16.6 release

2024-05-28 Thread ZhangJian He
gleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997) at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) ... 1 more ``` Thanks ZhangJian He Twitter: shoothzj Wechat: shoothzj On Tue, Ma

Re: [DISCUSS] BookKeeper 4.16.6 release

2024-05-28 Thread ZhangJian He
/pull/4400 https://github.com/apache/bookkeeper/pull/4395 Thanks ZhangJian He Twitter: shoothzj Wechat: shoothzj On Mon, May 27, 2024 at 2:57 PM Enrico Olivelli wrote: > +1 thanks > > Enrico > > Il Lun 27 Mag 2024, 08:52 Nicolò Boschi ha scritto: > > > +1 > > Th

[DISCUSS] Proposal for Updated JVM Support Strategy in Apache BookKeeper CI

2024-05-26 Thread ZhangJian He
advanced and supported JDK features and help expose more problems. Thank you for considering this strategic update. I look forward to your feedback and further discussion. [1] [JDK 11 End of Life Update](https://access.redhat.com/articles/1299013) Thanks ZhangJian He Twitter: shoothzj Wechat: shoothzj

[DISCUSS] BookKeeper 4.17.1 release

2024-05-24 Thread ZhangJian He
uide this release. Thanks ZhangJian He Twitter: shoothzj Wechat: shoothzj

[DISCUSS] BookKeeper 4.16.6 release

2024-05-24 Thread ZhangJian He
w in this thread. If there's any concern, I'd like to volunteer to guide this release. Thanks ZhangJian He Twitter: shoothzj Wechat: shoothzj

Re: BookKeeper 4.14.x EOL ?

2024-05-22 Thread ZhangJian He
+1(no-binding) Thanks ZhangJian He Twitter: shoothzj Wechat: shoothzj Nicolò Boschi 于2024年5月22日 周三17:33写道: > Hey folks, > > Now that 4.17.0 has been released, I was wondering if we should set > 4.14.x as EOL with 4.14.8 being the official last release. > I believe the pro

[DISCUSS] Introducing Typo CI Check to Apache BookKeeper

2024-05-19 Thread ZhangJian He
, etc. Second, commit typos in test files. Lastly, fix other typos and commit the lint. 1. https://github.com/crate-ci/typos 2. https://github.com/apache/bookkeeper/pull/4375/files Thanks ZhangJian He Twitter: shoothzj Wechat: shoothzj

Discussion on Default Implementation for isDriverMetadataServiceAvailable

2024-05-07 Thread ZhangJian He
ior if it's not properly overridden by all implementations. I'd suggest making this method abstract instead to avoid potential misinterpretation. Thanks ZhangJian He Twitter: shoothzj Wechat: shoothzj

Re: The 'news' section is not up-to-date

2024-05-07 Thread ZhangJian He
I also noticed that the 'upgrade' section is not up-to-date. PTAL https://github.com/apache/bookkeeper/pull/4348 Thanks ZhangJian He Twitter: shoothzj Wechat: shoothzj On Mon, May 6, 2024 at 6:46 PM ZhangJian He wrote: > I opened PR https://github.com/apache/bookkeeper/pull/43

Re: The 'news' section is not up-to-date

2024-05-06 Thread ZhangJian He
I opened PR https://github.com/apache/bookkeeper/pull/4341 using `git tag` time, also fix some grammar errors like `21st` :) Thanks ZhangJian He Twitter: shoothzj Wechat: shoothzj On Mon, May 6, 2024 at 2:04 PM ZhangJian He wrote: > I will take a look. > > Thanks > ZhangJian

Re: The 'news' section is not up-to-date

2024-05-05 Thread ZhangJian He
I will take a look. Thanks ZhangJian He Twitter: shoothzj Wechat: shoothzj On Mon, May 6, 2024 at 12:50 PM Enrico Olivelli wrote: > Hello, > I noticed that the News section is not up to date > https://bookkeeper.apache.org/releases > > Any volunteers to fix it ? > > Cheers > Enrico >

Re: [VOTE] BP-66: support throttling for zookeeper read of rereplication

2024-04-29 Thread ZhangJian He
+1(no-binding) Thanks ZhangJian He thetumbled 于2024年4月30日 周二11:06写道: > Hi, everyone.I would like to start voting thread for BP-66: support > throttling for zookeeper read of rereplication.Proposal PR:  > https://github.com/apache/bookkeeper/pull/4258 > Implementation PR: https:

Re: [DISCUSS] BP-66: support throttling for zookeeper read of rereplication

2024-04-29 Thread ZhangJian He
+0.5 for this change. And this is a zookeeper specified change, and refers to existing configuration params. I think `zkReplicationTaskRateLimit` might be better. Thanks ZhangJian He On Tue, Apr 30, 2024 at 2:07 AM Andrey Yegorov wrote: > +1 > > I am ok with the change if we maintai

Re: [discuss] Proposal to Gradually Migrate from JUnit 4 to JUnit 5

2024-04-29 Thread ZhangJian He
ar with our project before they make more valuable contributions. Thanks ZhangJian He On Mon, Apr 29, 2024 at 4:08 PM Lari Hotari wrote: > Support for JUnit 5 tests was added in > https://github.com/apache/bookkeeper/pull/4197. Junit 4 and Junit 5 tests > can co-exist in the code base. Ju

Re: [discuss] Proposal to Gradually Migrate from JUnit 4 to JUnit 5

2024-04-29 Thread ZhangJian He
t5. I created https://github.com/apache/bookkeeper/issues/4322 to track this migrate. Thanks ZhangJian He On Mon, Apr 29, 2024 at 2:39 PM Enrico Olivelli wrote: > ZhangJian > > Il giorno mer 24 apr 2024 alle ore 18:58 ZhangJian He > ha scritto: > > > I am reaching out to

[discuss] Proposal to Gradually Migrate from JUnit 4 to JUnit 5

2024-04-24 Thread ZhangJian He
ssume), parallel test execution, and other features. I think we can write new test classes using junit5, and existing-test classes can be slowly migrated. Thanks ZhangJian He

[discuss] Change scheduleAtFixedRate to scheduleWithFixedDelay in GarbageCollectorThread

2024-04-16 Thread ZhangJian He
bring considerable unnecessary data flow. I propose changing this to use scheduleWithFixedDelay instead, which ensures that there is a fixed delay period between the end of one execution and the start of the next. Thanks ZhangJian He

Re: [ANNOUNCE] New committer Wenbing Shen

2023-07-08 Thread ZhangJian He
Configurations Thanks ZhangJian He On Sun, 9 Jul 2023 at 06:51, Yan Zhao wrote: > Wenbing, Congratulatiton! > > On 2023/07/08 12:39:14 Enrico Olivelli wrote: > > Hello Bookkeepers, > > > > The Project Management Committee (PMC) for Apache BookKeeper > > has

Re: [VOTE] BP-62: Streamline batch add requests

2023-03-20 Thread ZhangJian He
+1(non-binding) Thanks ZhangJian He On Tue, 21 Mar 2023 at 08:11, Andrey Yegorov wrote: > Overall, +1. > I do have some concerns related to handling various limiters, so I left a > comment on the PR. > > On Mon, Mar 20, 2023 at 6:05 AM Hang Chen wrote: > > > Th

Re: [ANNOUNCE] Hang Chen on the Apache BookKeeper PMC

2023-03-14 Thread ZhangJian He
Congrats! Thanks ZhangJian He On Tue, 14 Mar 2023 at 19:12, Yunze Xu wrote: > Congrats! > > Thanks, > Yunze > > On Tue, Mar 14, 2023 at 6:57 PM Max Xu wrote: > > > > Congratulations! Hang. well deserved > > > > Best, > > Max Xu > > &

Re: The CI tests didn't cover bookkeeper V2 protocol.

2023-02-20 Thread ZhangJian He
+1 Thanks ZhangJian He On Tue, 21 Feb 2023 at 10:08, Hang Chen wrote: > +1 for Yong's suggestion. > > Thanks, > Hang > > Yan Zhao 于2023年2月20日周一 16:55写道: > > > > > According to the original PR's motivation > > > <https://gith

Re: Prometheus metrics provider > upgrade dataskeches lib

2023-02-13 Thread ZhangJian He
Hi, Salvi. I have tried it in https://github.com/apache/bookkeeper/pull/3264 and sent an issue to https://github.com/apache/datasketches-java/issues/398 You can see these for details. Recently, I had no time to keep working on this. Thank you for working on this. Thanks ZhangJian He On Mon, 13

Re: [DISCUSS] BookKeeper 4.14.7 release

2023-02-08 Thread ZhangJian He
+1 Thanks ZhangJian He On Wed, 8 Feb 2023 at 16:45, steven lu wrote: > +1 > > Hang Chen 于2023年2月8日周三 15:16写道: > > > Hi everyone, > > > > One core dump issue[1] related to RocksDB was introduced by [2] and > > released in BookKeeper 4.14.6. To fix the Rocks

Re: [ANNOUNCE] New Committer Steven Lu

2022-10-14 Thread ZhangJian He
Congratulations! Thanks ZhangJian He On Fri, 14 Oct 2022 at 19:02, Max Xu wrote: > Congratulations! Steven > > Best, > Max Xu > > > On Fri, Oct 14, 2022 at 3:25 PM Enrico Olivelli > wrote: > > > Hello BookKeepers, > > I am happy to announce that

Re: [DISCUSS] BP-58 Change the API for org.apache.bookkeeper.stats.Counter

2022-09-25 Thread ZhangJian He
+1 (non-binding) Thanks ZhangJian He On Sun, 25 Sept 2022 at 20:45, Enrico Olivelli wrote: > I agree > > Enrico > > Il Dom 25 Set 2022, 03:09 steven lu ha scritto: > > > Hi BookKeepers, I've changed the API for > > org.apache.bookkeeper.stats.Counter: &

Re: [VOTE] BP-57 Add a public API for creating embeddable servers

2022-09-25 Thread ZhangJian He
+1 , non binding Thanks ZhangJian He On Sun, 25 Sept 2022 at 21:56, Lan Liang wrote: > +1 , non binding. > > This is a useful feature! > > > > > > > > > Best Regards, > Lan Liang > Replied Message > | From | steven lu | > | Date | 9/25/

Re: [VOTE] BP-56: Support data migration

2022-09-15 Thread ZhangJian He
+1 non-binding Thanks ZhangJian He On Fri, 16 Sept 2022 at 14:27, Enrico Olivelli wrote: > +1 (binding) > > Enrico > > Il giorno ven 16 set 2022 alle ore 08:26 r...@apache.org > ha scritto: > > > > LGTM +1 > > > > On 2022/09/15 04:47:25 lordcheng

Re: [DISCUSS] Unify the import order in bookkeeper

2022-07-28 Thread ZhangJian He
https://github.com/apache/bookkeeper/pull/3311 is ready for review. Thanks ZhangJian He On Sun, 5 Jun 2022 at 16:43, ZhangJian He wrote: > Hi community, I want to open a discussion about importOrder in bookkeeper. > > Currently, we use puppycrawl checkstyle 6.19, which is not strict

Re: [DISCUSS] Bookkeeper 4.16.0 release

2022-07-14 Thread ZhangJian He
Hi, Hang Chen. I hope to get this change into version 4.16.0. https://github.com/apache/bookkeeper/pull/3406 Thanks ZhangJian He Hang Chen 于2022年7月15日周五 11:32写道: > Hi Community, >Bookkeeper 4.15.0 has been released for 2 months, and we have > introduced Direct IO support[1] for l

Re: microbenchmark depends on JMH which is licensed by GPLv2

2022-07-05 Thread ZhangJian He
I created https://github.com/apache/bookkeeper/pull/3385 to solve this. ping @enrico @merlimat Thanks ZhangJian He ZhangJian He 于2022年7月6日周三 14:17写道: > Hi tison. Thank you for telling us about this. > I will work on remove `microbenchmark` module. > > Thanks > ZhangJian He >

Re: microbenchmark depends on JMH which is licensed by GPLv2

2022-07-05 Thread ZhangJian He
Hi tison. Thank you for telling us about this. I will work on remove `microbenchmark` module. Thanks ZhangJian He tison 于2022年7月4日周一 15:37写道: > Hi BookKeepers, > > I notice that the main repo of bookkeeper has a module named microbenchmark > which depends on jmh-core[1] which is

Re: Start to remove gradle from project

2022-06-06 Thread ZhangJian He
@sreeam Hi, sreeam. I haven't consider Bazel yet. Currently encountering some problems on gradle, we still using maven for release. IMO, using Bazel doesn't solve problems we meet(No active volunteers solve build problems). Thanks ZhangJian He sreeram duvur 于2022年6月7日周二 05:15写道:

Start to remove gradle from project

2022-06-06 Thread ZhangJian He
have active committers who familiar with gradle Thanks ZhangJian He

[DISCUSS] Unify the import order in bookkeeper

2022-06-05 Thread ZhangJian He
Hi community, I want to open a discussion about importOrder in bookkeeper. Currently, we use puppycrawl checkstyle 6.19, which is not strictly verify the import order. In the recently checkstyle version, it needs a strictly ImportOrder verify if configs[1]. In simple terms, our config ImportOrder

[BP-52] Build and Run Bookkeeper on Java11

2022-06-05 Thread ZhangJian He
Hello community, I want to open a discussion about build bookkeeper on java11 ## Motivation Currently, bookkeeper keeps the compatible with java8. Java11, a lts version of jdk, provides new features and performance optimization. And Java11 was released in 2018 and is now mature. I think it's time t

[discuss] Buildsystems, keep gradle or maven in future

2022-04-27 Thread ZhangJian He
Hello, everyone. After talking with enrico and nicolo. I want to start a discussion about building systems. We are now maintaining two build systems, I don't think that we want to maintain both `maven` and `gradle`. I think that we need to decide to keep maven or gradle in the future. Personally,

replace some gradle check using maven instead

2022-04-15 Thread ZhangJian He
Hello, now we have backward-compat-tests and pr-validation step Generate Javadoc.I will try to make pr check consistent with release. Thanks ZhangJian He

Re: BookKeeper 4.14.5 - drop Log4J and move to Reload4J?

2022-04-01 Thread ZhangJian He
+1 agree with Nicolò Thanks ZhangJian He Nicolò Boschi 于2022年4月1日周五 21:20写道: > Enrico, I agree with you and that was what I meant. > > To be clear: > 4.14.3 and older: Log4J 1 > 4.14.5 and 4.14.6...: Reload4J > 4.15.0 and next: Log4J2 > > Nicolò Boschi > > >

Re: [ANNOUNCE] new BookKeeper Committer Nicolò Boschi

2022-03-30 Thread ZhangJian He
Congratulations Nicolò ! Thanks ZhangJian He Matteo Minardi 于2022年3月30日周三 17:36写道: > Congratulations Nico, well deserved!! > > Matteo > On 30 Mar 2022, 09:16 +0200, Enrico Olivelli , wrote: > > The Project Management Committee (PMC) for Apache BookKeeper > > has invited