Jenkins build is back to normal : brooklyn-master-build #1130

See

Re: Bundles in Brooklyn

+1 to this approach, but I suspect there's a lot more to discuss/plan. _*Leaking OSGi*_ I agree with Geoff's worry of us "leaking OSGi". However, we should just "leak" the semantics of bundle dependencies and versioning, which need to be explained to the user. I think we can avoid exposing the

Re: Versions in Brooklyn

+1; sounds sensible. You said /"I propose we resolve this by recommending a version syntax which fits what most things people are doing and which is bi-di mappable to OSGi"/. To clarify, I think you're saying we recommend a version syntax like of 1.0.0-SNAPSHOT (and discourage 1.0-SNAPSHOT),

[GitHub] brooklyn-server issue #737: Clean up inference around parsing `name:version`...

Github user geomacy commented on the issue: https://github.com/apache/brooklyn-server/pull/737 @ahgittin haven't ignored this but haven't been able to find the bandwidth to look at it - will be off tomorrow, but will look at this and related PRs on Monday! --- If your project is s

[GitHub] brooklyn-docs pull request #198: [WIP] Versioning

Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/198#discussion_r123557270 --- Diff: guide/blueprints/catalog/versioning.md --- @@ -3,18 +3,118 @@ title: Versioning layout: website-normal --- -### Version

[GitHub] brooklyn-docs pull request #198: [WIP] Versioning

Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/198#discussion_r123558404 --- Diff: guide/blueprints/catalog/versioning.md --- @@ -3,18 +3,118 @@ title: Versioning layout: website-normal --- -### Version

[GitHub] brooklyn-docs pull request #198: [WIP] Versioning

Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/198#discussion_r123556880 --- Diff: guide/blueprints/catalog/bundle.md --- @@ -5,7 +5,25 @@ layout: website-normal ### Bundling Catalog Resources -It is p

[GitHub] brooklyn-server issue #742: DefaultAzureArmNetworkCreator improvements

Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/742 LGTM, also see the comments I just added to https://github.com/apache/brooklyn-server/pull/739 --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] brooklyn-server issue #739: A default network is now created when deploying ...

Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/739 The most important from above comments is that `location` (which is region in brooklyn speak) could not be set, using the jclouds' default. Would be useful to have that improved. Another

[GitHub] brooklyn-server pull request #739: A default network is now created when dep...

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/739#discussion_r123533239 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/creator/DefaultAzureArmNetworkCreator.java --- @@ -0,0 +1,

[GitHub] brooklyn-server issue #743: Version new rules

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/743 unrelated non-det test failure `org.apache.brooklyn.entity.group.SequenceGroupTest.testGroupWithMatchingFilterReturnsEverythingThatMatches` --- If your project is set up for it, you can re

[GitHub] brooklyn-server pull request #739: A default network is now created when dep...

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/739#discussion_r123531214 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/creator/DefaultAzureArmNetworkCreator.java --- @@ -0,0 +1,

[GitHub] brooklyn-server pull request #739: A default network is now created when dep...

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/739#discussion_r123530475 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/creator/DefaultAzureArmNetworkCreator.java --- @@ -0,0 +1,

[GitHub] brooklyn-server pull request #739: A default network is now created when dep...

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/739#discussion_r123529723 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/creator/DefaultAzureArmNetworkCreator.java --- @@ -0,0 +1,

[GitHub] brooklyn-server pull request #739: A default network is now created when dep...

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/739#discussion_r123528419 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/creator/DefaultAzureArmNetworkCreator.java --- @@ -0,0 +1,

[GitHub] brooklyn-server issue #742: DefaultAzureArmNetworkCreator improvements

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/742 Squashed into single commit; merging as soon as jenkins build finishes again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] brooklyn-server pull request #743: Version new rules

GitHub user ahgittin opened a pull request: https://github.com/apache/brooklyn-server/pull/743 Version new rules Implements the behaviour discussed on ML re version syntax. Places where OSGi syntax is required (ie registering/searching OSGi bundles) convert to the OSGi synt

[GitHub] brooklyn-server issue #742: DefaultAzureArmNetworkCreator improvements

Github user Graeme-Miller commented on the issue: https://github.com/apache/brooklyn-server/pull/742 lgtm thanks @aledsage --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] brooklyn-docs pull request #200: Fixed advanced example by shipping blueprin...

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-docs/pull/200 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] brooklyn-server issue #742: DefaultAzureArmNetworkCreator improvements

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/742 p.s. I'll squash together my two commits before we merge this! So please ping me with any other suggested changes, or if you think it's good to merge. --- If your project is set up for it,

[GitHub] brooklyn-docs pull request #200: Fixed advanced example by shipping blueprin...

GitHub user Graeme-Miller opened a pull request: https://github.com/apache/brooklyn-docs/pull/200 Fixed advanced example by shipping blueprints in repo You can merge this pull request into a Git repository by running: $ git pull https://github.com/Graeme-Miller/brooklyn-docs

[GitHub] brooklyn-server issue #742: DefaultAzureArmNetworkCreator improvements

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/742 @Graeme-Miller incorporated review comments. Note that I've deleted some of the `verify` assertions. For example, I don't think it's worth calling `verify(azureComputeApi).getVirtualNetwork

Jenkins build is back to stable : brooklyn-dist-master #105

See

[GitHub] brooklyn-server pull request #742: DefaultAzureArmNetworkCreator improvement...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/742#discussion_r123496290 --- Diff: locations/jclouds/src/test/java/org/apache/brooklyn/location/jclouds/networking/creator/DefaultAzureArmNetworkCreatorTest.java --- @@ -9

[GitHub] brooklyn-server pull request #742: DefaultAzureArmNetworkCreator improvement...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/742#discussion_r123495340 --- Diff: locations/jclouds/src/test/java/org/apache/brooklyn/location/jclouds/networking/creator/DefaultAzureArmNetworkCreatorTest.java --- @@ -2

[GitHub] brooklyn-ui pull request #46: Update maven-compiler-plugin to 3.6.1

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-ui/pull/46 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] brooklyn-dist pull request #97: Update maven-compiler-plugin to 3.6.1

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-dist/pull/97 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] brooklyn-dist issue #97: Update maven-compiler-plugin to 3.6.1

Github user neykov commented on the issue: https://github.com/apache/brooklyn-dist/pull/97 Builds fine for me, merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[GitHub] brooklyn-ui issue #46: Update maven-compiler-plugin to 3.6.1

Github user neykov commented on the issue: https://github.com/apache/brooklyn-ui/pull/46 Builds fine for me, merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] brooklyn-server pull request #741: Update maven-compiler-plugin to 3.6.1

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/741 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] brooklyn-server issue #741: Update maven-compiler-plugin to 3.6.1

Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/741 Builds fine for me, merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] brooklyn-ui pull request #46: Update maven-compiler-plugin to 3.6.1

GitHub user bostko opened a pull request: https://github.com/apache/brooklyn-ui/pull/46 Update maven-compiler-plugin to 3.6.1 Related to https://github.com/apache/brooklyn-dist/pull/97 and https://github.com/apache/brooklyn-server/pull/741 You can merge this pull request into a Git

[GitHub] brooklyn-dist pull request #97: Update maven-compiler-plugin to 3.6.1

GitHub user bostko opened a pull request: https://github.com/apache/brooklyn-dist/pull/97 Update maven-compiler-plugin to 3.6.1 Related to https://github.com/apache/brooklyn-server/pull/741 You can merge this pull request into a Git repository by running: $ git pull https://git

[GitHub] brooklyn-server issue #741: Update maven-compiler-plugin to 3.6.1

Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/741 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server pull request #742: DefaultAzureArmNetworkCreator improvement...

Github user Graeme-Miller commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/742#discussion_r123482786 --- Diff: locations/jclouds/src/test/java/org/apache/brooklyn/location/jclouds/networking/creator/DefaultAzureArmNetworkCreatorTest.java ---

[GitHub] brooklyn-server pull request #742: DefaultAzureArmNetworkCreator improvement...

Github user Graeme-Miller commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/742#discussion_r123482551 --- Diff: locations/jclouds/src/test/java/org/apache/brooklyn/location/jclouds/networking/creator/DefaultAzureArmNetworkCreatorTest.java ---

[GitHub] brooklyn-server pull request #742: DefaultAzureArmNetworkCreator improvement...

GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/742 DefaultAzureArmNetworkCreator improvements * Don’t use RETURNS_DEEP_STUBS as causes non-deterministic test failure on my dev machine (ClassCastException when calling `thenReturn(...

[GitHub] brooklyn-server pull request #741: Update maven-compiler-plugin to 3.6.1

GitHub user bostko opened a pull request: https://github.com/apache/brooklyn-server/pull/741 Update maven-compiler-plugin to 3.6.1 I think since we upgrade java it will be useful to have later maven-compiler-plugin. If you approve this change, I will do the same PR for brooklyn-

Re: Versions in Brooklyn

Makes sense. > On 22.06.2017 г., at 12:27, Alex Heneveld > wrote: > > > inline > > On 22/06/2017 10:10, Svetoslav Neykov wrote: >> +1 to the proposal. >> >> One thing I have reservations about is having a recommended version syntax >> with other formats still supported but deprecated. >> A

Re: Versions in Brooklyn

inline On 22/06/2017 10:10, Svetoslav Neykov wrote: +1 to the proposal. One thing I have reservations about is having a recommended version syntax with other formats still supported but deprecated. As far as I understand the recommended syntax is there so we can guarantee a uniqueness of the

Re: Versions in Brooklyn

+1 to the proposal. One thing I have reservations about is having a recommended version syntax with other formats still supported but deprecated. As far as I understand the recommended syntax is there so we can guarantee a uniqueness of the OSGi versions (when the source version is unique). Inst

[GitHub] brooklyn-server pull request #739: A default network is now created when dep...

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/739 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] brooklyn-server issue #739: A default network is now created when deploying ...

Github user drigodwin commented on the issue: https://github.com/apache/brooklyn-server/pull/739 I'm going to merge this now, thankyou @Graeme-Miller! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] brooklyn-server issue #738: Delete deprecated ApplicationBuilder

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/738 @ahgittin changing a bunch of tests to extend `BrooklynAppUnitTestSupport` might well have sped things up (before the change, some of their `setUp` method created a normal `LocalManagementC

[jira] [Updated] (BROOKLYN-519) Persisting yaml blueprint with $brooklyn:entitySpec stores all configs

[ https://issues.apache.org/jira/browse/BROOKLYN-519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Valentin Aitken updated BROOKLYN-519: - Description: Scenario: # Deploy the blueprint: {noformat} location: localhost services: