[GitHub] brooklyn-server issue #743: Version new rules

Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/743 LGTM retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

Jenkins build is back to normal : brooklyn-client-master #58

See

[GitHub] brooklyn-server pull request #745: Azure ARM default network fixes from PR s...

GitHub user Graeme-Miller opened a pull request: https://github.com/apache/brooklyn-server/pull/745 Azure ARM default network fixes from PR suggestions Important Note: Azure ARM doesn't currently work with the master of Brooklyn. Currently, after a Azure ARM VM is created, JClouds a

[GitHub] brooklyn-docs pull request #201: Update location structure

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-docs/pull/201 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] brooklyn-server issue #745: Azure ARM default network fixes from PR suggesti...

Github user duncangrant commented on the issue: https://github.com/apache/brooklyn-server/pull/745 Tested with a location with no virtual network set but with overrideAuthenticateSudo set to true. Tested with a specified virtual network. --- If your project is set up for it, you

[GitHub] brooklyn-server pull request #734: Support ConfigKey deprecated names

Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/734#discussion_r123985528 --- Diff: core/src/main/java/org/apache/brooklyn/core/location/AbstractLocation.java --- @@ -215,6 +216,16 @@ public AbstractLocation configure(Map

[GitHub] brooklyn-server pull request #734: Support ConfigKey deprecated names

Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/734#discussion_r123979478 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/config/ConfigBag.java --- @@ -421,14 +430,22 @@ public Object getStringKey(String key) {

[GitHub] brooklyn-server pull request #734: Support ConfigKey deprecated names

Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/734#discussion_r123965177 --- Diff: core/src/main/java/org/apache/brooklyn/core/config/BasicConfigKey.java --- @@ -365,6 +384,7 @@ public boolean isValueValid(T value) {

[GitHub] brooklyn-server pull request #734: Support ConfigKey deprecated names

Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/734#discussion_r124008032 --- Diff: core/src/test/java/org/apache/brooklyn/core/config/ConfigKeyDeprecationTest.java --- @@ -0,0 +1,328 @@ +/* + * Licensed to the Ap

[GitHub] brooklyn-server pull request #734: Support ConfigKey deprecated names

Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/734#discussion_r124001663 --- Diff: core/src/test/java/org/apache/brooklyn/core/config/ConfigKeyDeprecationRebindTest.java --- @@ -0,0 +1,373 @@ +/* + * Licensed to

[GitHub] brooklyn-server pull request #734: Support ConfigKey deprecated names

Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/734#discussion_r123992282 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/config/ConfigBag.java --- @@ -518,6 +574,46 @@ protected Object getStringKey(String key,

[GitHub] brooklyn-server pull request #734: Support ConfigKey deprecated names

Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/734#discussion_r123979492 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/config/ConfigBag.java --- @@ -421,14 +430,22 @@ public Object getStringKey(String key) {

[GitHub] brooklyn-server pull request #734: Support ConfigKey deprecated names

Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/734#discussion_r123991510 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/config/ConfigBag.java --- @@ -507,6 +525,44 @@ protected Object getStringKey(String key,

[GitHub] brooklyn-server pull request #734: Support ConfigKey deprecated names

Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/734#discussion_r124009325 --- Diff: core/src/test/java/org/apache/brooklyn/core/config/ConfigKeyDeprecationTest.java --- @@ -0,0 +1,328 @@ +/* + * Licensed to the Ap

[GitHub] brooklyn-server pull request #745: Azure ARM default network fixes from PR s...

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/745#discussion_r124042243 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/creator/DefaultAzureArmNetworkCreator.java --- @@ -64,57 +

[GitHub] brooklyn-server pull request #745: Azure ARM default network fixes from PR s...

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/745#discussion_r124042939 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/creator/DefaultAzureArmNetworkCreator.java --- @@ -64,57 +

[GitHub] brooklyn-server issue #745: Azure ARM default network fixes from PR suggesti...

Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/745 * re azure jclouds 2.0.1 not having enough functionality - the changes here (and in previous PR) will create the default network, but will not assign it to the nodes because `ipOptions` doesn

[GitHub] brooklyn-server pull request #737: Clean up inference around parsing `name:v...

Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/737#discussion_r124018550 --- Diff: camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/BrooklynComponentTemplateResolver.java --- @@ -82,7 +79,6

[GitHub] brooklyn-server pull request #737: Clean up inference around parsing `name:v...

Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/737#discussion_r124014747 --- Diff: core/src/main/java/org/apache/brooklyn/core/typereg/RegisteredTypeNaming.java --- @@ -0,0 +1,111 @@ +/* + * Licensed to the Apach

[GitHub] brooklyn-server pull request #737: Clean up inference around parsing `name:v...

Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/737#discussion_r124013780 --- Diff: core/src/main/java/org/apache/brooklyn/core/typereg/RegisteredTypeNaming.java --- @@ -0,0 +1,111 @@ +/* + * Licensed to the Apach

[GitHub] brooklyn-server pull request #737: Clean up inference around parsing `name:v...

Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/737#discussion_r124058288 --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/BasicBrooklynCatalog.java --- @@ -855,24 +893,50 @@ private boolean attemptT

[GitHub] brooklyn-server pull request #737: Clean up inference around parsing `name:v...

Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/737#discussion_r124033012 --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/BasicBrooklynCatalog.java --- @@ -855,24 +893,50 @@ private boolean attemptT

[GitHub] brooklyn-server pull request #737: Clean up inference around parsing `name:v...

Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/737#discussion_r124025405 --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/BasicBrooklynCatalog.java --- @@ -601,14 +602,34 @@ private void collectCata

[GitHub] brooklyn-server issue #737: Clean up inference around parsing `name:version`...

Github user geomacy commented on the issue: https://github.com/apache/brooklyn-server/pull/737 Would also be interested in @neykov's comments on this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

Jenkins build is unstable: brooklyn-master-build #1134

See