jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r360760579
##
File path: src/butil/string_printf.h
##
@@ -45,6 +46,27 @@ int string_appendf(std::string* output, const char* format,
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r360761754
##
File path: src/brpc/redis_command.cpp
##
@@ -18,45 +18,30 @@
// Authors: Ge,Jun (ge...@baidu.com)
#include "butil/lo
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r360763133
##
File path: src/brpc/redis_reply.h
##
@@ -94,6 +122,9 @@ class RedisReply {
// Returns PARSE_ERROR_ABSOLUTELY_WRONG
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r360761555
##
File path: src/brpc/redis_reply.cpp
##
@@ -37,12 +39,65 @@ const char* RedisReplyTypeToString(RedisReplyType type) {
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r360760870
##
File path: src/brpc/redis_reply.h
##
@@ -200,11 +286,16 @@ inline const char* RedisReply::error_message() const {
}
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r360761223
##
File path: src/brpc/redis_reply.h
##
@@ -56,6 +59,29 @@ class RedisReply {
bool is_string() const; // True if the
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r359138143
##
File path: src/brpc/redis_command.cpp
##
@@ -360,4 +360,87 @@ butil::Status RedisCommandByComponents(butil::IOBuf*
outp
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r359138777
##
File path: src/brpc/redis.h
##
@@ -209,7 +213,74 @@ class RedisResponse : public ::google::protobuf::Message {
std::ost
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r359143686
##
File path: src/brpc/redis_reply.cpp
##
@@ -37,6 +38,61 @@ const char* RedisReplyTypeToString(RedisReplyType type) {
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r359140168
##
File path: src/brpc/redis.h
##
@@ -209,7 +213,74 @@ class RedisResponse : public ::google::protobuf::Message {
std::ost
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r359139447
##
File path: src/brpc/redis.h
##
@@ -209,7 +213,74 @@ class RedisResponse : public ::google::protobuf::Message {
std::ost
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r359138612
##
File path: src/brpc/redis.h
##
@@ -192,7 +196,7 @@ class RedisResponse : public ::google::protobuf::Message {
stati
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r359141418
##
File path: src/brpc/redis_reply.h
##
@@ -137,14 +174,26 @@ inline std::ostream& operator<<(std::ostream& os, const
Redi
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r359141767
##
File path: src/brpc/redis_reply.h
##
@@ -200,7 +286,12 @@ inline const char* RedisReply::error_message() const {
}
i
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r359141192
##
File path: src/brpc/redis_reply.cpp
##
@@ -352,4 +413,56 @@ void RedisReply::CopyFromDifferentArena(const RedisReply&
o
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r359142218
##
File path: test/brpc_redis_unittest.cpp
##
@@ -547,4 +550,636 @@ TEST_F(RedisTest, quote_and_escape) {
request.Clea
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r359138399
##
File path: src/brpc/policy/redis_protocol.cpp
##
@@ -52,62 +54,202 @@ struct InputResponse : public InputMessageBase {
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r359141036
##
File path: src/brpc/redis_reply.cpp
##
@@ -37,6 +38,61 @@ const char* RedisReplyTypeToString(RedisReplyType type) {
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r359137068
##
File path: src/brpc/policy/redis_protocol.cpp
##
@@ -52,62 +54,202 @@ struct InputResponse : public InputMessageBase {
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r358590090
##
File path: src/brpc/redis_reply.h
##
@@ -137,14 +180,24 @@ inline std::ostream& operator<<(std::ostream& os, const
Redi
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r358047288
##
File path: src/brpc/redis.cpp
##
@@ -435,5 +435,31 @@ std::ostream& operator<<(std::ostream& os, const
RedisResponse& r
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r358590004
##
File path: src/brpc/redis_reply.h
##
@@ -160,6 +213,46 @@ inline int64_t RedisReply::integer() const {
return 0;
}
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r358585429
##
File path: src/brpc/policy/redis_protocol.cpp
##
@@ -52,62 +54,202 @@ struct InputResponse : public InputMessageBase {
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r358586487
##
File path: src/brpc/policy/redis_protocol.cpp
##
@@ -52,62 +54,202 @@ struct InputResponse : public InputMessageBase {
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r358589445
##
File path: src/brpc/policy/redis_protocol.cpp
##
@@ -52,62 +54,202 @@ struct InputResponse : public InputMessageBase {
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r358587955
##
File path: src/brpc/policy/redis_protocol.cpp
##
@@ -52,62 +54,202 @@ struct InputResponse : public InputMessageBase {
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r358591542
##
File path: src/brpc/redis_reply.cpp
##
@@ -352,4 +413,52 @@ void RedisReply::CopyFromDifferentArena(const RedisReply&
o
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r358587475
##
File path: src/brpc/policy/redis_protocol.cpp
##
@@ -52,62 +54,202 @@ struct InputResponse : public InputMessageBase {
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r358591199
##
File path: src/brpc/redis_reply.cpp
##
@@ -352,4 +413,52 @@ void RedisReply::CopyFromDifferentArena(const RedisReply&
o
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r358586373
##
File path: src/brpc/policy/redis_protocol.cpp
##
@@ -52,62 +54,202 @@ struct InputResponse : public InputMessageBase {
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r351584310
##
File path: src/brpc/policy/redis_protocol.cpp
##
@@ -52,62 +56,287 @@ struct InputResponse : public InputMessageBase {
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r355397799
##
File path: src/brpc/redis_reply.h
##
@@ -160,6 +212,87 @@ inline int64_t RedisReply::integer() const {
return 0;
}
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r356952231
##
File path: src/brpc/redis.h
##
@@ -209,7 +213,54 @@ class RedisResponse : public ::google::protobuf::Message {
std::ost
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r355987152
##
File path: example/redis_c++/redis_server.cpp
##
@@ -0,0 +1,128 @@
+// Licensed to the Apache Software Foundation (ASF)
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r356952596
##
File path: src/brpc/policy/redis_protocol.h
##
@@ -33,6 +33,13 @@ ParseResult ParseRedisMessage(butil::IOBuf* source, So
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r356952885
##
File path: src/brpc/redis.h
##
@@ -209,7 +213,54 @@ class RedisResponse : public ::google::protobuf::Message {
std::ost
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r356952989
##
File path: src/brpc/redis_command.cpp
##
@@ -360,4 +360,86 @@ butil::Status RedisCommandByComponents(butil::IOBuf*
outp
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r356953916
##
File path: src/brpc/policy/redis_protocol.cpp
##
@@ -52,62 +58,206 @@ struct InputResponse : public InputMessageBase {
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r356954111
##
File path: src/brpc/redis_command.h
##
@@ -40,6 +40,28 @@ butil::Status RedisCommandByComponents(butil::IOBuf* buf,
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r356953434
##
File path: src/brpc/redis_reply.cpp
##
@@ -37,6 +38,61 @@ const char* RedisReplyTypeToString(RedisReplyType type) {
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r356973158
##
File path: src/brpc/policy/redis_protocol.cpp
##
@@ -52,62 +58,206 @@ struct InputResponse : public InputMessageBase {
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r356952177
##
File path: src/brpc/redis.h
##
@@ -124,7 +128,7 @@ class RedisRequest : public ::google::protobuf::Message {
void P
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r356954267
##
File path: src/brpc/redis_reply.h
##
@@ -128,6 +167,8 @@ class RedisReply {
} array;
uint64_t padding[
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r356971336
##
File path: src/brpc/policy/redis_protocol.cpp
##
@@ -52,62 +58,206 @@ struct InputResponse : public InputMessageBase {
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r356953233
##
File path: src/brpc/redis_reply.cpp
##
@@ -189,7 +245,7 @@ ParseError RedisReply::ConsumePartialIOBuf(butil::IOBuf&
buf
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r355392122
##
File path: src/brpc/policy/redis_protocol.cpp
##
@@ -52,62 +58,249 @@ struct InputResponse : public InputMessageBase {
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r355397799
##
File path: src/brpc/redis_reply.h
##
@@ -160,6 +212,87 @@ inline int64_t RedisReply::integer() const {
return 0;
}
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r355398301
##
File path: src/brpc/server.cpp
##
@@ -1588,7 +1589,8 @@ void Server::GenerateVersionIfNeeded() {
if (!_version.empt
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r355397430
##
File path: src/brpc/redis_reply.h
##
@@ -160,6 +212,87 @@ inline int64_t RedisReply::integer() const {
return 0;
}
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r355397364
##
File path: src/brpc/redis_reply.h
##
@@ -160,6 +212,87 @@ inline int64_t RedisReply::integer() const {
return 0;
}
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r355393947
##
File path: src/brpc/policy/redis_protocol.h
##
@@ -33,6 +33,11 @@ ParseResult ParseRedisMessage(butil::IOBuf* source, So
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r354707430
##
File path: src/brpc/policy/redis_protocol.cpp
##
@@ -52,62 +57,237 @@ struct InputResponse : public InputMessageBase {
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r354709450
##
File path: src/brpc/policy/redis_protocol.cpp
##
@@ -52,62 +57,237 @@ struct InputResponse : public InputMessageBase {
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r354706940
##
File path: src/brpc/policy/redis_protocol.cpp
##
@@ -52,62 +57,237 @@ struct InputResponse : public InputMessageBase {
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r354714608
##
File path: src/brpc/redis_reply.h
##
@@ -160,6 +189,80 @@ inline int64_t RedisReply::integer() const {
return 0;
}
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r354708023
##
File path: src/brpc/policy/redis_protocol.cpp
##
@@ -52,62 +57,237 @@ struct InputResponse : public InputMessageBase {
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r353130004
##
File path: src/brpc/policy/redis_protocol.cpp
##
@@ -52,62 +61,348 @@ struct InputResponse : public InputMessageBase {
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r353115566
##
File path: src/brpc/policy/redis_protocol.cpp
##
@@ -52,62 +61,348 @@ struct InputResponse : public InputMessageBase {
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r354715582
##
File path: src/brpc/redis_reply.h
##
@@ -203,6 +306,11 @@ inline size_t RedisReply::size() const {
return (is_array
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r354714156
##
File path: src/brpc/redis_reply.h
##
@@ -160,6 +189,80 @@ inline int64_t RedisReply::integer() const {
return 0;
}
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r353116105
##
File path: src/brpc/policy/redis_protocol.cpp
##
@@ -52,62 +61,348 @@ struct InputResponse : public InputMessageBase {
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r354712016
##
File path: src/brpc/redis_reply.cpp
##
@@ -320,9 +376,14 @@ void RedisReply::CopyFromDifferentArena(const RedisReply&
o
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r353113504
##
File path: example/redis_c++/redis_server.cpp
##
@@ -0,0 +1,124 @@
+// Licensed to the Apache Software Foundation (ASF)
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r354707771
##
File path: src/brpc/policy/redis_protocol.cpp
##
@@ -52,62 +57,237 @@ struct InputResponse : public InputMessageBase {
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r354706587
##
File path: src/brpc/options.proto
##
@@ -46,14 +46,14 @@ enum ProtocolType {
PROTOCOL_HTTP = 7;
PROTOCOL_PUBLI
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r354714097
##
File path: src/brpc/redis_reply.h
##
@@ -160,6 +189,80 @@ inline int64_t RedisReply::integer() const {
return 0;
}
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r354709781
##
File path: src/brpc/policy/redis_protocol.cpp
##
@@ -52,62 +57,237 @@ struct InputResponse : public InputMessageBase {
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r354712892
##
File path: src/brpc/redis_reply.h
##
@@ -80,6 +90,7 @@ class RedisReply {
// Get the index-th sub reply. If this re
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r353123021
##
File path: src/brpc/policy/redis_protocol.h
##
@@ -33,6 +33,11 @@ ParseResult ParseRedisMessage(butil::IOBuf* source, So
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r353114458
##
File path: src/brpc/policy/redis_protocol.cpp
##
@@ -30,17 +32,24 @@
#include "brpc/details/server_private_accessor.h"
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r354712253
##
File path: src/brpc/redis_reply.h
##
@@ -56,6 +59,13 @@ class RedisReply {
bool is_string() const; // True if the
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r354708651
##
File path: src/brpc/policy/redis_protocol.cpp
##
@@ -52,62 +57,237 @@ struct InputResponse : public InputMessageBase {
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r353117211
##
File path: src/brpc/policy/redis_protocol.cpp
##
@@ -52,62 +61,348 @@ struct InputResponse : public InputMessageBase {
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r354710095
##
File path: src/brpc/policy/redis_protocol.cpp
##
@@ -52,62 +57,237 @@ struct InputResponse : public InputMessageBase {
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r353119006
##
File path: src/brpc/policy/redis_protocol.cpp
##
@@ -52,62 +61,348 @@ struct InputResponse : public InputMessageBase {
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r354706421
##
File path: example/redis_c++/redis_server.cpp
##
@@ -0,0 +1,146 @@
+// Licensed to the Apache Software Foundation (ASF)
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r351585370
##
File path: src/brpc/redis.h
##
@@ -209,7 +212,51 @@ class RedisResponse : public ::google::protobuf::Message {
std::ost
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r351585165
##
File path: src/brpc/redis_message.cpp
##
@@ -19,29 +19,85 @@
#include
#include "butil/logging.h"
-#include "brpc/re
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r350649862
##
File path: test/brpc_redis_unittest.cpp
##
@@ -547,4 +549,442 @@ TEST_F(RedisTest, quote_and_escape) {
request.Clea
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r351584310
##
File path: src/brpc/policy/redis_protocol.cpp
##
@@ -52,62 +56,287 @@ struct InputResponse : public InputMessageBase {
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r351583191
##
File path: src/brpc/redis.h
##
@@ -209,7 +212,51 @@ class RedisResponse : public ::google::protobuf::Message {
std::ost
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r351579486
##
File path: src/brpc/redis.h
##
@@ -124,7 +127,7 @@ class RedisRequest : public ::google::protobuf::Message {
void P
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r351584844
##
File path: src/brpc/policy/redis_protocol.cpp
##
@@ -52,62 +56,287 @@ struct InputResponse : public InputMessageBase {
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r351584650
##
File path: src/brpc/policy/redis_protocol.cpp
##
@@ -52,62 +56,287 @@ struct InputResponse : public InputMessageBase {
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r351585705
##
File path: src/brpc/redis_command.h
##
@@ -40,6 +40,41 @@ butil::Status RedisCommandByComponents(butil::IOBuf* buf,
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r349551720
##
File path: test/brpc_redis_unittest.cpp
##
@@ -547,4 +549,356 @@ TEST_F(RedisTest, quote_and_escape) {
request.Clea
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r349555128
##
File path: src/brpc/redis.h
##
@@ -209,6 +209,44 @@ class RedisResponse : public ::google::protobuf::Message {
std::ost
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r349558206
##
File path: src/brpc/redis_message.h
##
@@ -30,32 +30,39 @@
namespace brpc {
// Different types of replies.
-enum Red
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r349557809
##
File path: src/brpc/policy/redis_protocol.cpp
##
@@ -52,62 +56,250 @@ struct InputResponse : public InputMessageBase {
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r349557359
##
File path: src/brpc/redis.h
##
@@ -209,6 +209,44 @@ class RedisResponse : public ::google::protobuf::Message {
std::ost
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r349553142
##
File path: src/brpc/redis.h
##
@@ -209,6 +209,44 @@ class RedisResponse : public ::google::protobuf::Message {
std::ost
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r349552356
##
File path: src/brpc/redis.h
##
@@ -209,6 +209,44 @@ class RedisResponse : public ::google::protobuf::Message {
std::ost
92 matches
Mail list logo
