[GitHub] calcite-avatica-go pull request #20: Documentation fixes

2018-04-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/calcite-avatica-go/pull/20 ---

[GitHub] calcite-avatica-go pull request #22: Check files for Apache license header i...

2018-04-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/calcite-avatica-go/pull/22 ---

Re: Towards Avatica-Go release ?.?

2018-04-22 Thread Francis Chuang
Hey Julian, Thanks for the review! The script has also been updated to allow the releaser to select a tag during build (defaults to the latest tag if no tag is entered). I've pushed the 3.0.0-rc1 tag to the repository. Can you build the artifacts and sign them please? Instructions for buildi

[VOTE] Release calcite-avatica-go-3.0.0 (release candidate 1)

2018-04-22 Thread Francis Chuang
Hi all, I have created a release for Apache Calcite Avatica Go 3.0.0, release candidate 1. The release notes are available here: https://github.com/apache/calcite-avatica-go/blob/master/site/go_history.md The commit to be voted on: http://git-wip-us.apache.org/repos/asf/calcite-avatica-go/

Re: [VOTE] Release calcite-avatica-go-3.0.0 (release candidate 1)

2018-04-22 Thread Kevin Risden
* Ran tests at git hash * Ran tests from tar.gz * Checked hashes and GPG key of tar.gz * Reviewed source for missing Apache headers * Reviewed history and documentation Few comments: * Dockerfile - think CMD ["python", "app.py"]" is not needed? line could be removed * go_development.md - docker-co

[GitHub] calcite-avatica-go pull request #23: Test against Go 1.9

2018-04-22 Thread F21
GitHub user F21 opened a pull request: https://github.com/apache/calcite-avatica-go/pull/23 Test against Go 1.9 You can merge this pull request into a Git repository by running: $ git pull https://github.com/Boostport/calcite-avatica-go go-1.9 Alternatively you can review and

Re: [VOTE] Release calcite-avatica-go-3.0.0 (release candidate 1)

2018-04-22 Thread Francis Chuang
Thanks for the review, Kevin! Please see my response in line. On 23/04/2018 11:18 AM, Kevin Risden wrote: * Ran tests at git hash * Ran tests from tar.gz * Checked hashes and GPG key of tar.gz * Reviewed source for missing Apache headers * Reviewed history and documentation Few comments: * Dock

[GitHub] calcite-avatica-go pull request #23: Test against Go 1.9

2018-04-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/calcite-avatica-go/pull/23 ---

Re: [VOTE] Release calcite-avatica-go-3.0.0 (release candidate 1)

2018-04-22 Thread Kevin Risden
Thanks for the quick cleanup response. > I will add Go 1.9 to the travis file, but maybe we should just remove the note that Go 1.7+ is supported to reduce confusion. +1 for removing 1.7+ since it seems like a promise we can't easily keep. Kevin Risden On Sun, Apr 22, 2018 at 8:42 PM, Francis C

Re: [VOTE] Release calcite-avatica-go-3.0.0 (release candidate 1)

2018-04-22 Thread Francis Chuang
Thanks, Kevin! Removed the statement regarding Go 1.7+ and updated the release date to be 3 days from today. On 23/04/2018 12:22 PM, Kevin Risden wrote: Thanks for the quick cleanup response. I will add Go 1.9 to the travis file, but maybe we should just remove the note that Go 1.7+ is sup