Calcite-Master - Build # 1626 - Failure

2020-02-26 Thread Apache Jenkins Server
The Apache Jenkins build system has built Calcite-Master (build #1626) Status: Failure Check console output at https://builds.apache.org/job/Calcite-Master/1626/ to view the results.

[jira] [Created] (CALCITE-3832) decimal cast double throws npe

2020-02-26 Thread Zhixiong Chen (Jira)
Zhixiong Chen created CALCITE-3832: -- Summary: decimal cast double throws npe Key: CALCITE-3832 URL: https://issues.apache.org/jira/browse/CALCITE-3832 Project: Calcite Issue Type: Bug

Build failed in Jenkins: Calcite-Snapshots #120

2020-02-26 Thread Apache Jenkins Server
See Changes: [jcamacho] [CALCITE-3734] MySQL JDBC rewrite is producing queries with CHAR with [yuzhao.cyz] [CALCITE-3818] Upgrade Avatica version to 1.16.0 [yuzhao.cyz] [CALCITE-3822] Source distribution must n

Re: javacc problem: support "!" as "NOT"

2020-02-26 Thread JiaTao Tao
Thank Danny Can you give an example? And I don't understand why "NOT" becomes "". Regards! Aron Tao Danny Chan 于2020年2月27日周四 上午11:39写道: > You can add a token and alias it as you like. The token is always a > reserved keyword. > > Best, > Danny Chan > 在 2020年2月27日 +0800 AM11:23,dev@calcite.ap

Re: javacc problem: support "!" as "NOT"

2020-02-26 Thread Danny Chan
You can add a token and alias it as you like. The token is always a reserved keyword. Best, Danny Chan 在 2020年2月27日 +0800 AM11:23,dev@calcite.apache.org,写道: > > SqlParserImplConstants

Calcite-Master - Build # 1624 - Still Failing

2020-02-26 Thread Apache Jenkins Server
The Apache Jenkins build system has built Calcite-Master (build #1624) Status: Still Failing Check console output at https://builds.apache.org/job/Calcite-Master/1624/ to view the results.

javacc problem: support "!" as "NOT"

2020-02-26 Thread JiaTao Tao
Hi I want to identify “!” as “NOT” in SQL, so I do So I made the following changes in parser.jj: | < NOT: "NOT"|"!" > It can work, but some test fails(testNoUnintendedNewReservedKeywords), then I found in SqlParserImplConstants, “NOT” becomes "" as in the pic. [image: image.png] It should be “\

Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 2)

2020-02-26 Thread JiaTao Tao
+1 (non-binding) Regards! Aron Tao Danny Chan 于2020年2月26日周三 下午1:23写道: > Hi all, > > I have created a build for Apache Calcite 1.22.0, release candidate 2. > > Thanks to everyone who has contributed to this release. > You can read the release notes here: > https://github.com/apache/calcite/bl

[jira] [Created] (CALCITE-3831) AbstractMaterializedViewRule throws exception with an Aggregate on a Project projecting duplicate RexNodes

2020-02-26 Thread Steven Talbot (Jira)
Steven Talbot created CALCITE-3831: -- Summary: AbstractMaterializedViewRule throws exception with an Aggregate on a Project projecting duplicate RexNodes Key: CALCITE-3831 URL: https://issues.apache.org/jira/brows

[jira] [Created] (CALCITE-3830) Digest of AggregateCall do not consider the ''

2020-02-26 Thread Shuo Cheng (Jira)
Shuo Cheng created CALCITE-3830: --- Summary: Digest of AggregateCall do not consider the '' Key: CALCITE-3830 URL: https://issues.apache.org/jira/browse/CALCITE-3830 Project: Calcite Issue Type:

Re: [DISCUSS] Adapter's performance is not that fast

2020-02-26 Thread Haisheng Yuan
For the first time it is indeed slow, because it has startup cost and code generation. Can you post how you test it (by single run or multiple runs) and how does the flame graph look like? - Haisheng -- 发件人:Xiangwei Wei 日 期:2020年02

Re: [DISCUSS] Code freeze policy during release

2020-02-26 Thread Michael Mior
I don't believe we have ever articulated an "official" policy on this. But yes, it's generally expected that once the process of preparing a release has started, no one will commit to master without checking with the release manager. It's up to this person to judge whether a commit is important/saf

Re: [DISCUSS] Code freeze policy during release

2020-02-26 Thread Julian Hyde
This thread sums up the rationale: https://lists.apache.org/thread.html/b49639d926e64955cdca49aca1d2183f00812b54d2d5957499d39c9f%40%3Cdev.calcite.apache.org%3E If someone commits to master during the release process we either have to rebase master, do a merge commit, or have a release that is not

Re: [DISCUSS] Code freeze policy during release

2020-02-26 Thread Stamatis Zampetakis
Hello, As far as I remember [1, 2, 3] the commits on master are suspended during the release process. In principle, if there is a commit that should go in it should pass by the release manager and its up to him to decide if he wants to include it or not. Now if I am missing something I leave the m

Re: [DISCUSS] Code freeze policy during release

2020-02-26 Thread Chunwei Lei
Thanks for pointing out this, Ruben. I also have this question. But in our scrum, we can merge commits to master at the moment we have a release branch. Best, Chunwei On Wed, Feb 26, 2020 at 8:52 PM Ruben Q L wrote: > Hello everyone, > > as you know, we are in the middle of the release proce

[jira] [Created] (CALCITE-3829) MergeJoinEnumerator should not use inputs enumerators until it is really required

2020-02-26 Thread Ruben Q L (Jira)
Ruben Q L created CALCITE-3829: -- Summary: MergeJoinEnumerator should not use inputs enumerators until it is really required Key: CALCITE-3829 URL: https://issues.apache.org/jira/browse/CALCITE-3829 Proje

[DISCUSS] Code freeze policy during release

2020-02-26 Thread Ruben Q L
Hello everyone, as you know, we are in the middle of the release process for 1.22 (btw, thanks Danny for your effort as release manager). However, if I am not mistaken I can see that some PRs have been merged during this time, at least [1] and [2]. I am wondering if during this process (from the b

Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 2)

2020-02-26 Thread Enrico Olivelli
Il giorno mer 26 feb 2020 alle ore 12:14 Danny Chan ha scritto: > > Gives a -1 when you are sure that it is a bug, or the voting would be very > depressing, anyone can give a -1 for any reasons. I am sorry. I am doing my best in helping with the validation of the release, it is in the interest o

Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 2)

2020-02-26 Thread Danny Chan
Gives a -1 when you are sure that it is a bug, or the voting would be very depressing, anyone can give a -1 for any reasons. Best, Danny Chan 在 2020年2月26日 +0800 PM3:04,Enrico Olivelli ,写道: > Danny, > I have created https://issues.apache.org/jira/browse/CALCITE-3826 > for the problem about bind va

Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 2)

2020-02-26 Thread Danny Chan
This is a long-overdue release, can we push it a little faster ? If we have any questions can we resolve it in release-1.23 which comes one month later, actually I have fixed many bugs when I do a local test with Apache Flink master with 1.22.0-SNAPSHOT, and in my opinion, it is qualified to be

Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 2)

2020-02-26 Thread Danny Chan
Sorry I would rather see it as not a regression, this is just our choice, if the plan changes: Either • There is physical node in the logical plan which should be fixed • User Table does not implement a QueryableTable but a (ScannableTable | FilterableTable | ProjectableFilterableTable), but the

Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 2)

2020-02-26 Thread Danny Chan
Replied in the JIRA issue, I tried to reproduce your case but failed, can you give one in Calcite, thanks. Best, Danny Chan 在 2020年2月26日 +0800 PM3:04,Enrico Olivelli ,写道: > Danny, > I have created https://issues.apache.org/jira/browse/CALCITE-3826 > for the problem about bind variables in UPDATE

[jira] [Created] (CALCITE-3828) MergeJoin throws NPE in case of null keys

2020-02-26 Thread Ruben Q L (Jira)
Ruben Q L created CALCITE-3828: -- Summary: MergeJoin throws NPE in case of null keys Key: CALCITE-3828 URL: https://issues.apache.org/jira/browse/CALCITE-3828 Project: Calcite Issue Type: Bug

[jira] [Created] (CALCITE-3827) Reduce the time complexity of finding in-edges of a vertex in the graph

2020-02-26 Thread Liya Fan (Jira)
Liya Fan created CALCITE-3827: - Summary: Reduce the time complexity of finding in-edges of a vertex in the graph Key: CALCITE-3827 URL: https://issues.apache.org/jira/browse/CALCITE-3827 Project: Calcite