Re: [VOTE] Release Apache Calcite 1.30.0 (release candidate 1)

Hi Xiong, Thanks for your feedback. I will change the logs in a follow up MR. Best, Liya Fan xiong duan 于2022年3月7日周一 15:30写道： > Hi, Liya Fan.Thanks for your work. +1. > Just a little problem: > I noticed the Bug-fixes logs all started with FixI think maybe we > should stay the same as JI

Could calcite support SortProjectPullUpConstantsRule?

Hi community: Could calcite support the rule to pull up constant project from sort, just like `AggregateProjectPullUpConstantsRule`? -- sql select pay_amount, pay_id, user_id from pay_tbl where pay_id = 1234 group by pay_amount, pay_id, user_id order by pay_amount, pay_id, user_id -- origin rel

Re: [VOTE] Release Apache Calcite 1.30.0 (release candidate 1)

+1 (non binding) Run all tests of HerdDB, all tests are passing without any code change. (https://github.com/diennea/herddb/pull/779) I would like to note that previous tests of HerdDB did not pass with 1.29.0 (and we were stuck to 1.28.0). With 1.29.0 tests on Github actions hang during some cla

Re: Could calcite support SortProjectPullUpConstantsRule?

Sounds reasonable. Please log a jira. Consider implementing this rule by inspecting predicates or unique keys, rather than by matching a Project or Filter. If you can ascertain that a sort column has only one value (counting NULL as a value for these purposes) then you can remove it from the s

Re: [VOTE] Release Apache Calcite 1.30.0 (release candidate 0)

Liya, in the next iteration can you go back to the usual sections e.g “Bug-fixes, API changes and minor enhancements”. Also remove the “Fix” prefix from messages. Quite a few cases, e.g “ Fix the problem that JDBC adapter incorrectly adds ORDER BY columns to the SELECT list of generated SQL que

Bugs dropped on the floor

There were a few bugs that had fix-version = 1.30 because they had PRs that looked like they were going to make it. Liya has removed the fix version. https://issues.apache.org/jira/browse/CALCITE-4908 https://issues.apache.org/jira/browse/CALC

Re: Bugs dropped on the floor

Especially https://issues.apache.org/jira/browse/CALCITE-4976 whose title is literally “Release Calcite 1.30.0”, no longer has fix-version 1.30. Good grief. > On Mar 7, 2022, at 2:22 PM, Julian Hyde wrote: > > There were a few bugs that had

Re: [VOTE] Release Apache Calcite 1.30.0 (release candidate 0)

Hi Julian, Thanks for your feedback. I will prepare another build, after addressing these issues. Best, Liya Fan Julian Hyde 于2022年3月8日周二 04:50写道： > Liya, in the next iteration can you go back to the usual sections e.g > “Bug-fixes, API changes and minor enhancements”. Also remove the “Fix” >

Re: Bugs dropped on the floor

Hello, In the "Towards Calcite 1.30.0" thread, when Liya Fan suggested last Friday for RC0, nobody objected or requested a delay to try to squeeze in any pending PR. We can set these tickets fix-version = 1.31 and aim for that version, which should be out in 8 weeks (or sooner if required). Regar

Re: Bugs dropped on the floor

Sorry. I will restore the fix-version. It seems CALCITE-4976 is duplicate with CALCITE-5031. So I will close CALCITE-5031. Best, Liya Fan Julian Hyde 于2022年3月8日周二 06:25写道： > Especially https://issues.apache.org/jira/browse/CALCITE-4976 < > https://issues.apache.org/jira/browse/CALCITE-4976> wh

Re: Bugs dropped on the floor

Hi Ruben, Good suggestion. Thanks. I removed the fix version for above JIRAs because I could not assign 1.31.0 to them. Version 1.31.0 has not been created, and I have no permission to create it. Could someone with permission please create it? Best, Liya Fan Fan Liya 于2022年3月8日周二 07:37写道： >

Re: [VOTE] Release Apache Calcite 1.30.0 (release candidate 0)

Hello Liya Fan, please be aware that, normally, when there are issues ONLY on the release notes, we do not require a new RC (they can be amended afterwards with a commit right after the release). So, I'd say that for the moment we can just cancel RC0 vote (an email "[CANCEL] [VOTE] Release Apache

Re: Bugs dropped on the floor

Hey Liya, I've added you to the administrator role, so you should be able to create the 1.31.0 release version in jira. Francis On 8/03/2022 10:44 am, Fan Liya wrote: Hi Ruben, Good suggestion. Thanks. I removed the fix version for above JIRAs because I could not assign 1.31.0 to them. Ver

Re: Bugs dropped on the floor

I have created version 1.31.0 myself, it should be already visible. Ruben On Mon, Mar 7, 2022 at 11:51 PM Francis Chuang wrote: > Hey Liya, > > I've added you to the administrator role, so you should be able to > create the 1.31.0 release version in jira. > > Francis > > On 8/03/2022 10:44 am,

Re: Allow Cascades driver invoking "derive" on the nodes produced by "passThrough"

Hi Vladimir, If I understand it correctly, your concern is still about [1], right? If it is, I think I have answered it in [2], perhaps it didn't jump into your inbox. I am still not convinced that enforcing derivation on all rels is the only way to solve your concern. If it is the other probl

Re: [VOTE] Release Apache Calcite 1.30.0 (release candidate 0)

Hi Ruben, Thanks for your suggestion. Let's go ahead with it. Best, Liya Fan Ruben Q L 于2022年3月8日周二 07:49写道： > Hello Liya Fan, > > please be aware that, normally, when there are issues ONLY on the release > notes, we do not require a new RC (they can be amended afterwards with a > commit righ

Re: Bugs dropped on the floor

Hi Francis and Ruben, Thanks for your kind help. I have set the fix version of the following JIRAs to 1.31.0 (their original fix version was 1.30.0). Please check. CALCITE-5021 CALCITE-4992 CALCITE-4990 CALCITE-4987 CALCITE-4976 CALCITE-4913 CALCITE-4908 CALCITE-4887 CALCITE-2552 Best, Liya Fan

RE: Re: Could calcite support SortProjectPullUpConstantsRule?

Hi Julian Thanks for your reply. As you said, using `org.apache.calcite.rel.metadata.RelMetadataQuery#getPulledUpPredicates` is very effective. I will log a jira later. Best Xurenhe On 2022/03/07 20:30:45 Julian Hyde wrote: > Sounds reasonable. Please log a jira. > > Consider implementing this

[jira] [Created] (CALCITE-5035) Define a rule of SortProjectPullUpConstantsRule to pull up constants project under Sort

Xurenhe created CALCITE-5035: Summary: Define a rule of SortProjectPullUpConstantsRule to pull up constants project under Sort Key: CALCITE-5035 URL: https://issues.apache.org/jira/browse/CALCITE-5035 Pro