Re: [RESULT] [VOTE] Release apache-calcite-1.24.0 (release candidate 0)

Thank you very much for your help, Francis and Haisheng. Best, Chunwei On Fri, Jul 24, 2020 at 1:09 PM Chunwei Lei wrote: > > Chunwei, did `prepareVote` fail when you were making rc0? If so, I think > those nexus repos were a byproduct and can be dropped. > > Yes. it indeed failed before succ

Re: [RESULT] [VOTE] Release apache-calcite-1.24.0 (release candidate 0)

> Chunwei, did `prepareVote` fail when you were making rc0? If so, I think those nexus repos were a byproduct and can be dropped. Yes. it indeed failed before success. Best, Chunwei On Fri, Jul 24, 2020 at 12:44 PM Francis Chuang wrote: > Actually, I am not sure why there are 6 repositories

Re: [RESULT] [VOTE] Release apache-calcite-1.24.0 (release candidate 0)

I dry run it, it will remove all the artifacts before 1.24.0. I think that is not Calcite's policy. At least it should keep 1.23.0. On 2020/07/24 04:40:50, Francis Chuang wrote: > orgapachecalcite-1096 is closed and released, so that's fine. The other > open ones are for rcs that did not pass,

Re: [RESULT] [VOTE] Release apache-calcite-1.24.0 (release candidate 0)

Actually, I am not sure why there are 6 repositories for 1.22.0 on nexus with 3 being closed and released. Chunwei, did `prepareVote` fail when you were making rc0? If so, I think those nexus repos were a byproduct and can be dropped. Francis On 24/07/2020 2:40 pm, Francis Chuang wrote: orga

Re: [RESULT] [VOTE] Release apache-calcite-1.24.0 (release candidate 0)

Can everyone please not commit to master branch for a moment? The release manager hasn't open the master branch yet. On 2020/07/24 04:38:07, Haisheng Yuan wrote: > Skipped the step of releaseRepository too. > Now finished release. > > There are several closed or open repos in > https://reposit

Re: [RESULT] [VOTE] Release apache-calcite-1.24.0 (release candidate 0)

orgapachecalcite-1096 is closed and released, so that's fine. The other open ones are for rcs that did not pass, so I don't think they should be closed and released. There are currently 3 calcite releases in the release folder: https://dist.apache.org/repos/dist/release/calcite/ We should ju

Re: [RESULT] [VOTE] Release apache-calcite-1.24.0 (release candidate 0)

Skipped the step of releaseRepository too. Now finished release. There are several closed or open repos in https://repository.apache.org/#stagingRepositories, should I manually release all of them? On 2020/07/24 04:25:43, Haisheng Yuan wrote: > I skipped the step, but now have this error: > ~/

Re: [RESULT] [VOTE] Release apache-calcite-1.24.0 (release candidate 0)

I skipped the step, but now have this error: ~/calcite ❯❯❯ ./gradlew publishDist -Prc=0 -Pasf -x publishSvnDist > Configure project : Building Apache Calcite 1.24.0 > Task :releaseRepository Initialized stagingRepositoryId orgapachecalcite-1096 for repository nexus POST request failed. 500: Serv

Re: [RESULT] [VOTE] Release apache-calcite-1.24.0 (release candidate 0)

How can I skip this step? ~/calcite ❯❯❯ ./gradlew publishDist -Prc=0 -Pasf > Configure project : Building Apache Calcite 1.24.0 > Task :publishSvnDist FAILED Listing SVN folders [dev/calcite/apache-calcite-1.24.0-rc0] at https://dist.apache.org/repos/dist Build calcite FAILURE reason: Exec

Re: [VOTE] Release apache-calcite-1.24.0 (release candidate 0)

Yes, I agree. I will add the details to the JIRA. Thanks for reminding. On 2020/07/23 17:43:24, Julian Hyde wrote: > > Haisheng, > > > > Julian wrote: > > > * why is 4032 'breaking'? > > > Haisheng wrote: > > With that change, the CalcMergeRule won't match PhysicalNode > > (including Enumerab

Re: [RESULT] [VOTE] Release apache-calcite-1.24.0 (release candidate 0)

I will help push the artifacts. On 2020/07/24 03:04:05, Francis Chuang wrote: > I wonder if this is because only PMCs can push to the SVN repo. If this > is the case, I think we need to nominate a PMC member to push the > artifacts for you. > > On 24/07/2020 12:58 pm, Chunwei Lei wrote: > > H

Re: [RESULT] [VOTE] Release apache-calcite-1.24.0 (release candidate 0)

I wonder if this is because only PMCs can push to the SVN repo. If this is the case, I think we need to nominate a PMC member to push the artifacts for you. On 24/07/2020 12:58 pm, Chunwei Lei wrote: Hi, Francis. I already put those settings in ~/.gradle/gradle.properties: $cat ~/.gradle/gra

Re: [RESULT] [VOTE] Release apache-calcite-1.24.0 (release candidate 0)

Hi, Francis. I already put those settings in ~/.gradle/gradle.properties: $cat ~/.gradle/gradle.properties asfCommitterId=chunwei asfNexusUsername=chunwei asfNexusPassword=xxx asfSvnUsername=chunwei asfSvnPassword=xxx asfGitSourceUsername=chunweilei asfGitSourcePassword=xxx useGpgCmd=true sign

Re: [RESULT] [VOTE] Release apache-calcite-1.24.0 (release candidate 0)

You need to include your username and password using the -Pasf* flags. Here's how I use those flags to publish an avatica release using docker: https://github.com/apache/calcite-avatica/blob/master/docker.sh#L251 Francis On 24/07/2020 12:43 pm, Chunwei Lei wrote: Hi all, I tried to push the

Re: [RESULT] [VOTE] Release apache-calcite-1.24.0 (release candidate 0)

Hi all, I tried to push the release out to mirrors. But I met an error: $ ./gradlew publishDist -Prc=0 -Pasf Starting a Gradle Daemon, 3 busy and 1 incompatible Daemons could not be reused, use --status for details > Configure project : Building Apache Calcite 1.24.0 > Task :publishSvnDist List

Re: [VOTE] Release apache-calcite-1.24.0 (release candidate 0)

Haisheng, > > Julian wrote: > > * why is 4032 'breaking'? > Haisheng wrote: > With that change, the CalcMergeRule won't match PhysicalNode > (including EnumerableCalc) in VolcanoPlanner. Perhaps I should > elaborate in the release notes. Maybe a little more in the release notes. But please add

Re: [VOTE] Release apache-calcite-1.24.0 (release candidate 0)

To re-iterate: The release notes must prominently mention the deprecated APIs, how they are going to be removed before 1.25, and that people should change their code replace them their replacements ASAP. (Especially if they are seeing NPEs.) > On Jul 23, 2020, at 10:05 AM, Julian Hyde wrote: >

Re: [VOTE] Release apache-calcite-1.24.0 (release candidate 0)

I see that Chunwei has just send out a [RESULT] email announcing that the vote has passed. This is the right decision, but it is a close call. https://issues.apache.org/jira/browse/CALCITE-4136 was discovered during the release vote It is a c

[RESULT] [VOTE] Release apache-calcite-1.24.0 (release candidate 0)

Thanks to everyone who has tested the release candidate and given their comments and votes. The tally is as follows. 5 binding +1s: Michael Mior Julian Hyde Haisheng Yuan Francis Chuang Danny Chen 4 non-binding +1s: Enrico Olivelli Ruleben Q L Rui Wang Chunwei Lei 1 binding 0s: Stamatis Zampeta

Re: [VOTE] Release apache-calcite-1.24.0 (release candidate 0)

Thanks to everyone who has tested the release candidate and given their comments. I have revised the release notes and updated the LICENSE[1]. Regarding CALCITE-4136[2], I have not looked into it yet. But from what I can see, it is not a blocking issue. [1] https://github.com/chunweilei/calcite

Re: [VOTE] Release apache-calcite-1.24.0 (release candidate 0)

Thanks Chunwei for taking care of the release ~ +1 (binding) - verified hashes and checksums - built from sources and run tests (1.8.0_161 on MacOS Mojave) - run some tests of Flink Best, Danny Chan 在 2020年7月22日 +0800 PM11:50，dev@calcite.apache.org，写道： > > +1 (non binding) > - verified hashes and

Re: [VOTE] Release apache-calcite-1.24.0 (release candidate 0)

Please see the comments I have added to CALCITE-4136. This issue is known, and we plan to fix in 1.25, and we cannot fix in 1.24 due to semantic versioning constraints. The issue may have become exacerbated because I reorganized the code a bit to deprecate - and provide alternatives for - fields

Re: [VOTE] Release apache-calcite-1.24.0 (release candidate 0)

Thanks Stamatis for logging the issue https://issues.apache.org/jira/browse/CALCITE-4136 I have looked into it a bit more in detail, and it seems indeed a blocking issue, which can be reproduced by tweaking some unit tests in Calcite. Even though the fix is simple (use the newer version of the rule

Re: [VOTE] Release apache-calcite-1.24.0 (release candidate 0)

I logged CALCITE-4136 [1] for the problem observed by Enrico and Ruben. Even though there is a workaround if the users cannot recompile their code it can become blocking. If we have a deprecated field that cannot be used it is as good as not having it at all. I didn't perform all the checks but at

Re: [VOTE] Release apache-calcite-1.24.0 (release candidate 0)

+1 (non-binding) - downloaded the artifacts, checked hash, verified signature, built and ran tests. All are OK - use `diff -r` to compare the artifact and the git tag. Like what Julian has pointed out, I can find a difference about license but it can be addressed after this vote. -Rui On Tue, J

Re: [VOTE] Release apache-calcite-1.24.0 (release candidate 0)

Hello everyone, Thanks Chunwei for taking care of this release. +1 (non binding) - Local Calcite build with tests (Windows10 + JDK8): OK - Calcite-based application test suite: OK Similarly to Enrico, I also found some issues with the deprecated version of the "standard" rules. Initially I had a

Re: [VOTE] Release apache-calcite-1.24.0 (release candidate 0)

+1 (non binding) - verified hashes and checksums - built from sources and run tests (JDK14 on Linux) - run tests of HerdDB and some client application I only had to fix a deprecation warning, changing from ReduceExpressionsRule.FILTER_INSTANCE to CoreRules.FILTER_REDUCE_EXPRESSIONS, see [1] below

Re: [VOTE] Release apache-calcite-1.24.0 (release candidate 0)

Thanks for making this release available for voting, Chunwei! Verified GPG Signature - OK Verified SHA512 - OK Ran tests per HOWTO (./gradlew check) - OK Quickly skimmed release notes - Looks good, but I agree with Julian's comments. Spotted checked a few JARs in the Maven repository - OK Envi

Re: [VOTE] Release apache-calcite-1.24.0 (release candidate 0)

Environment: Mac OS X 10.15.1, JDK 1.8.0_162 - Checked signatures and checksums, OK - Ran unit tests (./gradlew build), OK +1 (binding) > * why is 4032 'breaking'? With that change, the CalcMergeRule won't match PhysicalNode(including EnumerableCalc) in VolcanoPlanner. Perhaps I should elabora

Re: [VOTE] Release apache-calcite-1.24.0 (release candidate 0)

Downloaded, checked hashes, built and ran tests on Ubuntu/JDK 14; checked distro against git (see issue 1); reviewed release notes (see issue 2). +1 (binding) but issues 1 and 2 need to be fixed right after the release. Issue 1. License file is not the same as in source control: diff -r ./LICENS

Re: [VOTE] Release apache-calcite-1.24.0 (release candidate 0)

+1 Checked hash and signature and compiled and ran tests. Thanks Chunwei! -- Michael Mior mm...@apache.org Le lun. 20 juil. 2020 à 11:41, Chunwei Lei a écrit : > > Hi all, > > I have created a build for Apache Calcite 1.24.0, release > candidate 0. > > Thanks to everyone who has contributed to

[VOTE] Release apache-calcite-1.24.0 (release candidate 0)

Hi all, I have created a build for Apache Calcite 1.24.0, release candidate 0. Thanks to everyone who has contributed to this release. You can read the release notes here: https://github.com/apache/calcite/blob/calcite-1.24.0-rc0/site/_docs/history.md The commit to be voted upon: https://gitbox