Re: [for help] Should I change my commit user.email?

2022-10-17 Thread Julian Hyde
It happens to the best of us! It turns out that I've used not fewer than 5 different combinations over the years: $ git log --author=hyde|grep Author:|sort |uniq Author: Julian Hyde Author: Julian Hyde Author: Julian Hyde Author: julianhyde Author: julianhyde These days I prefer to use my

Re: [for help] Should I change my commit user.email?

2022-10-17 Thread Mou Wu
Thank you, Alessandro Solimando, and Benchao Li. Git commit history shouldn’t be changed in any case indeed, I am just a little nervous about the mistake I made. I will use my personal email in the future contributions. > 2022年10月17日 19:21,Benchao Li 写道: > > As I can see, there is no need

Re: [for help] Should I change my commit user.email?

2022-10-17 Thread Alessandro Solimando
I have probably misunderstood the concern then, if you just want to link different email addresses to the same GitHub account, then it's totally fine and doable (no need to rewrite git history or anything). I sensed that Mou Wu wanted to remove any reference to the work email (possibly because

Re: [for help] Should I change my commit user.email?

2022-10-17 Thread Benchao Li
As I can see, there is no need to change the git commit history. Github allows adding multiple email addresses, you can add your company's email address to your Github account as well. After that, all the things will work fine in Github, such as that Github will know that you have committed to

Re: [for help] Should I change my commit user.email?

2022-10-17 Thread Alessandro Solimando
Hi Mou Wu, over the years I have seen several contributors using their working emails in the git commits, in principle I don't think there is any issue with that. In any case, I guess it would not be possible to amend git history to change the email, as this will change the sha1 for all

[for help] Should I change my commit user.email?

2022-10-17 Thread Mou Wu
Hello committers: I contributed two pull requests(commits: 3d39fdcee, b16df019e) in recent two mouths, I found I committed my company’s email instead of my personal email on these two commits(thanks Benchao Li, he reminded me), and I should committed my personal email because my GitHub’s email