Re: [DISCUSS] Towards Calcite 1.21.0

Thanks for the effort, Stamatis Zampetakis ! Best, Danny Chan 在 2019年9月2日 +0800 PM8:15，Stamatis Zampetakis ，写道： > I'm preparing RC0. > > Please do not commit to master until further notice. > > Best, > Stamatis > > > On Mon, Sep 2, 2019 at 1:23 PM Vova Vysotskyi wrote: > > > Great, thanks Stamati

Re: [DISCUSS] Towards Calcite 1.21.0

I'm preparing RC0. Please do not commit to master until further notice. Best, Stamatis On Mon, Sep 2, 2019 at 1:23 PM Vova Vysotskyi wrote: > Great, thanks Stamatis! > > Kind regards, > Volodymyr Vysotskyi > > > On Mon, Sep 2, 2019 at 1:28 PM Stamatis Zampetakis > wrote: > > > Let's include

Re: [DISCUSS] Towards Calcite 1.21.0

Great, thanks Stamatis! Kind regards, Volodymyr Vysotskyi On Mon, Sep 2, 2019 at 1:28 PM Stamatis Zampetakis wrote: > Let's include CALCITE-3115; I will merge it now. > > On Mon, Sep 2, 2019 at 11:26 AM Vova Vysotskyi wrote: > > > Hi all, > > > > Let's get CALCITE-3115 < > https://issues.apac

Re: [DISCUSS] Towards Calcite 1.21.0

Let's include CALCITE-3115; I will merge it now. On Mon, Sep 2, 2019 at 11:26 AM Vova Vysotskyi wrote: > Hi all, > > Let's get CALCITE-3115 > > into the release. PR is ready, but there are some concerns about breaking > existing clients. > It

Re: [DISCUSS] Towards Calcite 1.21.0

Hi all, Let's get CALCITE-3115 into the release. PR is ready, but there are some concerns about breaking existing clients. It would be good to make a decision about this PR. Kind regards, Volodymyr Vysotskyi On Sun, Sep 1, 2019 at 5:34 AM Dan

Re: [DISCUSS] Towards Calcite 1.21.0

Nice Kanban, thanks for the effort Stamatis Zampetakis ! Best, Danny Chan 在 2019年9月1日 +0800 AM6:46，Stamatis Zampetakis ，写道： > Hello, > > We are really close in getting this release out. There are only a few issue > [1] left to handle before building RC0. > > I guess CALCITE-3314 and CALCITE-3315 w

Re: [DISCUSS] Towards Calcite 1.21.0

Hello, We are really close in getting this release out. There are only a few issue [1] left to handle before building RC0. I guess CALCITE-3314 and CALCITE-3315 will be done in the next 48 hours. That leaves mainly CALCITE-1581 but if we don't manage to get it in on time, I guess we can leave it

Re: [DISCUSS] Towards Calcite 1.21.0

Hello Julian, I'll work on the CALCITE-3297 and try to fix quickly. Thanks, Igor

Re: [DISCUSS] Towards Calcite 1.21.0

Julian, I’m going to merge CALCITE-2302 if you do not have strong objections. Best, Danny Chan 在 2019年8月28日 +0800 AM12:58，Julian Hyde ，写道： > Igor, > > Can you please help with > https://issues.apache.org/jira/browse/CALCITE-3297? It was caused, in > part, by your changes in > https://issues.apache

Re: [DISCUSS] Towards Calcite 1.21.0

Igor, Can you please help with https://issues.apache.org/jira/browse/CALCITE-3297? It was caused, in part, by your changes in https://issues.apache.org/jira/browse/CALCITE-3138. Julian On Tue, Aug 27, 2019 at 3:06 AM Igor Guzenko wrote: > > Hello everyone, > > It would be great to include CALCI

Re: [DISCUSS] Towards Calcite 1.21.0

Hello everyone, It would be great to include CALCITE-3115 [1] into the release. [1] https://issues.apache.org/jira/browse/CALCITE-3115 [2] https://github.com/apache/calcite/pull/1397 Thanks, Igor On Tue, Aug 27, 2019 at 5:43 AM Danny Chan wrote: > Thanks for the review for CALCITE-2302, Julia

Re: [DISCUSS] Towards Calcite 1.21.0

Thanks for the review for CALCITE-2302, Julian. Best, Danny Chan 在 2019年8月26日 +0800 PM12:27，Julian Hyde ，写道： > Sounds good. > * I am reviewing 3122 and will commit shortly. > * I see Danny has asked me to final review 2302. I'll do that tomorrow. > * Who owns 1581? > > Julian > > On Sun, Aug 25, 2

Re: [DISCUSS] Towards Calcite 1.21.0

Regarding 3122. The fix looks good to me, but one test is broken when I merge in the fix to [CALCITE-3138] "RelStructuredTypeFlattener doesn't restructure ROW type fields”. So, we are holding until I figure with Khai Tran (author of 3122) and Igor Guzenko (author or 3138) out how to combine the

Re: [DISCUSS] Towards Calcite 1.21.0

Thanks for your work, Stamatis. As for 1581, I have reviewed it and it looks good to me. So I am +1 for the change. Best, Chunwei On Mon, Aug 26, 2019 at 1:39 PM Stamatis Zampetakis wrote: > I see that Chunwei has reviewed 1581 and he gave a +1 so I suppose it is > ready to go. > > On Mon,

Re: [DISCUSS] Towards Calcite 1.21.0

I see that Chunwei has reviewed 1581 and he gave a +1 so I suppose it is ready to go. On Mon, Aug 26, 2019, 7:27 AM Julian Hyde wrote: > Sounds good. > * I am reviewing 3122 and will commit shortly. > * I see Danny has asked me to final review 2302. I'll do that tomorrow. > * Who owns 1581? > >

Re: [DISCUSS] Towards Calcite 1.21.0

Sounds good. * I am reviewing 3122 and will commit shortly. * I see Danny has asked me to final review 2302. I'll do that tomorrow. * Who owns 1581? Julian On Sun, Aug 25, 2019 at 1:28 PM Stamatis Zampetakis wrote: > > Hello, > > According to the discussion in JIRA the following issues seem to b

Re: [DISCUSS] Towards Calcite 1.21.0

Hello, According to the discussion in JIRA the following issues seem to be very close to been resolved: https://issues.apache.org/jira/browse/CALCITE-1581 https://issues.apache.org/jira/browse/CALCITE-2302 https://issues.apache.org/jira/browse/CALCITE-3122 I will wait for those to be merged and t

Re: [DISCUSS] Towards Calcite 1.21.0

+1 I’ve poked Khai Tran re. 3122 (Pig). > On Aug 16, 2019, at 11:20 PM, Stamatis Zampetakis wrote: > > Hi all, > > The release is advancing quite well, yet we have 22 issues marked for > 1.21.0 [1]. > > From those, the following 5 seem to be the most important: > > https://issues.apache.org/

Re: [DISCUSS] Towards Calcite 1.21.0

Hi all, The release is advancing quite well, yet we have 22 issues marked for 1.21.0 [1]. >From those, the following 5 seem to be the most important: https://issues.apache.org/jira/browse/CALCITE-1581 https://issues.apache.org/jira/browse/CALCITE-2302 https://issues.apache.org/jira/browse/CALCIT

Re: [DISCUSS] Towards Calcite 1.21.0

Let’s get the CALCITE-2302[1]: the full implicit type cast support into 1.21 ! [1] https://github.com/apache/calcite/pull/706 Best, Danny Chan 在 2019年7月21日 +0800 PM3:28，Stamatis Zampetakis ，写道： > Hi all, > > Approximately one month has passed from the previous release (Calcite > 1.20.0) and I was

Re: [DISCUSS] Towards Calcite 1.21.0

Thanks for your work, Stamatis! Besides issues you mentioned above, I wonder if CALCITE-1581 can be included in 1.21.0. Best, Chunwei On Thu, Aug 1, 2019 at 6:29 AM Stamatis Zampetakis wrote: > We are about three weeks before RC0 and we st

Re: [DISCUSS] Towards Calcite 1.21.0

We are about three weeks before RC0 and we still have a big number of pending PRs. Moreover there are only a few Jira cases that are marked to be fixed in 1.21.0. If we assume that we have 10 active committers at the moment and each one of them takes on ~5 PRs till the 20th of August, we should ha

Re: [DISCUSS] Towards Calcite 1.21.0

+1 for release at end of August. > Apart from very important issues it makes sense to treat PRs in FIFO order. Contributors who submit a PR early will certainly get discouraged to contribute again if we never merge these PRs in time. +1 since it is very important for encouraging contributors.

Re: [DISCUSS] Towards Calcite 1.21.0

>Apart from very important issues it makes sense to treat PRs in FIFO order. Contributors who submit a PR early will certainly get discouraged to contribute again if we never merge these PRs in time. There are 110+ PRs on the GitHub page, what should we do ? Best, Danny Chan 在 2019年7月22日 +0800 AM

Re: [DISCUSS] Towards Calcite 1.21.0

+1 to the proposed schedule. Thanks for being RM for this release, Stamatis! Francis On 22/07/2019 4:39 am, Enrico Olivelli wrote: Stamatis, We are trying to upgrade HerdDB to 1.20 but we are stuck into a little problem with simple aggregations [1] I will try to give feedback as it is possible

Re: [DISCUSS] Towards Calcite 1.21.0

Stamatis, We are trying to upgrade HerdDB to 1.20 but we are stuck into a little problem with simple aggregations [1] I will try to give feedback as it is possible, if there is a problem in Calcite I will be happy to try to report it before 1.21. I hope it is only a problem on HerdDB Cheers Enric

Re: [DISCUSS] Towards Calcite 1.21.0

+1 for release at end of August. +1 to figure out which PRs could make it into the release, and work on that list in FIFO order. We tend to merge PRs that are in good shape, and by active contributors, and we tend to ignore old PRs that are never going to make it, but we tend to ignore the imp