Thanks for clarifying Danny. I agree that what you suggest could be a good idea.
--
Michael Mior
mm...@apache.org
Le mar. 23 juil. 2019 à 21:50, Danny Chan a écrit :
>
> Thanks Michael, just to make things more clear, I’m not saying only
> committers can review the code, I’m talking about the
.
- Haisheng
--
发件人：Danny Chan
日 期：2019年07月24日 09:50:05
收件人：
主 题：Re: Add "IN REVIEW" state in JIRA Workflow
Thanks Michael, just to make things more clear, I’m not saying only committers
can review the code, I’m tal
Thanks Michael, just to make things more clear, I’m not saying only committers
can review the code, I’m talking about the “IN REVIEW” tag, if we mark the PR
in review, it would somehow discourage other people who has willingness on the
code review. So I think It is not a good idea to let anyone
Everybody (committer or not) should be able to review and this shouldn't
change in any case.
JIRA is really made for issue tracking so I think it is more appropriate
compared to GitHub. It allows to perform powerful queries and helpful views
that is impossible to achieve with GitHub (I outlined
I would strongly oppose limiting who can review code. Only committers
can actually commit code, so we already have a mechanism for limiting
what code makes it in. I haven't seen anyone give a really bad code
review and if that does happen, I would rather address it on a case by
case basis instead
Sounds like a good idea if this state can only be seen by committers/PMC,
because we should keep the quality of code reviewing, we should make some limit
on who can review the code, as far as I know, many contributors are not that
familiar with our code, and usually a good review comes from
I don’t think another state is necessary/helpful. It seems like more process,
when what we are suffering is lack of resources, not lack of process.
I do believe that it is helpful to add a comment when I am reviewing - see e.g.
https://issues.apache.org/jira/browse/CALCITE-3183
