Re: withExpand behavior with ANY/ALL subqueries

2023-02-11 Thread Benchao Li
+1, thanks Julian for pushing this towards the final vision. Ruben Q L 于2023年2月11日周六 17:05写道: > Agree. The change makes sense, and it must be clearly documented on the > next release notes. > > > On Sat, Feb 11, 2023 at 12:18 AM Julian Hyde wrote: > > > Agreed. This is a breaking change. > > >

Re: withExpand behavior with ANY/ALL subqueries

2023-02-11 Thread Ruben Q L
Agree. The change makes sense, and it must be clearly documented on the next release notes. On Sat, Feb 11, 2023 at 12:18 AM Julian Hyde wrote: > Agreed. This is a breaking change. > > I've started work in a branch: > https://github.com/julianhyde/calcite/tree/3870-sql2rel-expand-false > > On

Re: withExpand behavior with ANY/ALL subqueries

2023-02-10 Thread Julian Hyde
Agreed. This is a breaking change. I've started work in a branch: https://github.com/julianhyde/calcite/tree/3870-sql2rel-expand-false On Fri, Feb 10, 2023 at 1:47 PM Stamatis Zampetakis wrote: > > It totally makes sense to have expand=false since this is what we recommend. > > It can be a

Re: withExpand behavior with ANY/ALL subqueries

2023-02-10 Thread Stamatis Zampetakis
It totally makes sense to have expand=false since this is what we recommend. It can be a notable change though for those using SqlToRelConverter as it is so we have to at least put it in a prominent place in the release notes. Best, Stamatis On Fri, Feb 10, 2023 at 10:32 PM Julian Hyde wrote:

Re: withExpand behavior with ANY/ALL subqueries

2023-02-10 Thread Julian Hyde
You should definitely log a bug for this. Please do so. We would prefer that new features in SqlToRelConverter are developed with expand=false. (Rationale: Keeping subqueries as RexSubQuery expressions allows us to handle them later, via a planner rule, which makes the logic more composable and

withExpand behavior with ANY/ALL subqueries

2023-02-10 Thread Jonathan Sternberg
Hi, I'm using Calcite for a project and am attempting to implement the behavior for ANY/ALL such as: SELECT ... FROM ... WHERE a = ANY(SELECT ...) When I attempt to have Calcite create a plan for this query, I get the runtime exception from here: