Re: Some thoughts on bisecting Camel and our git commit practices

2023-06-23 Thread Otavio Rodolfo Piske
Andrea and Peter, I think you raised an important point about the CI: depending on what we decide, they are going to be even more critical to our workflow. I think the last few days have been outliers in terms of CI stability: the recent changes do touch on key parts of our build, so I think some

Re: Newcomer friendly default build, faster fast build and better reproducibility

2023-06-23 Thread Babak Vahdat
Thanks Peter! -- Babak > Am 23.06.2023 um 16:55 schrieb Peter Palaga : > > Thanks for the feedback, Alex and Babak! > > I have found a way how -Pfastinstall could be handled as an alias of > -Dquickly: https://github.com/apache/camel/pull/10483 > Hope that solution is good enough to meet your

Re: Newcomer friendly default build, faster fast build and better reproducibility

2023-06-23 Thread Alexandre Gallice
Well done Peter. There are spies even in maven those days... And here it helps well :) On Fri, Jun 23, 2023 at 4:55 PM Peter Palaga wrote: > Thanks for the feedback, Alex and Babak! > > I have found a way how -Pfastinstall could be handled as an alias of > -Dquickly: https://github.com/apache/ca

Re: Some thoughts on bisecting Camel and our git commit practices

2023-06-23 Thread Andrea Cosentino
As of today, the CI build (both Jenkins and Github action) is less reliable than building locally. So, we could discuss if we could add some better rules in terms of grouping commits or use mandatory PRs, but I don't think we are at that level of trust with CI. Il giorno ven 23 giu 2023 alle ore

Re: Some thoughts on bisecting Camel and our git commit practices

2023-06-23 Thread Peter Palaga
Thanks a lot Otavio, for bringing this up! I can only second Nicolas that CI should not be circumvented unless there is a serious reason. Second, PRs should ideally contain one compilable commit per logical change. As long as there is a just a single such commit in a PR, then the CI can work a

Re: Newcomer friendly default build, faster fast build and better reproducibility

2023-06-23 Thread Peter Palaga
Thanks for the feedback, Alex and Babak! I have found a way how -Pfastinstall could be handled as an alias of -Dquickly: https://github.com/apache/camel/pull/10483 Hope that solution is good enough to meet your needs? Thanks again, -- Peter On 23/06/2023 14:48, Babak Vahdat wrote: On 23

Re: Newcomer friendly default build, faster fast build and better reproducibility

2023-06-23 Thread Babak Vahdat
> On 23 Jun 2023, at 14:27, Alexandre Gallice wrote: > > Beyond bisect scripts, other developers could be impacted... it's a bit > like deprecating a profile. > For the sake of smooth transition, I wonder if it would be possible to have > something like the fastinstall profile setting -Dquickly

Re: Release 4.0-RC1

2023-06-23 Thread Nicolas Filotto
Hi Gregor, I created for you a branch release/4.0.0-RC1 in each repository (camel, camel-examples, camel-spring-boot, and camel-spring-boot-examples). Regards, Nicolas From: Andrea Cosentino Sent: Friday, June 23, 2023 14:05 To: dev@camel.apache.org Subject: Re

Re: Newcomer friendly default build, faster fast build and better reproducibility

2023-06-23 Thread Alexandre Gallice
Beyond bisect scripts, other developers could be impacted... it's a bit like deprecating a profile. For the sake of smooth transition, I wonder if it would be possible to have something like the fastinstall profile setting -Dquickly and printing a message that fastinstall might be possibly removed

Re: Release 4.0-RC1

2023-06-23 Thread Andrea Cosentino
CAMEL-19159 is now fixed. Il giorno ven 23 giu 2023 alle ore 13:52 Andrea Cosentino ha scritto: > To me, we just need to revert the related PRs. > > Il giorno ven 23 giu 2023 alle ore 13:26 Nicolas Filotto < > nfilo...@talend.com> ha scritto: > >> It can be fixed for CR2 as it is a bug >> __

Re: Release 4.0-RC1

2023-06-23 Thread Andrea Cosentino
To me, we just need to revert the related PRs. Il giorno ven 23 giu 2023 alle ore 13:26 Nicolas Filotto < nfilo...@talend.com> ha scritto: > It can be fixed for CR2 as it is a bug > > From: Andrea Cosentino > Sent: Friday, June 23, 2023 12:52 > To: dev@camel.apac

Re: Release 3.21.0

2023-06-23 Thread Gregor Zurowski
Hi Everyone: The branches look good, I am starting with the release process now. Thanks Gregor On Fri, Jun 23, 2023 at 11:45 AM Gregor Zurowski wrote: > > Hi Nicolas, > > Thanks for the fixes. I am taking a look at the branch now and will > send out another message once I start with the release

Re: Release 4.0-RC1

2023-06-23 Thread Nicolas Filotto
It can be fixed for CR2 as it is a bug From: Andrea Cosentino Sent: Friday, June 23, 2023 12:52 To: dev@camel.apache.org Subject: Re: Release 4.0-RC1 Only DynamoDB is pending. We should also look at https://urldefense.com/v3/__https://issues.apache.org/jira/bro

Re: Release 4.0-RC1

2023-06-23 Thread Andrea Cosentino
Only DynamoDB is pending. We should also look at https://issues.apache.org/jira/browse/CAMEL-19491, because it seems we merged PRs based on wrong assumptions. Il giorno ven 23 giu 2023 alle ore 11:10 Nicolas Filotto < nfilo...@talend.com> ha scritto: > Thanks Andrea, your ticket is the last one

Re: Newcomer friendly default build, faster fast build and better reproducibility

2023-06-23 Thread Otavio Rodolfo Piske
So, the primary reason I'd like to keep the fastinstall profile is because I bisect Camel often to find which commit introduced a certain bug, test failure or behavior. If we remove this profile, then I would have to adjust my bisect script so that in newer versions it uses "mvn -Dquickly" and in v

Re: Release 3.21.0

2023-06-23 Thread Gregor Zurowski
Hi Nicolas, Thanks for the fixes. I am taking a look at the branch now and will send out another message once I start with the release. Thanks, Gregor On Fri, Jun 23, 2023 at 8:49 AM Nicolas Filotto wrote: > > Hi, > > The OSGI problem is fixed, so the branches are ready for the release. > > Gre

Re: Newcomer friendly default build, faster fast build and better reproducibility

2023-06-23 Thread Peter Palaga
On 23/06/2023 09:38, Otavio Rodolfo Piske wrote: +1 from me. All in all I think this is a good thing. Our build takes _way_ too long, so any effort that can reduce this time is welcome. Also, I like that this would make the build similar to CEQ. Ideally, in the future, we could also apply the sa

Re: Release 3.21.0

2023-06-23 Thread Nicolas Filotto
Hi Gregor, I created for you a branch release/3.21.0 in each repository (camel, camel-examples, camel-spring-boot, camel-spring-boot-examples, and camel-karaf), I hope it is helpful. Regards, Nicolas From: Nicolas Filotto Sent: Friday, June 23, 2023 08:48 To:

Re: Release 4.0-RC1

2023-06-23 Thread Nicolas Filotto
Thanks Andrea, your ticket is the last one open for RC1 (https://issues.apache.org/jira/issues/?jql=project%20%3D%20CAMEL%20AND%20status%20in%20(Open%2C%20%22In%20Progress%22%2C%20Reopened)%20AND%20fixVersion%20%3D%204.0-RC1) so let us know when it is done. From:

Re: Release 4.0-RC1

2023-06-23 Thread Andrea Cosentino
https://issues.apache.org/jira/browse/CAMEL-19159 Il giorno ven 23 giu 2023 alle ore 11:02 Nicolas Filotto < nfilo...@talend.com> ha scritto: > The 2 dependency upgrades left are fixed now. > > Andrea, what is the link to the issue you are fixing? > > From: Andrea

Re: Release 4.0-RC1

2023-06-23 Thread Nicolas Filotto
The 2 dependency upgrades left are fixed now. Andrea, what is the link to the issue you are fixing? From: Andrea Cosentino Sent: Friday, June 23, 2023 10:16 To: dev@camel.apache.org Subject: Re: Release 4.0-RC1 I would like to complete the AWS profile Credential

Re: Release 4.0-RC1

2023-06-23 Thread Andrea Cosentino
I would like to complete the AWS profile Credentials issues for all the components before RC1. I'll try to finish today. Il giorno ven 23 giu 2023 alle ore 09:55 Nicolas Filotto < nfilo...@talend.com> ha scritto: > Hi, > > There are 2 dependency upgrades left before being ready for the release.

Re: Release 4.0-RC1

2023-06-23 Thread Nicolas Filotto
Hi, There are 2 dependency upgrades left before being ready for the release. Once merged, I will let you know. Regarding the release, Gregor, I don't know exactly what Claus does to prepare it, but if I can help anyhow, please let me know. Regards, Nicolas From

Re: Release 4.0-RC1

2023-06-23 Thread Otavio Rodolfo Piske
Hey Claus, Absolutely. I don't have any big change on my end. My pre-release items are: - Fix the flaky tests on core and components - Minor/safe cleanups here and there - Multi-architecture build and test fixes One note from my end: I'll also be on PTO from July 1st to July 9th. I can come onli

Re: Newcomer friendly default build, faster fast build and better reproducibility

2023-06-23 Thread Otavio Rodolfo Piske
+1 from me. All in all I think this is a good thing. Our build takes _way_ too long, so any effort that can reduce this time is welcome. Also, I like that this would make the build similar to CEQ. Ideally, in the future, we could also apply the same pattern to both CSB and CKC, so that we have an