Sure, created an INFRA ticket to disable it
https://issues.apache.org/jira/browse/INFRA-19914
On Wed, Feb 26, 2020 at 8:00 AM Andrea Cosentino wrote:
> +1 to remove it
>
> Il mer 26 feb 2020, 07:57 Jean-Baptiste Onofre ha
> scritto:
>
> > +1
> >
> > Thanks for the proposal.
> >
> > Regards
> >
+1 to remove it
Il mer 26 feb 2020, 07:57 Jean-Baptiste Onofre ha scritto:
> +1
>
> Thanks for the proposal.
>
> Regards
> JB
>
> > Le 17 déc. 2019 à 16:17, Omar Al-Safi a écrit :
> >
> > Hello folks,
> >
> > Recently, I stumbled across this code analysis tool https://lgtm.com/
> and
> > is fre
+1
Thanks for the proposal.
Regards
JB
> Le 17 déc. 2019 à 16:17, Omar Al-Safi a écrit :
>
> Hello folks,
>
> Recently, I stumbled across this code analysis tool https://lgtm.com/ and
> is free for open source integration. It looks pretty good based on the
> analysis results it gave for camel
+1
---
Luca Burgazzoli
On Wed, Feb 26, 2020 at 5:20 AM Claus Ibsen wrote:
> On Wed, Feb 26, 2020 at 12:53 AM Andrea Tarocchi
> wrote:
> >
> > Sorry to resume this old-ish conversation,
> >
> > do you still see value in having LGTM running on each PR?
> > it takes A LOT of time and it seems re
On Wed, Feb 26, 2020 at 12:53 AM Andrea Tarocchi
wrote:
>
> Sorry to resume this old-ish conversation,
>
> do you still see value in having LGTM running on each PR?
> it takes A LOT of time and it seems reports are seldom taken into account
> in regards to merging/not merging a PR.
> On top of tha
Sorry to resume this old-ish conversation,
do you still see value in having LGTM running on each PR?
it takes A LOT of time and it seems reports are seldom taken into account
in regards to merging/not merging a PR.
On top of that is seems there are 300 error/warning in the findings not
addressed..
I have already addressed most of the errors reported and some of the
warnings, I will wait for the next report to be generated and look if we
still need to fix.
I am going to ask INFRA to enable it and test it and see its scope since I
have no idea about but when I was looking at
https://lgtm.com/p
Le mer. 18 déc. 2019 à 09:15, Claus Ibsen a écrit :
> On Tue, Dec 17, 2019 at 4:17 PM Omar Al-Safi wrote:
> >
> > Hello folks,
> >
> > Recently, I stumbled across this code analysis tool https://lgtm.com/
> and
> > is free for open source integration. It looks pretty good based on the
> > analys
Simpler way, we can just add a badge to the readme file (
https://lgtm.com/help/lgtm/adding-badges-to-project-readme-files), so from
time to time we can take a look at the reports instead of having for every
PR.
On Wed, Dec 18, 2019 at 9:45 AM Omar Al-Safi wrote:
> It looks infra allows it due t
It looks infra allows it due to lgtm new integration
https://issues.apache.org/jira/browse/INFRA-17226?focusedCommentId=16864457&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16864457
On Wed, Dec 18, 2019 at 9:38 AM Luca Burgazzoli
wrote:
> On Wed, Dec 18, 2019
On Wed, Dec 18, 2019 at 9:25 AM Andrea Cosentino wrote:
> Do they require access to the github repo? In that case I do believe Infra
> won't allow us to use it.
>
>
Was actually thinking about the same thing, here what they do require:
https://lgtm.com/help/lgtm/github-apps-integration
> Il gio
Do they require access to the github repo? In that case I do believe Infra
won't allow us to use it.
Il giorno mer 18 dic 2019 alle ore 09:22 Omar Al-Safi ha
scritto:
> That honestly I don't know about. We can give a try for one PR and see how
> long it takes. If it takes some time, we just swit
That honestly I don't know about. We can give a try for one PR and see how
long it takes. If it takes some time, we just switch it off and rely on the
report it generates daily. We can also configure the type of code analysis
which can only limit to what we see that could help.
On Wed, Dec 18, 201
On Tue, Dec 17, 2019 at 4:17 PM Omar Al-Safi wrote:
>
> Hello folks,
>
> Recently, I stumbled across this code analysis tool https://lgtm.com/ and
> is free for open source integration. It looks pretty good based on the
> analysis results it gave for camel (
> https://lgtm.com/projects/g/apache/ca
Hi
Yeah this tools seems at first sight much improved over other tools we
have seen in the past, that gives a lot of false positives and noises.
On Wed, Dec 18, 2019 at 8:55 AM Guillaume Nodet wrote:
>
> Agreed, we can easily create a profile for that.
> In addition, we should quickly review th
You mean as a maven profile? If that is what you mean, sounds to me a good
idea as we did for the checkstyle. However I don't think it will be
possible with that tool since they do the analysis as service. Perhaps we
can look for another tool that we can integrate into maven.
Indeed, I will look at
Agreed, we can easily create a profile for that.
In addition, we should quickly review them because some of the alerts are
actual bugs, like the second one at least.
We can filter the ones that coud be investigated:
https://lgtm.com/projects/g/apache/camel/alerts/?sort=name&dir=ASC&mode=list&tag=c
Hi Omar,
if it's in a profile, why not, but I don't like such tool "forced" in
the default build.
Regards
JB
On 17/12/2019 16:17, Omar Al-Safi wrote:
> Hello folks,
>
> Recently, I stumbled across this code analysis tool https://lgtm.com/ and
> is free for open source integration. It looks pret
Well I was pretty skeptical about it. But by looking at the list, it looks
to me pretty good actually :).
On Tue, Dec 17, 2019 at 4:34 PM Andrea Cosentino
wrote:
> My personal opinion about these tools is the same of the security
> scanners: I really don't like them :-)
>
> --
> Andrea Cosentino
My personal opinion about these tools is the same of the security scanners: I
really don't like them :-)
--
Andrea Cosentino
--
Apache Camel PMC Chair
Apache Karaf Committer
Apache Servicemix PMC Member
Email: ancosen1...@yahoo.com
Twitter: @oscerd2
Github: oscerd
Hello folks,
Recently, I stumbled across this code analysis tool https://lgtm.com/ and
is free for open source integration. It looks pretty good based on the
analysis results it gave for camel (
https://lgtm.com/projects/g/apache/camel/) (sure some of them it can be
neglected). However, I was wond
21 matches
Mail list logo
