Re: [Website] Possible change in components page generation (preview available)

OK I think everything’s ready to merge…. we’ll see if CI agrees :-) David Jencks > On Sep 20, 2021, at 11:48 PM, Zoran Regvart wrote: > > Hi David, > big thanks for cleaning that up! > > On Tue, Sep 21, 2021 at 6:30 AM David Jencks wrote: >> >> I think I’ve covered all the work related to th

Re: [Website] Possible change in components page generation (preview available)

Hi David, big thanks for cleaning that up! On Tue, Sep 21, 2021 at 6:30 AM David Jencks wrote: > > I think I’ve covered all the work related to this in a final PR, > https://github.com/apache/camel/pull/6124. It was supposed to be simple but > I discovered quite a few problems… > > I suspect i

Re: [Website] Possible change in components page generation (preview available)

On Tue, Sep 21, 2021 at 6:30 AM David Jencks wrote: > > I think I’ve covered all the work related to this in a final PR, > https://github.com/apache/camel/pull/6124. It was supposed to be simple but > I discovered quite a few problems… > > I suspect it would be fairly simple to back port these

Re: [Website] Possible change in components page generation (preview available)

I think I’ve covered all the work related to this in a final PR, https://github.com/apache/camel/pull/6124. It was supposed to be simple but I discovered quite a few problems… I suspect it would be fairly simple to back port these changes to 3.11.x. Shall I look into doing that? 3.7.x would

Re: [Website] Possible change in components page generation (preview available)

> On Sep 13, 2021, at 8:05 AM, Zoran Regvart wrote: > > Hi Cameleers, > some of these changes are in, and for the last one explicitly stated > in the $subject I'll create a pull request soon. > > You will notice changes in the workflow and in the git repository. > We're now using symbolic lin

Re: [Website] Possible change in components page generation (preview available)

Hi Cameleers, some of these changes are in, and for the last one explicitly stated in the $subject I'll create a pull request soon. You will notice changes in the workflow and in the git repository. We're now using symbolic links and not copying files over to the docs directory, with the jsonpath

Re: [Website] Possible change in components page generation (preview available)

On Sat, Sep 11, 2021 at 11:06 PM David Jencks wrote: > I was inspired:-) and came up with > https://github.com/apache/camel-website/pull/624 Awesome, thanks, merged :) zoran -- Zoran Regvart

Re: [Website] Possible change in components page generation (preview available)

Hi David, On Fri, Sep 10, 2021 at 7:36 PM David Jencks wrote: ...snip... > I certainly agree build speed is important. However, I also think that we > should make it difficult for people to edit the docs and not look at the > results: this is analogous to changing the java code and not checkin

Re: [Website] Possible change in components page generation (preview available)

I was inspired:-) and came up with https://github.com/apache/camel-website/pull/624 David Jencks > On Sep 8, 2021, at 11:19 AM, Zoran Regvart wrote: > > Hi David, > > On Wed, Sep 8, 2021 at 4:42 PM David Jencks wrote: >> I’m going to leave checking the sitemap generation to you because AFAIC

Re: [Website] Possible change in components page generation (preview available)

> On Sep 10, 2021, at 12:57 AM, Zoran Regvart wrote: > > Hi David, > > On Thu, Sep 9, 2021 at 6:36 PM David Jencks wrote: >> I wonder if we could have, as part of the maven build of a component, >> perhaps in a profile, Antora build just that component's doc page. It might >> be possible t

Re: [Website] Possible change in components page generation (preview available)

Hi David & Cameleers, after much arguing with Gulp I created a pull request for the next step in this: to use symbolic links instead of file copies for the documentation. The pull request is up for review and I very much welcome feedback, for example I did not test this other than on a Unix (Linux)

Re: [Website] Possible change in components page generation (preview available)

Hi David, On Thu, Sep 9, 2021 at 6:36 PM David Jencks wrote: > I wonder if we could have, as part of the maven build of a component, perhaps > in a profile, Antora build just that component's doc page. It might be > possible to make this visible as part of the whole Antora site using the > sit

Re: [Website] Possible change in components page generation (preview available)

Hi David & Cameleers, On Thu, Sep 9, 2021 at 6:57 PM David Jencks wrote: > > Overall I like the gulp file changes, I left one comment. Thanks for that, good point, I think for future maintenance it's important to have the Gulp build as understandable as possible. Otherwise we'll end up with blac

Re: [Website] Possible change in components page generation (preview available)

Overall I like the gulp file changes, I left one comment. I discovered another anomaly you might like to investigate: Is components/camel-disruptor/src/main/docs/disruptor-vm-component.adoc supposed to exist? It doesn’t appear to have a json file for properties etc, and it’s rendering in the cu

Re: [Website] Possible change in components page generation (preview available)

> On Sep 8, 2021, at 11:22 AM, Zoran Regvart wrote: > > Hi David & Cameleers, > > On Wed, Sep 8, 2021 at 4:48 PM David Jencks > wrote: >> >>> >> - If nothing else is using the model building in UpdateReadmeMojo it can >> probably be simplified furth

Re: [Website] Possible change in components page generation (preview available)

Hi David & Cameleers, I've made some progress in the main Camel repository focusing on the Gulp tasks to generate symlinks and maintain nav.adoc files. Much inspired by the work David did on the JSON files and trying to generate Gulp tasks from data rather than having multiple, mostly same, functio

Re: [Website] Possible change in components page generation (preview available)

Hi I am on PTO this week. So will walk away from the computer in a minute. Good work and progress on this one. On Tue, Aug 17, 2021 at 7:42 AM David Jencks wrote: > > I’ve made a lot of progress on this and put up a preview of the current > state. Only components in the latest branch are done

Re: [Website] Possible change in components page generation (preview available)

Hi David & Cameleers, On Wed, Sep 8, 2021 at 4:48 PM David Jencks wrote: > > > > - If nothing else is using the model building in UpdateReadmeMojo it can > probably be simplified further. > >>> > >>> From what I understand we only need the JSON files generated now, > >>> perhaps the w

Re: [Website] Possible change in components page generation (preview available)

Hi David, On Wed, Sep 8, 2021 at 4:42 PM David Jencks wrote: > I’m going to leave checking the sitemap generation to you because AFAICT they > are correct when generated with the site:url. > > Would you like to make the UI changes you suggest or shall I write a PR? I can definitively have a go,

Re: [Website] Possible change in components page generation (preview available)

FWIW all the changes I’ve proposed to repos other than camel main and camel-website have already been merged. In any case this is an excellent strategy :-) David Jencks > On Sep 8, 2021, at 5:59 AM, Zoran Regvart wrote: > > Hi David & Cameleers, > I've decided to pick smaller changes into se

Re: [Website] Possible change in components page generation (preview available)

> - If nothing else is using the model building in UpdateReadmeMojo it can probably be simplified further. >>> >>> From what I understand we only need the JSON files generated now, >>> perhaps the we don't need the UpdateReadmeMojo at all any more? >> >> Perhaps. It still generates t

Re: [Website] Possible change in components page generation (preview available)

Hi Zoran! I’m going to leave checking the sitemap generation to you because AFAICT they are correct when generated with the site:url. Would you like to make the UI changes you suggest or shall I write a PR? Thanks! David Jencks > On Sep 8, 2021, at 2:26 AM, Zoran Regvart wrote: > > Hi David,

Re: [Website] Possible change in components page generation (preview available)

Hi David & Cameleers, I've decided to pick smaller changes into separate PRs, starting first with the camel-website ones, I think we can get those merged and then piecemeal merge changes to the non-website repositories. Reason behind this is to try to scope the changes being merged, allowing for ea

Re: [Website] Possible change in components page generation (preview available)

Hi David, and Cameleers trying to follow this while David and myself geek out :) On Tue, Sep 7, 2021 at 1:12 PM Zoran Regvart wrote: > On Wed, Sep 1, 2021 at 8:42 AM David Jencks wrote: > > > > With both the CI build for my PR and locally, `yarn build-all` is building > > the UI after the main

Re: [Website] Possible change in components page generation (preview available)

Hi David, On Tue, Sep 7, 2021 at 7:32 PM David Jencks wrote: > > I investigated the patch-sitemap.js question a bit. > > Using my `issue-16854-jsonpath-options` camel-website branch, I built the > site twice, with site:url set to `https://camel.apache.org` and set to `/`. > I didn’t look at ev

Re: [Website] Possible change in components page generation (preview available)

Hi David, snipping a bunch of text, trying to keep this short for other folk to follow... On Tue, Sep 7, 2021 at 5:22 PM David Jencks wrote: > > On Fri, Sep 3, 2021 at 8:21 AM David Jencks > > wrote: > >> comments: > >> > >> - I removed the patch-sitemap.js use. I can’t figure out why this is

Re: [Website] Possible change in components page generation (preview available)

I investigated the patch-sitemap.js question a bit. Using my `issue-16854-jsonpath-options` camel-website branch, I built the site twice, with site:url set to `https://camel.apache.org` and set to `/`. I didn’t look at every page, but diffing the generated sites seems to consistently show two

Re: [Website] Possible change in components page generation (preview available)

Hi Zoran, I just pushed some more fixes, I hope this isn’t making reviewing too hard. Starting far back in the email chain is probably pretty confusing, since I or others have fixed a lot of the problems noted. I’ve tried to summarize all the current problems in each email: I think I should ha

Re: [Website] Possible change in components page generation (preview available)

Hi David, working through the changes and emails, some more comments here... On Fri, Sep 3, 2021 at 8:21 AM David Jencks wrote: > comments: > > - I removed the patch-sitemap.js use. I can’t figure out why this is needed. > If it really is needed, it should be done with a pipeline extension. I

Re: [Website] Possible change in components page generation (preview available)

Hi David, On Wed, Sep 1, 2021 at 8:42 AM David Jencks wrote: > > With both the CI build for my PR and locally, `yarn build-all` is building > the UI after the main build command. Obviously this doesn’t work. Can you point to the CI build that does that so I can have a look? > Can someone poi

Re: [Website] Possible change in components page generation (preview available)

Hi David, On Sun, Aug 29, 2021 at 10:20 AM David Jencks wrote: > The current source state is now visible. First of all, thank you this is a herculean effort, and I think it'll help us tremendously! > - I npm-published my asciidoctor-jsonpath extension > - The site content changes are at https:/

Re: [Website] Possible change in components page generation (preview available)

I’ve addressed all the problems I know about…. now we can find more :-) At this point I think we could apply the PRs and work from there. In more detail: (1) https://github.com/apache/camel-kamelets/pull/487 fixes the Kamelet catalog rendering and AFAICT doesn’t break the Antora 2 build. I’d m

Re: [Website] Possible change in components page generation (preview available)

Hi Great work David. I noticed the data formats table, then the 1st row is in bold, and the others are not, and the styling of the javaType is also different https://pr-614--camel.netlify.app/components/latest/dataformats/thrift-dataformat.html And for languages then we should skip the "expressi

Re: [Website] Possible change in components page generation (preview available)

I’ve been thinking of this as monolithic across repositories (camel and camel-website at least) but perhaps a more sensible path is to put the attribute fixes in camel main into a separate PR, and then update camel-website to use Antora 3, and configure it to make @djencks/asciidoctor-jsonpath

Re: [Website] Possible change in components page generation (preview available)

I think this work is complete enough to be used. There’s now a Ci built preview at https://pr-614--camel.netlify.app The main work is on https://github.com/apache/camel/pull/6040. Possibly the commits should be squashed into fewer. Once this is merged the camel-website PR can be updated to us

Re: [Website] Possible change in components page generation (preview available)

With both the CI build for my PR and locally, `yarn build-all` is building the UI after the main build command. Obviously this doesn’t work. Can someone point to a situation in which the UI is built before it is used? Any ideas why yarn is picking this dysfunctional workspace build order? Da

Re: [Website] Possible change in components page generation (preview available)

On Sun, Aug 29, 2021 at 10:20 AM David Jencks wrote: > > The current source state is now visible. > > - I npm-published my asciidoctor-jsonpath extension > - The site content changes are at https://github.com/djencks/camel.git > jsonpath-options branch. I’ve put all the generated changes as the l

Re: [Website] Possible change in components page generation (preview available)

The current source state is now visible. - I npm-published my asciidoctor-jsonpath extension - The site content changes are at https://github.com/djencks/camel.git jsonpath-options branch. I’ve put all the generated changes as the last commit, so it should be possible to update the branch by dro

Re: [Website] Possible change in components page generation (preview available)

Hi Ah yeah those were an idea to include the full page documentation in case tooling may be able to use that for something useable. However the tooling uses all the other bits, so we have just marked those apis as deprecated. So we can remove the files from the camel-catalog. I have created a tic

Re: [Website] Possible change in components page generation (preview available)

Hi David, On Sat, Aug 21, 2021 at 10:10 PM David Jencks wrote: > > I have a question about the purpose of the .adoc files in the catalog. The > changes proposed here will remove the tables of options from these copies of > the component .adoc files. These copies are already quite skimpy as th

Re: [Website] Possible change in components page generation (preview available)

I have a question about the purpose of the .adoc files in the catalog. The changes proposed here will remove the tables of options from these copies of the component .adoc files. These copies are already quite skimpy as they don’t successfully include the spring-boot information. What are the

Re: [Website] Possible change in components page generation (preview available)

Hi Zoran, > On Aug 17, 2021, at 2:46 AM, Zoran Regvart wrote: > > Hi David > > On Tue, Aug 17, 2021 at 7:42 AM David Jencks wrote: >> >> I’ve made a lot of progress on this and put up a preview of the current >> state. Only components in the latest branch are done (not dataformats, eips, >>

Re: [Website] Possible change in components page generation (preview available)

Hi David On Tue, Aug 17, 2021 at 7:42 AM David Jencks wrote: > > I’ve made a lot of progress on this and put up a preview of the current > state. Only components in the latest branch are done (not dataformats, eips, > languages, other, and not other versions). Perhaps we can create (sub)issues

Re: [Website] Possible change in components page generation (preview available)

I’ve made a lot of progress on this and put up a preview of the current state. Only components in the latest branch are done (not dataformats, eips, languages, other, and not other versions). The arrangement of, in particular, API data didn’t make much sense to me so I reorganized it so relevan