Re: RFC: deprecating camel-testcontainers modules

2022-02-09 Thread Otavio Rodolfo Piske
; > Hello, > > > > I was talking to Luca a while ago where he pointed me to this discussion > on > > StackOverflow [1]. This reminded me that last year I raised this > suggestion > > about deprecating some of the camel-testcontainers components. I think we > > ha

Re: RFC: deprecating camel-testcontainers modules

2022-02-08 Thread Claus Ibsen
On Tue, Feb 8, 2022 at 9:32 AM Otavio Rodolfo Piske wrote: > > Hello, > > I was talking to Luca a while ago where he pointed me to this discussion on > StackOverflow [1]. This reminded me that last year I raised this suggestion > about deprecating some of the camel-testcontai

Re: RFC: deprecating camel-testcontainers modules

2022-02-08 Thread Otavio Rodolfo Piske
Hello, I was talking to Luca a while ago where he pointed me to this discussion on StackOverflow [1]. This reminded me that last year I raised this suggestion about deprecating some of the camel-testcontainers components. I think we have migrated all of our code to test-infra by now. I am

Re: RFC: deprecating camel-testcontainers modules

2021-01-14 Thread Otavio Rodolfo Piske
://github.com/apache/camel/tree/master/test-infra Kind regards On Fri, Jan 8, 2021 at 10:00 AM Alexandre Gallice wrote: > I see no show stopper to deprecation. > Some camel-testcontainers-junit5 users out in the community might enjoy a > short and concise migration guide with explana

Re: RFC: deprecating camel-testcontainers modules

2021-01-08 Thread Alexandre Gallice
I see no show stopper to deprecation. Some camel-testcontainers-junit5 users out in the community might enjoy a short and concise migration guide with explanation from Otavio above. On Fri, Jan 8, 2021 at 9:00 AM Andrea Cosentino wrote: > I'm ok with deprecating the classes :-) >

Re: RFC: deprecating camel-testcontainers modules

2021-01-08 Thread Andrea Cosentino
ned removing them before the next LTS, but, > > indeed, this may be way too soon. > > > > Kind regards > > > > On Thu, Jan 7, 2021 at 2:49 PM Andrea Cosentino > wrote: > > > >> I use test-infra stuff even at ckc but before deprecating the > >&g

Re: RFC: deprecating camel-testcontainers modules

2021-01-07 Thread Otavio Rodolfo Piske
ra stuff even at ckc but before deprecating the >> testcontainers components I'd like to have feedback from existing users.. >> >> Il mar 5 gen 2021, 11:36 Otavio Rodolfo Piske ha >> scritto: >> >> > Thanks Claus! That's a good point and I haven't writ

Re: RFC: deprecating camel-testcontainers modules

2021-01-07 Thread Otavio Rodolfo Piske
, 2021 at 2:49 PM Andrea Cosentino wrote: > I use test-infra stuff even at ckc but before deprecating the > testcontainers components I'd like to have feedback from existing users.. > > Il mar 5 gen 2021, 11:36 Otavio Rodolfo Piske ha > scritto: > > > Thanks Claus! That

Re: RFC: deprecating camel-testcontainers modules

2021-01-07 Thread Andrea Cosentino
I use test-infra stuff even at ckc but before deprecating the testcontainers components I'd like to have feedback from existing users.. Il mar 5 gen 2021, 11:36 Otavio Rodolfo Piske ha scritto: > Thanks Claus! That's a good point and I haven't written much - other than > th

Re: RFC: deprecating camel-testcontainers modules

2021-01-05 Thread Otavio Rodolfo Piske
camel/component/pg/replication/slot/integration/PgReplicationTestSupport.java#L31 13. https://github.com/apache/camel/pull/4706/files On Tue, Jan 5, 2021 at 10:36 AM Claus Ibsen wrote: > Hi Otavia > > Great work. > > Can you maybe tell a bit about what if an end user have used > ca

Re: RFC: deprecating camel-testcontainers modules

2021-01-05 Thread Andrea Cosentino
Hello, I think it's probably too early to deprecate testcontainers modules, because test-infra modules are probably less easy to use currently. I would leave them without deprecation for the moment. But lets wait for more feedback. Il giorno mar 5 gen 2021 alle ore 10:36 Claus Ibse

Re: RFC: deprecating camel-testcontainers modules

2021-01-05 Thread Claus Ibsen
Hi Otavia Great work. Can you maybe tell a bit about what if an end user have used camel-testcontainers-junit5 to do his/her own container testing with Camel (for example to use their own container image, or for example a database container or something). How would they do that today with the

RFC: deprecating camel-testcontainers modules

2021-01-05 Thread Otavio Rodolfo Piske
tests from Localstack containers to an actual AWS instance by simply adjusting the test parameters. It still uses testcontainers under the hood, but it is abstracted from the test code. As result of this migration, the code in the following components has become unused within Camel: - camel-test

Re: R: [camel] branch master updated: Revert "Upgrade TestContainers to version 1.9.0", because "org.testcontainers:testcontainers:jar:1.9.0" is not in maven central yet.

2018-09-10 Thread Pascal Schumacher
No problem, I just wanted to fix the build on builds.apache.org: e.g.: https://builds.apache.org/view/C/view/Apache%20Camel/job/Camel/job/master/623/console org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal on project camel-testcontainers: Could not resolve

R: [camel] branch master updated: Revert "Upgrade TestContainers to version 1.9.0", because "org.testcontainers:testcontainers:jar:1.9.0" is not in maven central yet.

2018-09-10 Thread Andrea Cosentino
it to branch master in repository https://gitbox.apache.org/repos/asf/camel.git The following commit(s) were added to refs/heads/master by this push:     new ad8308c  Revert "Upgrade TestContainers to version 1.9.0", because "org.testcontainers:testcontainers:jar:1.9.0" is

Re: JUnit5, was: testcontainers

2018-06-17 Thread Pascal Schumacher
-1330 to be merged to get surefire support? Den ons. 23. mai 2018 kl. 10:08 skrev Zoran Regvart : Hi, on the testcontainers thread I mentioned that we can switch to JUnit5. I've attended a talk by Sam Brannen at the local JUG. I think it was a variant of the talk[1] he gave at SpringOne

Re: JUnit5, was: testcontainers

2018-06-16 Thread David Karlsen
for > > https://issues.apache.org/jira/browse/SUREFIRE-1330 to be merged to get > > surefire support? > > > > Den ons. 23. mai 2018 kl. 10:08 skrev Zoran Regvart : > > > >> Hi, > >> on the testcontainers thread I mentioned that we can switch to JUnit5. > &g

[GitHub] camel pull request #2362: CAMEL-12534: create camel-testcontainers

2018-06-05 Thread lburgazzoli
Github user lburgazzoli closed the pull request at: https://github.com/apache/camel/pull/2362 ---

[GitHub] camel pull request #2362: CAMEL-12534: create camel-testcontainers

2018-06-05 Thread lburgazzoli
GitHub user lburgazzoli opened a pull request: https://github.com/apache/camel/pull/2362 CAMEL-12534: create camel-testcontainers Initial bits of testcontainers integration with camel test suite. ### WHAT'S NEW - two new modules: - camel-testconta

Re: testcontainers

2018-05-23 Thread Luca Burgazzoli
mage would have helped > in testing a regular camel component. > Would it be in the scope of camel-testcontainers ? I mean building a custom > image, pushing it to docker hub and use that for route level tests of a > regular component ? > > Alex > > > > On Wed, May

Re: testcontainers

2018-05-23 Thread Alex Dettinger
Hi Luca, +1 as you demonstrated the use to test starters. I already faced a situation where a custom docker image would have helped in testing a regular camel component. Would it be in the scope of camel-testcontainers ? I mean building a custom image, pushing it to docker hub and use that

Re: JUnit5, was: testcontainers

2018-05-23 Thread Zoran Regvart
v Zoran Regvart : > >> Hi, >> on the testcontainers thread I mentioned that we can switch to JUnit5. >> I've attended a talk by Sam Brannen at the local JUG. I think it was a >> variant of the talk[1] he gave at SpringOne 2017. >> >> The key takeaway for m

Re: JUnit5, was: testcontainers

2018-05-23 Thread David Karlsen
Would you have to await for https://issues.apache.org/jira/browse/SUREFIRE-1330 to be merged to get surefire support? Den ons. 23. mai 2018 kl. 10:08 skrev Zoran Regvart : > Hi, > on the testcontainers thread I mentioned that we can switch to JUnit5. > I've attended a talk by Sam

JUnit5, was: testcontainers

2018-05-23 Thread Zoran Regvart
Hi, on the testcontainers thread I mentioned that we can switch to JUnit5. I've attended a talk by Sam Brannen at the local JUG. I think it was a variant of the talk[1] he gave at SpringOne 2017. The key takeaway for me was that JUnit5 is forward and backward compatible, so you can run the

Re: testcontainers

2018-05-23 Thread Luca Burgazzoli
; > I would also consider marking those as integration tests so they are >>> > run only if we want them to be run, or in environments that we know >>> > they'll run without issues. >>> > >>> >>> As first iteration I'd use profiles, jun

Re: testcontainers

2018-05-23 Thread Luca Burgazzoli
n only if we want them to be run, or in environments that we know >> > they'll run without issues. >> > >> >> As first iteration I'd use profiles, junit 5 is not exatly as easy as >> junit 4 is. >> >> > zoran >> > >>

Re: testcontainers

2018-05-22 Thread Willem Jiang
un only if we want them to be run, or in environments that we know > > they'll run without issues. > > > > As first iteration I'd use profiles, junit 5 is not exatly as easy as > junit 4 is. > > > zoran > > > > On Tue, May 22, 2018 at 5:35 PM, Luca

Re: testcontainers

2018-05-22 Thread Luca Burgazzoli
gt; > On Tue, May 22, 2018 at 5:35 PM, Luca Burgazzoli > wrote: >> Hi all, >> >> I've been using testcontainers [1] for a while and I found it useful >> to test against non java services such as consul, etcd and so on so >> I'd like to create a camel-testc

Re: testcontainers

2018-05-22 Thread Claus Ibsen
+1 On Tue, May 22, 2018 at 5:35 PM, Luca Burgazzoli wrote: > Hi all, > > I've been using testcontainers [1] for a while and I found it useful > to test against non java services such as consul, etcd and so on so > I'd like to create a camel-testcontainers "c

Re: testcontainers

2018-05-22 Thread Onder SEZGIN
ool that we can start the container in the Java unit test. > > > > @Luca > > Could you provide a typic use case(with code) of using > camel-testcontainers? > > Normally, we just need to spin up the service image for the testing, I > > think testcontainer already provi

Re: testcontainers

2018-05-22 Thread Luca Burgazzoli
23, 2018 at 12:35 AM, Willem Jiang wrote: > Hi > > I just go through the test container introduction, > it's cool that we can start the container in the Java unit test. > > @Luca > Could you provide a typic use case(with code) of using camel-testcontainers? > Normally,

Re: testcontainers

2018-05-22 Thread Willem Jiang
Hi I just go through the test container introduction, it's cool that we can start the container in the Java unit test. @Luca Could you provide a typic use case(with code) of using camel-testcontainers? Normally, we just need to spin up the service image for the testing, I think testcont

Re: testcontainers

2018-05-22 Thread Zoran Regvart
them to be run, or in environments that we know they'll run without issues. zoran On Tue, May 22, 2018 at 5:35 PM, Luca Burgazzoli wrote: > Hi all, > > I've been using testcontainers [1] for a while and I found it useful > to test against non java services such as consul, e

Re: testcontainers

2018-05-22 Thread Luca Burgazzoli
Yes test only, sometimes you do not have a java test framework to spin up an instance of the target service you want to integrate so having some support in camel to spin up a containerized service may be useful. I used testcontainers to test etcd and consul and by spinning up a container for the

Re: testcontainers

2018-05-22 Thread Paul Gale
> > Thanks, > Paul > > On Tue, May 22, 2018 at 11:35 AM, Luca Burgazzoli > wrote: > >> Hi all, >> >> I've been using testcontainers [1] for a while and I found it useful >> to test against non java services such as consul, etcd and so on so >>

Re: testcontainers

2018-05-22 Thread Paul Gale
What would be some example use cases that illustrate the need to manage containers using Camel in particular? Just testing only? Thanks, Paul On Tue, May 22, 2018 at 11:35 AM, Luca Burgazzoli wrote: > Hi all, > > I've been using testcontainers [1] for a while and I found it us

R: testcontainers

2018-05-22 Thread Andrea Cosentino
Great idea! +1 Il mar, 22 mag, 2018 alle 17:35, Luca Burgazzoli ha scritto: Hi all, I've been using testcontainers [1] for a while and I found it useful to test against non java services such as consul, etcd and so on so I'd like to create a camel-testcontainers "component

testcontainers

2018-05-22 Thread Luca Burgazzoli
Hi all, I've been using testcontainers [1] for a while and I found it useful to test against non java services such as consul, etcd and so on so I'd like to create a camel-testcontainers "component" that includes some facilities like a dedicated test support that take care