Re: cgen into the future

2021-10-10 Thread Aristedes Maniatis
On 11/10/21 2:56am, Michael Gentry wrote: If someone generated the "incorrect" classes from the default templates, cgen would fix that mistake for them when they built the project (happened frequently enough that I made it part of the build process). This isn't true when deleting or renaming an

Re: cgen into the future

2021-10-10 Thread Michael Gentry
On Sun, Oct 10, 2021 at 3:04 AM Aristedes Maniatis wrote: > Can you explain a bit more? We don't store generated superclasses in > version control since that's confusing and redundant. [1] This is > similar to how we don't store swagger generated classes in version > control for the server side

Re: cgen into the future

2021-10-10 Thread Mike Kienenberger
On Sun, Oct 10, 2021 at 5:09 AM Andrus Adamchik wrote: > I expected tools removal to be a controversial proposal. Still decided to > throw it out there. I am always looking for opportunities to minimize our > support footprint (hi, ROP :)). Properly maintaining the tools across 3 > build systems

Re: cgen into the future

2021-10-10 Thread Andrus Adamchik
> I don't see the benefit in storing the output of generated code in version > control. There's no benefit, but there's no downside either. I barely give it a thought during my daily work. Entity removal is probably the only snag, but it is not completely addressed by not having superclasses in

Re: cgen into the future

2021-10-10 Thread Aristedes Maniatis
I don't see the benefit in storing the output of generated code in version control. It makes commit history more noisy and hard to read without any real benefit. For just this one project, that includes: * Cayenne * Swagger * Antlr So if someone makes a change to the data model of one of those

Re: CI

2021-10-10 Thread Andrus Adamchik
Oops. I guess we shouldn't jump to GA just yet. > On Oct 10, 2021, at 10:28 AM, Nikita Timofeev > wrote: > > > Hi all, > I've read about limitations on the Apache side. It turns out not so great in > that case. There's only approved actions available and, more important, > there's limited nu

Re[2]: CI

2021-10-10 Thread Nikita Timofeev
Hi all, I've read about limitations on the Apache side. It turns out not so great in that case. There's only approved actions available and, more important, there's limited number of runners available for *all* Apache projects. Ifra warns that it could be really slow [1] [1] https://cwiki.apac

Re: cgen into the future

2021-10-10 Thread Andrus Adamchik
> We don't store generated superclasses in version control since that's > confusing and redundant. I commit generated superclasses to Git everywhere. Never caused any issues that I can remember. But yes, I think that would be a prerequisite to switching away from cgen in build scripts to the Mo

Re: CI

2021-10-10 Thread Andrus Adamchik
> [1] https://github.com/ishgroup/oncourse/actions Nice! FWIW Bootique is using Github Actions for its dozens of modules, including cross-DB tests. A huge improvement over Travis. > However a bit more limited with regard to database choices. We can run tests against any database that has a Doc

cgen into the future

2021-10-10 Thread Aristedes Maniatis
On 10/10/21 5:42pm, Andrus Adamchik wrote: A bit OT... Before 4.1 all my projects used cgen and most - cdbimport. Not anymore. Things went full circle and Modeler has become the only way to sync up project with the DB. DataMap XML file now stores all the settings of the c* tasks. So now I c