Github user kwhitehall commented on the issue:
https://github.com/apache/climate/pull/439
Hey @lewismc
Tested and found the following:
1. need to convert this spaces to tabs in this folder
2. updated code to reduce the number of datasets needed to test.
Code for
Github user kwhitehall commented on the issue:
https://github.com/apache/climate/pull/439
Ack'ed @lewismc
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wish
Github user kwhitehall closed the pull request at:
https://github.com/apache/climate/pull/196
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user kwhitehall commented on the pull request:
https://github.com/apache/climate/pull/207#issuecomment-145014907
This was addressed in a later PR for CLIMATE-654.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user kwhitehall closed the pull request at:
https://github.com/apache/climate/pull/207
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user kwhitehall opened a pull request:
https://github.com/apache/climate/pull/207
CLIMATE-642 - Fix improper unit set in water_flux_unit_conversion
- removed 'swe' conversion to SI units (km) as this is neither common nor
CF convention
You can merge this pull requ
Github user kwhitehall commented on the pull request:
https://github.com/apache/climate/pull/196#issuecomment-101771065
@darth-pr From the latter comments on @huikyole PR#197 it would appear that
the request is to deprecate this and a number of other functions with another
function
Github user kwhitehall commented on the pull request:
https://github.com/apache/climate/pull/196#issuecomment-101379241
@huikyole I'm not entirely sure I am following your slide on PR #197
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user kwhitehall commented on the pull request:
https://github.com/apache/climate/pull/196#issuecomment-101378372
@MJJoyce thanks for the advice! I'm not entirely sure it's for the code
base in general, more so for explanation of what's going on here. But if you
Github user kwhitehall commented on a diff in the pull request:
https://github.com/apache/climate/pull/197#discussion_r30156559
--- Diff: examples/simple_model_to_model_bias_DJF_and_JJA.py ---
@@ -0,0 +1,64 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user kwhitehall commented on the pull request:
https://github.com/apache/climate/pull/196#issuecomment-101349340
@chrismattmann I've added a unittest as suggested. (I can clean it up
later if we decide to keep it The purpose is to illustrate the shape of the
dataset
Github user kwhitehall commented on the pull request:
https://github.com/apache/climate/pull/196#issuecomment-101144654
The reshape function was moved out of the if-else statement.
The offset variable is used to shift the DS.values to "begin" @ that month
The mont
Github user kwhitehall commented on the pull request:
https://github.com/apache/climate/pull/196#issuecomment-101124957
@huikyole thank you for your review. As the tix indicates, this is a bug.
If one tried to use month_start=12 and month_end=2 for a dataset, the code in
the if block
GitHub user kwhitehall opened a pull request:
https://github.com/apache/climate/pull/196
CLIMATE-634 Fix bug related to month_start > month_end
- Fix offset to apply to DS.values in if-else statement
You can merge this pull request into a Git repository by running:
$ git p
Github user kwhitehall commented on the pull request:
https://github.com/apache/climate/pull/194#issuecomment-97553355
This merge failed because of the following import
from pyhdf.SD import SD
@MJJoyce can you please advice here? I
---
If your project is set up for it, you
Github user kwhitehall commented on a diff in the pull request:
https://github.com/apache/climate/pull/194#discussion_r29371122
--- Diff: ocw/data_source/local.py ---
@@ -109,6 +111,61 @@ def _get_netcdf_variable_name(valid_var_names, netcdf,
netcdf_var):
)
raise
Github user kwhitehall commented on the pull request:
https://github.com/apache/climate/commit/ee3854e4a0253de7fae707f705b1457f8b6cb82f#commitcomment-10969603
Please check what is causing the test to fail. I noticed something in
dataset.py that may be causing the error. Also, please
Github user kwhitehall commented on the pull request:
https://github.com/apache/climate/commit/ee3854e4a0253de7fae707f705b1457f8b6cb82f#commitcomment-10969554
In ocw/dataset.py:
if lat_dim == 1 lon_count isn't set.
---
If your project is set up for it, you can reply to
Github user kwhitehall commented on the pull request:
https://github.com/apache/climate/commit/ee3854e4a0253de7fae707f705b1457f8b6cb82f#commitcomment-10969513
In ocw/dataset.py:
Please check the functionality here.
---
If your project is set up for it, you can reply to this
Github user kwhitehall commented on the pull request:
https://github.com/apache/climate/pull/112#issuecomment-97084414
Ack @chrismattmann and @MJJoyce. Thanks for the advice, still learning!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user kwhitehall commented on the pull request:
https://github.com/apache/climate/pull/111#issuecomment-96043711
@huikyole This PR needs cleaning.
For e.g. what your tix says, and what work has been done here don't align.
Please be certain to include the other function
Github user kwhitehall commented on the pull request:
https://github.com/apache/climate/pull/112#issuecomment-95965439
@huikyole Please close this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user kwhitehall commented on the pull request:
https://github.com/apache/climate/pull/112#issuecomment-95965230
Resolve CLIMATE-508. Merged PR#112.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user kwhitehall commented on the pull request:
https://github.com/apache/climate/pull/112#issuecomment-95783622
@huikyole I looked through this code, but I don't see the dependency to
#111 that you refer.
If it is a dependency that is wrapped up in an example, then I
Github user kwhitehall commented on the pull request:
https://github.com/apache/climate/pull/125#issuecomment-95728971
@huikyole please close this PR. The issue has been resolved in PR #127.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user kwhitehall commented on the pull request:
https://github.com/apache/climate/pull/112#issuecomment-95727966
@MJJoyce @cgoodale @huikyole @chrismattmann This is great functionality
to have in the code base which been demonstrated to work. It has been
outstanding here for
Github user kwhitehall closed the pull request at:
https://github.com/apache/climate/pull/191
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user kwhitehall commented on a diff in the pull request:
https://github.com/apache/climate/pull/192#discussion_r28974879
--- Diff: ocw/dataset.py ---
@@ -180,17 +180,23 @@ def _validate_inputs(self, lats, lons, times, values):
err_msg = "Longitude
GitHub user kwhitehall opened a pull request:
https://github.com/apache/climate/pull/193
CLIMATE-624 - fix logical error in subregions_portrait_diagram.py exampl...
...e
- Update the function call used to use calc_climatology_year
- Update to normalize_dataset_datetimes
Github user kwhitehall commented on the pull request:
https://github.com/apache/climate/pull/192#issuecomment-94969390
The change in dataset_processor.py is very cumbersome. I couldn't think of
a way to write it more succinctly. @cgoodale @MJJoyce @MBoustani any
suggestions wou
GitHub user kwhitehall opened a pull request:
https://github.com/apache/climate/pull/192
CLIMATE-623 - Allow propogation of 2D arrays
- update subset function in DSP to subset 2D (lat,lon) arrays
- update Dataset class to allow 2D (lat,lon) arrays
- update associated test in
GitHub user kwhitehall opened a pull request:
https://github.com/apache/climate/pull/191
CLIMATE-622 - allow Bounds object to take optional start and end times
- Update the start and end parameter in the Bounds class in DS to optional
parameters
- Update the subset and
GitHub user kwhitehall opened a pull request:
https://github.com/apache/climate/pull/190
Add example script of timeseries for subregions
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kwhitehall/climate CLIMATE-613
Github user kwhitehall commented on the pull request:
https://github.com/apache/climate/pull/184#issuecomment-91708558
I messed up trying to close this PR. It is closed with the commit messages
'Add a function to calculate time series' and 'Add unittest to test
calc_
Github user kwhitehall closed the pull request at:
https://github.com/apache/climate/pull/184
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user kwhitehall opened a pull request:
https://github.com/apache/climate/pull/188
CLIMATE-586 - add barchart as a plotter option
- add draw_barchart function to plotter.py to plot basic (horizontal)
barchart
You can merge this pull request into a Git repository by running
Github user kwhitehall commented on a diff in the pull request:
https://github.com/apache/climate/pull/183#discussion_r27177986
--- Diff: ocw/utils.py ---
@@ -335,5 +337,11 @@ def calc_climatology_monthly(dataset):
)
raise ValueError(error)
else
Github user kwhitehall commented on the pull request:
https://github.com/apache/climate/pull/181#issuecomment-86254156
Np @MJJoyce. Sorry to have put you through the extra work!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user kwhitehall closed the pull request at:
https://github.com/apache/climate/pull/181
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user kwhitehall opened a pull request:
https://github.com/apache/climate/pull/184
CLIMATE-612 - Calculate time series of a dataset
To capture the docstring edits in CLIMATE-598, I branched this off that
branch. Note that only 39262db and 5443b9f , are actually associated
Github user kwhitehall commented on the pull request:
https://github.com/apache/climate/pull/181#issuecomment-85086810
Acknowledge @MJJoyce. Yes the plots are those generated by the scripts. We
can remove them, no worries. I'll update.
---
If your project is set up for it, yo
Github user kwhitehall commented on the pull request:
https://github.com/apache/climate/pull/183#issuecomment-85080574
Ack. My bad! I'll clean it up.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user kwhitehall opened a pull request:
https://github.com/apache/climate/pull/183
Climate 598
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kwhitehall/climate CLIMATE-598
Alternatively you can review and apply these
Github user kwhitehall closed the pull request at:
https://github.com/apache/climate/pull/182
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user kwhitehall commented on the pull request:
https://github.com/apache/climate/pull/182#issuecomment-84488645
I realize that instead of updating reshape_monthly_to_annually, I should
have done it in calc_climatology_monthly, etc.
I am updating this accordingly
Github user kwhitehall commented on the pull request:
https://github.com/apache/climate/pull/182#issuecomment-84482314
I realize that providing the functionality in reshape_monthly_to_annually
instead of in calc_climatology_year and calc_climatology_season is not the best
approach. I
GitHub user kwhitehall opened a pull request:
https://github.com/apache/climate/pull/182
CLIMATE-598 - Update time attribute of Dataset when values are reshaped
Update the function reshape_monthly_to_annually in utils.py to edit the
times attribute of Dataset when reshaping occurs
GitHub user kwhitehall opened a pull request:
https://github.com/apache/climate/pull/181
examples of multimodel and subregion plots
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kwhitehall/climate CLIMATE-610
Alternatively
Github user kwhitehall closed the pull request at:
https://github.com/apache/climate/pull/175
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user kwhitehall opened a pull request:
https://github.com/apache/climate/pull/175
CLIMATE-604 - draw_subregions doesn't work
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kwhitehall/climate CLIMATE-604
Alternat
Github user kwhitehall commented on the pull request:
https://github.com/apache/climate/pull/170#issuecomment-81763474
w.r.t. to the safe_subset function, the logic is not affected and neither
is the documentation that goes with that function so I think we are ok there.
---
If your
Github user kwhitehall commented on the pull request:
https://github.com/apache/climate/pull/170#issuecomment-81746345
Hey @MJJoyce, I don't follow what you mean by a test... An example?
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user kwhitehall commented on a diff in the pull request:
https://github.com/apache/climate/pull/170#discussion_r26495784
--- Diff: ocw/dataset_processor.py ---
@@ -173,6 +176,11 @@ def subset(subregion, target_dataset):
# Get subregion indices into subregion data
GitHub user kwhitehall opened a pull request:
https://github.com/apache/climate/pull/170
added (optional) string subregion_name to subset
Made the naming of the subregion optional at it is not a necessity, but a
nice feature to keep track of datasets.
You can merge this pull
Github user kwhitehall closed the pull request at:
https://github.com/apache/climate/pull/163
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user kwhitehall closed the pull request at:
https://github.com/apache/climate/pull/165
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user kwhitehall closed the pull request at:
https://github.com/apache/climate/pull/167
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user kwhitehall closed the pull request at:
https://github.com/apache/climate/pull/166
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user kwhitehall closed the pull request at:
https://github.com/apache/climate/pull/164
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user kwhitehall commented on the pull request:
https://github.com/apache/climate/pull/154#issuecomment-78506425
+1 to @chrismattmann suggestion to make the settings configurable - that
solution perfectly crosses the t's and dots i's in this PR and for future
similar
Github user kwhitehall commented on the pull request:
https://github.com/apache/climate/pull/154#issuecomment-78356976
Yip @MJJoyce that was my suggestion w.r.t. the examples-esque folder or
apps-esque folder, and I think this thread drives that home.
So I gather that
Github user kwhitehall commented on the pull request:
https://github.com/apache/climate/pull/154#issuecomment-77007417
True @MBoustani I'm thinking about later down. As functionality for e.g. is
added to OCW, persons may wish to change the cli or update it etc. Whilst the
Github user kwhitehall commented on the pull request:
https://github.com/apache/climate/pull/154#issuecomment-77002707
hrm. @MBoustani I definitely agree that the RCMES-cli.py should go into its
own folder as it is an application of OCW. But, I'm not entirely sure about
removin
GitHub user kwhitehall opened a pull request:
https://github.com/apache/climate/pull/167
CLIMATE-590 - Update data_source/local.py to store units from datasets
-This update depends on the new Dataset class
You can merge this pull request into a Git repository by running:
$ git
GitHub user kwhitehall opened a pull request:
https://github.com/apache/climate/pull/166
CLIMATE-592 - Update functions in dataset_processor.py to accommodate units
in Dataset
- this update depends on the new Dataset class
You can merge this pull request into a Git repository by
GitHub user kwhitehall opened a pull request:
https://github.com/apache/climate/pull/165
CLIMATE-591 - Update data_source/rcmed.py to store units from the database
- this request depends on the new Dataset being presented in dataset.py
You can merge this pull request into a Git
GitHub user kwhitehall opened a pull request:
https://github.com/apache/climate/pull/164
CLIMATE-585 - add units instance attribute to class Dataset
- update functions in this files accordingly to reflect the new Dataset
attributes
You can merge this pull request into a Git
GitHub user kwhitehall opened a pull request:
https://github.com/apache/climate/pull/163
CLIMATE-585 Fixed the bias calcuation in Bias, TemporalMeanBias, and Spat...
- Fix the order of the bias calculation in metrics.py
- Fix the test in test_metrics.py to reflect the change of
Github user kwhitehall closed the pull request at:
https://github.com/apache/climate/pull/156
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user kwhitehall closed the pull request at:
https://github.com/apache/climate/pull/162
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user kwhitehall closed the pull request at:
https://github.com/apache/climate/pull/155
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user kwhitehall closed the pull request at:
https://github.com/apache/climate/pull/158
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user kwhitehall closed the pull request at:
https://github.com/apache/climate/pull/157
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user kwhitehall opened a pull request:
https://github.com/apache/climate/pull/162
CLIMATE-585 Fixed the bias calcuation in Bias, TemporalMeanBias, and Spat...
...ialMeanOfTemporalMeanBias
You can merge this pull request into a Git repository by running:
$ git pull
Github user kwhitehall commented on the pull request:
https://github.com/apache/climate/pull/162#issuecomment-76741781
Bias calculation will fail 100% test_metric bias function because the order
of the dataset has changed.
---
If your project is set up for it, you can reply to
Github user kwhitehall commented on the pull request:
https://github.com/apache/climate/pull/155#issuecomment-76463823
Thanks for the feedback Michael.
Looks like I committed away on one branch after all. Any direction on how
to rectify this mismatch up of issues and PR
GitHub user kwhitehall opened a pull request:
https://github.com/apache/climate/pull/158
CLIMATE - 589 Add unit attribute to the Dataset class
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kwhitehall/climate CLIMATE589
GitHub user kwhitehall opened a pull request:
https://github.com/apache/climate/pull/157
CLIMATE - 585 - change the bias calculations in the metrics class
change to target_dataset - ref_dataset
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user kwhitehall opened a pull request:
https://github.com/apache/climate/pull/156
CLIMATE - 590 - update data_source/local.py to store units from datasets
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kwhitehall/climate
GitHub user kwhitehall opened a pull request:
https://github.com/apache/climate/pull/155
CLIMATE - 592 update functions in dataset_processor.py to accommodate units
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kwhitehall
Github user kwhitehall closed the pull request at:
https://github.com/apache/climate/pull/148
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user kwhitehall opened a pull request:
https://github.com/apache/climate/pull/148
Climate ds
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kwhitehall/climate climateDS
Alternatively you can review and apply these
GitHub user kwhitehall opened a pull request:
https://github.com/apache/climate/pull/142
CLIMATE-559 - removing the GrADSScript folder from the repo
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kwhitehall/climate CLIMATE-559
Github user kwhitehall closed the pull request at:
https://github.com/apache/climate/pull/141
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user kwhitehall reopened a pull request:
https://github.com/apache/climate/pull/141
CLIMATE-530 - updated documentation
- update documentation to reflect the removal of the GrADS dependency
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user kwhitehall opened a pull request:
https://github.com/apache/climate/pull/141
CLIMATE-530 - updated documentation
- update documentation to reflect the removal of the GrADS dependency
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user kwhitehall opened a pull request:
https://github.com/apache/climate/pull/140
CLIMATE-530 converted GrADS plots to matplotlib
- removed GrADs dependency in the preprocessing section
- updated the plots to use matplotlib instead of GrADs
You can merge this pull
GitHub user kwhitehall opened a pull request:
https://github.com/apache/climate/pull/121
removing files.py and process.py from the code repo
Addressed CLIMATE-536 & 537 here by removing the unnecessary file.py and
process.py files from the code base, as well as removed t
Github user kwhitehall commented on the pull request:
https://github.com/apache/climate/pull/119#issuecomment-60461656
Sure @lewismc. The subsetting of the netcdf files in the readMergData
method (around line 143) was leading to the exception being thrown. So I add a
few lines to
GitHub user kwhitehall opened a pull request:
https://github.com/apache/climate/pull/119
CLIMATE-535 Update mccsearch files.py to use current replacement of
toolkit.process function
removed process.py dependency and fixed Nio toNETCDF logical errors
You can merge this pull request
90 matches
Mail list logo
