---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11907/#review22154
---
Commit 576884ec10b4a46b243b8138926c0fc650bcdaba in branch
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11907/#review22153
---
Commit d3d6350219c9f02ce5d604a81a0c3c12ff700672 in branch
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11981/#review22157
---
Minor nitpick : our code conventions recommend the method naming to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11936/#review22158
---
Ship it!
Ship It!
- Nitin Mehta
On June 18, 2013, 2:38 p.m.,
I am not authorized to access the link you are sending Edison, but
interested in the contents. Could you send it please?
On Wed, Jun 19, 2013 at 10:26 PM, Edison Su edison...@citrix.com wrote:
The double slash can happen in every where, there is bug fix long time ago(
On Wed, Jun 19, 2013 at 05:46:06PM -0700, Sheng Yang wrote:
Hi,
I just found out that some commands (e.g. AddBaremetalHostCmd,
AddBaremetalKickStartPxeCmd) didn't show in the marvin's
API(tools/marvin/marvin/cloudstackAPI), make it hard for me to write marvin
test case for them.
The
A conflict was checked in with 97f8c52.
Regards,
Any great ruby lovers out there ?
I created a session on Deltacloud, we should create a cloudstack driver for it.
With couple great ruby guys we could knock this off in 6 hours chrono :)
I will buy the beers,
-sebastien
On Jun 19, 2013, at 10:03 PM, David Nalley da...@gnsa.us wrote:
It is
Hi,
Will you be looking at/documenting the need to enable PCI pass-through by
creating a customised kernel for KVM hosts?
[we've needed to change the DMAR flag to 'on' by default]
Regards,
Paul Angus
S: +44 20 3603 0540 | M: +447711418784
paul.an...@shapeblue.com
-Original Message-
Edison burning the midnight oil. He's fixed it in the subsequent
commit however.
On Thu, Jun 20, 2013 at 08:38:47AM +, Daan Hoogland wrote:
A conflict was checked in with 97f8c52.
Regards,
--
Prasanna.,
Powered by BigRock.com
On Thu, Jun 20, 2013 at 10:50 AM, Prasanna Santhanam t...@apache.org wrote:
He's fixed it in the subsequent
commit however
Yeah, I apologized for the early noise making ;)
On Thu, Jun 20, 2013 at 11:20:54AM +0200, Daan Hoogland wrote:
On Thu, Jun 20, 2013 at 10:50 AM, Prasanna Santhanam t...@apache.org wrote:
He's fixed it in the subsequent
commit however
Yeah, I apologized for the early noise making ;)
Not at all. Prompted me to look at other broken
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11989/
---
Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
Description
Hi all:
There is an error when i upgrade the version of cloudstack from 3.0.2 to
4.0.1.The following are my steps:
1. Use CloudStack-oss-3.0.2-1-rhel6.2.tar.gz. Execute ./install choose M
and D.
2. Create zone and creat an instance.
3. Stop cloud-management service.
4. upgrade cloudstack from
On Jun 18, 2013, at 2:08 PM, Brian Federle brian.fede...@citrix.com wrote:
FYI, I created an improvement ticket for plugin localization:
https://issues.apache.org/jira/browse/CLOUDSTACK-3058
Hi folks, how does this play out with the translation efforts which populates
the properties files
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11989/#review22161
---
Ship it!
Ship It!
- Nitin Mehta
On June 20, 2013, 9:42 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11990/
---
Review request for cloudstack.
Description
---
refuse to destroy a vm
H,
can someone have a look?
https://reviews.apache.org/r/11990/
This is a very valid question and I think the file containing the translation
strings for support for other languages would also have to be taken care off
when the standard English strings are being dynamically added to the dictionary
from the plugin.
-Original Message-
From:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11991/
---
Review request for cloudstack.
Description
---
Added condition for vmware
Does anyone have problem building non oss? The build is failing at:
http://jenkins.buildacloud.org/view/master/job/build-master-nonoss/503/console
Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile)
on project cloud-plugin-hypervisor-vmware:
I'm looking for JSON serialised samples of the attach and detach commands.
These will be in logs generated during testing.
Where can I look to find such logs?
DL
(apologies for rebroadcast, used wrong dev list at first)
I'm looking for JSON serialised samples of the attach and detach commands.
These will be in logs generated during testing.
Where can I look to find such logs?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11992/
---
Review request for cloudstack, Sateesh Chodapuneedi, edison su, Alex Huang, and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11992/
---
(Updated June 20, 2013, 11:53 a.m.)
Review request for cloudstack, Sateesh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11992/#review22162
---
Ship it!
there is a lot of code cleaning in with the functional
Hi,
Here is an easy bug to fix for a newcomer to cloudstack:
https://issues.apache.org/jira/browse/CLOUDSTACK-3096
install pep8 on your machine
git clone cloudstack repo
go to the marvin directory
run pep8 like I show in the bug.
edit the python scripts to fix the errors
once pep8 is clean,
Devs,
I would like to call a vote on the following modification to our by-laws.
This is in response to the
Summary of changes:
* Addition of 3.4.2. Non-Technical Decisions section. This specifies that
non-technical decisions can be made on any appropriate list (i.e. marketing@)
and also allows
Uh... [This is in response to the] quoted thread wherein Sebastian
highlights that we have nothing in our by-laws to tell us how to make
general non-technical decisions.
On 20 June 2013 14:21, Noah Slater nsla...@apache.org wrote:
Devs,
I would like to call a vote on the following
Sure,
One file at a time!
-Original Message-
From: Sebastien Goasguen [mailto:run...@gmail.com]
Sent: donderdag 20 juni 2013 14:35
To: dev@cloudstack.apache.org
Subject: easy bug to fix for new comer
Hi,
Here is an easy bug to fix for a newcomer to cloudstack:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11994/
---
Review request for cloudstack and Prasanna Santhanam.
Description
---
Sure, I read it. I retracted the submission, due to difficulties in reproducing
the error state I am trying to solve. I will adjust according to your comment
when I get a better feel of the necessity of the fix.
thanks
-Original Message-
From: John Burwell [mailto:jburw...@basho.com]
On Wed, Jun 19, 2013 at 07:11:19PM +, Edison Su wrote:
-Original Message-
From: John Burwell [mailto:jburw...@basho.com]
Sent: Wednesday, June 19, 2013 11:43 AM
To: Edison Su
Cc: dev@cloudstack.apache.org
Subject: Re: NFS Cache storage query
Edison,
Based on
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11995/
---
Review request for cloudstack and Sebastien Goasguen.
Description
---
one
cloudstackConnection was pep8 compliant but seems to have flouted it
again. I'll look at setting up a jenkins job for style check when the
full pep8 compliance is done.
On Thu, Jun 20, 2013 at 01:42:36PM +, Daan Hoogland wrote:
Sure,
One file at a time!
-Original Message-
Btw Sebastien,
Newcomer as I am; how do I test the test-code tests?
-Original Message-
From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com]
Sent: donderdag 20 juni 2013 15:43
To: 'dev@cloudstack.apache.org'
Subject: RE: easy bug to fix for new comer
Sure,
One file at a time!
I noticed some are very small. Doing those first and I am still doing them one
file at a time!
-Original Message-
From: Prasanna Santhanam [mailto:t...@apache.org]
Sent: donderdag 20 juni 2013 16:02
To: dev@cloudstack.apache.org
Subject: Re: easy bug to fix for new comer
On Thu, Jun 20, 2013, at 08:21 AM, Noah Slater wrote:
Devs,
I would like to call a vote on the following modification to our by-laws.
This is in response to the
Summary of changes:
* Addition of 3.4.2. Non-Technical Decisions section. This specifies
that
non-technical decisions can be
On Thu, Jun 20, 2013 at 03:01:28PM +0530, Prasanna Santhanam wrote:
On Thu, Jun 20, 2013 at 11:20:54AM +0200, Daan Hoogland wrote:
On Thu, Jun 20, 2013 at 10:50 AM, Prasanna Santhanam t...@apache.org
wrote:
He's fixed it in the subsequent
commit however
Yeah, I apologized
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11996/
---
Review request for cloudstack and Sebastien Goasguen.
Description
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11998/
---
Review request for cloudstack and Sebastien Goasguen.
Description
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12001/
---
Review request for cloudstack and Sebastien Goasguen.
Description
---
Hi All,
I am currently working on a Cloudstack VMWare integration project and we
have setup up a dedicated vSwitch and PortGroup for cloudstack.
On reading the VMware vSphere Installation and Configuration (
On Wed, 19 Jun 2013 22:16:40 +0530, Prasanna Santhanam wrote:
On Wed, Jun 19, 2013 at 10:53:37AM -0400, Han,Meng wrote:
You can run all the management server code from your laptop as a
development environment and add an external hypervisor host (Either
Xen/KVM) to it. The guests, system VMs
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12005/
---
Review request for cloudstack and Sebastien Goasguen.
Description
---
Halting now, will take on the bigger ones tonight/-morow
-Original Message-
From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com]
Sent: donderdag 20 juni 2013 16:12
To: 'dev@cloudstack.apache.org'
Subject: RE: easy bug to fix for new comer
I noticed some are very small. Doing those
thanks, I will check your patches now
On Jun 20, 2013, at 10:54 AM, Daan Hoogland dhoogl...@schubergphilis.com
wrote:
Halting now, will take on the bigger ones tonight/-morow
-Original Message-
From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com]
Sent: donderdag 20 juni
I don't consider a website change to be technical.
On 20 June 2013 15:14, Joe Brockmeier j...@zonker.net wrote:
On Thu, Jun 20, 2013, at 08:21 AM, Noah Slater wrote:
Devs,
I would like to call a vote on the following modification to our by-laws.
This is in response to the
Summary
Less terse follow up... ;)
Note that our current by-laws effectively state that any technical decision
needs to happen on dev@. I am just clarifying the intent.
Note also that we currently do not define what a technical decision is,
but it is my opinion that this is any decision which relates to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11995/#review22166
---
Ship it!
applied to master with
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11996/#review22167
---
Ship it!
committed to master with
-Original Message-
From: Noel King [mailto:noelk...@gmail.com]
Sent: 20 June 2013 20:16
To: dev@cloudstack.apache.org
Subject: VMWare changing the default vSwitch Name
Hi All,
I am currently working on a Cloudstack VMWare integration project and we have
setup up a dedicated
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11998/#review22169
---
Ship it!
applied to master with
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12001/#review22170
---
Ship it!
applied to master with
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12005/#review22171
---
Ship it!
applied to master with
Daan,
Your patches applied cleanly and have been committed to master.
Please mark the review as submitted
In your next patches try to use the bug id in at the start of the comment, that
way the commit will automatically show up in JIRA and review board…magic.
do something like that:
git
Daan, also assign the bug to yourself in JIRA…
If you cannot do it, we need to give you karma
On Jun 20, 2013, at 1:04 PM, Sebastien Goasguen run...@gmail.com wrote:
Daan,
Your patches applied cleanly and have been committed to master.
Please mark the review as submitted
In your next
Hi Sateesh
Thanks for your reply, I have made those changes and restarted but with no
joy and am still seeing vSwitch0 being used in the log and my portgroup is
returning Message: Uable to find management port group MyPortGroup
INFO [vmware.resource.VmwareResource] (ClusteredAgentManager
-Original Message-
From: Noel King [mailto:noelk...@gmail.com]
Sent: 20 June 2013 22:37
To: dev@cloudstack.apache.org
Subject: Re: VMWare changing the default vSwitch Name
Hi Sateesh
Thanks for your reply, I have made those changes and restarted but with no
joy and am still
Hi Sateesh,
Sorry replied too quick from phone when I away from my desk, Are those
global config changes in 4.1 as well as I dont see them but will have a
quick search in docs for them.
private.network.vswitch.name
public.network.vswitch.name
guest.network.vswitch.name
Thanks
Noel
On 20 June
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11479/
---
(Updated June 20, 2013, 5:35 p.m.)
Review request for cloudstack, edison su
I am looking at this, it might be caused by last night's object_store
branch merge, will provide a fix soon.
-min
On 6/20/13 4:51 AM, Jayapal Reddy Uradi jayapalreddy.ur...@citrix.com
wrote:
Hi,
I am also getting the same error.
Thanks,
Jayapal
On 20-Jun-2013, at 5:04 PM, Prasanna Santhanam
On June 20, 2013, 12:20 p.m., daan Hoogland wrote:
there is a lot of code cleaning in with the functional change. I'd submit
two changes. No blocking remarks, though.
Thanks Daan for the review and comments.
this patch can be submit in two parts.
- Rajesh
Mike,
I am booked up this afternoon. I will start my review tomorrow and complete as
necessary on the flight Saturday.
Thanks,
-John
On Jun 20, 2013, at 1:39 PM, Mike Tutkowski mike.tutkow...@solidfire.com
wrote:
You've possibly seen the auto-generated e-mail that I updated Review Board
You've possibly seen the auto-generated e-mail that I updated Review Board
with a new diff. This third diff is comprehensive in that it includes all
of the changes I've made for this feature.
I believe I have now completed all actions that were required of me.
Please let me know if you have
For interface/API changes, we'd better have a code review, as more storage
vendors and more developers outside Citrix are contributing code to CloudStack
storage subsystem. The code change should have less surprise for everybody who
cares about storage subsystem.
Hi Sateesh,
Did not realise unitl I started looking at the code that you contributed
greatly to it, great to get reply from you.I have done some
investigation around the VmwareManagerImpl.java which uses this
configuration and see that change was made for 4.2 branch, sadly.
Do you have any
My karma is fine. I overlooked this detail
Verzonden vanaf mobiel
Oorspronkelijk bericht
Van: Sebastien Goasguen run...@gmail.com
Datum: 2013-06-20 19:05 (GMT+01:00)
Aan: dev@cloudstack.apache.org
Onderwerp: Re: easy bug to fix for new comer
Daan, also assign the bug
I uploaded the patch to dropbox:
https://www.dropbox.com/s/d9fn17xmho19fdc/cloud-3.0.1-bug14066.patch, can you
access it? The patch is cooked by Fred Wittekind r...@twister.dyndns.org one
year ago.
-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
Sent:
No problem :)
Just wanted to let you know that it's there and that I believe I've
completed all of what you, Wei, and I talked about.
Thanks!
On Thu, Jun 20, 2013 at 11:42 AM, John Burwell jburw...@basho.com wrote:
Mike,
I am booked up this afternoon. I will start my review tomorrow and
Yes, got it. It is quite big. It is dealing with more than just a path
format, isn't it?
On Thu, Jun 20, 2013 at 8:53 PM, Edison Su edison...@citrix.com wrote:
I uploaded the patch to dropbox:
https://www.dropbox.com/s/d9fn17xmho19fdc/cloud-3.0.1-bug14066.patch, can
you access it? The patch
On Jun 20, 2013, at 10:50 AM, Han,Meng meng...@ufl.edu wrote:
On Wed, 19 Jun 2013 22:16:40 +0530, Prasanna Santhanam wrote:
On Wed, Jun 19, 2013 at 10:53:37AM -0400, Han,Meng wrote:
You can run all the management server code from your laptop as a
development environment and add an external
Dharmesh, Shiva, how are you guys doing ?
-sebastien
-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
Sent: Thursday, June 20, 2013 1:03 PM
To: dev
Subject: Re: fixPath (was: committer wanted for review)
Yes, got it. It is quite big. It is dealing with more than just a path
format, isn't it?
Yah, I agree
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12017/
---
Review request for cloudstack and Sebastien Goasguen.
Description
---
Edison,
As I mentioned in a previous email, it feels like a good place for Path value
object that encapsulates behavior. I propose we throw this topic on the board
for Sunday's Storage Architecture session, and bring the resulting proposals
back to the ML.
rantTo my mind, we overuse String
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11992/#review22204
---
server/src/com/cloud/storage/StoragePoolAutomationImpl.java
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11984/#review22205
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9818/#review22206
---
NFS secondary storage is not stored in host table any more. Yes,
Hi Paul,
I think that is more or less dependent on the hardware quirks. For my
case I only had to add intel_iommu=on to the kernel cmdline to get PCI
Passthrough working. An additional cmdline, pci=nocrs, was needed to
get SR-IOV mode of the Mellanox ConnectX-2 card working.
Best Regards,
Pawit
On Thu, Jun 20, 2013 at 05:59:01PM +, Edison Su wrote:
For interface/API changes, we'd better have a code review, as more storage
vendors and more developers outside Citrix are contributing code to
CloudStack storage subsystem. The code change should have less surprise for
everybody who
I found there is an issue about versioning.
When we cut 4.1.1 release, we have to patch like this:
---
diff --git a/server/src/com/cloud/upgrade/dao/Upgrade40to41.java
b/server/src/com/cloud/upgrade/dao/Upgrade40to41.java
index 9e386b9..89f54bc 100644
---
Hi,
I've updated baremetal-4.2 branch, added integration test for some of
baremetal related APIs, also fixed a bunch of baremetal API issues exposed
by the testing.
Thanks!
--Sheng
On Wed, Jun 19, 2013 at 11:41 AM, Chip Childers
chip.child...@sungard.comwrote:
On Wed, Jun 19, 2013 at
Nice! I'm glad the feature has the benefit of tests now. Thanks for
doing this Sheng!
David - are you comfortable with this, and will you now +1 the feature?
On Thu, Jun 20, 2013 at 9:55 PM, Sheng Yang sh...@yasker.org wrote:
Hi,
I've updated baremetal-4.2 branch, added integration test for
Yes
Happy to +1. Sheng, thanks for stepping up and getting this done.
--David
On Jun 20, 2013 7:19 PM, Chip Childers chip.child...@sungard.com wrote:
Nice! I'm glad the feature has the benefit of tests now. Thanks for
doing this Sheng!
David - are you comfortable with this, and will you
I am studying the current ui and still working on the prototype with
angular.js. Hoping to finish it by sunday.
On Fri, Jun 21, 2013 at 2:17 AM, Sebastien Goasguen run...@gmail.comwrote:
Dharmesh, Shiva, how are you guys doing ?
-sebastien
On Thu, Jun 20, 2013 at 06:07:05PM -0400, John Burwell wrote:
Edison,
As I mentioned in a previous email, it feels like a good place for
Path value object that encapsulates behavior. I propose we throw
this topic on the board for Sunday's Storage Architecture session,
and bring the
Prasanna,
I believe the problem Edison is trying to address is high churn and
rework incurred by long review cycles. I find it hard to review
interfaces in isolation without implementations depicting actual
usage. I would also like to see process ceremony kept to minimum to
reduce drag on the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12021/
---
Review request for cloudstack, Prasanna Santhanam and SrikanteswaraRao Talluri.
89 matches
Mail list logo
