Re: Review Request 22126: [Windows]Integrate SystemSeed Template into installer and add progress bar messages to the installer so that admin can aware of changes happening to the system

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22126/#review44697 --- Ship it! Ship It! - Abhinandan Prateek On June 2, 2014, 4:36 a.m

Re: Review Request 22193: Fixed ResourceLeak on pstmtCidr in the function Upgrade430to440.moveCidrsToTheirOwnTable as reported by coverity

> On June 3, 2014, 11:07 a.m., Santhosh Edukulla wrote: > > Ship It! Hi Hugo, Can you commit the latest patch as well which fixes the issue reported by Santhosh. - Rajani --- This is an automatically generated e-mail. To reply, visit:

Re: [DISCUSS] Increasing VM IOPS by separating golden image in high IOPS partition in Xen Server ?

Hi Mike, Could you please give edit/create permission on ASF Jira/Wiki confluence ? I can not add a new Wiki page. My Jira ID: hieulq Wiki: hieulq89 Review Board: hieulq Thanks ! On Wed, Jun 4, 2014 at 9:17 AM, Mike Tutkowski wrote: > Hi, > > Yes, please feel free to add a new Wiki page for

Re: [DISCUSS] Increasing VM IOPS by separating golden image in high IOPS partition in Xen Server ?

Hi, Yes, please feel free to add a new Wiki page for your design. Here is a link to applicable design info: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Design Also, feel free to ask more questions and have me review your design. Thanks! Mike On Tue, Jun 3, 2014 at 7:29 PM, Hieu LE

Re: [DISCUSS] Increasing VM IOPS by separating golden image in high IOPS partition in Xen Server ?

Hi Mike, You are right, performance will be decreased over time because writes IOPS will always end up on slower storage pool. In our case, we are using CloudStack integrated in VDI solution to provived pooled VM type[1]. So may be my approach can bring better UX for user with lower bootime ...

Re: [DISCUSS] NetConf client Library for Brocade Network Plugin implemenatation...

On Tue, Jun 3, 2014 at 1:48 PM, Ritu Sabharwal wrote: > Hi, > > > > The Brocade Network plugin uses NetConf Java client library, NetConf4j > https://github.com/dana-i2cat/netconf4j for its implementation. It is > available under LGPL license. Is it ok to use this library with CloudStack > or

Re: Spectacular networking fail with KVM Adv zone - can someone address this bug?

On 03.06.2014 22:23, Marcus wrote: Edison applied it for some reason, I guess it won't hurt anything. That's fantastisch, thanks guys. Wonder how this was not caught sooner. Anyway, good job! Lucian -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro

Re: [GSOC2014] Progress Update - week two

>> Dif you upload a new version to pypi ? Not yet, this will be done very shortly though. >> I dont recall if we had the same version number or not. Probably good to increment it so we can upggrade via pip Yup, the versions numbers are different, upgrade should work fine. 0.0.1 = initial gcloud

Re: [ACS44]cherry-pick: dfb59cd6cc0292a88cb619e53f34cdb713879ffd

Your commit 5e80e5d33d9a295b91cdba9377f52d9d963d802a actually does the fix mgmt server side and makes this patch irrelevant, as we are now passing a proper vlan:// in this command. However, Daan's fix will make the data in the db consistent for upgraders and fresh installers, which will fix this an

Re: [ACS44]cherry-pick: dfb59cd6cc0292a88cb619e53f34cdb713879ffd

I don't think that's the root cause, but it shouldn't hurt. The root cause seems to be that we're telling the agent that the broadcastUri for the vlan is 'vlan://100' (as reported by Anders), but the IpAssocCmd passes broadcast URI as just '100'. This is a bit messy to workaround the mgmt server in

Re: VPC's VR missing public NIC eth1

Hmm.. ok. I guess we can apply the bandaid patch as well On Tue, Jun 3, 2014 at 12:16 PM, Edison Su wrote: > I checked in a commit: 5e80e5d33d9a295b91cdba9377f52d9d963d802a, which > will fix some of the mess of vlan id. > > > -Original Message- > > From: Marcus [mailto:shadow...@gmail.c

Re: Spectacular networking fail with KVM Adv zone - can someone address this bug?

Edison applied it for some reason, I guess it won't hurt anything. On Tue, Jun 3, 2014 at 2:10 PM, Daan Hoogland wrote: > H Marcus, saw your comment on the patch. I refused it as well and commented > 'use BroadcastDomainType to do this' . I think Nux can use the dB update as > well. > On 3 Jun

Re: UI Development

Adding a column was just an example I was trying to figure out as it seemed like it should be straight forward if I can find where the columns are referenced. Ideally I would like to add an option for intermediate certificates when adding an SSL Cert under infrastructure. It appears I just need to

RE: [ACS44]cherry-pick: dfb59cd6cc0292a88cb619e53f34cdb713879ffd

Need to cherry pick it into 4.3.1 also. > -Original Message- > From: Edison Su [mailto:edison...@citrix.com] > Sent: Tuesday, June 03, 2014 1:37 PM > To: dev@cloudstack.apache.org > Subject: [ACS44]cherry-pick: dfb59cd6cc0292a88cb619e53f34cdb713879ffd > > CLOUDSTACK-6464: > The root cause

Re: [GSOC2014] Progress Update - week two

Great job Darren, and thanks for the update. See inline -Sebastien > On 3 Jun 2014, at 22:25, Darren Brogan wrote: > > Hi Guys, > > Just a quick update on progress for last week. > > *[ec2stack]* > > Since the last progress email I've completed support of tag actions. There > is now support

[ACS44]cherry-pick: dfb59cd6cc0292a88cb619e53f34cdb713879ffd

CLOUDSTACK-6464: The root cause is that, in 3.0.x, if guest network is "vlan://untagged", then kvm agent will use whatever value in "private.network.device", while in 4.x, kvm agent will use "guest.network.device". So if both value are not the same in the agent.properties, then kvm agent will us

Re: Review Request 21908: Fix for CLOUDSTACK-6464

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21908/#review44665 --- Commit dfb59cd6cc0292a88cb619e53f34cdb713879ffd in cloudstack's bran

Re: Review Request 21908: Fix for CLOUDSTACK-6464

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21908/#review44664 --- Commit 15385948dcdf4c69136e99bf3c602f95fd018f39 in cloudstack's bran

[GSOC2014] Progress Update - week two

Hi Guys, Just a quick update on progress for last week. *[ec2stack]* Since the last progress email I've completed support of tag actions. There is now support for listing / creating / deleting Cloudstack tags through ec2stack. I wrote the required tests and updated the documentation accordingly.

Re: Spectacular networking fail with KVM Adv zone - can someone address this bug?

H Marcus, saw your comment on the patch. I refused it as well and commented 'use BroadcastDomainType to do this' . I think Nux can use the dB update as well. On 3 Jun 2014 18:46, "Marcus" wrote: > Good catch. This patch works around the main problem that the mgmt server > is passing broadcastUri

Marvin Question

Hi, I've been playing around with Marvin lately. I got it to build a CS cloud with one zone, one pod, one cluster, and two hosts in it just fine. I've been trying to run another script to create a Compute Offering, but get the following error (below). Perhaps I'm missing some piece of Marvin co

[ACS44] cherry pick 5e80e5d33d9a295b91cdba9377f52d9d963d802a

If Vpc public network with snat enabled, mgt server will send down "vlan-id" instead of "vlan://vlan-id" in ipassoccommand, which will cause issue on the hypervisor resource to program VR.

RE: VPC's VR missing public NIC eth1

I checked in a commit: 5e80e5d33d9a295b91cdba9377f52d9d963d802a, which will fix some of the mess of vlan id. > -Original Message- > From: Marcus [mailto:shadow...@gmail.com] > Sent: Tuesday, June 03, 2014 9:57 AM > To: Daan Hoogland > Cc: dev > Subject: Re: VPC's VR missing public NIC eth

[ACS44] Cherry pick 73330167228d14ea8494c9c1893627b6936626a7

Hi Daan, Can you please cherry-pick the following commit ? commit 73330167228d14ea8494c9c1893627b6936626a7 CLOUDSTACK-6824: In case there is a failure to delete the soft link of a download url, dont bail out since there can be cases such as destroy ssvm where the soft links do not exist any more

Re: [ACS44] Cherry pick CLOUDSTACK-6599

Thanks Daan. Regarding test cases, I will check and get back. Just that we don¹t loose this it in mails I have created a bug for 4.4, for adding test cases if they don¹t already exist. -Nitin On 03/06/14 1:08 AM, "Daan Hoogland" wrote: >strong point, > >I added both commits. Are there tests to

Re: [Proposal] Integrating Apache Stratos with Apache CloudStack.

On Tue, Jun 3, 2014 at 11:15 PM, Alex Hitchins wrote: > Are any of your designs available to read? I'm interested in Stratos and > how > it could be integrated with CloudStack. I'd be interested to see what you > are working to achieve. > Alex, Unfortunately I'm not follow it anymore. Jason (fr

[DISCUSS] NetConf client Library for Brocade Network Plugin implemenatation...

Hi, The Brocade Network plugin uses NetConf Java client library, NetConf4j https://github.com/dana-i2cat/netconf4j for its implementation. It is available under LGPL license. Is it ok to use this library with CloudStack or are there any other recommendations that have been used earlier for

RE: UI Development

Hi Matt, There are ui controls in /ui/scripts/ui/widgets that generate the actual controls/page based on JSON definitions at /ui/scripts. AFAIK there is no complete UI documentation, but you can take a look here: https://cwiki.apache.org/confluence/display/CLOUDSTACK/UI+widget+samples To add a

Re: VPC's VR missing public NIC eth1

Ok, thanks. It seems there are other cases where the Command being passed from the mgmt server has inconsistent broadcastUri as well, this should blanket fix them. In the meantime there's a growing group of 4.3 upgraders who are getting pitchforks out over at CLOUDSTACK-6464, so we may want to have

Re: Review Request 21908: Fix for CLOUDSTACK-6464

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21908/#review44635 --- I would vote to reject this patch, by the way, on the terms that it

Re: Spectacular networking fail with KVM Adv zone - can someone address this bug?

Good catch. This patch works around the main problem that the mgmt server is passing broadcastUri in one way (e.g. vlan://100 in his example) for one Command and broadcastUri in another way (just '100') for a different Command. It doesn't affect fresh 4.3 installs because the way new values are sto

Re: Review Request 21908: Fix for CLOUDSTACK-6464

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21908/#review44634 --- Actually, this would be fixed by changing the upgraded db to have vl

Re: [ANNOUNCE] Amogh Vasekar as committer

Thanks a ton everyone! :-) Regards, Amogh On 6/3/14 4:06 AM, "Nux!" wrote: >On 02.06.2014 19:14, John Kinsella wrote: >> The Project Management Committee (PMC) for Apache CloudStack has >> asked Amogh Vasekar to become a committer and we are pleased to >> announce >> that he has accepted. >> >

Re: [ACS5.0] IAM feature postponed from 4.4 to 5.0?

As mentioned in our FS doc in wiki, "In phase I, all the permissions attached to any policy are by default explicit 'Allow' permissions. As of now 'Deny' permissions cannot be added." For your use cases, you can have two options: 1. Assign the two accounts into 2 different groups, and attach dif

Re: Spectacular networking fail with KVM Adv zone - can someone address this bug?

On 03.06.2014 16:20, Marcus wrote: I think a fresh 4.3 install with vlan isolation is pretty well tested, but there have been issues with upgrades, and apparently basic/no isolation networks. I'm taking a shot in the dark to try to help, and I'll see if I can reproduce, but the symptoms seem ra

RE: [Proposal] Integrating Apache Stratos with Apache CloudStack.

Hi Chris & Tuna, Are any of your designs available to read? I'm interested in Stratos and how it could be integrated with CloudStack. I'd be interested to see what you are working to achieve. Alex Hitchins | 07788 423 969 | 01892 523 587 -Original Message- From: chris snow [mailto:chsno

UI Development

I am trying to get a grasp on how the UI is generated for CloudStack. Are there any good documented resources for the UI? For example, say I wanted to add another column to the table of storage devices, is there any documentation that would help me figure this out?

Cpu, cpu speed and memory in usage records

Hi, Is it normal if CloudStack does not return usage details (cpu cores, cpu speed and memory) in the usage records? Since the introduction of dynamic compute offerings, these details are recorded in table cloud_usage.usage_vm_instance, but they are not in table cloud_usage.cloud_usage, and they

Re: Spectacular networking fail with KVM Adv zone - can someone address this bug?

I think a fresh 4.3 install with vlan isolation is pretty well tested, but there have been issues with upgrades, and apparently basic/no isolation networks. I'm taking a shot in the dark to try to help, and I'll see if I can reproduce, but the symptoms seem rather complex and varied. If I can repro

RE: Regarding Blocker bug CLOUDSTACK-6603

Tuna, Can you please move your schema changes appropriately? Thanks Rajesh Battala -Original Message- From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] Sent: Tuesday, June 3, 2014 5:26 PM To: Rajesh Battala Cc: dev@cloudstack.apache.org; ng.t...@gmail.com Subject: Re: Regarding Blocke

Spectacular networking fail with KVM Adv zone - can someone address this bug?

Hello, Any dev experienced with the KVM networking available to have a look at this bug? https://issues.apache.org/jira/browse/CLOUDSTACK-6464 Seems like it's widespread and with no resolution in sight. I have not experienced it in my 4.3 deployments, wonder if it'll come back to bite me aft

RE: [ACS4.4] [Issue] Unable to create a resource tag on ISO and Template resource

Two things: 1. Is this feature of tagging iso or template available\supported in CS? What API we are using for it? 2. If this is supported feature, can you "manually" do it from UI on simulator and check if its working there? Thanks! Santhosh From: Nami

Re: [ACS4.4] [Issue] Unable to create a resource tag on ISO and Template resource

Hi Santhosh, These are new test cases. On simulator and in same test case, I have created tags on various resources like volume, project, snapshot etc and they work perfectly fine. I face this issue only for ISO and Template resource tag creation. Thanks, Namita On Tue, Jun 3, 2014 at 6:16 PM,

RE: [ACS4.4] [Issue] Unable to create a resource tag on ISO and Template resource

Namita, 1. Just to separate this issue as simulator vs test code, can we just check from UI whether the objective of creating tags for simulator is possible there? If yes, then we can look in to test code. 2. As well, are these new tests or existing tests? Thanks! Santhosh ___

Re: Review Request 22197: CLOUDSTACK-6776: Removed hard coded vlan ids from BVT test_non_contiguous_vlan.py

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22197/#review44616 --- test/integration/smoke/test_non_contigiousvlan.py

[ACS4.4] [Issue] Unable to create a resource tag on ISO and Template resource

Hi All, I was trying to create a resource tag on ISO and Template with a sample data for a test case. Can anyone help me toknow is there anything I'm missing in the input parameters ? For both resources, I get a db exception "Out of range value for column 'domain_id' at row 1" where the domainid

Re: Review Request 22194: Fixed Resource leak reported by coverity

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22194/#review44615 --- Ship it! master -> 793462e5fa40dc73ce30658fe6a27e4284ed9cdb 4.4-for

Re: [ACS5.0] IAM feature postponed from 4.4 to 5.0?

Hi Min, With reference to the wiki doc, I had a query. In case of a customized role with deny permissions how will the listAll, isrecursive ..etc. input parameters values will be ? For example, there are two accounts and they belong to a group with Allow all permissions. If I have to remove some

Re: Regarding Blocker bug CLOUDSTACK-6603

if a schema change fixes a bug, yes we can On Tue, Jun 3, 2014 at 10:58 AM, Rajesh Battala wrote: > Hi, > > > > This bug https://issues.apache.org/jira/browse/CLOUDSTACK-6603 [Upgrade]DB > Exception while Autoscale monitoring after upgrading from 4.3 to 4.4] got > introduced by the feature of “Au

Re: Review Request 22197: CLOUDSTACK-6776: Removed hard coded vlan ids from BVT test_non_contiguous_vlan.py

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22197/ --- (Updated June 3, 2014, 11:45 a.m.) Review request for cloudstack, Girish Shilam

Re: Review Request 22197: CLOUDSTACK-6776: Removed hard coded vlan ids from BVT test_non_contiguous_vlan.py

> On June 3, 2014, 11:22 a.m., Santhosh Edukulla wrote: > > test/integration/smoke/test_non_contigiousvlan.py, line 29 > > > > > > Is it ok to move to test data? Removed services dictionary as it is no longer used -

Re: Review Request 22197: CLOUDSTACK-6776: Removed hard coded vlan ids from BVT test_non_contiguous_vlan.py

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22197/#review44612 --- test/integration/smoke/test_non_contigiousvlan.py

Re: Review Request 22194: Fixed Resource leak reported by coverity

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22194/#review44611 --- Ship it! Ship It! - Santhosh Edukulla On June 3, 2014, 10:42 a.m

Re: Review Request 22193: Fixed ResourceLeak on pstmtCidr in the function Upgrade430to440.moveCidrsToTheirOwnTable as reported by coverity

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22193/#review44610 --- Ship it! Ship It! - Santhosh Edukulla On June 3, 2014, 11:02 a.m

Re: [ANNOUNCE] Amogh Vasekar as committer

On 02.06.2014 19:14, John Kinsella wrote: The Project Management Committee (PMC) for Apache CloudStack has asked Amogh Vasekar to become a committer and we are pleased to announce that he has accepted. Being a committer allows many contributors to contribute more autonomously. For developers,

Re: Review Request 22193: Fixed ResourceLeak on pstmtCidr in the function Upgrade430to440.moveCidrsToTheirOwnTable as reported by coverity

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22193/ --- (Updated June 3, 2014, 11:02 a.m.) Review request for cloudstack, Abhinandan Pr

Review Request 22197: CLOUDSTACK-6776: Removed hard coded vlan ids from BVT test_non_contiguous_vlan.py

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22197/ --- Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla. Bugs: CL

Re: Review Request 22194: Fixed Resource leak reported by coverity

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22194/ --- (Updated June 3, 2014, 10:42 a.m.) Review request for cloudstack, Abhinandan Pr

Re: Review Request 22194: Fixed Resource leak reported by coverity

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22194/#review44608 --- engine/schema/src/com/cloud/upgrade/dao/Upgrade421to430.java

Re: Review Request 22194: Fixed Resource leak reported by coverity

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22194/#review44606 --- engine/schema/src/com/cloud/upgrade/dao/Upgrade421to430.java

Re: Review Request 22194: Fixed Resource leak reported by coverity

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22194/ --- (Updated June 3, 2014, 9:31 a.m.) Review request for cloudstack and Koushik Das

Re: Review Request 22194: Fixed Resource leak reported by coverity

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22194/#review44605 --- engine/schema/src/com/cloud/upgrade/dao/Upgrade421to430.java

Review Request 22194: Fixed Resource leak reported by coverity

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22194/ --- Review request for cloudstack and Koushik Das. Repository: cloudstack-git Des

Unable to upload SSL certificate

Hi, I am trying to upload an SSL certificate to Cloudstack using uploadSslCert API since 4.3 version does not have UI support for the same. And I am getting following exception: Invalid Certificate format. Expected X509 certificate The certificate, private key and certificate-c

Regarding Blocker bug CLOUDSTACK-6603

Hi, This bug https://issues.apache.org/jira/browse/CLOUDSTACK-6603 [Upgrade]DB Exception while Autoscale monitoring after upgrading from 4.3 to 4.4] got introduced by the feature of "Autoscaling without netscaler" A new column "last_interval" got added to autoscale_vmgroups table by this commi

Re: Review Request 22193: Fixed ResourceLeak on pstmtCidr in the function Upgrade430to440.moveCidrsToTheirOwnTable as reported by coverity

Good find Santhosh. I uploaded another patch on review board to fix this. ~Rajani On 03-Jun-2014, at 1:41 pm, Hugo Trippaers wrote: > Good find Santhosh. I missed the outer loop while doing the review. > > Cheers, > > Hugo > >> -Original Message- >> From: Santhosh Edukulla [ma

Re: Review Request 22193: Fixed ResourceLeak on pstmtCidr in the function Upgrade430to440.moveCidrsToTheirOwnTable as reported by coverity

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22193/ --- (Updated June 3, 2014, 8:41 a.m.) Review request for cloudstack, Abhinandan Pra

RE: [ANNOUNCE] Amogh Vasekar as committer

Congratulations Amogh! Regards, Likitha -Original Message- From: John Kinsella [mailto:j...@stratosec.co] Sent: Monday, June 2, 2014 11:44 PM To: Subject: [ANNOUNCE] Amogh Vasekar as committer The Project Management Committee (PMC) for Apache CloudStack has asked Amogh Vasekar to beco

RE: Review Request 22193: Fixed ResourceLeak on pstmtCidr in the function Upgrade430to440.moveCidrsToTheirOwnTable as reported by coverity

Good find Santhosh. I missed the outer loop while doing the review. Cheers, Hugo > -Original Message- > From: Santhosh Edukulla [mailto:santhosh.eduku...@citrix.com] > Sent: Tuesday, June 03, 2014 9:35 AM > To: dev@cloudstack.apache.org; Hugo Trippaers; daan Hoogland; > Abhinandan Pratee

Re: [ACS44] Cherry pick CLOUDSTACK-6599

strong point, I added both commits. Are there tests to the old code as well? this is a lot of untested code like this. On Mon, Jun 2, 2014 at 7:50 PM, Nitin Mehta wrote: > Daan - Thanks for your comment. The java upgrade code has never been data > migration code only. > I have always seen comple

RE: Review Request 22193: Fixed ResourceLeak on pstmtCidr in the function Upgrade430to440.moveCidrsToTheirOwnTable as reported by coverity

Not able to mark it inside the review, so making a note here. The below statement ( preparestatement creation) is called inside the while loop multiple times, but was closed only once in finally. This may still result in leak. pstmtCidr = conn.prepareStatement(networkAclItemCidrSql); 1. Either

Re: Review Request 22193: Fixed ResourceLeak on pstmtCidr in the function Upgrade430to440.moveCidrsToTheirOwnTable as reported by coverity

> On June 3, 2014, 7:20 a.m., Hugo Trippaers wrote: > > master: > > commit 2424d9a9e0f1189044303a98c40e60033808f0b2 > > Author: Rajani Karuturi > > Date: Tue Jun 3 12:31:20 2014 +0530 > > > > Fixed ResouceLeak on pstmtCidr in the function > > Upgrade430to440.moveCidrsToTheirOwnTable as r

Re: Review Request 22193: Fixed ResourceLeak on pstmtCidr in the function Upgrade430to440.moveCidrsToTheirOwnTable as reported by coverity

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22193/#review44603 --- Ship it! master: commit 2424d9a9e0f1189044303a98c40e60033808f0b2 Au

Re: [ACS4.4] [Issue] Unable to create a autoscalevmprofile

Thanks Daan. On Fri, May 30, 2014 at 1:59 PM, Daan Hoogland wrote: > Long accountId = > _accountService.finalyzeAccountId(accountName, domainId, projectId, > true); > _accountService didn't get initialized/injected!?! The spring stuff > should have taken care of that. > I think the pro

Review Request 22193: Fixed ResourceLeak on pstmtCidr in the function Upgrade430to440.moveCidrsToTheirOwnTable as reported by coverity

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22193/ --- Review request for cloudstack, Abhinandan Prateek and daan Hoogland. Repository