Re: New Defects reported by Coverity Scan for cloudstack

Hey Ritu, Thanks! Could you post the patch as a separate review? That way it will be a lot easier for me to merge the changes. The easiest way to do it is to base the new patch on the current state of the master branch. Cheers, Hugo On 29 jul. 2014, at 22:32, Ritu Sabharwal wrote: > Hi Hu

RE: Marvin Package?

please add me as well. username "santhoshe" Santhosh From: Rohit Yadav [rohit.ya...@shapeblue.com] Sent: Tuesday, July 29, 2014 5:28 PM To: dev@cloudstack.apache.org Subject: Re: Marvin Package? Ian Duffy wrote: >> Ian and other committers who may be inter

multiple primary storage

Hi, I am using ACS 4.3 with xenserver 6.2 I have one primary storage as nfs, can i add another one as iscsi and migrate vms (storage migration) from one primary storage to another one. ? Also as per cloudstack Doc, " iscsi supports Clustered LVM on Xenserver " What does it mean. Regards, Tejas

Re: [DISCUSS] git commit proces

And talking about to achieve good code quality, I think compulsive review and testing through some kind of automation system is much more helpful. --Sheng On Tue, Jul 29, 2014 at 4:14 PM, Sheng Yang wrote: > Hi Leo, > > I am afraid the answer is too generic. We'd better look into details to >

RE: building cloudstack

So this is the screen shot of the error I am getting. This was after trying to start the management server mvn -pl :cloud-client-ui jetty:run -Dnoredist [INFO] [ERROR] Failed to execute goal on project cloud-client-u

Re: [DISCUSS] git commit proces

Hi Leo, I am afraid the answer is too generic. We'd better look into details to see what's the exactly problem. So I am trying to sort it out. The first question we want to ask is: A. What's current develop process? I don't know where is it documented, but as I know, it works like this(please

RE: [ACS4.5] GUI Question

I think that would be doable. One idea is to extend that 'tagger' widget, or a plain text field if that is all you need, to bind a 'change' event to the text field, which would trigger an AJAX call to the listStorageTags and display a popup box of results generated via jQuery (i.e., generate a n

Re: [ACS4.5] GUI Question

Hi Brian, Actually what we want exactly to do is adding autocompletion to the "Storage Tags" field in the "Create Primary Storage" dialog. Ideally, it will look like this :* http://i.imgur.com/2ypzmGN.png * So, suggestions of existing storage tags that match the ty

Re: Marvin Package?

Ian Duffy wrote: Ian and other committers who may be interested, let me know your pypi username I'll add you on the admin list as well. Sure, imduffy15 is my pypi username. Done, feel free to help release marvin in future. Regards. On 29 July 2014 22:08, Rohit Yadav wrote: Hi Ian, Th

Re: Marvin Package?

> Ian and other committers who may be interested, let me know your pypi username I'll add you on the admin list as well. Sure, imduffy15 is my pypi username. On 29 July 2014 22:08, Rohit Yadav wrote: > Hi Ian, > > Thanks for the find, I think since sharing things on pypi does not need > to be

Re: [ACS4.5] GUI Question

Thanks, Brian! On Tue, Jul 29, 2014 at 2:48 PM, Brian Federle wrote: > I think the main area to look in is dialog.js, which handles rendering > the form dialogs. > > > > One possible approach: > > > > - Edit the dialog.js -> ‘createForm’ widget function, find the > each loop where the

Re: Marvin Package?

Since no one objects to the versioning, I've set next release versions on 4.4 and master branches to 4.4.1 and 4.5.0 respectively. Further fixed the module author/maintainer email to use that of ACS dev which is same as cloudmonkey. Regards. Hugo Trippaers wrote: Sounds good to me. Cheers, Hu

Re: Marvin Package?

Hi Ian, Thanks for the find, I think since sharing things on pypi does not need to be officially voted I think we can go ahead and release marvin for past CloudStack releases for at least 4.4.0 Hugo, PMC and other can comment on the releasing part? I went ahead and added cloudmonkey pypi module

RE: [ACS4.5] GUI Question

I think the main area to look in is dialog.js, which handles rendering the form dialogs. One possible approach: - Edit the dialog.js -> ‘createForm’ widget function, find the each loop where the fields are iterated - Here, you can check for a new type param of your choosing

RE: New Defects reported by Coverity Scan for cloudstack

Hi Hugo, I have fixed the reported findings and posted the patch on review board. Thanks & Regards, Ritu S. From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers Sent: Tuesday, July 29, 2014 6:41 AM To: Ritu Sabharwal Cc: ; Santhosh Edukulla Subject: Fwd: New Defects reported by C

Re: [DISCUSS] git commit proces

I think the general rule for fixes is to branch from where the bug is. If the bug is in prod, branch from master. If the bug is in the release process, branch from the release branch. If the bug is in development, branch from development. The previous comment about pulling dev code into master via

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22863/ --- (Updated July 29, 2014, 8:31 p.m.) Review request for cloudstack and Hugo Tripp

Re: [DISCUSS] git commit proces

I'm not sure this applies to hotfixes to previous versions, ie. not the current master release. The hotfix might not code wise apply to the current develop/master at all. Assume that we one year from now, after releasing 4.5 and 4.6 using gitflow, and are working towards a 4.7 in develop, we need

Re: Marvin Package?

I see the pypi entry now goes to 404: https://pypi.python.org/pypi/cloudstack-marvin/ Came we go ahead and set the version of marvin to 4.4 and do a release? Thanks, Ian On 28 July 2014 18:50, Ian Duffy wrote: > +1 on same version, makes sense to me. > > > On 28 July 2014 13:55, Hugo Trippaer

RE: building cloudstack

I did a git pull and tried but still I got the same error. I shall try once again and check. -Original Message- From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] Sent: Tuesday, July 29, 2014 4:06 PM To: dev Subject: Re: building cloudstack Jaya, Did you update and try again? As Rohi

Re: [DISCUSS] git commit proces

My understanding is - we should always merge the fixes to both *develop and *master branches. Merging to develop branch should be mandatory as that’s the place where automatic nightly builds + the regression tests are run against. That’s what the article from Daan’s email says: Master branch: "We

Re: building cloudstack

Jaya, Did you update and try again? As Rohit said, a patch was submitted as fix for this. On Tue, Jul 29, 2014 at 8:44 PM, Elapavuluri, Jaya wrote: > So, is there any way the bug can be fixed?? > > -Original Message- > From: Rohit Yadav [mailto:rohit.ya...@shapeblue.com] > Sent: Monday, J

Re: [DISCUSS] git commit proces

If a bug fix branch is cut off from Develop branch then all the current changes like new feature merges, new enhancement/development of a future release will also get merged to Master branch instead of a Release branch once the bug fix branch is merged. Our motto about keeping Master is to maintain

Re: [ACS44][BUG] SystemVM not working on 4.4

Frankly I don't know, I didn't focus much on the management server logs. It's easy to check if you're affected by checking the /var/log/cloud/cloud.out on either the ssvm or cpvm for the version error. Erik On Tue, Jul 29, 2014 at 8:34 PM, Tanner Danzey wrote: > Is the behavior you are descri

Re: [DISCUSS] git commit proces

Ah. I simply misunderstood. That sounds very reasonable to me. On Tue, Jul 29, 2014 at 1:59 PM, Alena Prokharchyk < alena.prokharc...@citrix.com> wrote: > Tanner, > > My question was about bugs happening not in production (the branch that is > already released). For those hot fix branches are ne

Re: [DISCUSS] git commit proces

Tanner, My question was about bugs happening not in production (the branch that is already released). For those hot fix branches are needed - and that described in the article. My question was about new bugs happening either in the *developer branch or *release branch that hasn’t been released ye

Re: [DISCUSS] git commit proces

This seems like a reasonable use scenario, but is it not what the article located at @ http://nvie.com/posts/a-successful-git-branching-model/ already describes? On Tue, Jul 29, 2014 at 1:45 PM, Alena Prokharchyk < alena.prokharc...@citrix.com> wrote: > I would rather say that the bug fix branch

Re: [DISCUSS] git commit proces

I would rather say that the bug fix branch should be cut from *developer branch, not master, then merged to *developer upon fixing so all the tests are run for the fix. Only after tests pass, the merge to master from developer should be done. If the bug doesn’t require branching out (see the propos

RE: building cloudstack

So, is there any way the bug can be fixed?? -Original Message- From: Rohit Yadav [mailto:rohit.ya...@shapeblue.com] Sent: Monday, July 28, 2014 5:10 PM To: dev@cloudstack.apache.org Subject: Re: building cloudstack Hi Jaya, Which branch are you on? It's a bug we'll fix it by placing a

Re: [DISCUSS] git commit proces

I think it would be good if the bug fixes are delivered to the Release branch only if they are found in that particular Release. But if there are any productions fixes then a new hot fix branch should be cut out of Master and once the changes are made and released, the branch should be merged back

Re: [ACS44][BUG] SystemVM not working on 4.4

Is the behavior you are describing here followed by a "com.cloud.exception.AgentUnavailableException: Resource [Host:13] is unreachable: Host 13: Unable to start instance due to Unable to get answer that is of class com.cloud.agent.api.StartAnswer"? We upgraded from 4.3 and found this fun little nu

Re: [DISCUSS] git commit proces

For what it's worth, I support the move to a git-flow project layout. It seems to have a more sensible structure than what ACS currently has, although I'm not going to say that ACS's current structure has not been sufficient, just that it simply seems to be the time for change. The git-flow model s

Re: [DISCUSS] git commit proces

On 7/29/14, 11:05 AM, "Nate Gordon" wrote: >This might be somewhere that we can extend the basic concept of gitflow. >If >there are trivial fixes (I forgot an edge case in an if statement), it >probably isn't necessary to branch the release and merge back, but if you >need to do some significan

Re: [DISCUSS] git commit proces

This might be somewhere that we can extend the basic concept of gitflow. If there are trivial fixes (I forgot an edge case in an if statement), it probably isn't necessary to branch the release and merge back, but if you need to do some significant work (I broke one of the other hypervisors and nee

[CLOUDSTACK-6886] Fixed SDX on 4.4

I fixed the 4.4 branch with this commit: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=ba025c9a7c59b62cc21e5c931407f2a0f72f9f45 I tried a new git workflow this time and I was not able to specify the commit message before it pushed. I apologize for that ugly commit message, I

Re: [DISCUSS] git commit proces

I have one more question in addition to what Sheng asked. Document http://nvie.com/posts/a-successful-git-branching-model/ mentions that the *hotfix branch should be created for the blocker/critical bugs in the current production release. What about bugs happenning in the *release branch (the one t

Re: [DISCUSS][PROPOSAL] git workflow

I just got caught up on this. My apologies for the delay. I think that we are very much on the right track and that we are right to deviate from the normal gitflow concept around the maintenance versions. Since we will in theory have a 4.5.1 after 4.6.0 is released, there will be some level of con

Re: [DISCUSS][PROPOSAL] git workflow

Hey guys, I totally agree that going with a git workflow is the best way forward: * Having developers branch off of "development" onto a bugfix/feature branch to add or fix something in cloudstack, and controlling the merge back into "development". * Using a "release" branch off of "development

Review Request 24055: CLOUDSTACK-2251: Automation test cases for feature - Dedicated guest VLAN ranges per tenant

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24055/ --- Review request for cloudstack, suresh sadhu, sailaja mada, sanjeev n, and Sowmya

Re: [ACS44][BUG] SystemVM not working on 4.4

Changing subject as it's not only KVM related. Am I the only one concerned about the fact that potentially every ACS44 installation, if installed according to doc, is broken? The last day there's been atleast three people on IRC with similar symptoms (system vms not working), one reverted to 4.3

Fwd: New Defects reported by Coverity Scan for cloudstack

Ritu, Coverity identified a number of issues with the brocade plugin. Could you have a look at them and post the fixes on the review board? If you need additional details on the findings you can request coverity access here : https://scan.coverity.com/projects/943 Cheers, Hugo Begin forwa

Review Request 24050: CLOUDSTACK-7173 Make getNewMinIops and getNewMaxIops return Longs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24050/ --- Review request for cloudstack. Bugs: CLOUDSTACK-7173 https://issues.apache.

Re: [ACS44] systemvm templates inconsistency on cloudstack.apt-get.eu

Leo, That make total sense, thanks ! *Pierre-Luc DION* Architecte de Solution Cloud | Cloud Solutions Architect t 855.652.5683 *CloudOps* Votre partenaire infonuagique* | *Cloud Solutions Experts 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com *|* tw @CloudOps_ On Tue, Jul 29

[GitHub] cloudstack-docs-install pull request: CentOS Link Broken

Github user pdion891 commented on the pull request: https://github.com/apache/cloudstack-docs-install/pull/14#issuecomment-50467917 This PR can be close. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] cloudstack-docs-install pull request: Updated systemvm template pa...

Github user pdion891 commented on the pull request: https://github.com/apache/cloudstack-docs-install/pull/18#issuecomment-50467797 This PR can be close, look like it will have to be done manually. Althought, links included in this PR are not yet confirmed for acs4.4 release yet. -

Re: [ACS44] systemvm templates

On Jul 28, 2014, at 11:51 AM, Pierre-Luc Dion wrote: > Hi > > I've had it wrong in the release-notes for system vm templates. used and > old outdated ones. > Also the Install guide point to outdated templates. I'll fix documentations > today hopefully, although, Which one should I used ? > > S

[GitHub] cloudstack-docs-install pull request: Updated systemvm template pa...

Github user runseb commented on the pull request: https://github.com/apache/cloudstack-docs-install/pull/18#issuecomment-50466209 @pdion891 I am not sure that your message "close PR: " will actually close the PR automatically. I always use "closes: #14" but never checked if there

Re: [DISCUSS] git commit proces

On Tue, Jul 29, 2014 at 1:42 PM, Sebastien Goasguen wrote: > 'pain in the #$%#$%' and revert commits to master that don't follow the new > process. You bet I am/will be > I expect that it will take a big of time pun not intended, i suppose -- Daan

Re: [DISCUSS] git commit proces

On Jul 29, 2014, at 4:01 AM, Daan Hoogland wrote: > On Tue, Jul 29, 2014 at 5:45 AM, Sheng Yang wrote: >> I found the discussion mostly took place later >> last week. > > > Yes, but it was started by Rajani at May 30th (and I think it was > mentioned even earlier) It is about time to take ste

Re: Review Request 23805: Added "state" parameter to the "listPublicIpAddresses" API call

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23805/#review48976 --- Looks fine, we still need to test it before we land it on master. I

Re: [BUG] upgrade path to 4.4.1

Alena Prokharchyk wrote: > Just one thing was missing - upgrade path from 4.4.1->4.5, I’ve added it > to DataBaseUpgradeChecker: > > _upgradeMap.put("4.4.1", new DbUpgrade[] { new Upgrade441to450() }); Thanks for catching that and fixing it. Regards. > > > -Alena. > > On 7/28/14, 3:26 PM, "Alen

Re: [ACS44] KVM SystemVM template trouble

given the move from java6 to j7; all On Tue, Jul 29, 2014 at 11:49 AM, Erik Weber wrote: > On Tue, Jul 29, 2014 at 11:41 AM, Wido den Hollander wrote: > >> >> >> On 07/29/2014 02:44 AM, Erik Weber wrote: >> >>> Tried helping Soeren Malchow on irc today, with a new ACS44 installation. >>> >>> The

Re: [ACS44] KVM SystemVM template trouble

On Tue, Jul 29, 2014 at 11:41 AM, Wido den Hollander wrote: > > > On 07/29/2014 02:44 AM, Erik Weber wrote: > >> Tried helping Soeren Malchow on irc today, with a new ACS44 installation. >> >> The docs referenced ACS43 system templates from January, but even by using >> the late June ones that go

Re: [ACS44] KVM SystemVM template trouble

On 07/29/2014 02:44 AM, Erik Weber wrote: Tried helping Soeren Malchow on irc today, with a new ACS44 installation. The docs referenced ACS43 system templates from January, but even by using the late June ones that got uploaded after the heartbleed incident it still does not work. Have you

Re: [ACS44] systemvm templates inconsistency on cloudstack.apt-get.eu

Hey Pierre-Luc, The content of the .zip is just the .vhd, and they are the same. $ cd ~/Downloads; mkdir foo; cd foo $ unzip ../systemvmtemplate-4.4.0-hyperv.vhd.zip Archive: ../systemvmtemplate-4.4.0-hyperv.vhd.zip inflating: systemvmtemplate-4.4.0-3-hyperv.vhd $ ls -al systemvmtemplate-4.4

'Read timed out' issue

Hello CloudStack Developers, Could you please help me to investigate or understand following issue with time out: When I am creating new VMs from CloudStack template with large storage size and if 'Clone virtual machine' in VMware takes more that 20 min CloudStack can't provision this VM and s

Re: [ACS44] systemvm templates inconsistency on cloudstack.apt-get.eu

created a job in jenkins.bac.o with tag 4.4.0 On Tue, Jul 29, 2014 at 9:51 AM, Wido den Hollander wrote: > > > On 07/29/2014 03:53 AM, Pierre-Luc Dion wrote: >> >> there is 2 hyper-V systemvm template availables: .vhd, .vhd.zip at >> http://cloudstack.apt-get.eu/systemvm/4.4/ >> >> So, I've downl

Re: [DISCUSS] git commit proces

On Tue, Jul 29, 2014 at 5:45 AM, Sheng Yang wrote: > I found the discussion mostly took place later > last week. Yes, but it was started by Rajani at May 30th (and I think it was mentioned even earlier) It is about time to take steps as we are at 4.5 freeze time. -- Daan

Re: [DISCUSS] git commit proces

On Jul 29, 2014, at 5:45 AM, Sheng Yang wrote: > I am trying to catch up, by reading the thread and checking what's gitflow > etc, but could someone already familiar with the topic give an overview of > the issue? > > For example, we can start by asking these questions: > 1. What's the issue with

Re: [ACS44] systemvm templates inconsistency on cloudstack.apt-get.eu

On 07/29/2014 03:53 AM, Pierre-Luc Dion wrote: there is 2 hyper-V systemvm template availables: .vhd, .vhd.zip at http://cloudstack.apt-get.eu/systemvm/4.4/ So, I've download both, but it turn out that the template .vhd file don't have the same size at the end of the process in both cases. Ple