Build failed in Jenkins: build-master-jdk18 #42

See Changes: [Gaurav Aradhye] CLOUDSTACK-8476: Disabling Zone, Pod, Cluster: --Test cases for testing the behaviour of resources running on zone and admin/non-admin user after disabling the Zone

[GitHub] cloudstack pull request: Refactor/libvirt resource

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/233#issuecomment-102951817 Hi @kishankavala, I will have a look at that, although that's pretty weird since I have tested on a KVM environment as well. Don't see why the bean w

RE: Preparing for 4.6

I don't like squashed commits either. Merging a branch on github lets the reviewer switch between seeing the overall diff, and seeing the individual commits' diffs. (And to answer the other point, also allows the author to make a pull request comment, different from any of the individual commits

[GitHub] cloudstack pull request: Refactor/libvirt resource

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/233#issuecomment-102954888 Hi @karuturi, I had a look and it has more to do with the hard coded paths in the code (which were already present) and the setup of the machine wher

Re: Preparing for 4.6

-1 for squashed commits on refactor/new features work. ;) If we have, let’s say, 2 commits, I think that would be fine to squash. But if someone has the courage to refactor 7 thousand lines of code on +30 commits, by squashing would difficult the review In addition, if those 2 commits are part

Re: Preparing for 4.6

Hi On 15.05.2015 11:27, Sebastien Goasguen wrote: > Folks, > > As we prepare to try a new process for 4.6 release it would be nice to start > paying attention to master. > > - Good commit messages The question is, what makes a commit message good? Maybe this helps: http://chris.beams.io/posts

Re: Preparing for 4.6

On Mon, May 18, 2015 at 10:26 AM, Rene Moser wrote: > Hi > > On 15.05.2015 11:27, Sebastien Goasguen wrote: > > Folks, > > > > As we prepare to try a new process for 4.6 release it would be nice to > start paying attention to master. > > > > - Good commit messages > > The question is, what makes

RE: Preparing for 4.6

In my XenCenter dev team at Citrix, we have the policy of requiring a ticket number on every commit. If we find a bug and there isn't already a ticket, we create a ticket before committing the fix. I guess I've just dug through history too many times to understand why something that appears wron

Re: Preparing for 4.6

That is a problem with linear history while its not actually linear. If you look at the DAG, its reflects the actual $ git log --graph --pretty=short * commit 256e227cd5be63186a989e2c99ded0da5e7dea71 | Author: Rohit Yadav | | schema: fix foreign key checks for 3.0.7 to 4.1.0 upgrade path | *

Re: Preparing for 4.6

Hi there, I agree with the Jira ticket for the "new features, important fixes, security fixes" But I don’t think only about "new features, important fixes, security fixes”. I put most of my time in make the code better and tested, for what we call refactoring/rewriting/redesigning. Should we a

Re: Preparing for 4.6

Hi Stephan On 18.05.2015 10:39, Stephen Turner wrote: > In my XenCenter dev team at Citrix, we have the policy of requiring a ticket > number on every commit. If we find a bug and there isn't already a ticket, we > create a ticket before committing the fix. I guess I've just dug through > histo

RE: Preparing for 4.6

Speaking for my XenCenter team again, for things like that we would have an improvement ticket, pointing to the wiki page. By the way, this also allows us to schedule the work on our sprint, but we had the policy even before we were doing Scrum. In a large, distributed, volunteer organisation,

Re: Preparing for 4.6

> On 18-May-2015, at 2:02 pm, Erik Weber wrote: > > On Mon, May 18, 2015 at 10:26 AM, Rene Moser wrote: > >> Hi >> >> On 15.05.2015 11:27, Sebastien Goasguen wrote: >>> Folks, >>> >>> As we prepare to try a new process for 4.6 release it would be nice to >> start paying attention to master. >>>

Re: Preparing for 4.6

Okay, +1 for create the ACS Jira issue for improvements as well. Since Xen and Libvirt redesign will be on 4.6 - and are already documented - I will just create 2 issues so we have a way of keeping track of them. Cheers, Wilder On 18 May 2015, at 11:16, Stephen Turner mailto:stephen.tur...@c

RE: Preparing for 4.6

Yes, a really detailed commit comment like that Linux one can work too, and I would be happy if I found that when doing code archaeology. But I guess I find that most of the time, a Jira ticket is a better place to hold that information. Somehow the developer is encouraged to write more, and it

Re: Preparing for 4.6

I am also in favor of text changelog in the root. Creating JIRA for everything may lead to bad tickets anyway. What is also nice is a quick changelog. The habit would be for everyone to remember to update the change log when they do a commit (and agree on a format for it)... > On May 18, 201

Re: Preparing for 4.6

On a related note, commits should reference the JIRA ticket as well. -- Erik On Mon, May 18, 2015 at 11:27 AM, Wilder Rodrigues < wrodrig...@schubergphilis.com> wrote: > Okay, > > +1 for create the ACS Jira issue for improvements as well. > > Since Xen and Libvirt redesign will be on 4.6 - and

Re: Preparing for 4.6

I don't like the writing of a changelog in the root, it is in git already. The comments should be good and describing the changes. The changes should be small enough to be described adequately in a short changelog. That's why I don't like squashing anything but the very trivial. Op ma 18 mei 2015

Re: Preparing for 4.6

> On May 18, 2015, at 1:14 PM, Daan Hoogland wrote: > > I don't like the writing of a changelog in the root, it is in git already. Even in a release tarball ? > The comments should be good and describing the changes. The changes should > be small enough to be described adequately in a short ch

Re: Preparing for 4.6

the release tarball is a repo snapshot. do you want a generated changelog? Op ma 18 mei 2015 om 13:30 schreef Sebastien Goasguen : > > > On May 18, 2015, at 1:14 PM, Daan Hoogland > wrote: > > > > I don't like the writing of a changelog in the root, it is in git > already. > > Even in a release

[JENKINS] Java 8 job doesn't use Java 8 at all

Hi guys, After [a guy] reported that the Java 8 build was broken due to a failure in an Unit Test, I traced the route cause and tried to build ACS using the OpenJDK 1.8 in my test environment. Unfortunately, it did not work due to an error when loading the Mockito classes : Error: java.io.IOEx

[GitHub] cloudstack pull request: Systemvm: Disable services that slow down...

GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/254 Systemvm: Disable services that slow down boot The console-setup service brings a nice font to the console, but why would we want to use it. In most cases it takes a <10 seconds to set it up

[GitHub] cloudstack pull request: Systemvm: Disable services that slow down...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/254#issuecomment-103043166 seems like it could be applied to 4.4 and 4.5 as well. the pull-builder fails however. I think it is unrelated but it is in kvm. --- If your project is set up

[GitHub] cloudstack pull request: Fixing the testGetHostStatsCommand test u...

GitHub user wilderrodrigues opened a pull request: https://github.com/apache/cloudstack/pull/255 Fixing the testGetHostStatsCommand test under LibvirtComputingResourceTest - Removed the expected value from the Test annotation - Mocking the bash path in order to avoid environm

[GitHub] cloudstack pull request: Systemvm: Disable services that slow down...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/254#issuecomment-103050221 The PR is failing due to a timeout error on Travis. This timeout problem is occurring not so often, and when it does it's not really related the content of t

[GitHub] cloudstack pull request: Fixing the testGetHostStatsCommand test u...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/255#issuecomment-103062657 @DaanHoogland @bhaisaab, Build and Travis are happy. Could you please review/close it? Cheers, Wilder --- If your project is set up fo

[GitHub] cloudstack pull request: Systemvm: Disable services that slow down...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/254#issuecomment-103074746 The KVM unit tests error was fixed on PR 255 Unexpected exception, expected but was This PR looks good and I tested it against my KVM enviro

[GitHub] cloudstack pull request: Systemvm: Disable services that slow down...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/254 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Build failed in Jenkins: build-master-jdk18 #43

See Changes: [github] Systemvm: Disable services that slow down boot -- [...truncated 2665 lines...] [INFO] --- maven-remote-resources-plugin:1.3:process (default) @ cloud-plugin-hyperviso

RE: delete local storage pool on cloudstack 4.4.3

Star Guo, While I wasn't been able to have a look at the error/image you shared, I believe the issue is due to the orphaned entries in the table *storage_pool_host_ref*. Remove that and you should be good. Also make sure to remove the entry in *op_host_capacity* for this storage pool. Somesh C

[GitHub] cloudstack pull request: Systemvm: Disable services that slow down...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/254#issuecomment-103111320 @DaanHoogland Yes, merging to 4.5 and 4.4 would be nice. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] cloudstack pull request: Systemvm: Disable services that slow down...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/254#issuecomment-10315 @remibergsma good stuff, we should have it on 4.4/4.5. @wilderrodrigues I don't know, perhaps open a ticket on ASF Infra's JIRA? Since ASF are a paid custom

[GitHub] cloudstack pull request: Fixing the testGetHostStatsCommand test u...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/255#issuecomment-103151365 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cloudstack pull request: Fixing the testGetHostStatsCommand test u...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/255 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Build failed in Jenkins: build-master-jdk18 #44

See Changes: [Rohit Yadav] systemvmtemplate: install libc6:i386 for 64bit template -- [...truncated 2665 lines...] [INFO] --- maven-remote-resources-plugin:1.3:process (default) @ cloud-pl

Re: VPC Firewall Rule Limitations

Thanks Marcus, I get the tier model in principle, and for pure web apps with a web->app->db tier model it makes good sense. However we have many hosting clients using VPC with a single tier so that they can use the IPsec tunnels, and sometimes only a subset of the instances should have access

[GitHub] cloudstack pull request: ui: add custom error handling page

GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/256 ui: add custom error handling page This just catches any exception and avoid showing stacktrace. You can merge this pull request into a Git repository by running: $ git pull https://github

[GitHub] cloudstack pull request: ui: add custom error handling page

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/256#issuecomment-103220844 LGTM, why for 4.5 will you merge forward? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] cloudstack pull request: ui: add custom error handling page

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/256#issuecomment-103228420 yeah, will merge on both 4.5/master :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] cloudstack pull request: ui: add custom error handling page

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/256#issuecomment-103228536 ok, I will push to 4.5 Op di 19 mei 2015 om 00:10 schreef Rohit Yadav : > yeah, will merge on both 4.5/master :) > > — > Reply to

[GitHub] cloudstack pull request: ui: add custom error handling page

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/256#issuecomment-103229050 you beat me Op di 19 mei 2015 om 00:11 schreef Daan Hoogland : > ok, I will push to 4.5 > > Op di 19 mei 2015 om 00:10 schreef Rohit Yad

[GitHub] cloudstack pull request: ui: add custom error handling page

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/256 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: ui: add custom error handling page

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/256#issuecomment-103229305 oh, I did not know you were doing it :) Pushed to master as well. --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] cloudstack pull request: ui: add custom error handling page

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/256#issuecomment-103229542 @DaanHoogland I could be faster as I use a Github PR merging automation alias, you may try this: https://github.com/bhaisaab/dotfiles/blob/master/git/gitconfig#L46

[GitHub] cloudstack pull request: Systemvm: Disable services that slow down...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/254#issuecomment-103232141 Merged on 4.5 and 4.4; I made another fix to include libc:i386, will refresh 4.5 systemvmtemplates on packages.shapeblue.com tomorrow. --- If your project is set u

Re: [GitHub] cloudstack pull request: ui: add custom error handling page

looks impressive but I think it was the test compile that did me in ;) Op di 19 mei 2015 om 00:14 schreef bhaisaab : > Github user bhaisaab commented on the pull request: > > https://github.com/apache/cloudstack/pull/256#issuecomment-103229542 > > @DaanHoogland I could be faster as I use

CLOUDSTACK DAY SEATTLE] CFP Deadline June 12

Hi everyone, Just a friendly reminder that the deadline for submitting a proposal for CloudStack Day Seattle is Friday, June 12. You can submit your proposal @ http://events.linuxfoundation.org/events/cloudstack-seattle/program/cfp . Thanks, Likitha

Re: Preparing for 4.6

On Mon, May 18, 2015 at 1:14 PM, Daan Hoogland wrote: > I don't like the writing of a changelog in the root, it is in git already. > The comments should be good and describing the changes. The changes should > be small enough to be described adequately in a short changelog. That's why > I don't l

[GitHub] cloudstack pull request: Implementation for the ability to disable...

GitHub user devdeep opened a pull request: https://github.com/apache/cloudstack/pull/257 Implementation for the ability to disable a storage pool for provisioning of new volumes. Implementation for the ability to disable a storage pool for provisioning of new volumes. Following cha

[GitHub] cloudstack pull request: Implementation for the ability to disable...

Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/257#issuecomment-103369983 I love this feature! Is there a related Jira issue and/or FS spec for it? What happens if a user tries to resize a volume that resides on a disabled storag

[GitHub] cloudstack pull request: Implementation for the ability to disable...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/257#issuecomment-103371847 @devdeep thanks probably one of the frequently asked features, LGTM. I'll wait and merge when travis goes green. --- If your project is set up for it, you can repl