[GitHub] cloudstack pull request: CLOUDSTACK-8987 call s3xen/swiftxen plugi...

2015-10-26 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/970#issuecomment-151083526 Code look good to me, no rocket science involved. I will test it with XenServer 6.5, but I might need help figuring out how to get it covered.

[GitHub] cloudstack pull request: CLOUDSTACK-8987 call s3xen/swiftxen plugi...

2015-10-26 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/970#issuecomment-151091001 Since a8212d9 changed names from "xen" to "xenserver", shouldn't the change be to rename the files s3xen to s3xenserver and swiftxen to swiftxenserver in

[GitHub] cloudstack pull request: CLOUDSTACK-8977: remove session creation ...

2015-10-26 Thread K0zka
Github user K0zka commented on the pull request: https://github.com/apache/cloudstack/pull/961#issuecomment-151102999 @ustcweizhou could you share some details about the problem? Are you not able to login? --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: CLOUDSTACK-8987 call s3xen/swiftxen plugi...

2015-10-26 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/970#issuecomment-151104185 Good point, @koushik-das. @remibergsma: do you agree on that one as well? --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: CLOUDSTACK-8990: start a stopped machine ...

2015-10-26 Thread ustcweizhou
GitHub user ustcweizhou opened a pull request: https://github.com/apache/cloudstack/pull/978 CLOUDSTACK-8990: start a stopped machine on a specific determinable host on UI You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack pull request: CLOUDSTACK-8889: delete volume doesnt dec...

2015-10-26 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/860#issuecomment-151089307 @remibergsma @karuturi I tested this PR with the changes in #979. Results: ``` nosetests --with-marvin

Re: [DISCUSS] Move to GitHub

2015-10-26 Thread Wido den Hollander
On 25-10-15 10:52, Milamber wrote: > > > On 25/10/2015 07:05, Sebastien Goasguen wrote: >> Folks, >> >> We have been using GitHub for PR now for a while, it seems to work >> despite the fact that we still have to get used to the workflow. >> We lack some privileges on the mirror to be able to

[GitHub] cloudstack pull request: CLOUDSTACK-8977: remove session creation ...

2015-10-26 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/961#issuecomment-151087205 guys, CS UI is broken by this commit on my env. I am using Chrome (Version 46.0.2490.80 m) It works after reverting this commit. --- If your project is

[GitHub] cloudstack pull request: CLOUDSTACK-8989 test_ps_limits.py tests c...

2015-10-26 Thread borisroman
GitHub user borisroman opened a pull request: https://github.com/apache/cloudstack/pull/979 CLOUDSTACK-8989 test_ps_limits.py tests can also be run on a "basic" setup. The tests in the test_ps_limits.py file can all be run on a "basic" setup. This PR adds that functionality. You

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

2015-10-26 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-151090163 @wido I agree with you. The ideal solution is to implement the features in libvirt-java. At this moment, I do not know how long it will take and when it will

ACS 4.5.2 Error while Implementation PVLAN

2015-10-26 Thread Keerthiraja SJ
Hi All, Today I tried to create Advance Zone I added new network with using of vlan primary 41 secondary vlan 42 all the basic necessary been done on switch. While I create a VM I could see error as nw-label: cloudstack, isolated-pvlan: 42, op: add, primary-pvlan: 41, due to There was a

[GitHub] cloudstack pull request: CLOUDSTACK-8987 call s3xen/swiftxen plugi...

2015-10-26 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/970#issuecomment-151092704 Ping @runseb. Is there a handle/userid for Tim Mackey? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

2015-10-26 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-151094003 @ustcweizhou It's just a matter of sending patches to RedHat and they will accept it. You can also request a new release of the bindings when you need to. It

[GitHub] cloudstack pull request: CLOUDSTACK-8889: delete volume doesnt dec...

2015-10-26 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/860#issuecomment-151096159 @karuturi Jenkins failed; [ERROR] Error in Cobertura Report generation: Unable to execute Cobertura. Could maybe force push again? --- If your

[GitHub] cloudstack pull request: Pass LbProtocol down to the HAProxyConfig...

2015-10-26 Thread insom
Github user insom commented on the pull request: https://github.com/apache/cloudstack/pull/848#issuecomment-151097482 @remibergsma Hi, rebased and pushed! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: CLOUDSTACK-8987 call s3xen/swiftxen plugi...

2015-10-26 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/970#issuecomment-151081518 @remibergsma @borisroman - I'm starting tests now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Fix KVM snap to vol and ...

2015-10-26 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/962#issuecomment-151086437 @snuf @NuxRo KVMGuru and LXCGuru are defined at

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

2015-10-26 Thread wido
Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/977#discussion_r42975042 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java --- @@ -3388,4 +3419,83 @@ public String

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

2015-10-26 Thread wido
Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/977#discussion_r42975005 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtRestoreVMSnapshotCommandWrapper.java --- @@ -0,0 +1,121 @@ +//

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

2015-10-26 Thread wido
Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/977#discussion_r42975057 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java --- @@ -3388,4 +3419,83 @@ public String

[GitHub] cloudstack pull request: CLOUDSTACK-8889: delete volume doesnt dec...

2015-10-26 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/860#issuecomment-151096712 3rd attempt. I hope it succeeds this time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-8989 test_ps_limits.py tests c...

2015-10-26 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/979#issuecomment-151104355 thanks for the tests, @karuturi! I will test this PR. Cheers, Wilder --- If your project is set up for it, you can reply to this email and have

Re: TransactionContextInterceptor Keeps Releasing My Lock

2015-10-26 Thread Jeff Hair
I have narrowed it down to multithreading being the cause. I have a set of workers running through an executor service, and it seems cglib is not respecting the @DB annotation on the method being called by the thread. I can force the lock to be acquired if the entire method is executed in a

[GitHub] cloudstack pull request: CLOUDSTACK-8977: remove session creation ...

2015-10-26 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/961#issuecomment-151105807 @K0zka the page is blank. I tried sometimes with the same result (blank page with this commit, works without this commit). --- If your project is set up for

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

2015-10-26 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/950#issuecomment-151037118 @miguelaferreira Can you please have a look why both Travis and Jenkins are unhappy again? Thx! --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

2015-10-26 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/950#issuecomment-151055701 Can't we include it as dependency? Or are there licencing issues? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

2015-10-26 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-151049279 @ustcweizhou Can you please share FS or design document for this work? It'd help greatly in reviewing this patch. Thanks. --- If your project

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

2015-10-26 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-151050842 @sateesh-chodapuneedi Thanks for your comment, I will fix it soon. This is an implementation of vm snapshot for KVM. You may find the FS

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

2015-10-26 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/977#discussion_r42966249 --- Diff: api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotFromVMSnapshotCmd.java --- @@ -0,0 +1,191 @@ +//

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

2015-10-26 Thread ustcweizhou
Github user ustcweizhou commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/977#discussion_r42966712 --- Diff: api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotFromVMSnapshotCmd.java --- @@ -0,0 +1,191 @@ +// Licensed to the

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

2015-10-26 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/950#issuecomment-151057998 It's already included as a dependency in the `noredist` profile. This PR includes it as a dependency in the `developer` profile, and forces the MySQL driver

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

2015-10-26 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-151054893 @ustcweizhou I think it's handy to include account access checks for the backup snapshot from vm snapshot. --- If your project is set up for it,

[GitHub] cloudstack pull request: CLOUDSTACK-8975:skip test case if niciraN...

2015-10-26 Thread pvr9711
Github user pvr9711 commented on the pull request: https://github.com/apache/cloudstack/pull/960#issuecomment-151071811 +1 move this test out of BVTs - this was brought up on almost 3-4 weeks ago. @runseb - I guess, my understanding is - we need 100% passrate on all BVTs - we

[GitHub] cloudstack pull request: CLOUDSTACK-8889: delete volume doesnt dec...

2015-10-26 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/860#issuecomment-151047752 @borisroman yes this is real :) . I think this might exist in 4.5 as well. Haven't tested it there. I rebased with the current master --- If your project is

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

2015-10-26 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/977#discussion_r42965130 --- Diff: api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotFromVMSnapshotCmd.java --- @@ -0,0 +1,191 @@ +//

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

2015-10-26 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/950#issuecomment-151050165 The erros, travis and Jenkins report are due to missing mysql connector jar. Shall I make Travis build with the developer profile (i.e. `-Pdeveloper`)? Or

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

2015-10-26 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/977#discussion_r42966399 --- Diff: engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java --- @@ -1702,6 +1705,18 @@ protected boolean

[GitHub] cloudstack pull request: CLOUDSTACK-8924: Enable dynamic scaling t...

2015-10-26 Thread sanju1010
Github user sanju1010 commented on the pull request: https://github.com/apache/cloudstack/pull/902#issuecomment-151068985 @pvr9711 can you please review this PR? I have made changes as per the review comments and rebased it with master. --- If your project is set up for it, you can

[GitHub] cloudstack pull request: CLOUDSTACK-8924: Enable dynamic scaling t...

2015-10-26 Thread pvr9711
Github user pvr9711 commented on the pull request: https://github.com/apache/cloudstack/pull/902#issuecomment-151070859 LGTM, I have tested this on a private setup and is working. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

2015-10-26 Thread ustcweizhou
GitHub user ustcweizhou opened a pull request: https://github.com/apache/cloudstack/pull/977 CLOUDSTACK-8746: VM Snapshotting implementation for KVM You can merge this pull request into a Git repository by running: $ git pull https://github.com/ustcweizhou/cloudstack

[GitHub] cloudstack pull request: CLOUDSTACK-8906: /var/log/cloud/ doesn't ...

2015-10-26 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/883#issuecomment-151047344 Changes LGTM. I haven't tested it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43043984 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java --- @@ -129,66 +132,93 @@ public Network

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43042353 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -367,22 +483,16 @@ public boolean

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43042274 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -303,13 +414,17 @@ protected boolean

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43048038 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -152,50 +241,185 @@ public NuageVspDeviceVO

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43050571 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -152,50 +241,185 @@ public NuageVspDeviceVO

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43050493 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -152,50 +241,185 @@ public NuageVspDeviceVO

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43050603 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -152,50 +241,185 @@ public NuageVspDeviceVO

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43052473 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -285,60 +529,334 @@ public boolean

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43052507 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -285,60 +529,334 @@ public boolean

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43052957 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -348,6 +866,6 @@ public String

[GitHub] cloudstack pull request: [wip] CLOUDSTACK-8708: gson update and Ar...

2015-10-26 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/932#issuecomment-151293897 @remibergsma @borisroman @wido I just pushed a 650 file commit. I fair the future of this change. --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43042002 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -205,6 +250,75 @@ public boolean

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43042630 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -395,65 +505,135 @@ public IpDeployer

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43043241 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -483,7 +663,7 @@ protected HostVO

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43044473 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java --- @@ -358,19 +441,22 @@ private String

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Can't create template or...

2015-10-26 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/954#issuecomment-151273466 Hi Remi, I have rebuilt my entire 4.6 CS environment from scratch and re-run my tests. I'm happy to report that I no longer see the

Service Offering documentation

2015-10-26 Thread Ron Wheeler
The GPU section on page http://docs.cloudstack.apache.org/projects/cloudstack-administration/en/4.5/service_offerings.html seems to be lacking some information (at least as far as I can tell). 1) What does the GPU do? It says to select a card that I want to use. No hint about the basis on which

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43041851 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -194,7 +224,23 @@ public boolean

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43053663 --- Diff: plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/NuageVspPluginClientLoader.java --- @@ -19,28 +19,101 @@ package

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43053698 --- Diff: plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/NuageVspPluginClientLoader.java --- @@ -19,28 +19,101 @@ package

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43053678 --- Diff: plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/NuageVspPluginClientLoader.java --- @@ -19,28 +19,101 @@ package

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43044620 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java --- @@ -201,51 +234,82 @@ public NicProfile

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43050866 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -152,50 +241,185 @@ public NuageVspDeviceVO

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43043089 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -395,65 +505,135 @@ public IpDeployer

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43046732 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -67,25 +74,76 @@ import

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43053099 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java --- @@ -112,8 +111,8 @@ public boolean

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43050959 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -152,50 +241,185 @@ public NuageVspDeviceVO

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43051815 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -285,60 +529,334 @@ public boolean

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43053334 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java --- @@ -191,36 +188,26 @@ public boolean

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43053203 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java --- @@ -170,20 +169,18 @@ public boolean

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43042164 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -303,13 +414,17 @@ protected boolean

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43043433 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java --- @@ -114,7 +115,9 @@ public Network

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43045509 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java --- @@ -409,8 +472,8 @@ private HostVO

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43052201 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -285,60 +529,334 @@ public boolean

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43052276 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -285,60 +507,341 @@ public boolean

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/801#issuecomment-151287245 @KrisSterckx @nlivens overall, this PR is looking good. I found a few more items. and we have a few outstanding bits of feedback to complete. Also, don't forget

[GitHub] cloudstack pull request: [wip] CLOUDSTACK-8708: gson update and Ar...

2015-10-26 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/932#issuecomment-151299203 Well... We could have expected it... https://sites.google.com/site/gson/gson-roadmap After version 2.0 Primtive Types weren't allowed

[GitHub] cloudstack-docs pull request: Based on my conversation with the us...

2015-10-26 Thread epretorious
GitHub user epretorious opened a pull request: https://github.com/apache/cloudstack-docs/pull/12 Based on my conversation with the user terbolous in #cloudstack... Changed the sequence of operations in the section "Initial setup of your fork" to move the two commands related to the

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

2015-10-26 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-151160292 @ustcweizhou I want a stable master branch which works all the time. Executing binaries is not reliable as we can't do proper exception handling. Also, virsh

[GitHub] cloudstack pull request: CLOUDSTACK-8990: start a stopped machine ...

2015-10-26 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/978#issuecomment-151115822 @borisroman None means cloudstack will allocate the host to start the vm. I think it is also needed for users. Not everyone wants to specify a host, right? ---

[GitHub] cloudstack pull request: CLOUDSTACK-8917 : Instance tab takes long...

2015-10-26 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/894#issuecomment-151130113 LGTM, based on a set of tests that I run on this branch: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a

[GitHub] cloudstack pull request: CLOUDSTACK-8992 Allow 32 disks to be atta...

2015-10-26 Thread borisroman
GitHub user borisroman opened a pull request: https://github.com/apache/cloudstack/pull/980 CLOUDSTACK-8992 Allow 32 disks to be attached to a KVM VM. Tested manually. Added 32 disks to a VM, booted the VM, formatted all disks and mounted them all. Also created volume

[GitHub] cloudstack pull request: CLOUDSTACK-8993: DHCP fails with "no addr...

2015-10-26 Thread serbaut
GitHub user serbaut opened a pull request: https://github.com/apache/cloudstack/pull/981 CLOUDSTACK-8993: DHCP fails with "no address available" when an IP is… … reused Repopulate /etc/dhcphosts.txt to remove old entries with the same IP address. You can merge this

Re: ACS 4.5.2 Error while Implementation PVLAN

2015-10-26 Thread Keerthiraja SJ
Can someone help me how to set the community vlan in cloudstack I can see only options as SecondaryVLAN id. Thanks, Keerthi On Mon, Oct 26, 2015 at 3:54 PM, Keerthiraja SJ wrote: > Hi All, > > Today I tried to create Advance Zone I added new network with using of > vlan

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

2015-10-26 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-151155683 @wido it depends on which is more important for us, more features in cloudstack or removing virsh from cloudstack? we know "virsh" provides more features than

[GitHub] cloudstack pull request: CLOUDSTACK-8987 call s3xen/swiftxen plugi...

2015-10-26 Thread xenserverarmy
Github user xenserverarmy commented on the pull request: https://github.com/apache/cloudstack/pull/970#issuecomment-151157372 @koushik-das One of the goals of a8212d9ef458dd7ac64b021e6fa33fcf64b3cce0 was to ensure that we have clarity in which hypervisor we support since Xen !=

[GitHub] cloudstack pull request: CLOUDSTACK-8989 test_ps_limits.py tests c...

2015-10-26 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/979#issuecomment-151145630 Hi @borisroman Although my first round of tests failed, after looking into the test code it seems to be environment related: ``` Test

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

2015-10-26 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-151153457 @ustcweizhou I understand the reasoning and that you want this feature in 4.7, but there is no guarantee it will be fixed afterwards. Once the feature is in there

Re: [DISCUSS] Move to GitHub

2015-10-26 Thread Rene Moser
Hi On 10/26/2015 10:59 AM, Wido den Hollander wrote: >> But, I thinks that would be better to keep the control of the source >> code repo. This is the core of your work. >> > > Agree. I love Github and it works great, but make it THE primary source > for the source code and go away from ASF?

Re: [DISCUSS] Move to GitHub

2015-10-26 Thread Nux!
+1 what Wido said. -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - > From: "Wido den Hollander" > To: dev@cloudstack.apache.org > Sent: Monday, 26 October, 2015 09:59:18 > Subject: Re: [DISCUSS] Move to GitHub > On 25-10-15

[GitHub] cloudstack pull request: CLOUDSTACK-8990: start a stopped machine ...

2015-10-26 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/978#issuecomment-151115178 @ustcweizhou Thanks for implementing this feature. I've got 1 comment, could you select the first host available instead of none? See image. ![screenshot

[GitHub] cloudstack pull request: CLOUDSTACK-8990: start a stopped machine ...

2015-10-26 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/978#issuecomment-151116076 @ustcweizhou Oke! Though can you make that visible to the user? Now it seems like you "have to" select a host, like you're forced to do so. --- If your project

[GitHub] cloudstack pull request: CLOUDSTACK-8990: start a stopped machine ...

2015-10-26 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/978#issuecomment-151136095 change default host from empty to 'Default'. done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

RE: BVT report - 10/22

2015-10-26 Thread Raja Pullela
Cool, BTW, The reason for failure for the following tests is downloading of templates/ISOs is taking a long time to download 1) integration.smoke.test_vm_life_cycle.TestVMLifeCycle.test_10_attachAndDetach_iso 2)

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread nlivens
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/801#issuecomment-151120955 @remibergsma, I've rebased against current master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: CLOUDSTACK-8990: start a stopped machine ...

2015-10-26 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/978#issuecomment-151127784 @borisroman sorry my comment made you confused. The users I meant is one who use cloudstack for deployment. This window is only visible for root admins. For

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

2015-10-26 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-151130476 @wido good to know it, thanks. I will implement some features in libvirt-java. I would like to keep current command line and merge it to cs 4.7, and change

[GitHub] cloudstack pull request: CLOUDSTACK-8990: start a stopped machine ...

2015-10-26 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/978#issuecomment-151115265 @remibergsma @karuturi I've run the following tests: ``` --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: CLOUDSTACK-8990: start a stopped machine ...

2015-10-26 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/978#issuecomment-151133235 @borisroman yes, sure --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

  1   2   >