Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/980#issuecomment-151397659
I am running the tests for #980 and #983 together.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43090521
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
@@ -129,6 +145,18 @@
AgentManager _agentMgr;
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43090554
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
@@ -205,6 +250,75 @@ public boolean implement(Network
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43090895
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
---
@@ -201,51 +234,82 @@ public NicProfile allocat
Prakesh,
Thanks for the offer to step in. There are lots of improvements and
refactorings to be made. Made sure you have a good test bed first. At the
moment we are in freeze so getting contributions accepted is hard on the
beginner.
For starters I would suggest finding the massive blobs (huge me
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43091029
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
---
@@ -358,19 +441,22 @@ private String getVirtual
On Tue, Oct 27, 2015 at 7:57 AM, B Prakash wrote:
> Hi, I am an experience Java EE professional (new to cloudstack though).
>
>
>I am interested in contributing to the development. As suggested
> in the newcomer section, I have been following the jira and the dev emails
> for a few days
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43091160
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -285,60 +507,341 @@ public boolean
deleteNuag
GitHub user milamberspace opened a pull request:
https://github.com/apache/cloudstack/pull/984
Update L10N files for Next 4.6.
Update the localization files for the next CloudStack version. This PR is
open until the start of the release candidate 1 for CS 4.6.
This PR cance
Github user milamberspace closed the pull request at:
https://github.com/apache/cloudstack/pull/974
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
Github user milamberspace commented on the pull request:
https://github.com/apache/cloudstack/pull/974#issuecomment-151403745
Mishandling git commands. I've recreated this open PR for the localization
files, see #984
Closes this PR.
---
If your project is set up for it, you
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43091274
--- Diff: plugins/network-elements/nuage-vsp/pom.xml ---
@@ -28,6 +28,13 @@
4.6.0-SNAPSHOT
../../pom.xml
+
+
+
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43091431
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -67,25 +74,76 @@
import com.cloud.network
Dear Ron,
I suggest you to read this document:
https://cwiki.apache.org/confluence/display/CLOUDSTACK/GPU+and+vGPU+support+for+CloudStack+Guest+VMs.
I have tested pass-through mode with XenServer 6.2 and can give probably
a bit more information if you need. The reference document is good
Dear Ron,
I suggest you to read this document:
https://cwiki.apache.org/confluence/display/CLOUDSTACK/GPU+and+vGPU+support+for+CloudStack+Guest+VMs
[1]. I have tested pass-through mode with XenServer 6.2 and can give
probably a bit more information if you need. The reference document is
goo
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43091957
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/PingNuageVspCommand.java
---
@@ -17,18 +17,37 @@
// under the License.
//
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43091944
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/PingNuageVspCommand.java
---
@@ -17,18 +17,37 @@
// under the License.
//
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43092262
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/UpdateNuageVspDeviceCommand.java
---
@@ -0,0 +1,61 @@
+//
+// Licensed to th
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43092257
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/UpdateNuageVspDeviceCommand.java
---
@@ -0,0 +1,61 @@
+//
+// Licensed to th
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43092609
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/VspResourceCommand.java
---
@@ -79,4 +79,41 @@ public String getProxyUserDomainuuid(
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43092627
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/VspResourceCommand.java
---
@@ -79,4 +79,41 @@ public String getProxyUserDomainuuid(
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43092950
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspCommand.java
---
@@ -58,20 +73,117 @@ public String getVpcOrS
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43092964
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspCommand.java
---
@@ -79,4 +191,47 @@ public boolean executeIn
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43092995
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspCommand.java
---
@@ -79,4 +191,47 @@ public boolean executeIn
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093020
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyStaticNatVspCommand.java
---
@@ -51,13 +61,91 @@ public boolean isL3Net
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093012
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyStaticNatVspCommand.java
---
@@ -51,13 +61,91 @@ public boolean isL3Net
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093062
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ImplementVspCommand.java
---
@@ -0,0 +1,295 @@
+//
+// Licensed to t
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093055
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ImplementVspCommand.java
---
@@ -0,0 +1,295 @@
+//
+// Licensed to t
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093076
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ShutDownVpcVspCommand.java
---
@@ -40,9 +43,61 @@ public String getVpcUuid()
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093086
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ShutDownVpcVspCommand.java
---
@@ -40,9 +43,61 @@ public String getVpcUuid()
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093132
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/DeallocateVmVspCommand.java
---
@@ -83,9 +92,130 @@ public String getVmUuid() {
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093140
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/DeallocateVmVspCommand.java
---
@@ -83,9 +92,130 @@ public String getVmUuid() {
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093154
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ImplementNetworkVspCommand.java
---
@@ -112,13 +147,212 @@ public boolean isDef
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093160
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ImplementNetworkVspCommand.java
---
@@ -112,13 +147,212 @@ public boolean isDef
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093202
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReserveVmInterfaceVspCommand.java
---
@@ -87,29 +114,285 @@ public boolean isDo
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093227
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/TrashNetworkVspCommand.java
---
@@ -48,13 +53,93 @@ public boolean isL3Network(
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093192
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReserveVmInterfaceVspCommand.java
---
@@ -87,29 +114,285 @@ public boolean isDo
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093221
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/TrashNetworkVspCommand.java
---
@@ -48,13 +53,93 @@ public boolean isL3Network(
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093317
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/manager/GetClientDefaultsAnswer.java
---
@@ -0,0 +1,79 @@
+//
+// Licensed t
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093300
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/manager/GetClientDefaultsAnswer.java
---
@@ -0,0 +1,79 @@
+//
+// Licensed t
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093355
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/manager/SupportedApiVersionCommand.java
---
@@ -17,38 +17,42 @@
// under the Li
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093369
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/manager/SupportedApiVersionCommand.java
---
@@ -17,38 +17,42 @@
// under the Li
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093430
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncDomainCommand.java
---
@@ -0,0 +1,91 @@
+//
+// Licensed to the Apa
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093444
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncNuageVspCmsIdAnswer.java
---
@@ -0,0 +1,71 @@
+//
+// Licensed to t
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093396
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncDomainAnswer.java
---
@@ -17,28 +17,38 @@
// under the License.
/
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093404
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncDomainAnswer.java
---
@@ -17,28 +17,38 @@
// under the License.
/
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/981#issuecomment-151412107
Is there any way we can test this automatically? I think there is no Unit
Test for this, right?
I currently don't have a setup to test this, but can you explain
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093426
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncDomainCommand.java
---
@@ -0,0 +1,91 @@
+//
+// Licensed to the Apa
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093455
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncNuageVspCmsIdAnswer.java
---
@@ -0,0 +1,71 @@
+//
+// Licensed to t
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093502
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncVspCommand.java
---
@@ -39,4 +39,21 @@ public String getNuageVspEntity() {
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093482
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncNuageVspCmsIdCommand.java
---
@@ -0,0 +1,70 @@
+//
+// Licensed to
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093497
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncVspCommand.java
---
@@ -39,4 +39,21 @@ public String getNuageVspEntity() {
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093469
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncNuageVspCmsIdCommand.java
---
@@ -0,0 +1,70 @@
+//
+// Licensed to
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-151412595
@ustcweizhou I think we shouldn't want a enable/disable flag in the
agent.properties, it should work for anybody.
That we already have a lot of commands being e
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093698
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
@@ -194,7 +224,23 @@ public boolean configure(String
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093875
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
@@ -303,13 +414,17 @@ protected boolean canHandle(Net
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093940
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
@@ -303,13 +414,17 @@ protected boolean canHandle(Net
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43094017
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
@@ -367,22 +483,16 @@ public boolean applyStaticNats(
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43094088
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
@@ -395,65 +505,135 @@ public IpDeployer getIpDeploye
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43094914
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
@@ -483,7 +663,7 @@ protected HostVO getNuageVspHost(
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43095297
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
---
@@ -114,7 +115,9 @@ public Network design(Netwo
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43095562
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
---
@@ -129,66 +132,93 @@ public Network design(Net
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43095672
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
---
@@ -409,8 +472,8 @@ private HostVO getNuageVspH
Github user serbaut commented on the pull request:
https://github.com/apache/cloudstack/pull/981#issuecomment-151418751
I tested this manually. I did not manage to get any test environment to
work but there is some tests in test/systemvm/test_update_config.py that could
probably be ex
Hi all,
if we delete a project, the name of the project is set to NULL in the
database and thus does not appear in the usage records.
But the display_text ist still available. This makes no sense imho.
We have no chance to display project names of deleted projects in a
monthly report for example.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-151440654
So @wido , is the discussion whether we should change libvirt-java and
contribute back or use virsh?
I'm all for the first one but I recall problems you
GitHub user wido opened a pull request:
https://github.com/apache/cloudstack/pull/985
CLOUDSTACK-8715: Add VirtIO channel to all Instances for the Qemu Gueâ¦
â¦st Agent
This commit adds a additional VirtIO channel with the name
'org.qemu.guest_agent.0'
to all Instance
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-151442130
@DaanHoogland Indeed, that is the case.
The problems I had were with libvirt, not the bindings. libvirt-java is
distributed via Maven and we include it in our p
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43102657
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -152,50 +241,185 @@ public NuageVspDeviceVO
a
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43102747
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -152,50 +241,185 @@ public NuageVspDeviceVO
a
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43102867
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -152,50 +241,185 @@ public NuageVspDeviceVO
a
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43102851
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -152,50 +241,185 @@ public NuageVspDeviceVO
a
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43103148
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -152,50 +241,185 @@ public NuageVspDeviceVO
a
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43103330
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -152,50 +241,185 @@ public NuageVspDeviceVO
a
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/978#issuecomment-151444216
LGTM
Nice feature indeed :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43103443
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -285,60 +529,334 @@ public boolean
deleteNuag
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43103718
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -285,60 +529,334 @@ public boolean
deleteNuag
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43104160
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -285,60 +529,334 @@ public boolean
deleteNuag
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43104184
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -285,60 +529,334 @@ public boolean
deleteNuag
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43104207
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -348,6 +866,6 @@ public String getConfigCompon
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/977#discussion_r43104186
--- Diff: ui/scripts/cloudStack.js ---
@@ -22,13 +22,13 @@
var sections = [];
if (isAdmin()) {
-
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/977#discussion_r43104351
--- Diff:
api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotFromVMSnapshotCmd.java
---
@@ -0,0 +1,191 @@
+// Licensed to the Apa
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43104314
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java
---
@@ -112,8 +111,8 @@ public boolean configure(String
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/977#discussion_r43104400
--- Diff:
api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotFromVMSnapshotCmd.java
---
@@ -0,0 +1,197 @@
+// Licensed to the Apa
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/977#discussion_r43104473
--- Diff:
api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotFromVMSnapshotCmd.java
---
@@ -0,0 +1,197 @@
+// Licensed to the Apa
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/977#discussion_r43104502
--- Diff:
api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotFromVMSnapshotCmd.java
---
@@ -0,0 +1,197 @@
+// Licensed to the Apa
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/977#discussion_r43104526
--- Diff:
api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotFromVMSnapshotCmd.java
---
@@ -0,0 +1,197 @@
+// Licensed to the Apa
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43104632
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java
---
@@ -191,36 +188,26 @@ public boolean configure(Stri
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43104591
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java
---
@@ -170,20 +169,18 @@ public boolean configure(Stri
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-151447134
@ustcweizhou Can you add some unit tests for the new methods and classes,
thanks
---
If your project is set up for it, you can reply to this email and have your
re
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43104873
--- Diff:
plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/NuageVspPluginClientLoader.java
---
@@ -19,28 +19,101 @@
package net.nuage.
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43104885
--- Diff:
plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/NuageVspPluginClientLoader.java
---
@@ -19,28 +19,101 @@
package net.nuage.
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43104880
--- Diff:
plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/NuageVspPluginClientLoader.java
---
@@ -19,28 +19,101 @@
package net.nuage.
Cloudmonkey 5.3.1.
Usage records are missing if a whole month is used as the time frame for
usagerecord type 6 although the usage data is in the database
So we have to call cloudmonkey for every single day in this case.
Large amounts of usage data is missing in the output:
cloudmonkey list usage
Cloudmonkey 5.3.1.
The position of columns in the output is mixed up.
> cloudmonkey list virtualmachines listall=true
projectid=4865e6c6-b1ff-48ef-b908-1f5fde7d7b6e
filter=id,name,cpunumber,cpuspeed,memory,created
count = 16
virtualmachine:
+---+--+-
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/960#issuecomment-151455578
@pvr9711 There are so many things to do for 4.6, do you really want _me_ to
send a PR for moving a file? Please send it yourself, and both @miguelaferreira
and m
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/984#issuecomment-151455654
Thanks for the update @milamberspace !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/979#issuecomment-151460148
Hi @borisroman ,
I just finish the tests: All looking fine!
```
[root@cs3 integration]# nosetests --with-marvin
--marvin-config=/data/sh
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/979#issuecomment-151467948
Ping @borisroman @remibergsma @karuturi @DaanHoogland
This PR LGTM :+1:
```
[root@cs3 integration]# nosetests --with-marvin
--marvin-c
GitHub user wido opened a pull request:
https://github.com/apache/cloudstack/pull/986
Add Unit Tests for Libvirt/KVM storage code
These classes were not covered by Unit Tests and this commit
adds some tests for their basic functionality.
You can merge this pull request into a Gi
1 - 100 of 188 matches
Mail list logo
