Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1453#issuecomment-207954572
I am having other problems (after the merge) in my test environment, not
related to the PR.
---
If your project is set up for it, you can reply to this email
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-207956609
@GabrielBrascher you could try to close the PR and reopen it. It matters if
the queue at builds.apache.org has a full queue or not.
---
If your project is set
Github user GabrielBrascher closed the pull request at:
https://github.com/apache/cloudstack/pull/1263
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
GitHub user GabrielBrascher reopened a pull request:
https://github.com/apache/cloudstack/pull/1263
Removed unused code from com.cloud.api.ApiServer
**Removed â\_â from variables names**: private variables with â\_â
at the beginning is common in C++ but not in Java.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1262#issuecomment-207987383
@rafaelweingartner how about creating a test-child instead of testing in
all child-tests ;)
---
If your project is set up for it, you can reply to this email
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1483#issuecomment-207988893
@alexandrelimassantana please make a pull request to the branch that the PR
is created from, Remi can include you change in this one by pulling it to his
branc
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-207989355
@DaanHoogland thanks for the tip.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1466#issuecomment-207994438
@bhaisaab Most of the indexes being dropped are duplicate. In
create-schema.sql quite a lot of tables are created like this:
CREATE TABLE `cloud`.`version` (
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1485
Set default networkDomain to empty instead of username
The 10th field of `createUserAccount` is `networkDomain` (See
`AccountService.java`) and it is set to a var named `admin`, which is th
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1486
Reimplement router.redundant.vrrp.interval setting
Global setting `router.redundant.vrrp.interval` is not used any more and it
is now set to a hardcoded 1.
This results in a failo
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1331#issuecomment-208034027
@syed, you could delete the line 631, or use it as a java doc that explains
the method.
I believe that there is, at least, one test you can do her
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1262#issuecomment-208059482
@DaanHoogland, I did not understand what you meant with test-child.
We could do the test a little bit different if we had a newer version of
Mocki
Hi all
Thanks for reviewing the FS. Based on the received comments I clarified
further in the FS that the Vpc Inline LB appliance solution is based on the
Internal LB appliance solution, only now extended with secondary IP's and
static NAT to Public IP.
I also corrected the "management" nic to "
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1262#issuecomment-208063842
Well @rafaelweingartner you can make a test class for each of the child
classes of the abstract class, as done now or you can make a
CitrixResourceTest-class c
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1262#issuecomment-208064117
Sure it does.
And yes we can create a spy from an abstract class. The problem is that
with the current version of Mockito the spy method only work
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1262#issuecomment-208064261
Well, I am not interested in elegant at this stage, just in reducing the
code base if it make sense. The simplest solution is an named test resource
class as c
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1262#issuecomment-208064343
Got your point.
@cristofolini is a little without time now, so I will do that.
---
If your project is set up for it, you can reply to this email and h
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1262#issuecomment-208071389
@DaanHoogland Done.
What do you think now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1262#issuecomment-208074579
@rafaelweingartner a lot less code (not in the diff but in the result) :+1:
---
If your project is set up for it, you can reply to this email and have your
rep
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1262#issuecomment-208076663
I agree with you.
We did not use this solution at first because of this:
```
protected CitrixResourceBase citrixResourceBase = new CitrixResourc
Github user pedro-martins commented on the pull request:
https://github.com/apache/cloudstack/pull/1484#issuecomment-208086436
Hi @GabrielBrascher .
I think this params are removed in this PR
https://github.com/apache/cloudstack/pull/1447
=)
Ty.
---
If your project is set
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1484#issuecomment-208086640
Where did you two analyzed that? How did you two find this problem?
How about opening a Jira ticket detailing the problem, so we can have a log
of it.
Github user pedro-martins commented on the pull request:
https://github.com/apache/cloudstack/pull/1484#issuecomment-208087293
@rafaelweingartner
I will open a Jira, the way that I found the problem was described in an
answer to Daan Hoogland in the same PR.
Ty
---
If your p
Github user pedro-martins commented on the pull request:
https://github.com/apache/cloudstack/pull/1484#issuecomment-208088632
@rafaelweingartner
Done. the Jira is CLOUDSTACK-9343 if you can take a look.
Ty
---
If your project is set up for it, you can reply to this email and
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1466#discussion_r59146682
--- Diff: setup/db/db/schema-481to490.sql ---
@@ -413,3 +413,89 @@ VIEW `user_vm_view` AS
-- Add cluster.storage.operations.exclude p
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1466#discussion_r59146860
--- Diff: setup/db/db/schema-481to490.sql ---
@@ -413,3 +413,89 @@ VIEW `user_vm_view` AS
-- Add cluster.storage.operations.exclude p
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1466#discussion_r59146919
--- Diff: setup/db/db/schema-481to490.sql ---
@@ -413,3 +413,89 @@ VIEW `user_vm_view` AS
-- Add cluster.storage.operations.exclude p
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1466#discussion_r59147080
--- Diff: setup/db/db/schema-481to490.sql ---
@@ -413,3 +413,89 @@ VIEW `user_vm_view` AS
-- Add cluster.storage.operations.exclude p
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/1403#issuecomment-208120039
@jburwell Unfortunately Google's ImmutableMap doesn't support null for a
value (which we use). I noticed this while running regression tests and googled
to s
Github user serg38 commented on the pull request:
https://github.com/apache/cloudstack/pull/1466#issuecomment-208121230
@rafaelweingartner
Here you change this table "ovs_tunnel_network", you dropped the primary
key "id"; Will that remove only the index or the field
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r59150605
--- Diff: api/src/com/cloud/network/vpc/OSPFZoneConfig.java ---
@@ -0,0 +1,332 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r59150683
--- Diff: api/src/com/cloud/network/vpc/OSPFZoneConfig.java ---
@@ -0,0 +1,332 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r59150749
--- Diff: api/src/com/cloud/network/vpc/OSPFZoneConfig.java ---
@@ -0,0 +1,332 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r59150902
--- Diff: api/src/com/cloud/network/vpc/OSPFZoneConfig.java ---
@@ -0,0 +1,332 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r59151152
--- Diff: api/src/com/cloud/network/vpc/OSPFZoneConfig.java ---
@@ -0,0 +1,332 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r59151239
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/vpc/VPCOSPFConfigCmd.java ---
@@ -0,0 +1,73 @@
+// Licensed to the Apache Software Foundat
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r59151301
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/vpc/VPCOSPFConfigCmd.java ---
@@ -0,0 +1,73 @@
+// Licensed to the Apache Software Foundat
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1454#discussion_r59152198
--- Diff: tools/marvin/marvin/lib/utils.py ---
@@ -520,4 +520,22 @@ def verifyRouterState(apiclient, routerid,
allowedstates):
if rout
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1454#discussion_r59152218
--- Diff: tools/marvin/marvin/lib/utils.py ---
@@ -520,4 +520,22 @@ def verifyRouterState(apiclient, routerid,
allowedstates):
if rout
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1410#issuecomment-208159074
@alexandrelimassantana volumeTO has setting of volume I/O throttling. it is
different with volTO.
please have a look at storageMgr.setVolumeObjectTOThrottlin
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1454#discussion_r59155288
--- Diff: test/integration/component/test_host_maintenance.py ---
@@ -0,0 +1,325 @@
+# Licensed to the Apache Software Foundation (ASF) unde
Welcome Rashmi!
On 4/7/16 9:58 PM, Rashmi Dixit wrote:
> Hello!
>
> I am Rashmi Dixit and have recently joined the CloudPlatform team in
> Accelerite. I have worked on a hybrid cloud management solution supporting
> hypervisors such as KVM, Xen, VMware, HyperV and public clouds such as EC2.
>
Kris and Nick
Noticed an update in the FS:
>> The VPC Inline LB appliance therefore is a regular System VM, exactly
the same as the Internal LB appliance today. Meaning it has 1 guest nic
and 1 control (link-local / management) nic.
This should be ok. The premise behind my concern was - if LB
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1331#issuecomment-208176655
@rafaelweingartner Updated the comment as a javadoc.
For the test. I am not sure what the best strategy is. Maybe you can help
me understand better. Would woul
The failure suggests some unit test might have failed causing the build to
fail, causing Marvin distribution to be not built.
I have sent a PR that adds verbosity to the Travis build.
Regards.
Regards,
Rohit Yadav
rohit.ya...@shapeblue.com
www.shapeblue.com
53 Chandos Place, Covent Garden, Lo
45 matches
Mail list logo
