RE: Metrics UI - Incorrect metrics data for zone/cluster

2016-05-11 Thread Rashmi Dixit
Thanks Rohit. Once you play with the page size - set it to say 40, then the issues show up. This also affects the number of cluster calculations as well. -Original Message- From: Rohit Yadav [mailto:rohit.ya...@shapeblue.com] Sent: Thursday, May 12, 2016 11:44 AM To: dev@cloudstack.apa

[GitHub] cloudstack pull request: Disable NioTest

2016-05-11 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/1538#issuecomment-218670692 I should be able to try your branch out later today. Thanks! On May 12, 2016, at 12:18 AM, Rohit Yadav mailto:notificati...@github.com>> wrote:

[GitHub] cloudstack pull request: NioTest: relax test counts to pass under ...

2016-05-11 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1538#issuecomment-218669737 @swill @nvazquez @mike-tutkowski appreciate if we can discuss the issue here instead of ML, we'll lose discussion otherwise and I'm unable to keep up discussions at t

RE: Metrics UI - Incorrect metrics data for zone/cluster

2016-05-11 Thread Rohit Yadav
Rashmi, Originally, the feature was implemented using all the available list APIs in future we may have a backend metrics API instead of aggregation in the UI/client side (done right now). This feature assumes that no single cluster would have 500 hosts (also not supported by many hypervisors t

RE: Test failure on master?

2016-05-11 Thread Rohit Yadav
For some reason the NioTest had been disabled historically (git history tells me it was disabled in 881a6e as it is dependent on network config running the test) , my PR has re-enabled it. Since this unit test `NioTest` creates actual server/client instances -- in many environments this may fail

RE: Test failure on master?

2016-05-11 Thread Rohit Yadav
The issue is not specific to the change but the how test are run. On OSX, when a process tries to listen on a port the firewall (enabled by default on most cases) would block the process from running. The other issue is the test relies on wall clock which can depend if the test/CI env was virtual

RE: Question: commands.properties.in deprecated

2016-05-11 Thread Rohit Yadav
Hi Mike and Will, I'll update the admin-docs PR on this, if you take a look at the dynamic roles FS it has pointers on how to deal with new API, what are role types (RoleType has existed since at least 4.3) etc. In short use the authorized field in the APICommand annotation to set default auth

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

2016-05-11 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-218667408 @swill Yes, it does. It install the Qemu Quest Agent inside the SSVM. It doesn't hurt to do that already, it is just that the libvirt-java bindings don't allow

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-05-11 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-218666241 @jburwell fixed the ProcessRunner issues, please do a final review and LGTM or suggest changes. Thanks. @nvazquez @swill I've fixed two CI issues (Travis and

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

2016-05-11 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62967326 --- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java --- @@ -0,0 +1,172 @@ +// +// Licensed to the Apache Software Foundati

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-05-11 Thread rhtyd
Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1502 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-05-11 Thread rhtyd
GitHub user rhtyd reopened a pull request: https://github.com/apache/cloudstack/pull/1502 CLOUDSTACK-9299: Out-of-band Management for CloudStack Support access to a host’s out-of-band management interface (e.g. IPMI, iLO, DRAC, etc.) to manage host power operations (on/off etc

[GitHub] cloudstack pull request: CLOUDSTACK-9378: Fix for #1497

2016-05-11 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1539#discussion_r62967100 --- Diff: test/integration/smoke/test_list_ids_parameter.py --- @@ -194,10 +194,7 @@ def setUpClass(cls): cls._cleanup = [

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

2016-05-11 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62965518 --- Diff: utils/src/main/java/com/cloud/utils/net/NetUtils.java --- @@ -1159,6 +1181,25 @@ public static boolean validateGuestCidr(final String

Metrics UI - Incorrect metrics data for zone/cluster

2016-05-11 Thread Rashmi Dixit
Hi, I came across an issue in the metrics for zone and cluster. I have logged a bug for the same. https://issues.apache.org/jira/browse/CLOUDSTACK-9377 To quickly summarize the issue: APIs have a pagesize restriction - the default.page.size global setting is used as the max result count - value

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

2016-05-11 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62963739 --- Diff: test/integration/component/test_ospf.py --- @@ -0,0 +1,477 @@ +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

2016-05-11 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62963628 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsQuagga.py --- @@ -0,0 +1,85 @@ +# Licensed to the Apache Software Foundation (AS

[GitHub] cloudstack pull request: CLOUDSTACK-9378: Fix for #1497

2016-05-11 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1539#issuecomment-218657103 I think one way to cleanup would be to do it case by case basis for each test case manually instead of relying on the class level cleanup. Also, it's best to avoid us

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

2016-05-11 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-218656836 @kiwiflyer along with this patch, have you also applied the optimization patch #1534 (make sure to apply the patch on both mgmt server and KVM agent) ? We can debug y

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

2016-05-11 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1511#issuecomment-218656345 @DaanHoogland done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

2016-05-11 Thread rhtyd
Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1511 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

2016-05-11 Thread rhtyd
GitHub user rhtyd reopened a pull request: https://github.com/apache/cloudstack/pull/1511 4.9/master bountycastle changes This PR adds bountycastle related version and code fixes from @DaanHoogland on top of https://github.com/apache/cloudstack/pull/1510 I could not fix jav

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

2016-05-11 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62962859 --- Diff: server/src/org/apache/cloudstack/network/topology/BasicNetworkVisitor.java --- @@ -316,4 +317,9 @@ public boolean visit(final StaticR

[GitHub] cloudstack pull request: CLOUDSTACK-9378: Fix for #1497

2016-05-11 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1539#issuecomment-218654451 Sorry for the delay getting to this. I think this probably works in all cases, but I suspect it will not clean up correctly always. Because this was working sometim

[GitHub] cloudstack pull request: CLOUDSTACK-9378: Fix for #1497

2016-05-11 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1539#issuecomment-218652190 LGTM, cc @swill let's merge this first to avoid other PRs failing --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

2016-05-11 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-218651517 Does this require a change to the system VM template? I am pulling this in for testing now... --- If your project is set up for it, you can reply to this email and h

[GitHub] cloudstack pull request: CLOUDSTACK-9287 - Fix unique mac address ...

2016-05-11 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1483#issuecomment-218649701 I need some code review on this one. Thanks... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

2016-05-11 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1514#issuecomment-218649383 @dsclose can you force push or close and reopen the PR to kick off travis and jenkins again? Thanks... --- If your project is set up for it, you can reply to this e

[GitHub] cloudstack pull request: Apply static routes on change to master s...

2016-05-11 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1472#issuecomment-218649198 Thanks gents. I will get this merged... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] cloudstack pull request: Handle private gateways more reliably

2016-05-11 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1474#issuecomment-218649126 Thank you sir. I will get this merged... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] cloudstack pull request: Make the generated json files unique to p...

2016-05-11 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1470#issuecomment-218648913 Thanks for the hard work @remibergsma. 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: Remove extraneous log directory and add c...

2016-05-11 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1537#issuecomment-218648825 This one is ready other than Jenkins. @PaulAngus, can you please either force push the PR or close and reopen it so it kicks off Jenkins so we can get this PR all gr

[GitHub] cloudstack pull request: Remove extraneous log directory and add c...

2016-05-11 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1537#issuecomment-218648555 ### CI RESULTS ``` Tests Run: 85 Skipped: 0 Failed: 1 Errors: 0 Duration: 6h 07m 12s ``` **Summary of the p

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

2016-05-11 Thread kiwiflyer
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1514#issuecomment-218611825 LGTM. Tested in hardware lab and works as designed. tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: Apply static routes on change to master s...

2016-05-11 Thread kiwiflyer
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1472#issuecomment-218607629 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: Handle private gateways more reliably

2016-05-11 Thread kiwiflyer
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1474#issuecomment-218607576 LGTM. Tested in a hardware lab. tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: Apply static routes on change to master s...

2016-05-11 Thread dmabry
Github user dmabry commented on the pull request: https://github.com/apache/cloudstack/pull/1472#issuecomment-218600092 LGTM. We tested this in our Lab on HW and all static routes on each PG came up as expected. --- If your project is set up for it, you can reply to this email and h

[GitHub] cloudstack pull request: CLOUDSTACK-9373: Class methods over-shawd...

2016-05-11 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1528#issuecomment-218597484 I think this one is good to go... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: Apply static routes on change to master s...

2016-05-11 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1472#issuecomment-218597071 @rafaelweingartner yes, it will be forward merged. Sorry I only just got around to answering your question. I need one more code review on this one. Thanks... --

[GitHub] cloudstack pull request: Make the generated json files unique to p...

2016-05-11 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1470#issuecomment-218595232 Worked with @swill and @kiwiflyer and found the issue: one bit was missing in the backport from Cosmic. Will look into that tomorrow. --- If your project is se

[GitHub] cloudstack pull request: [CLOUDSTACK-9207] Test to verify restarti...

2016-05-11 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1304#issuecomment-218596132 The additional run of these tests in a new environment gives the same results. I think this needs some work still... --- If your project is set up for it, you can r

[GitHub] cloudstack pull request: Apply static routes on change to master s...

2016-05-11 Thread kiwiflyer
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1472#issuecomment-218592243 LGTM. Tested in a hardware lab. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-05-11 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-218591057 @syed can you have a look at this one. I am not sure why, but I am having a lot of trouble with this PR. I have not been able to get a test run to actually w

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

2016-05-11 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1444#issuecomment-218579831 I think this one is pretty much ready. I have one code review on this one. Can I get one more person to look over this for me? Thanks... --- If your project is se

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

2016-05-11 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1444#issuecomment-218579019 ### CI RESULTS ``` Tests Run: 85 Skipped: 0 Failed: 1 Errors: 0 Duration: 9h 12m 09s ``` **Summary of the p

[GitHub] cloudstack pull request: Make the generated json files unique to p...

2016-05-11 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1470#issuecomment-218578631 ### CI RESULTS ``` Tests Run: 85 Skipped: 0 Failed: 24 Errors: 10 Duration: 10h 46m 24s ``` **Summary of th

[GitHub] cloudstack pull request: Apply static routes on change to master s...

2016-05-11 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1472#issuecomment-218577635 ### CI RESULTS ``` Tests Run: 85 Skipped: 0 Failed: 1 Errors: 0 Duration: 9h 06m 23s ``` **Summary of the p

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

2016-05-11 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/816#issuecomment-218553761 @swill OK, looks like are OK here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] cloudstack pull request: CLOUDSTACK-9265 cleanup around httpclient...

2016-05-11 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1385#issuecomment-218544251 It was stuck due to another jenkins job running. I am still not sure I saw what I saw. when I stopped 1252, shortly after 1253 through 1256 finished. --- If y

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-05-11 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-218543261 @swill PR1539 passed Jenkins and Travis. After you merge it should resolve the issue in other PRs --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

2016-05-11 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1511#issuecomment-218542671 Good point, I am numb to travis timeouts. RM work remnance :( --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

2016-05-11 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1403#issuecomment-218540891 Did a review, I have some remarks, some questions as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

2016-05-11 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62892495 --- Diff: server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java --- @@ -144,6 +145,8 @@ @Inject SnapshotDataStoreDao _snap

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

2016-05-11 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62892410 --- Diff: core/src/com/cloud/agent/api/StartupRoutingCommand.java --- @@ -35,7 +35,7 @@ long memory; long dom0MinMemory; boole

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

2016-05-11 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62892193 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -172,78 +232,211 @@ private vo

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

2016-05-11 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62891804 --- Diff: server/src/com/cloud/storage/StorageManagerImpl.java --- @@ -209,6 +211,8 @@ @Inject protected HostDao _hostDao;

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

2016-05-11 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62890825 --- Diff: plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/driver/SolidFirePrimaryDataStoreDriver.java --- @@ -692,12 +

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

2016-05-11 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62890766 --- Diff: plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/driver/SolidFirePrimaryDataStoreDriver.java --- @@ -665,22 +

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

2016-05-11 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62886608 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java --- @@ -2351,17 +2376,52 @@ public SR g

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

2016-05-11 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62886063 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java --- @@ -1792,10 +1796,26 @@ protected v

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

2016-05-11 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62885313 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java --- @@ -164,9 +165,12 @@ *

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

2016-05-11 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-218522071 No worries. 👍 I am really short on sleep, but I was pretty confident. :P --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

2016-05-11 Thread nvazquez
Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-218520703 Sorry, I confused PRs. Please ignore my last comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-05-11 Thread nvazquez
Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-218520519 @rhtyd @kiwiflyer @swill a PR for fixing the problem #1539 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

2016-05-11 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-218519246 @nvazquez I don't think #1539 is related to this PR. I think this one has completely separate issues... --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

2016-05-11 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62881271 --- Diff: engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java --- @@ -554,6 +574,51 @@ protected Void managedCop

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

2016-05-11 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62881152 --- Diff: engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java --- @@ -554,6 +574,51 @@ protected Void managedCop

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

2016-05-11 Thread nvazquez
Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-218514854 @rhtyd @kiwiflyer @swill a PR for fixing the problem #1539 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

2016-05-11 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62880956 --- Diff: engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java --- @@ -134,6 +146,14 @@ EndPointSelector

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

2016-05-11 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62880949 --- Diff: engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java --- @@ -134,6 +146,14 @@ EndPointSelector

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

2016-05-11 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62880464 --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java --- @@ -289,7 +291,7 @@ public boolean

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

2016-05-11 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62880347 --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java --- @@ -347,38 +395,87 @@ private S

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

2016-05-11 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62879575 --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java --- @@ -347,38 +395,87 @@ private S

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

2016-05-11 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62878912 --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java --- @@ -72,8 +77,10 @@ pri

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

2016-05-11 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62876283 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -361,59 +603,221 @@ privat

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

2016-05-11 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62876182 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -361,59 +603,221 @@ privat

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

2016-05-11 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62876040 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -361,59 +608,225 @@ privat

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

2016-05-11 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62875666 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -255,99 +473,123 @@ privat

[GitHub] cloudstack pull request: CLOUDSTACK-9265 cleanup around httpclient...

2016-05-11 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1385#issuecomment-218505040 @DaanHoogland it finished!!! :P --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: Remove extraneous log directory and add c...

2016-05-11 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1537#issuecomment-218503981 I am testing now... 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

2016-05-11 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62875028 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -172,78 +254,214 @@ privat

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

2016-05-11 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1511#issuecomment-218503116 @DaanHoogland well a timeout in combination with a connection is not being able to be established seems relevant since it is related to the code that has changed.

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

2016-05-11 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62874090 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -172,78 +232,211 @@ privat

Re: Question: commands.properties.in deprecated

2016-05-11 Thread Will Stevens
I think this is the extent of the documentation at this point. https://github.com/apache/cloudstack-docs-admin/pull/37/files Rohit, maybe you can shed some light on this from a developer's perspective and how we should be handling this going forward? Are there official docs which covered how to

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

2016-05-11 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-218500189 Thank you, I will merge it assuming Jenkins and Travis come back clean. Thx... 👍 --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

2016-05-11 Thread nvazquez
Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-218499768 Done @swill @serg38 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: CLOUDSTACK-9378: Fix for #1497

2016-05-11 Thread nvazquez
GitHub user nvazquez opened a pull request: https://github.com/apache/cloudstack/pull/1539 CLOUDSTACK-9378: Fix for #1497 JIRA TICKET: https://issues.apache.org/jira/browse/CLOUDSTACK-9378 After #1497 was merged, test_list_ids_parameter.py failed on Travis. It was noticed t

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

2016-05-11 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62872442 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -172,78 +232,211 @@ privat

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

2016-05-11 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62868269 --- Diff: engine/schema/src/com/cloud/dc/dao/ClusterDaoImpl.java --- @@ -260,4 +268,41 @@ public boolean remove(Long id) { sc.setParamet

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

2016-05-11 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62867309 --- Diff: engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/PrimaryDataStoreInfo.java --- @@ -36,6 +36,7 @@ static final S

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

2016-05-11 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/816#issuecomment-218489553 I think we are definitely having issues with it not cleaning correctly. I have seen a couple cases where we get the "unable to update index" when it tries to do a git

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

2016-05-11 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-218489998 Can you create a new PR to fix this and we will get it tested right away. Thanks for being on top of this. 👍 --- If your project is set up for it, you can repl

[GitHub] cloudstack pull request: [CLOUDSTACK-9207] Test to verify restarti...

2016-05-11 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1304#issuecomment-218483982 The added test fails, but lots of tests failed. I will rebuild my environment and test again to see if anything changes. --- If your project is set up for it, you c

[GitHub] cloudstack pull request: [CLOUDSTACK-9207] Test to verify restarti...

2016-05-11 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1304#issuecomment-218483641 ### CI RESULTS ``` Tests Run: 7 Skipped: 0 Failed: 4 Errors: 0 Duration: 0h 37m 50s ``` **Summary of the pr

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

2016-05-11 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-218480013 The issue that it couldn't find a snaphsot because it is already cleaned by account cleanup. +cls._cleanup = [ +cls.disk_off

Question: commands.properties.in deprecated

2016-05-11 Thread Tutkowski, Mike
Hi, I see in afcbd27 that we've deprecated commands.properties.in. Is there documentation on the new way that we specify permissions for a given API these days? Thanks! Mike

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

2016-05-11 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/816#issuecomment-218480720 That is the rat test. it is usually right. I didn't see a new file without license though. May one of the to with a license starting with an empty comment line

[GitHub] cloudstack pull request: DAO: Hit the cache for entity flagged as ...

2016-05-11 Thread marcaurele
GitHub user marcaurele reopened a pull request: https://github.com/apache/cloudstack/pull/1532 DAO: Hit the cache for entity flagged as removed too I came along this part of the code and I don't see any reason why the cache should not be used when fetching with the "removed" ones. I

Re: Test failure on master?

2016-05-11 Thread Will Stevens
I can't point to this PR for this, but I have noticed an increase in random failures in my CI runs since this code has gone in. I have not tracked it down to this, but resources are tight in those environments, so if we are getting CPU maxing out, that could potentially account for the higher fail

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

2016-05-11 Thread kiwiflyer
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-218473922 ![image](https://cloud.githubusercontent.com/assets/17278194/15184123/94553146-1759-11e6-8dec-c4e0bb0c1795.png) --- If your project is set up for it, you can re

  1   2   >