Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1545#issuecomment-221166274
I missed that this one was going to need a new systemvmtemplate. Given
that I am already over a week late on this release and I have not done any
testing or work
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1531#issuecomment-221165014
Ping @wido @swill @DaanHoogland @abhinandanprateek can we get some
review/lgtm thanks. This fixes build environment issues, updates readme and
updates to use the
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1545#issuecomment-221165022
LGTM, to use this feature. KVM users will need to use new
systemvmtemplates, can we get #1531 merged as well? /cc @swill
---
If your project is set up for it, you
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1533#issuecomment-221162872
Yes, ready now. Thank you. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-221162753
This one is green. I think this one is ready??? Please verify if there is
anything outstanding on this one. Thanks... :)
---
If your project is set up for it,
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1549#issuecomment-221162055
@rhtyd fingers crossed, things seem to be in pretty good shape. The first
two runs after the merge had `addHost` errors, but I have done about 6-7 CI
runs since and
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1550#issuecomment-221160650
This is a clean CI run. The failures are not related to this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1550#issuecomment-221160504
### CI RESULTS
```
Tests Run: 78
Skipped: 0
Failed: 0
Errors: 4
Duration: 7h 14m 41s
```
**Summary of the
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-221160368
This is coming back clean now. Those failures are not related to this PR.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-221160321
The AddNuageVspDeviceCmd can be upgraded to follow new RBAC pattern for
access permissions, api and response naming. (Look at CreateRoleCmd.java).
After
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-221160227
### CI RESULTS
```
Tests Run: 82
Skipped: 0
Failed: 0
Errors: 3
Duration: 8h 35m 03s
```
**Summary of the
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1555#issuecomment-221159974
I think this one is ready...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1555#issuecomment-221159912
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 0
Errors: 0
Duration: 8h 55m 13s
```
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1556#issuecomment-221159792
I ran CI again hoping to clear up those errors and I got the same ones
again. I don't think they are related to this PR, but twice in a row concerns
me a bit. I
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-221159200
@DaanHoogland can you rebase and push again to try to kick off Travis and
see if we can clear this one up? Thanks...
---
If your project is set up for it, you can
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-221159015
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 0
Errors: 1
Duration: 4h 20m 05s
```
**Summary of the
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1545#issuecomment-221158910
This is coming back clean. Can I get a second LGTM? Maybe @rhtyd?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1545#issuecomment-221158751
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 0
Errors: 0
Duration: 4h 25m 18s
```
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1494#discussion_r64323811
--- Diff: engine/schema/src/com/cloud/vm/dao/DomainRouterDaoImpl.java ---
@@ -432,4 +432,12 @@ public void removeRouterFromGuestNetwork(final
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1552#issuecomment-221155776
Ok, so I have two LGTM both with validation that the code behaves as
expected. I think that is enough for this to get in. Thanks...
---
If your project is set up
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1482#issuecomment-221151970
@remibergsma ok, no problem. Thanks for the heads up. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-221098134
@NuxRo can you test if it is still working for you?
@ustcweizhou can you see if your fixes are still met?
@swill can you reschedule integration tests?
Github user KrisSterckx commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-221087524
@rhtyd, @koushik-das, @remibergsma, @abhinandanprateek, @rafaelweingartner
anyone wants to further review ? We would like votes :)
Thanks!
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1557#issuecomment-221028275
@rodrigo93,
I was reviewing your PR, nice work; but, I think you can remove some other
lines too.
I checked and the variable
Github user sverrirab commented on the pull request:
https://github.com/apache/cloudstack/pull/1533#issuecomment-221026255
everything looking good now it seems - time to merge @swill ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user KrisSterckx commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-221023752
Travis CI failure : Is it a known issue ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user KrisSterckx commented on the pull request:
https://github.com/apache/cloudstack/pull/1553#issuecomment-221024596
@DaanHoogland moreover it is proven in Nuage lab to resolve the issues we
had
---
If your project is set up for it, you can reply to this email and have your
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1494#discussion_r64229436
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/util/NuageVspEntityBuilder.java
---
@@ -0,0 +1,370 @@
+//
+// Licensed to the Apache
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1494#discussion_r64229325
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java
---
@@ -270,15 +258,15 @@ public PingCommand
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-220988239
@NuxRo it means debugging the problem has started. what is in here now is
not much (you can review it)
---
If your project is set up for it, you can reply to
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1553#issuecomment-220987228
ping @swill tag:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1553#issuecomment-220986821
Changed db.x.path to db.x.driver as @DaanHoogland suggested
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user NuxRo commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-220984529
Thanks Daan,
Does that mean we're good to go?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1553#issuecomment-220983955
LGTM though it remains kluncy to some extend I think this is a considerable
improvement over what we had
---
If your project is set up for it, you can reply
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1553#discussion_r64223844
--- Diff: client/tomcatconf/db.properties.in ---
@@ -25,6 +25,7 @@ region.id=1
db.cloud.username=@DBUSER@
db.cloud.password=@DBPW@
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1553#discussion_r64223798
--- Diff: engine/storage/snapshot/test/resources/db.properties ---
@@ -46,6 +47,8 @@
db.cloud.url.params=prepStmtCacheSize=517=true
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1553#discussion_r64223758
--- Diff: build/replace.properties ---
@@ -21,6 +21,7 @@ DBROOTPW=
MSLOG=vmops.log
APISERVERLOG=api.log
DBHOST=localhost
GitHub user dsclose reopened a pull request:
https://github.com/apache/cloudstack/pull/1514
CLOUDSTACK-6975: Prevent dnsmasq from starting on backup redundant RvR
Rebase of PR #1509 against the 4.7 branch as requested by @swill
One LGTM from @ustcweizhou carried from
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1553#discussion_r64223544
--- Diff: engine/storage/snapshot/test/resources/db.properties ---
@@ -46,6 +47,8 @@
db.cloud.url.params=prepStmtCacheSize=517=true
Github user dsclose closed the pull request at:
https://github.com/apache/cloudstack/pull/1514
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-220982534
@luhaijiao I reverted to a vanilla Cloudstack 4.8.0 ISO. The
cloud-passwd-srvr service failed to start. The following appears in
/var/log/messages on the router:
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-220973201
got the test to run locally with
```
ssh cs0 /data/shared/helper_scripts/cloudstack/build_run_deploy_test.sh -m
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1553#issuecomment-220976080
@nlivens supakoel
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1553#issuecomment-220974849
@DaanHoogland, I've added the piece we were talking about, this can be
found it the logs regarding loading the driver dynamically :
> 2016-05-23 05:42:57,880
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1552#issuecomment-220974370
@swill I don't think so, CI doesn't test this feature. It is a script for
INSIDE Guest Instances.
---
If your project is set up for it, you can reply to this email
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/1406#issuecomment-220971211
Have opened #1559 against master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/1559#issuecomment-220971156
New version of #1406, opened against master instead of the 4.6 branch.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user ProjectMoon closed the pull request at:
https://github.com/apache/cloudstack/pull/1406
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user ProjectMoon opened a pull request:
https://github.com/apache/cloudstack/pull/1559
CLOUDSTACK-9280: System VM volumes can be expunged if no SSVM exists.
This commit adds a special SSVM endpoint which simply returns true for
all operations sent to it, without actually
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-220964156
@luhaijiao I've seen the same error in our XenServer setup but wasn't sure
what the cause is. I'd be surprised if this was the cause but it's worth
exploring.
GitHub user DaanHoogland reopened a pull request:
https://github.com/apache/cloudstack/pull/1297
CLOUDSTACK-9203 Implement security group move on updateVM API call
cherry-picked from a exoscale internal fix
Conflicts:
Github user DaanHoogland closed the pull request at:
https://github.com/apache/cloudstack/pull/1297
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user luhaijiao commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-220950805
@dsclose we install this patch in our environment(ACS 4.7.1, KVM) to solve
the password issue with RVR.
We found the new password for VM is still
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-220946105
@swill, the test_scale_vm didn't error out because it wasn't run on this
version! I have lost a tiny bit of confidence in our travis runs again. I will
now
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-220943511
@swill, i had a nice weekend, thanks. The test that is failing throws a
different kind of exception if I run it on master in my bubble. I have just
pushed a
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/846#issuecomment-220939007
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/846#discussion_r64197154
--- Diff: engine/schema/src/com/cloud/host/dao/HostDaoImpl.java ---
@@ -1087,4 +1087,11 @@ public HostVO findByPublicIp(String publicIp) {
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1553#discussion_r64195563
--- Diff: framework/db/src/com/cloud/utils/db/TransactionLegacy.java ---
@@ -1014,6 +1014,13 @@ public static void initDataSource(Properties
dbProps) {
Github user kishankavala commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/846#discussion_r64195431
--- Diff: engine/schema/src/com/cloud/host/dao/HostDaoImpl.java ---
@@ -1087,4 +1087,11 @@ public HostVO findByPublicIp(String publicIp) {
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/846#issuecomment-220935383
@swill rebased with latest master
@GabrielBrascher fixed the typo
---
If your project is set up for it, you can reply to this email and have your
reply
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1553#discussion_r64193717
--- Diff: framework/db/src/com/cloud/utils/db/TransactionLegacy.java ---
@@ -1014,6 +1014,13 @@ public static void initDataSource(Properties
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1553#discussion_r64191953
--- Diff: framework/db/src/com/cloud/utils/db/TransactionLegacy.java ---
@@ -1014,6 +1014,13 @@ public static void initDataSource(Properties
dbProps) {
Github user dsclose closed the pull request at:
https://github.com/apache/cloudstack/pull/1514
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user dsclose reopened a pull request:
https://github.com/apache/cloudstack/pull/1514
CLOUDSTACK-6975: Prevent dnsmasq from starting on backup redundant RvR
Rebase of PR #1509 against the 4.7 branch as requested by @swill
One LGTM from @ustcweizhou carried from
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-220918847
@dsclose you can close/reopen this PR instead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-220918123
@swill
Pardon me - I was on leave for a week. I'll get this force pushed
momentarily.
---
If your project is set up for it, you can reply to this email and
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1553#discussion_r64179203
--- Diff: framework/db/src/com/cloud/utils/db/TransactionLegacy.java ---
@@ -1014,6 +1014,13 @@ public static void initDataSource(Properties
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1553#discussion_r64178488
--- Diff: framework/db/src/com/cloud/utils/db/TransactionLegacy.java ---
@@ -1014,6 +1014,13 @@ public static void initDataSource(Properties
dbProps) {
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1549#issuecomment-220893971
@swill I ran tests on latest master using packages:
http://packages.shapeblue.com/cloudstack/custom/master-latest/
I was able to deploy a zone with two KVM
69 matches
Mail list logo
