[GitHub] cloudstack issue #1681: CLOUDSTACK-9491: incorrect parsing of device list to...

2016-09-22 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue: https://github.com/apache/cloudstack/pull/1681 @murali-reddy Makes sense to get fresh listing of virtual NICs in next iteration as the first iteration might have missed the hot-plugged virtual NIC (for VPC tier being configured)

[GitHub] cloudstack issue #1681: CLOUDSTACK-9491: incorrect parsing of device list to...

2016-09-22 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1681 The fix looks like the correct thing to do. @muali-reddy LGTM for code review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] cloudstack issue #1681: CLOUDSTACK-9491: incorrect parsing of device list to...

2016-09-22 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1681 @murali-reddy Thanks for the explanation. LGTM for code review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack issue #1674: CLOUDSTACK-9460: For long running transactions, if t...

2016-09-22 Thread murali-reddy
Github user murali-reddy commented on the issue: https://github.com/apache/cloudstack/pull/1674 LGTM from the code change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request #1684: CLOUDSTACK-9489: the new config vars that are...

2016-09-22 Thread abhinandanprateek
GitHub user abhinandanprateek opened a pull request: https://github.com/apache/cloudstack/pull/1684 CLOUDSTACK-9489: the new config vars that are added do not goto DB if… … values are set to NULL, removing this check so the entries in DB are made with NULL values You can merge

[GitHub] cloudstack issue #1681: CLOUDSTACK-9491: incorrect parsing of device list to...

2016-09-22 Thread murali-reddy
Github user murali-reddy commented on the issue: https://github.com/apache/cloudstack/pull/1681 @serg38 Though same code path, i ran into different issue. When i was adding new tier to VPC, eth3 was plugged into VR from vCenter. As commented in the function there is delay for ethernet

[GitHub] cloudstack issue #1642: CLOUDSTACK-9504: System VMs on Managed Storage

2016-09-22 Thread mike-tutkowski
Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1642 Thanks for running that, @serg38! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

Re: [DISCUSS] Replacing the VR

2016-09-22 Thread Murali Reddy
Matthew, Please see https://cwiki.apache.org/confluence/display/CLOUDSTACK/Extending+CloudStack+Networking Thanks, Murali On 22/09/16, 11:23 PM, "Matthew Smart" wrote: >Hey Murali, > >I have been reading through the API and other documentation to try to >get a basic understanding of the

[GitHub] cloudstack issue #1659: CLOUDSTACK-9339 Virtual Routers don't handle Multipl...

2016-09-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1659 Trillian test result (#21) Environment: vmware-55u3 (x2), Advanced Networking Total time taken: 27908s Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/tr

[GitHub] cloudstack issue #1642: CLOUDSTACK-9504: System VMs on Managed Storage

2016-09-22 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1642 LGTM testing on Vmware hardware. RHEL 6 management servers, ESX 5.5 and 6 hypervisors, advanced networking ``` test DeployVM in anti-affinity groups for project ... === TestName: test_De

RE: [DISCUSS] Replacing the VR

2016-09-22 Thread Will Stevens
Well the community is in charge of the documentation, so all of us. My colleague Pierre-Luc and I have spent quite a bit of time with the docs, but we have not attacked this. There was an initiative earlier this year to improve the docs, but I am not sure how far they got. On Sep 22, 2016 2:37 PM,

RE: [DISCUSS] Replacing the VR

2016-09-22 Thread Marty Godsey
Seems like we need someone to step up and document the process of this. I would offer however I am not a coder so I would not get far. How is "in charge" of documentation of ACS? Regards, Marty Godsey -Original Message- From: Matthew Smart [mailto:msm...@smartsoftwareinc.com] Sent: Thu

Re: [DISCUSS] Replacing the VR

2016-09-22 Thread Matthew Smart
Thanks Will. That is the answer I expected tbh. But it never hurts to ask! Matthew Smart President Smart Software Solutions Inc. 108 S Pierre St. Pierre, SD 57501 Phone: (605) 280-0383 Skype: msmart13 Email: msm...@smartsoftwareinc.com On 09/22/2016 01:24 PM, Will Stevens wrote: Unfortunately

Re: [DISCUSS] Replacing the VR

2016-09-22 Thread Will Stevens
Unfortunately there is not much documentation around the network plugin functionality. When I wrote the Palo Alto integration I basically figured out how to do it by reviewing existing plugins and just figuring it out. So if you were to begin to implement a new hardware firewall for example, I wo

[GitHub] cloudstack issue #1677: CLOUDSTACK-8830 - [Vmware] VM snapshot fails for 12 ...

2016-09-22 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1677 @jburwell Yes our VM snapshot test covers this (with the exception of the issue that @nvazquez asked in PR871 which is unrelated to this PR ) . We will post results of vmsnaphsot test run on ESX6

[GitHub] cloudstack issue #1677: CLOUDSTACK-8830 - [Vmware] VM snapshot fails for 12 ...

2016-09-22 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1677 @nvazquez @serg38 thank you for the background information -- we are working around a quirk in the VMware SDK not obscuring a CloudStack bug. Do our current snapshot tests cover this condition

Re: [DISCUSS] Replacing the VR

2016-09-22 Thread Matthew Smart
Hey Murali, I have been reading through the API and other documentation to try to get a basic understanding of the network service offering abstraction methodology in CS. I have not dove into the code yet but before I did I thought I would try a different approach. Imagine I were to come to

[GitHub] cloudstack issue #1677: CLOUDSTACK-8830 - [Vmware] VM snapshot fails for 12 ...

2016-09-22 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1677 @jburwell Just to add, this is to address changes in backend task processing introduced in ESX 6. In 5.5 and before processing task had always had a name. In 6 it doesn't and competed task is kep

[GitHub] cloudstack issue #1677: CLOUDSTACK-8830 - [Vmware] VM snapshot fails for 12 ...

2016-09-22 Thread nvazquez
Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1677 @jburwell actually with this small changes vm snapshots can be taken, I already tested manually and succeeds. This problem was related to Vmware API, which sends a task with null name within 12

[GitHub] cloudstack issue #1677: CLOUDSTACK-8830 - [Vmware] VM snapshot fails for 12 ...

2016-09-22 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1677 @nvazquez this fix appears to get rid of the exception, but I'd like to understand why we can't take a snapshot for exactly 12 minutes after a VM starts. Is a VMware thing or is it a more fund

[GitHub] cloudstack issue #1642: CLOUDSTACK-9504: System VMs on Managed Storage

2016-09-22 Thread karuturi
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1642 Great!! Hopefully, we can merge this by Monday then. This is one of the good PRs we have with good description, screenshots, demo, new tests and test runs by author. (Thanks @mike-tutkowski

[GitHub] cloudstack issue #1659: CLOUDSTACK-9339 Virtual Routers don't handle Multipl...

2016-09-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1659 @murali-reddy a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your r

[GitHub] cloudstack issue #1659: CLOUDSTACK-9339 Virtual Routers don't handle Multipl...

2016-09-22 Thread murali-reddy
Github user murali-reddy commented on the issue: https://github.com/apache/cloudstack/pull/1659 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wi

[GitHub] cloudstack issue #1642: CLOUDSTACK-9504: System VMs on Managed Storage

2016-09-22 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1642 @karuturi discussing with @rhtyd being able to specify a list of additional component tests to blueorgantan on the test command. Hopefully, we can get something together by tomorrow (23 Sept 2

[GitHub] cloudstack issue #1642: CLOUDSTACK-9504: System VMs on Managed Storage

2016-09-22 Thread karuturi
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1642 That is great. Let us wait for @blueorangutan to post the results. There still is a pending request for 'system VM integration test suites (SSVM, CPVM, and VR)' --- If your project is

[GitHub] cloudstack issue #1642: CLOUDSTACK-9504: System VMs on Managed Storage

2016-09-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1642 @jburwell a Trillian-Jenkins matrix job (centos6 mgmt + xs56sp1, centos7 mgmt + vmware55u3, ubuntu mgmt + kvmcentos7) has been kicked to run smoke tests --- If your project is set up for

[GitHub] cloudstack issue #1642: CLOUDSTACK-9504: System VMs on Managed Storage

2016-09-22 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1642 @mike-tutkowski @karuturi I have asked blueorganutan to test this PR across VMware, KVM, and XenServer (I accidentally told it to all 3). --- If your project is set up for it, you can reply to

[GitHub] cloudstack issue #1642: CLOUDSTACK-9504: System VMs on Managed Storage

2016-09-22 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1642 @blueorangutan test matrix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1680: CLOUDSTACK-9498: VR CsFile search utility methods fa...

2016-09-22 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1680 LGTM for code --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, o

[GitHub] cloudstack issue #1683: fix ping tests to properly recognise successful ping...

2016-09-22 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1683 @PaulAngus can you open a JIRA ticket for this issue and amend your commit message to reference it? Also, this change would be beneficial to testing the upcoming 4.8.2.0 and 4.9.1.0 releases a

[GitHub] cloudstack issue #1642: CLOUDSTACK-9504: System VMs on Managed Storage

2016-09-22 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1642 @blueorangutan matrix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wish

[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1678#discussion_r80064540 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtModifySshKeysCommandWrapper.java --- @@ -108,7 +108,7 @@ public

[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1678#discussion_r80064208 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java --- @@ -2377,7 +2378,7 @@ public Type getType() {

[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1678#discussion_r80064306 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java --- @@ -3197,7 +3198,7 @@ public boolean defaultN

[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1678#discussion_r80064254 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java --- @@ -3150,7 +3151,7 @@ protected long getMemor

[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1678#discussion_r80064380 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java --- @@ -3300,7 +3301,7 @@ public boolean configu

[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1678#discussion_r80065874 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java --- @@ -1660,18 +1661,18 @@ public StopAnsw

[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1678#discussion_r80064404 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java --- @@ -3317,7 +3318,7 @@ public boolean cleanupR

[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1678#discussion_r80064168 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java --- @@ -1319,7 +1320,7 @@ public Answer executeRe

[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1678#discussion_r80064103 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java --- @@ -1226,7 +1227,7 @@ private boolean checkOv

[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1678#discussion_r80062812 --- Diff: core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java --- @@ -374,9 +375,9 @@ private Answer execute(AggregationControl

[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1678#discussion_r80064229 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java --- @@ -2973,7 +2974,7 @@ public Domain getDomain

[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1678#discussion_r80064464 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtModifySshKeysCommandWrapper.java --- @@ -52,7 +52,7 @@ public An

[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1678#discussion_r80064873 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtPvlanSetupCommandWrapper.java --- @@ -58,11 +59,11 @@ public Ans

[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1678#discussion_r80064597 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtOvsCreateTunnelCommandWrapper.java --- @@ -40,14 +40,11 @@ publi

[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1678#discussion_r80065801 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -1280,7 +1281,7 @@ public ExecutionResult exec

[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1678#discussion_r80064723 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtOvsDestroyTunnelCommandWrapper.java --- @@ -42,7 +42,7 @@ public

[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1678#discussion_r80065456 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -1265,11 +1266,11 @@ private ExecutionResult

[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1678#discussion_r80065183 --- Diff: plugins/hypervisors/ovm3/src/main/java/com/cloud/hypervisor/ovm3/resources/Ovm3VirtualRoutingResource.java --- @@ -38,7 +40,7 @@ pri

[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1678#discussion_r80064319 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java --- @@ -3229,7 +3230,7 @@ protected boolean post_

[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1678#discussion_r80064432 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java --- @@ -3327,7 +3328,7 @@ public boolean cleanupR

[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1678#discussion_r80064905 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtPvlanSetupCommandWrapper.java --- @@ -87,7 +88,7 @@ public Answe

[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1678#discussion_r80064777 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtOvsVpcPhysicalTopologyConfigCommandWrapper.java --- @@ -36,7 +36

[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1678#discussion_r80064807 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtOvsVpcRoutingPolicyConfigCommandWrapper.java --- @@ -36,7 +36,7

[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1678#discussion_r80063605 --- Diff: plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java --- @@ -636,7 +637,7 @@ public Execution

[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1678#discussion_r80064364 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java --- @@ -3273,7 +3274,7 @@ public boolean addNetwo

[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1678#discussion_r80064180 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java --- @@ -1373,7 +1374,7 @@ public synchronized boo

[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1678#discussion_r80063935 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java --- @@ -279,12 +280,12 @@ @Overrid

[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1678#discussion_r80064278 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java --- @@ -3170,7 +3171,7 @@ public boolean destroyN

[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1678#discussion_r80061842 --- Diff: core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java --- @@ -374,9 +375,9 @@ private Answer execute(AggregationControl

[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1678#discussion_r80064346 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java --- @@ -3255,7 +3256,7 @@ public boolean configu

[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1678#discussion_r80062899 --- Diff: core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java --- @@ -374,9 +375,9 @@ private Answer execute(AggregationControl

[GitHub] cloudstack issue #1642: CLOUDSTACK-9504: System VMs on Managed Storage

2016-09-22 Thread karuturi
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1642 @jburwell I never asked you to remove your -1. I am not even trying to convince you to remove your -1. If Vmware + nfs is such an important combination, it should be the prerequisite for

[GitHub] cloudstack issue #1642: CLOUDSTACK-9504: System VMs on Managed Storage

2016-09-22 Thread mike-tutkowski
Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1642 @jburwell Let me run those tests next week (probably Monday) as I'm just about ready to head out on a flight to a customer site for an upcoming meeting and won't be back until the weekend

Speakers announced for Cloudstack EU User Group

2016-09-22 Thread Giles Sirett
We're very excited to announce the Autumn 2016 meeting of the CloudStack European User group, this time kindly hosted by BT, the people behind BT Cloud Compute. Would be great to see as many from the community there as possible. Folks who cant make it, would appreciate if you're able to tweet an

[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring

2016-09-22 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1593 @rafaelweingartner In usage_evant_details there will be never details with event_id=0 so there will be no conflict ever if we do it this way. Based on the code there are some details e.g. CPU spe

[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring

2016-09-22 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue: https://github.com/apache/cloudstack/pull/1593 I understand why you want to use something that already exists, instead of creating a new table/DAO/service class. Isn’t this table (event_details) used for anything else? If

[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring

2016-09-22 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1593 @rhtyd @jburwell @rafaelweingartner Can we use event_details table which is not used at the moment? if we consider sanity job to generate event_id=0 then max_id can be easily represented there a

Re: State of IPv6 implementation

2016-09-22 Thread Wido den Hollander
> Op 21 september 2016 om 18:30 schreef Thomas Schneider > : > > > Hi, > > Basicaly I have a plan to implement IPv6 in advanced zone with ospf or > bgp routing based on this doc with some improvement: > https://cwiki.apache.org/confluence/display/CLOUDSTACK/IPv6+in+VPC+Router > > The first th

[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring

2016-09-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1593 @serg38 since we don't have a general key/value store table, we may need to create a new table in `cloud_usage` db. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1642: CLOUDSTACK-9504: System VMs on Managed Storage

2016-09-22 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1642 @mike-tutkowski I only see results for the new test suites for XenServer + Managed Storage. Have you also run the entire smoke test suite with `require_hardware` set to `true`? If so, could y

[GitHub] cloudstack issue #1642: CLOUDSTACK-9504: System VMs on Managed Storage

2016-09-22 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1642 @karuturi I am not going to debate the commonality of VMware. It is the market leader in the hypervisor space, and NFS is one of the most popular storage protocols used with it. Like the gene

[GitHub] cloudstack issue #1642: CLOUDSTACK-9504: System VMs on Managed Storage

2016-09-22 Thread karuturi
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1642 @jburwell 'most commonly deployed' - I doubt. As @blueorangutan is ready to test, we can wait. In general, waiting for test results on a configuration which no one has(Hardware is hard), ju

[GitHub] cloudstack issue #1642: CLOUDSTACK-9504: System VMs on Managed Storage

2016-09-22 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1642 @karuturi VMware with NFS primary/secondary storage. It is one of the most commonly deployed CloudStack configurations. Therefore, I am -1 on merging this PR until this regression test is per

[GitHub] cloudstack issue #1545: CLOUDSTACK-8715: Add channel to Instances for Qemu G...

2016-09-22 Thread wido
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1545 @jburwell The old systemVM will also work, but that assumes it's serial port is *always* the first port attached. The XML we generate will make sure that the Qemu Guest Agent port is the s

[GitHub] cloudstack issue #1638: CLOUDSTACK-9456: Migrate master to Spring 4.x

2016-09-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1638 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] cloudstack issue #1638: CLOUDSTACK-9456: Migrate master to Spring 4.x

2016-09-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1638 @blueorangutan test centos7 vmware-55u3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] cloudstack issue #1682: IGNORE this PR

2016-09-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1682 @rhtyd a Trillian-Jenkins matrix job (centos6 mgmt + xs56sp1, centos7 mgmt + vmware55u3, ubuntu mgmt + kvmcentos7) has been kicked to run smoke tests --- If your project is set up for it,

[GitHub] cloudstack issue #1682: IGNORE this PR

2016-09-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1682 @blueorangutan test matrix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wi

[GitHub] cloudstack issue #1682: IGNORE this PR

2016-09-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1682 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been kicked to run smoke tests against packages at http://packages.shapeblue.com/cloudstack/pr/1682 --- If your projec

[GitHub] cloudstack issue #1682: IGNORE this PR

2016-09-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1682 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack pull request #1682: IGNORE this PR

2016-09-22 Thread rhtyd
Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1682 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack issue #1682: IGNORE this PR

2016-09-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1682 Trillian smoketest result (#) Hypervisor: kvm (x2) Network type: Advanced Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/trillian-19-kvm-cs410.