[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...

2017-03-02 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1961 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...

2017-03-02 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1961 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-03-02 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1813 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-03-02 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1813 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1797: CLOUDSTACK-9630: Cannot use listNics API as advertis...

2017-03-02 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/1797 LGTM on the code changes. Make sense to keep listVirtualMachines and listNics in sync for nic response. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1911: CLOUDSTACK-9742:Simultaneous snapshots for detached ...

2017-03-02 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/1911 @mrunalinikankariya Can you provide some marvin test? Also is it possible to add some snapshots/test results? --- If your project is set up for it, you can reply to this email and have

Re: Modern template hosting

2017-03-02 Thread Daan Hoogland
Nice little thing Will, One question: if I read the code correctly it ‘go’es and tries all mirrors at once and whichever responses first is redirected to the client. This might well be the same every time. This might be the one closest to the mirror302 and not to the client. Is that correct or

[GitHub] cloudstack issue #1908: CLOUDSTACK-9317: Fixed disable static nat on leaving...

2017-03-02 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1908 @ProjectMoon I have today this PR after rebasing latest master. I did not observe the add:true for the removed ip. Here is output from the ips.json and ip addr show output.

Re: Removed IPs with add = true in /etc/cloudstack/ips.json on router

2017-03-02 Thread Jayapal Uradi
Hi Jeff, I tested in my setup with latest master rebasing. I did not see the add:true (ips.json) when ips are removed from the UI. Removed public ip is not configured on the eth2 interface. Here is the output: 4: eth2: mtu 1500 qdisc pfifo_fast state UP qlen

Re: GSoC projects

2017-03-02 Thread Daan Hoogland
On Thu, Mar 2, 2017 at 11:22 PM, Syed Ahmed wrote: > I've talked to folks here and I don't think I can give write access to you > for the Wiki. I will create a google form and lets' use that instead. > > On Thu, Mar 2, 2017 at 2:58 PM, sachin patil

Re: GSoC projects

2017-03-02 Thread Raja Pullela
Thanks Syed! On 3/3/17, 3:52 AM, "Syed Ahmed" wrote: I've talked to folks here and I don't think I can give write access to you for the Wiki. I will create a google form and lets' use that instead. On Thu, Mar 2, 2017 at 2:58 PM, sachin patil

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

2017-03-02 Thread priyankparihar
Github user priyankparihar commented on the issue: https://github.com/apache/cloudstack/pull/1773 @karuturi This seems to be ready for merge (tag:mergeready). It has 3 LGTMs and tests are passed. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1978: CLOUDSTACK-9779 : Releasing secondary guest IP fails...

2017-03-02 Thread niteshsarda
Github user niteshsarda commented on the issue: https://github.com/apache/cloudstack/pull/1978 @borisstoyanov : The test cases which are failing are not related to my code changes. Can you please verify ? --- If your project is set up for it, you can reply to this email and

Re: Migration of SystemVMs and Routers

2017-03-02 Thread Will Stevens
​@Pierre-Luc: Why did we have to roll back XenServer 7? I seem to remember it being because our SAS controllers were too old and were not supported. Is that right? *Will Stevens* On Thu, Mar 2, 2017 at 9:26 PM, Marty Godsey wrote: > Sorry, forgot to mention.. This is

Re: Removed IPs with add = true in /etc/cloudstack/ips.json on router

2017-03-02 Thread Jayapal Uradi
Let me have quick look at my setup and will respond to you. Thanks, Jayapal > On Mar 2, 2017, at 3:48 PM, Jeff Hair wrote: > > Jayapal, > > As far as I understand and it (and what I've seen based on some testing), > IPs shouldn't be getting reconfigured (and thus arpinged)

[GitHub] cloudstack issue #1900: CLOUDSTACK-8862: Introduced new state attaching for ...

2017-03-02 Thread cloudmonger
Github user cloudmonger commented on the issue: https://github.com/apache/cloudstack/pull/1900 ### ACS CI BVT Run **Sumarry:** Build Number 416 Hypervisor xenserver NetworkType Advanced Passed=105 Failed=0 Skipped=7 _Link to logs Folder

[GitHub] cloudstack pull request #1973: CLOUDSTACK-9795: moved logrotate from cron.da...

2017-03-02 Thread dmabry
Github user dmabry closed the pull request at: https://github.com/apache/cloudstack/pull/1973 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack issue #1973: CLOUDSTACK-9795: moved logrotate from cron.daily to ...

2017-03-02 Thread dmabry
Github user dmabry commented on the issue: https://github.com/apache/cloudstack/pull/1973 Closing PR as it will be cherry-picked from master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1974: CLOUDSTACK-9795: moved logrotate from cron.daily to ...

2017-03-02 Thread dmabry
Github user dmabry commented on the issue: https://github.com/apache/cloudstack/pull/1974 shall I close this PR or do you guys need it open to make sure the cherry-pick happens? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

RE: Migration of SystemVMs and Routers

2017-03-02 Thread Marty Godsey
Sorry, forgot to mention.. This is XenServer 7.1 and not 7.0.. Don't see how this is an issue however, since the instances, network creation, etc, are all working fine. And ACS did not complain about me putting these into production. Regards, Marty Godsey Principal Engineer nSource Solutions,

Migration of SystemVMs and Routers

2017-03-02 Thread Marty Godsey
I am curious if I am missing something. I added a new cluster/hosts to my 4.9.2 instance. Made sure the switches that were added had all the VLANS that needed to be added, my XenServer cluster had the appropriate network tags, etc. I also, for migration purposes, cause I want to rebuilt an

[GitHub] cloudstack issue #1866: Advanced isolated network egress destination cidr su...

2017-03-02 Thread cloudmonger
Github user cloudmonger commented on the issue: https://github.com/apache/cloudstack/pull/1866 ### ACS CI BVT Run **Sumarry:** Build Number 415 Hypervisor xenserver NetworkType Advanced Passed=100 Failed=5 Skipped=7 _Link to logs Folder

Re: Modern template hosting

2017-03-02 Thread Will Stevens
Hey All, Please review this repo and tell me what you think: https://github.com/swill/mirror302 Let me know if you have questions or you would like me to make changes before I bring this topic up with ASF Infra and open a ticket to get this implemented. Cheers, *Will Stevens* On Wed, Mar 1,

Re: GSoC projects

2017-03-02 Thread Syed Ahmed
I've talked to folks here and I don't think I can give write access to you for the Wiki. I will create a google form and lets' use that instead. On Thu, Mar 2, 2017 at 2:58 PM, sachin patil wrote: > @syed I tried to edit the Candidates column but couldn't do it. I think

[GitHub] cloudstack issue #1862: CLOUDSTACK-9704 Remove dependency on VmwareContext o...

2017-03-02 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1862 Trillian test result (tid-924) Environment: vmware-60u2 (x2), Advanced Networking with Mgmt server 7 Total time taken: 40322 seconds Marvin logs:

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-03-02 Thread remibergsma
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1955 Tested it manually, works great. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

Re: GSoC projects

2017-03-02 Thread sachin patil
@syed I tried to edit the Candidates column but couldn't do it. I think there are some restrictions to edit the page. Please have a look into it. I would like to work for CLOUDSTACK-8629 On Fri, Mar 3, 2017 at 12:03 AM, Syed Ahmed

[GitHub] cloudstack issue #1849: CLOUDSTACK-9690: Scale CentOS7 VM fails with error

2017-03-02 Thread cloudmonger
Github user cloudmonger commented on the issue: https://github.com/apache/cloudstack/pull/1849 ### ACS CI BVT Run **Sumarry:** Build Number 414 Hypervisor xenserver NetworkType Advanced Passed=105 Failed=0 Skipped=7 _Link to logs Folder

[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...

2017-03-02 Thread nvazquez
Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1961 @borisstoyanov I refactored marvin test to migrate a detached disk instead of vm's root volume as it was before. Can you please test it again in your env? --- If your project is set up for

Re: GSoC projects

2017-03-02 Thread Syed Ahmed
I have found the following links to be useful. Please read them. This concerns both mentors and students https://community.apache.org/gsoc.html https://community.apache.org/guide-to-being-a-mentor.html On Thu, Mar 2, 2017 at 12:10 PM, Syed Ahmed wrote: > So here is the

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-03-02 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1813 @borisstoyanov Can you kick off B.O for Vmware again? Hopefully it will pass. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack issue #1981: CLOUDSTACK-9806: Nuage domain template selection per...

2017-03-02 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1981 Trillian test result (tid-923) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 28590 seconds Marvin logs:

[GitHub] cloudstack issue #1978: CLOUDSTACK-9779 : Releasing secondary guest IP fails...

2017-03-02 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1978 Trillian test result (tid-922) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 28067 seconds Marvin logs:

[GitHub] cloudstack issue #1792: CLOUDSTACK-9623: Deploying virtual machine fails due...

2017-03-02 Thread nitin-maharana
Github user nitin-maharana commented on the issue: https://github.com/apache/cloudstack/pull/1792 @koushik-das : No failure now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Re: GSoC projects

2017-03-02 Thread Syed Ahmed
So here is the wiki https://cwiki.apache.org/confluence/display/CLOUDSTACK/Google+Summer+of+Code+2017 I have added the person who created the ticket on Jira as the potential mentor for now. Please add anything that I might have missed. The candidates should add their names against the projects

Re: :[VOTE] Apache Cloudstack 4.10.0.0

2017-03-02 Thread Tutkowski, Mike
I rolled back to my master branch at da66b06e7d562393da2e4b52206943f8bad49d10 and it works. It appears something that went into after that commit has broken this. It looks like this SHA is about two weeks old and that 43 commits have gone into master since it. On 3/2/17, 7:06 AM, "Tutkowski,

Re: GSoC projects

2017-03-02 Thread Daan Hoogland
Syed, On 02/03/17 16:49, "Syed Ahmed" wrote: It looks like there is interest in GSoC. I saw some posts on Slack about someone asking for help. I can't find the conversation now but there are people definitely interested. I can create a Wiki page of all

[GitHub] cloudstack pull request #1917: CLOUDSTACK-9756: Configure to ignore the ipas...

2017-03-02 Thread srinivas-gandikota
Github user srinivas-gandikota commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1917#discussion_r103966991 --- Diff: engine/components-api/src/com/cloud/network/IpAddressManager.java --- @@ -43,6 +43,9 @@ "If true, when account has

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-03-02 Thread mike-tutkowski
Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1813 This code LGTM. I reviewed the code, but don't have the ability to run tests at the moment as I'm in the process of testing RC1 for 4.10. We have updates to two unit tests and two

Re: GSoC projects

2017-03-02 Thread Syed Ahmed
It looks like there is interest in GSoC. I saw some posts on Slack about someone asking for help. I can't find the conversation now but there are people definitely interested. I can create a Wiki page of all the proposals till now and then we can direct people to that page and they can add their

[GitHub] cloudstack issue #1797: CLOUDSTACK-9630: Cannot use listNics API as advertis...

2017-03-02 Thread cloudmonger
Github user cloudmonger commented on the issue: https://github.com/apache/cloudstack/pull/1797 ### ACS CI BVT Run **Sumarry:** Build Number 413 Hypervisor xenserver NetworkType Advanced Passed=104 Failed=1 Skipped=7 _Link to logs Folder

[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...

2017-03-02 Thread nvazquez
Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1961 @borisstoyanov actually disk is not being dettached from vm before migrating it, it is using vm's ROOT disk, it can be done on Vmware by setting `livemigrate='true'` to migrate command. I'll

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-03-02 Thread priyankparihar
Github user priyankparihar commented on the issue: https://github.com/apache/cloudstack/pull/1813 Hi @mike-tutkowski sir, You have done enough work in storage area. Please review this PR. Your one LGTM comment is enough to lift this PR. --- If your project is set up for it, you

[GitHub] cloudstack pull request #1961: Fix for test_snapshots.py using nfs2 instead ...

2017-03-02 Thread nvazquez
Github user nvazquez commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1961#discussion_r103932149 --- Diff: test/integration/smoke/test_snapshots.py --- @@ -275,7 +275,7 @@ def test_02_list_snapshots_with_removed_data_store(self):

[GitHub] cloudstack pull request #1813: CLOUDSTACK-9604: Root disk resize support for...

2017-03-02 Thread priyankparihar
Github user priyankparihar commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1813#discussion_r103931610 --- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java --- @@ -3614,6 +3604,26 @@ public UserVmVO doInTransaction(TransactionStatus status)

Re: :[VOTE] Apache Cloudstack 4.10.0.0

2017-03-02 Thread Tutkowski, Mike
According to where the code fails, though, it appears to be a networking problem. If I set a breakpoint before the failure and change a variable to say that security groups are not being used, then the VM starts. I think this is a recently introduced problem because I have another branch based

Re: :[VOTE] Apache Cloudstack 4.10.0.0

2017-03-02 Thread Pierre-Luc Dion
Hi Mike, Try vm with at least 512MB for memory. On Mar 1, 2017 15:01, "Tutkowski, Mike" wrote: > I see the following exception when trying to deploy a user VM in a Basic > Zone with two XenServer 6.5 hosts in one cluster. My system VMs have all > deployed properly.

[GitHub] cloudstack pull request #1982: CLOUDSTACK-9807/CLOUDSTACK-9808 - Added upgra...

2017-03-02 Thread kishankavala
GitHub user kishankavala opened a pull request: https://github.com/apache/cloudstack/pull/1982 CLOUDSTACK-9807/CLOUDSTACK-9808 - Added upgrade changes for 4.10 system vm template Removed systemvm template upgrade code in 4.6 upgrade. Added 4.10 system vm template upgrade changes

[GitHub] cloudstack pull request #1961: Fix for test_snapshots.py using nfs2 instead ...

2017-03-02 Thread borisstoyanov
Github user borisstoyanov commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1961#discussion_r103897965 --- Diff: test/integration/smoke/test_snapshots.py --- @@ -275,7 +275,7 @@ def test_02_list_snapshots_with_removed_data_store(self):

[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring

2017-03-02 Thread cloudmonger
Github user cloudmonger commented on the issue: https://github.com/apache/cloudstack/pull/1593 ### ACS CI BVT Run **Sumarry:** Build Number 412 Hypervisor xenserver NetworkType Advanced Passed=104 Failed=1 Skipped=7 _Link to logs Folder

[GitHub] cloudstack issue #1861: CLOUDSTACK-9698 [VMware] Make hardcorded wait timeou...

2017-03-02 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue: https://github.com/apache/cloudstack/pull/1861 Hi @karuturi This has test results as well as 2 LGTMs. I think this can be merged. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request #1917: CLOUDSTACK-9756: Configure to ignore the ipas...

2017-03-02 Thread jayapalu
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1917#discussion_r103897727 --- Diff: engine/components-api/src/com/cloud/network/IpAddressManager.java --- @@ -43,6 +43,9 @@ "If true, when account has dedicated

[GitHub] cloudstack issue #1861: CLOUDSTACK-9698 [VMware] Make hardcorded wait timeou...

2017-03-02 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue: https://github.com/apache/cloudstack/pull/1861 @harikrishna-patnala Thanks. Did not make the parameter as dynamic, to avoid unexpected timeout errors upon timeout changes, for those VPC tier configurations in progress. --- If

[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...

2017-03-02 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1961 @nvazquez I'm getting the following error: ``` File "/marvin/tests/smoke/test_snapshots.py", line 327, in test_02_list_snapshots_with_removed_data_store\nlivemigrate="true"\n',

[GitHub] cloudstack issue #1861: CLOUDSTACK-9698 [VMware] Make hardcorded wait timeou...

2017-03-02 Thread harikrishna-patnala
Github user harikrishna-patnala commented on the issue: https://github.com/apache/cloudstack/pull/1861 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1774: CLOUDSTACK-9608: Errored State and Abandoned state T...

2017-03-02 Thread karuturi
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1774 code LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cloudstack issue #1776: CLOUDSTACK-9603: 'concurrent.snapshots.threshold.per...

2017-03-02 Thread sowmyakrishn
Github user sowmyakrishn commented on the issue: https://github.com/apache/cloudstack/pull/1776 Reviewed test code. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1862: CLOUDSTACK-9704 Remove dependency on VmwareContext o...

2017-03-02 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1862 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + vmware-60u2) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1862: CLOUDSTACK-9704 Remove dependency on VmwareContext o...

2017-03-02 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1862 @blueorangutan test centos7 vmware-60u2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #1862: CLOUDSTACK-9704 Remove dependency on VmwareContext o...

2017-03-02 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1862 @borisstoyanov unsupported parameters provided. Supported mgmt server os are: `centos6, centos7, ubuntu`. Supported hypervisors are: `kvm-centos6, kvm-centos7, kvm-ubuntu,

[GitHub] cloudstack issue #1862: CLOUDSTACK-9704 Remove dependency on VmwareContext o...

2017-03-02 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1862 @blueorangutan test centos7 vmware65 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #1949: Automated Cloudstack bugs 9277 9276 9275 9274 9273 9...

2017-03-02 Thread shwetaag
Github user shwetaag commented on the issue: https://github.com/apache/cloudstack/pull/1949 @rhtyd : I executed all the travis failures manually on my setup and both test case passed copy pasting the result: Test Create/delete a volume and verify correct usage is recorded ...

[GitHub] cloudstack issue #1981: CLOUDSTACK-9806: Nuage domain template selection per...

2017-03-02 Thread prashanthvarma
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1981 @borisstoyanov I am glad you liked the PR, we (@nuagenetworks) made it a practice to add and run integration tests that test the changes we propose/make in a PR. Moreover, we internally

[GitHub] cloudstack issue #1862: CLOUDSTACK-9704 Remove dependency on VmwareContext o...

2017-03-02 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1862 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-557 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request #1302: CLOUDSTACK-9104: VM naming convention in case...

2017-03-02 Thread priyankparihar
Github user priyankparihar commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1302#discussion_r103892827 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -2226,17 +2227,33 @@ int

[GitHub] cloudstack issue #1302: CLOUDSTACK-9104: VM naming convention in case vmware...

2017-03-02 Thread priyankparihar
Github user priyankparihar commented on the issue: https://github.com/apache/cloudstack/pull/1302 @rhtyd I think now all of your questions are answered. Please provide your LGTM comment. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack issue #1861: CLOUDSTACK-9698 [VMware] Make hardcorded wait timeou...

2017-03-02 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue: https://github.com/apache/cloudstack/pull/1861 Yes, @karuturi rebased with latest master. And changed base branch of this PR to master. Please review. --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack issue #1246: CLOUDSTACK-9165 unable to use reserved IP range in a...

2017-03-02 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/1246 @nlivens As suggested I have moved the getValidNetworkCidr to common class NetworkModel. --- If your project is set up for it, you can reply to this email and have your reply appear on

Re: Removed IPs with add = true in /etc/cloudstack/ips.json on router

2017-03-02 Thread Jeff Hair
Jayapal, As far as I understand and it (and what I've seen based on some testing), IPs shouldn't be getting reconfigured (and thus arpinged) once PR 1907 is applied. The JSON entry is not removed from the DataBag, but they SHOULD have the "add" property set to false, at least. Can you clarify:

[GitHub] cloudstack pull request #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KV...

2017-03-02 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1960#discussion_r103890661 --- Diff: api/src/org/apache/cloudstack/api/command/admin/ha/DisableHAForClusterCmd.java --- @@ -0,0 +1,114 @@ +// Licensed to the Apache

[GitHub] cloudstack issue #883: CLOUDSTACK-8906: /var/log/cloud/ doesn't get logrotat...

2017-03-02 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/883 Previous CI failures were not relevant to my changes. tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack issue #1862: CLOUDSTACK-9704 Remove dependency on VmwareContext o...

2017-03-02 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1862 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1862: CLOUDSTACK-9704 Remove dependency on VmwareContext o...

2017-03-02 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1862 Sure @sateesh-chodapuneedi @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack issue #1865: CLOUDSTACK-9705: Unauthenticated API allows Admin pa...

2017-03-02 Thread koushik-das
Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1865 Code changes LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

RE: :[VOTE] Apache Cloudstack 4.10.0.0

2017-03-02 Thread Kishan Kavala
@Rajani Both the blockers are related. I'll create a PR for the fix. -Original Message- From: Rajani Karuturi [mailto:raj...@apache.org] Sent: Thursday, March 02, 2017 3:18 PM To: Boris Stoyanov Cc: dev@cloudstack.apache.org; Wido den Hollander

[GitHub] cloudstack issue #1862: CLOUDSTACK-9704 Remove dependency on VmwareContext o...

2017-03-02 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue: https://github.com/apache/cloudstack/pull/1862 @borisstoyanov @borisroman Can you please run trillian tests for this PR? This already has enough code LGTMs, and needs tests for merge. --- If your project is set up for it,

[GitHub] cloudstack issue #1868: CLOUDSTACK-9707: While using hostid parameter, vm ge...

2017-03-02 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1868 @ustcweizhou, Actually I am restoring to old behaviour of 3.x release which got changed to current behaviour because of bug. --- If your project is set up for it, you can reply to this

[GitHub] cloudstack issue #1759: CLOUDSTACK-9589 vmName entries from host_details tab...

2017-03-02 Thread harikrishna-patnala
Github user harikrishna-patnala commented on the issue: https://github.com/apache/cloudstack/pull/1759 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1872: CLOUDSTACK-3223 Exception observed while creating CP...

2017-03-02 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue: https://github.com/apache/cloudstack/pull/1872 @ping sureshanaparti @anshul1886 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #1841: CLOUDSTACK-9684 Invalid zone id error while listing ...

2017-03-02 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue: https://github.com/apache/cloudstack/pull/1841 @karuturi Checked the tests errors, they seem to be unrelated to this PR code fix. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack issue #1865: CLOUDSTACK-9705: Unauthenticated API allows Admin pa...

2017-03-02 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1865 @koushik-das, This method is there so that it only gets called when the call is made through 8096 port. Other parameters processing is done at common place. --- If your project is set up

[GitHub] cloudstack issue #1940: CLOUDSTACK-9781:ACS records ID in events tables inst...

2017-03-02 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1940 Thanks @jayantpatil1234 those failures are known issues that we're looking forward to address soon. No need to rerun. --- If your project is set up for it, you can reply to this email

Re: :[VOTE] Apache Cloudstack 4.10.0.0

2017-03-02 Thread Rajani Karuturi
@pierre-Luc, I think we have to support centos6 atleast till Q2 2017. https://wiki.centos.org/About/Product Thanks for testing Boris, Rene and Mike. We currently have the following blockers for RC2: https://github.com/apache/cloudstack/pull/1923

[GitHub] cloudstack issue #1981: CLOUDSTACK-9806: Nuage domain template selection per...

2017-03-02 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1981 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1981: CLOUDSTACK-9806: Nuage domain template selection per...

2017-03-02 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1981 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack pull request #1841: CLOUDSTACK-9684 Invalid zone id error while l...

2017-03-02 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1841#discussion_r103883712 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java --- @@ -1180,10 +1180,7 @@ public

[GitHub] cloudstack issue #1978: CLOUDSTACK-9779 : Releasing secondary guest IP fails...

2017-03-02 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1978 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack pull request #1917: CLOUDSTACK-9756: Configure to ignore the ipas...

2017-03-02 Thread srinivas-gandikota
Github user srinivas-gandikota commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1917#discussion_r103880552 --- Diff: engine/components-api/src/com/cloud/network/IpAddressManager.java --- @@ -43,6 +43,9 @@ "If true, when account has

[GitHub] cloudstack pull request #1302: CLOUDSTACK-9104: VM naming convention in case...

2017-03-02 Thread priyankparihar
Github user priyankparihar commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1302#discussion_r103880795 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -2226,17 +2227,33 @@ int

Re: :[VOTE] Apache Cloudstack 4.10.0.0

2017-03-02 Thread Boris Stoyanov
Hi all, I’m adding the smoketests resluts. I’ve executed them agains the 3 most common hypervisors with the latests versions deployed. KVM env: 2x KVM on CentOS7.2 Management CentOS7.2 Primary and secondary storage: NFS Java 1.8.0_121 Advanced network with one zone (2 hosts) VMware env: 2x

[GitHub] cloudstack issue #859: Bug-ID: CLOUDSTACK-8882: calculate network offering u...

2017-03-02 Thread kishankavala
Github user kishankavala commented on the issue: https://github.com/apache/cloudstack/pull/859 @DaanHoogland cloudmonger failures are not related to this PR. Changes in this PR are related to usage server only. --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack issue #1573: CLOUDSTACK-9396:fixing issue related to script test_...

2017-03-02 Thread nitt10prashant
Github user nitt10prashant commented on the issue: https://github.com/apache/cloudstack/pull/1573 not needed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack pull request #1573: CLOUDSTACK-9396:fixing issue related to scrip...

2017-03-02 Thread nitt10prashant
Github user nitt10prashant closed the pull request at: https://github.com/apache/cloudstack/pull/1573 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack issue #1563: CLOUDSTACK-9389:[automation]updating test_routers_ne...

2017-03-02 Thread nitt10prashant
Github user nitt10prashant commented on the issue: https://github.com/apache/cloudstack/pull/1563 Not needed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack pull request #1979: CLOUDSTACK-9198: Donot allow VMs to be deplye...

2017-03-02 Thread abhinandanprateek
Github user abhinandanprateek closed the pull request at: https://github.com/apache/cloudstack/pull/1979 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cloudstack pull request #1563: CLOUDSTACK-9389:[automation]updating test_rou...

2017-03-02 Thread nitt10prashant
Github user nitt10prashant closed the pull request at: https://github.com/apache/cloudstack/pull/1563 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack issue #1868: CLOUDSTACK-9707: While using hostid parameter, vm ge...

2017-03-02 Thread ustcweizhou
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1868 @anshul1886 Considering about backwards compatibility. I would like to add the global setting, then users will have two options (1) deploy vm fails if specified host does not have

[GitHub] cloudstack pull request #1865: CLOUDSTACK-9705: Unauthenticated API allows A...

2017-03-02 Thread koushik-das
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1865#discussion_r103875741 --- Diff: server/src/com/cloud/api/ApiServer.java --- @@ -430,8 +433,27 @@ public void handle(final HttpRequest request, final HttpResponse

[GitHub] cloudstack issue #1865: CLOUDSTACK-9705: Unauthenticated API allows Admin pa...

2017-03-02 Thread koushik-das
Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1865 @anshul1886 @karuturi Should this be treated as a security issue and fixed on priority? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack issue #1868: CLOUDSTACK-9707: While using hostid parameter, vm ge...

2017-03-02 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1868 @ustcweizhou, In my opinion we should not do that as that way we are giving them option of silently deploying VM on some host which he might not be aware of. As after specifying host he is

  1   2   >