Re: CloudStack Logging, the log4j Configuration file

2015-12-07 Thread Miguel Ferreira
+1 on this question. I too would like to know the reason for having all these files in different modules. On 07/12/15 12:52, "Chaz PC" wrote: >Hello, > > > > >I am studying the logging process used by CloudStack and came accross the >configuration file that is used by Log4j. What is confusin

Re: cloudstack UI

2015-11-18 Thread Miguel Ferreira
I think that would be a good move too. The only impediment I see are the hardcoved url endpoints. Specifically "client/" and "client/api". The UI code is already a separate module. But that gets bundled inside the management server WAR. We could separate that in two WARs if te UI would allow us

Re: [PROPOSAL] remove travis pull request checks from github

2015-10-29 Thread Miguel Ferreira
It would add speed. Just for running maven we could move the travis build to their docker based infra which is faster than what we use now. I’m guess that the apache build does more stuff like packaging RPMs, but I’m not sure there. \ Miguel Ferreira mferre...@schubergphilis.com

Re: [PROPOSAL] remove travis pull request checks from github

2015-10-29 Thread Miguel Ferreira
-P developer,systemvv That is because, still many people commenting on PRs don’t even do that. In addition this would be faster than the Jenkins build, so it would provide faster feedback. Cheers, \ Miguel Ferreira mferre...@schubergphilis.com<mailto:mferre...@schubergphilis.com>

Re: test_nicira_controller.py is failing on all Advzone - XS, KVM

2015-10-01 Thread Miguel Ferreira
efforts in running much needed tests. Cheers, \ Miguel Ferreira mferre...@schubergphilis.com<mailto:mferre...@schubergphilis.com>

Re: test_nicira_controller.py is failing on all Advzone - XS, KVM

2015-10-01 Thread Miguel Ferreira
Or maybe, another possibility, create a directory with the tests you want to call the BVT suite? \ Miguel Ferreira mferre...@schubergphilis.com<mailto:mferre...@schubergphilis.com> On 01 Oct 2015, at 14:22, Miguel Ferreira mailto:mferre...@schubergphilis.com>> wrote: Raja,

Re: test_nicira_controller.py is failing on all Advzone - XS, KVM

2015-10-01 Thread Miguel Ferreira
Raja, I might be missing something obvious here, please do correct me if I’m wrong: one other option you could consider is to improve your setup by adding the possibility of excluding certain test files. Cheers, \ Miguel Ferreira mferre...@schubergphilis.com<mailto:mfe

Re: test_nicira_controller.py is failing on all Advzone - XS, KVM

2015-10-01 Thread Miguel Ferreira
Can’t we not run the test if we do not wish to do so? \ Miguel Ferreira mferre...@schubergphilis.com<mailto:mferre...@schubergphilis.com> On 01 Oct 2015, at 12:11, Koushik Das mailto:koushik@citrix.com>> wrote: Can't we output a proper message (missing OR incorr

Re: test_nicira_controller.py is failing on all Advzone - XS, KVM

2015-10-01 Thread Miguel Ferreira
tests get skipped. I think the test should fail if the config is not right, or otherwise be excluded if the indentation is to not run them. Cheers, \ Miguel Ferreira mferre...@schubergphilis.com<mailto:mferre...@schubergphilis.com> On 30 Sep 2015, at 19:40, Raja Pullela mailto:raj

Re: test_nicira_controller.py is failing on all Advzone - XS, KVM

2015-09-30 Thread Miguel Ferreira
ng (ie. setting up the cluster internals, and adding a more controllers to the cluster). I can help you with that if you need. Cheers, \ Miguel Ferreira mferre...@schubergphilis.com<mailto:mferre...@schubergphilis.com> On 30 Sep 2015, at 09:05, Raja Pullela mailto:raja.pull...@citrix

Re: BVT report 9/29

2015-09-30 Thread Miguel Ferreira
ssful=== Marvin Init Successful === TestName: test_01_scale_vm | Status : SUCCESS === === TestName: test_02_scale_vm_without_hypervisor_specifics | Status : EXCEPTION === ===final results are now copied to: /tmp//MarvinLogs/test_scale_vm_FUCV6R=== Cheers, \ Miguel Ferreira m

Re: BVT report 9/29

2015-09-30 Thread Miguel Ferreira
that’s the one that should be running against real hypervisors. Have a look at the PR where that test was introduced if you want to have the full context. (https://github.com/apache/cloudstack/pull/741) I’ll let you guys know if I can run the test or not, and what’s the output. \ Miguel Fe

Re: [PROPOSAL] stable master and 4.6 release

2015-09-16 Thread Miguel Ferreira
I totally agree with this proposal. By the way, until there is a reliable CI build, PR reviews should always follow point 2. Cheers, \ Miguel Ferreira mferre...@schubergphilis.com<mailto:mferre...@schubergphilis.com> On 16 Sep 2015, at 08:17, Rajani Karuturi mailto:raj...@apac

Re: No more direct commits to master please!

2015-09-12 Thread Miguel Ferreira
T-like usage. Always double check your git tree against the remote git tree before pushing anything upstream. In case of doubts, find someone to double check. I will always be more than happy to help out with such things. Cheers, \ Miguel Ferreira mferre...@schubergphilis.com<mailto:mferr

Re: No more direct commits to master please!

2015-09-11 Thread Miguel Ferreira
Hi Wido, In order to figure out what went wrong, could you please point me to the merge commit (the one saying “Merge pull request …”) for commit b66dcda49f370e6fc91ebff889a694f17826ca44 ? Cheers, \ Miguel Ferreira mferre...@schubergphilis.com<mailto:mferre...@schubergphilis.com>

Re: Git Rebase Question

2015-07-30 Thread Miguel Ferreira
Happy to know your problem is fixed. Cheers \ Miguel Ferreira mferre...@schubergphilis.com<mailto:mferre...@schubergphilis.com> On 29 Jul 2015, at 19:34, Mike Tutkowski mailto:mike.tutkow...@solidfire.com>> wrote: Hi Miguel, I appreciate your willingness to help - thanks!

Re: Git Rebase Question

2015-07-29 Thread Miguel Ferreira
branch yo want to pull and rebase from, I could give it a try and let you know what I find. Cheers, \ Miguel Ferreira mferre...@schubergphilis.com<mailto:mferre...@schubergphilis.com> On 15 Jul 2015, at 03:03, Mike Tutkowski mailto:mike.tutkow...@solidfire.com>> wrote: Hi

Re: Review Request 23856: Fix VPC distributed routing integration tests

2014-07-24 Thread Miguel Ferreira
7;ve added a method to the setup that makes sure Ovs is enabled, or throws an exception if it is not present. Diffs - test/integration/component/test_vpc_distributed_routing_offering.py cc9a191 tools/marvin/marvin/lib/common.py 187ede6 Diff: https://reviews.apache.org/r/23856/diff/ Testing --- Both test #1 and #2 in that class succeed. Thanks, Miguel Ferreira

Re: Review Request 23856: Fix VPC distributed routing integration tests

2014-07-24 Thread Miguel Ferreira
ffering.py cc9a191 tools/marvin/marvin/lib/common.py 187ede6 Diff: https://reviews.apache.org/r/23856/diff/ Testing --- Both test #1 and #2 in that class succeed. Thanks, Miguel Ferreira

Re: Review Request 23856: Use local test configuration to enable testing of VPC distributed routing

2014-07-24 Thread Miguel Ferreira
changed that and also added two new lines in between every python method to make the class more readable. Diffs (updated) - test/integration/component/test_vpc_distributed_routing_offering.py cc9a191 Diff: https://reviews.apache.org/r/23856/diff/ Testing --- Both test #1 and #2 in that class succeed. Thanks, Miguel Ferreira

Re: Review Request 23856: Use local test configuration to enable testing of VPC distributed routing

2014-07-24 Thread Miguel Ferreira
ew lines in between every python method to make the class more readable. Diffs (updated) - test/integration/component/test_vpc_distributed_routing_offering.py cc9a191 Diff: https://reviews.apache.org/r/23856/diff/ Testing --- Both test #1 and #2 in that class succeed. Thanks, Miguel Ferreira

Re: Review Request 23856: Use local test configuration to enable testing of VPC distributed routing

2014-07-24 Thread Miguel Ferreira
f: https://reviews.apache.org/r/23856/diff/ Testing (updated) --- Both test #1 and #2 in that class succeed. Thanks, Miguel Ferreira

Re: Review Request 23735: Fix deployment of data center with marvin

2014-07-24 Thread Miguel Ferreira
t to me. - Miguel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23735/#review48216 --- On July 22, 2014, 7:24 a.m., Miguel Ferreira wrote:

Re: Review Request 23735: Fix deployment of data center with marvin

2014-07-24 Thread Miguel Ferreira
h I'm submitting add support for lists in the logger element of the > configuration. > > [1] - https://cwiki.apache.org/confluence/display/CLOUDSTACK/DevCloud > > > Diffs > - > > tools/marvin/marvin/deployDataCenter.py ae48839 > tools/marvin/marvin/marvinLog.py ea8eaee > > Diff: https://reviews.apache.org/r/23735/diff/ > > > Testing > --- > > With the patch I was able to deploy a zone in cloudstack. > > > Thanks, > > Miguel Ferreira > >

Re: Review Request 23847: Check if config specifies zones before iterating

2014-07-23 Thread Miguel Ferreira
ts. > Sure. Thanks - Miguel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23847/#review48509 --- On July 23, 2014,

Review Request 23856: Use local test configuration to enable testing of distributed routing

2014-07-23 Thread Miguel Ferreira
the other 2 tests in the class because my development setup does not support Ovs. Diffs - test/integration/component/test_vpc_distributed_routing_offering.py cc9a191 Diff: https://reviews.apache.org/r/23856/diff/ Testing --- The test that was failing now passes. Thanks, Miguel Ferreira

Re: Need edit rights for Wiki to improve Marvin - Testing with Python tutorial

2014-07-23 Thread Miguel Ferreira
place got missed. Please add the one with latest. > > I can add that change for you if you require. > > Santhosh > ____ > From: Miguel Ferreira [mferre...@schubergphilis.com] > Sent: Wednesday, July 23, 2014 6:23 AM > To: Daan Hoogland >

Re: Review Request 23847: Check if config specifies zones before iterating

2014-07-23 Thread Miguel Ferreira
> On July 23, 2014, 12:05 p.m., Santhosh Edukulla wrote: > > tools/marvin/marvin/marvinInit.py, line 114 > > <https://reviews.apache.org/r/23847/diff/1/?file=640532#file640532line114> > > > > please use is not None, rather != > > Miguel Ferreira wrote:

Re: Review Request 23847: Check if config specifies zones before iterating

2014-07-23 Thread Miguel Ferreira
views.apache.org/r/23847/diff/ Testing --- Tests now run without the mentioned exception Thanks, Miguel Ferreira

Re: Review Request 23847: Check if config specifies zones before iterating

2014-07-23 Thread Miguel Ferreira
> On July 23, 2014, 12:05 p.m., Santhosh Edukulla wrote: > > tools/marvin/marvin/marvinInit.py, line 114 > > <https://reviews.apache.org/r/23847/diff/1/?file=640532#file640532line114> > > > > please use is not None, rather != > > Miguel Ferreira wrote:

Re: Review Request 23847: Check if config specifies zones before iterating

2014-07-23 Thread Miguel Ferreira
Tests now run without the mentioned exception Thanks, Miguel Ferreira

Re: Review Request 23847: Check if config specifies zones before iterating

2014-07-23 Thread Miguel Ferreira
ttps://reviews.apache.org/r/23847/#review48496 --- On July 23, 2014, 11:56 a.m., Miguel Ferreira wrote: > > --- > This is an automatically generated e-mail. To reply, v

Review Request 23847: Check if config specifies zones before iterating

2014-07-23 Thread Miguel Ferreira
exist. I've added a check for the existence of the list of zones before iterating. Diffs - tools/marvin/marvin/marvinInit.py ce9b43f Diff: https://reviews.apache.org/r/23847/diff/ Testing --- Tests now run without the mentioned exception Thanks, Miguel Ferreira

Re: Review Request 23737: Improve usability of deployDataCenter.py and advanced zone config

2014-07-23 Thread Miguel Ferreira
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23737/#review48219 ------- On July 21, 2014, 1:42 p.m., Miguel Ferreira wrote: > > --- &g

Review Request 23843: Removed duplicated code block

2014-07-23 Thread Miguel Ferreira
://reviews.apache.org/r/23843/diff/ Testing --- Tests I'm running that create service offerings produce the same results before and after the change. Thanks, Miguel Ferreira

Re: Need edit rights for Wiki to improve Marvin - Testing with Python tutorial

2014-07-23 Thread Miguel Ferreira
and wrote: > On Wed, Jul 23, 2014 at 11:56 AM, Miguel Ferreira > wrote: >> miguelferreira > > > in > > -- > Daan

Need edit rights for Wiki to improve Marvin - Testing with Python tutorial

2014-07-23 Thread Miguel Ferreira
Hi, I’m following the "Marvin - Testing with Python" tutorial and found some problems with the first example already. I would like to contribute what I found back, but for that I need to be able to edit the page. Username: miguelferreira Cheers, Miguel

Re: Review Request 23735: Fix deployment of data center with marvin

2014-07-22 Thread Miguel Ferreira
://cwiki.apache.org/confluence/display/CLOUDSTACK/DevCloud Diffs (updated) - tools/marvin/marvin/deployDataCenter.py ae48839 tools/marvin/marvin/marvinLog.py ea8eaee Diff: https://reviews.apache.org/r/23735/diff/ Testing --- With the patch I was able to deploy a zone in cloudstack. Thanks, Miguel Ferreira

Re: Review Request 23735: Fix deployment of data center with marvin

2014-07-22 Thread Miguel Ferreira
inLog.py ea8eaee Diff: https://reviews.apache.org/r/23735/diff/ Testing --- With the patch I was able to deploy a zone in cloudstack. Thanks, Miguel Ferreira

Re: Review Request 23735: Fix deployment of data center with marvin

2014-07-22 Thread Miguel Ferreira
marvin/misc/build/kvm.cfg:"logger": [ ../marvin/marvin/misc/build/xen.cfg:"logger": [ - Miguel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23735/#review48

Re: Review Request 23735: Fix deployment of data center with marvin

2014-07-22 Thread Miguel Ferreira
atically generated e-mail. To reply, visit: https://reviews.apache.org/r/23735/#review48217 ------- On July 21, 2014, 1:35 p.m., Miguel Ferreira wrote: > > --- > This is an automatically generat

Review Request 23737: Improve usability of deployDataCenter.py and advanced zone config

2014-07-21 Thread Miguel Ferreira
ae48839 Diff: https://reviews.apache.org/r/23737/diff/ Testing --- Used deployDataCenter.py together with advanced zone config to deploy a zone in my development environment Thanks, Miguel Ferreira

Review Request 23735: Fix deployment of data center with marvin

2014-07-21 Thread Miguel Ferreira
vcloud/devcloud-advanced.cfg 74b6366 tools/devcloud/devcloud.cfg 5232e3a tools/marvin/marvin/deployDataCenter.py ae48839 tools/marvin/marvin/marvinLog.py ea8eaee Diff: https://reviews.apache.org/r/23735/diff/ Testing --- With the patch I was able to deploy a zone in cloudstack. Thanks, Miguel Ferreira

[PROPOSAL] Use Liquibase to manage DB changes

2014-03-18 Thread Miguel Ferreira
All, Following from the discussion of [1], I have written a small tool [2] to detect potential conflicts related to ACS DB changes. With the input supplied by that tool, I will proceed to check every commit since tag 4.2 up to the head of master. For every commit that introduces relevant changes

RE: [DISCUSS] Enabling databse upgrades on master branch

2014-03-12 Thread Miguel Ferreira
made incrementally and independently of each other. All-in-all I think Liquibase is a better tool for the job. Cheers, Miguel From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com] Sent: dinsdag 11 maart 2014 6:52 To: dev@cloudstack.apache.org Cc: Miguel Ferreira Subject: Re: [DISCUSS] Enabling da

RE: [DISCUSS] Enabling databse upgrades on master branch

2014-03-11 Thread Miguel Ferreira
project? [1] http://markmail.org/message/r7wv36o356nolq7f [2] http://markmail.org/message/wlua3l4o5shayidf [liquibase] http://www.liquibase.org/ [flyway] http://flywaydb.org/ [3] http://stackoverflow.com/a/8489144/201514 ~Rajani On 10-Mar-2014, at 8:35 pm, Miguel Ferreira mailto:mferre..

[DISCUSS] Enabling databse upgrades on master branch

2014-03-10 Thread Miguel Ferreira
hear your opinions about the issue I described, as well as, the proposed solution and any other solutions you might come up with. Kind regards, Miguel Ferreira Mission Critical Engineer Schuberg Philis Boeingavenue 271 1119 PD Schiphol-Rijk schubergphilis.com +31 207506617 +31 610907106 _

RE: [DISCUSS] Checking in code that will break others' environments

2014-03-06 Thread Miguel Ferreira
Hi all, I've been looking at the way DB related code (SQL scripts and Java classes) are updated and what is the impact of those updates on a live cloudstack DB. By the way, my intention is to support a per-commit DB upgrade of a running system. Anyway, I completely agree that sending an email w

Review Request 18733: Refactor DbUpgradeUtils

2014-03-04 Thread Miguel Ferreira
Diff: https://reviews.apache.org/r/18733/diff/ Testing --- Ran all unit tests in eclipse. Ran "mvn clean install". Thanks, Miguel Ferreira

Re: Review Request 18358: NetUtils unit testing

2014-02-22 Thread Miguel Ferreira
/utils/net/NetUtilsTest.java d3e283c Diff: https://reviews.apache.org/r/18358/diff/ Testing --- Ran all the tests in the test class before and after refactoring. Thanks, Miguel Ferreira

Re: Review Request 18358: NetUtils unit testing

2014-02-22 Thread Miguel Ferreira
il. To reply, visit: https://reviews.apache.org/r/18358/#review35179 --- On Feb. 21, 2014, 4:43 p.m., Miguel Ferreira wrote: > > --- > This is an automatically generat

Review Request 18358: NetUtils unit testing

2014-02-21 Thread Miguel Ferreira
after refactoring. Thanks, Miguel Ferreira

Re: Review Request 18114: Fix findbugs findings in cloudstack-service-console-proxy-rdpclient

2014-02-20 Thread Miguel Ferreira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18114/#review34990 --- Ship it! Ship It! - Miguel Ferreira On Feb. 14, 2014, 2:48 p.m

Re: Review Request 18114: Fix findbugs findings in cloudstack-service-console-proxy-rdpclient

2014-02-20 Thread Miguel Ferreira
you ask? - Miguel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18114/#review34851 --- On Feb. 14, 2014, 2:48 p.m., Miguel Ferreira wrote: > >

Re: Review Request 18114: Fix findbugs findings in cloudstack-service-console-proxy-rdpclient

2014-02-14 Thread Miguel Ferreira
18114/diff/ Testing --- Added tests for code that changed and tested in Devcloud Thanks, Miguel Ferreira

Re: Review Request 18113: Fix findbugs findings in cloud-plugin-network-elb

2014-02-14 Thread Miguel Ferreira
/diff/ Testing --- Added unit tests the changes in the patch and tested in DevCloud. Thanks, Miguel Ferreira

Re: Review Request 18113: Fix findbugs findings in cloud-plugin-network-elb

2014-02-14 Thread Miguel Ferreira
/18113/diff/ Testing --- Added unit tests the changes in the patch and tested in DevCloud. Thanks, Miguel Ferreira

Re: Review Request 18114: Fix findbugs findings in cloudstack-service-console-proxy-rdpclient

2014-02-14 Thread Miguel Ferreira
y-rdp/rdpconsole/src/test/java/streamer/ByteBufferTest.java PRE-CREATION Diff: https://reviews.apache.org/r/18114/diff/ Testing --- Added tests for code that changed and tested in Devcloud Thanks, Miguel Ferreira

Review Request 18114: Fix findbugs findings in cloudstack-service-console-proxy-rdpclient

2014-02-14 Thread Miguel Ferreira
e.org/r/18114/diff/ Testing --- Added tests for code that changed and tested in Devcloud Thanks, Miguel Ferreira

Review Request 18113: Fix findbugs findings in cloud-plugin-network-elb

2014-02-14 Thread Miguel Ferreira
. Thanks, Miguel Ferreira