stop LGTM
> PRs that do not contain:
>
> 1. Jira ticket
> 2. Proper description of what it fixes/improves
> 3. Unit and/or Integration tests
> 4. And was tested
>
> After 4.6 our first priority should be to get a proper CI environment that
> not only run simulator, but also KV
dav
> <rohit.ya...@shapeblue.com>; Rajani Karuturi <raj...@apache.org>; Daan
> Hoogland <daan.hoogl...@gmail.com>
> Subject: Re: VPC router issue
>
> 6 days ago test_pc_routers.py succeeded with PR 788:
>
> https://github.com/apache/cloudstack/pull/788
>
&
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack/pull/841
Cloudstack 8868: use PasswordGenerator.generateRandomPassword() to generate
systemvm passwords
generateRandomPassword() is supposed to create root user passwords. Right
now it is only used
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/841#issuecomment-140715229
mm.. I really think we should change the way we generate password both for
uservms and systemvms. May be would could track that separately and for now
increase
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/841#issuecomment-140696212
should we add another global setting for systemvm password length (like
vm.password.length for uservms) and use it to generate systemvm passwords?
---
If your
I agree. Most of the blockers we see now are VR related.
~Rajani
On 16-Sep-2015, at 10:15 am, Raja Pullela wrote:
> I agree with jayapal, so far none of the BVTs for the hypervisors are at 100%
> except for the simulator's.
> Also, changes/refactoring some of the
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/833#issuecomment-140628293
Thanks guys. Will merge in sometime.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
-Sep-2015, at 9:59 am, Rajani Karuturi <rajani.karut...@citrix.com>
> wrote:
>
> Anyone understands why this is failing?
>
>
> ~Rajani
>
>
>
> On 15-Sep-2015, at 3:23 am, jenk...@cloudstack.org wrote:
>
> See <http://jenkins.buildacloud.org/job/bu
Rohit,
Can you review https://github.com/apache/cloudstack/pull/833 ?
Thanks,
~Rajani
On Tue, Sep 15, 2015 at 12:45 PM, Rajani Karuturi <raj...@apache.org> wrote:
> ok. thanks. I will attempt a fix.
>
> ~Rajani
>
> On Tue, Sep 15, 2015 at 11:34 AM, Rohit Yadav <r
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack/pull/833
changed the systemvm base iso file from debian-7.8.0 to debian-7.9.0
7.8.0 url is not available(404 Error)
This fixes the jenkins
http://jenkins.buildacloud.org/job/build-systemvm
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/833#issuecomment-140460941
I really dont know the implications of change it from debian-7.8.0 to
debian-7.9.0. If there is a better fix available, please advise.
---
If your project is set
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/819#issuecomment-140053317
No direct commits to master. all the commits to master should be merges.
I earlier reverted and merged a PR. Please check the comments on PR #728
and merge
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/819#issuecomment-140053426
I am reverting this direct commit. Please reopen the PR and use the git pr
script to merge
---
If your project is set up for it, you can reply to this email
Done.
~Rajani
On 14-Sep-2015, at 3:58 pm, Suresh Kumar Anaparti
wrote:
> Hi,
>
> I wanted to add some design documentation to wiki. Please grant me edit
> permissions. My ID: sureshkumar.anaparti.
>
> Thanks,
> Suresh
>
Anyone understands why this is failing?
~Rajani
On 15-Sep-2015, at 3:23 am, jenk...@cloudstack.org wrote:
> See <http://jenkins.buildacloud.org/job/build-systemvm-master/624/changes>
>
> Changes:
>
> [Rajani Karuturi] CLOUDSTACK-8816 Fixed entityUuid missing in so
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/793#issuecomment-139980724
you are decreasing the code coverage with these changes. especially with
interface changes and new methods, I think unittests should
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/793#discussion_r39365314
--- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java ---
@@ -1046,4 +1046,51 @@ private VmWorkJobVO createPlaceHolderWork(long
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/802#issuecomment-139974582
@anshul1886 next time, please specify the bug id in the commit message
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/802#issuecomment-139974159
merging..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/793#issuecomment-140003171
@anshul1886 I do not agree to your statement and hence I already tried to
explain what you can test in this piece of code. If you still dont get it(or
dont want
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/795#discussion_r39372256
--- Diff:
services/secondary-storage/server/src/org/apache/cloudstack/storage/template/DownloadManagerImpl.java
---
@@ -382,7 +424,7 @@ private String
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/782#issuecomment-139958046
Thanks for the review guys. Two LGTMs mergins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/810#issuecomment-139969167
builds were aborted probably because the PR was merged.
This PR is properly merged to master with below commits
* | | 120e1cc Merge pull request #810
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/808#issuecomment-139957981
@DaanHoogland the repeated code is two lines calling sendalert and logger.
may be we could move the logging to send alert itself. Will check that later
slow build is broken due to a new findbugs warning
I think its not really new but, its reported maybe because of some
reformatting.
It maybe due to changes from commit
1c6378ec0056e8c75990a4a0c15e99b2df162a75 and PR 795
@borisroman @widodh can you take a look at the slow build please?
~Rajani
On
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/728#issuecomment-139586066
I reverted the directed commit and merged this pr.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack/pull/807
unittests to verify empty password is not allowed during account/user create
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/karuturi
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack/pull/808
CLOUDSTACK-8835: Added alerts incase of template download failure
Authored-By: @sanjaytripathi
Reviewed-By: Devdeep
You can merge this pull request into a Git repository by running
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/728#issuecomment-139582425
Hi @sanju1010 please use git-pr script to merge pull requests. Its in the
source code at tools/git/git-pr
Here is a doc on how to use it
https
Did you login to ACS jira? Its visible only after login.
~Rajani
On Thu, Sep 10, 2015 at 5:24 PM, Wilder Rodrigues <
wrodrig...@schubergphilis.com> wrote:
> Hi Remi,
>
> I went to the Dashboard but the message I got was:
>
> No matching issues<
>
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/796#issuecomment-139215606
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/780#discussion_r39122432
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -4662,8 +4663,14 @@ private
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/780#issuecomment-139109578
I see tests only for LibrvirtResource. They are missing for StatsCollector,
CitrixResourceBase, VmwareResource
---
If your project is set up for it, you can reply
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/780#discussion_r39122397
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
---
@@ -189,6 +190,7 @@
private long
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/780#discussion_r38916972
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
---
@@ -2981,11 +2985,16 @@ public VmStatsEntry
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/780#discussion_r38917202
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -4663,7 +4663,7 @@ private
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/780#discussion_r38917337
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -4751,7 +4760,7 @@ private
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/685#issuecomment-138771684
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/768#issuecomment-138774846
There is a FS here
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Quota+Service+-+FS
---
If your project is set up for it, you can reply to this email
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/779#issuecomment-138214857
Thanks everyone for the quick merge :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
and then run this new
container in daemon mode.
Register the user with curl (we need to change that).
Install awscli and configure it, giving it the CloudStack keys and set the
signature version to 2.
This should work. If it does not, it’s probably an issue with how you configure
the cloudstack end
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/765#issuecomment-138238373
@miguelaferreira @wilderrodrigues waiting for the PR merge :)
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack/pull/781
Fixed issue: UI labels are display with key. ex: label.yes
due to missing comma in the jsp, all the labels below it are broken leading
to showing keys instead of strings in UI
You can merge
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/732#issuecomment-138426187
@ustcweizhou this caused a new coverity issue. Can you check?
```
411 SnapshotInfo snapshotOnPrimaryStore =
_snapshotFactory.getSnapshot
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack/pull/782
Cloudstack 8816 entityuuid missing in some of the events
In some of the events generated, entity uuid was missing making it
difficult to find the entity. Fixed the same.
Tested
Can I get two LGTMs for the PR https://github.com/apache/cloudstack/pull/779?
Its a very simple fix and fixes the new findbugs warning.
~Rajani
On Sun, Sep 6, 2015 at 12:11 PM, Remi Bergsma
wrote:
> FYI: talked to Rajani and the findbugs issue will be resolved
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack/pull/779
Fixing findbugs error due to PR #755 merge
issue: Boxing/unboxing to parse a primitive
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/755#issuecomment-137758483
I am merging this as there are two :+1: Let me know if there are any
objections.
---
If your project is set up for it, you can reply to this email and have your
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38731619
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java
---
@@ -52,21 +58,71 @@ public LdapAuthenticator(final
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38732126
--- Diff: server/src/com/cloud/user/AccountManagerImpl.java ---
@@ -2177,6 +2173,7 @@ private UserAccount getUserAccount(String username,
String
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/773#issuecomment-137682596
code :+1: (Busy with something else and cannot test right now)
---
If your project is set up for it, you can reply to this email and have your
reply appear
its in 4.5.2 and will also be in 4.6.0
~Rajani
On Wed, Sep 2, 2015 at 5:33 PM, cs user wrote:
> Hi Folks,
>
> Looks like this is fixed in https://github.com/apache/cloudstack/pull/479
> ?
>
> Which cloudstack release contains this fix?
>
> Many thanks!
>
> On Wed, Sep 2,
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/755#issuecomment-137645397
travis build for the PR is here.
https://travis-ci.org/apache/cloudstack/builds/78567814
for some reason, its not showing it here.
---
If your project is set
tch to work against new version.
- Resolves: rhbz#1235150
Nothing dramatic, though I do not have permission to read those bugzilla
entries.
--
Sent from the Delta quadrant using Borg technology!
Nux!
www.nux.ro
----- Original Message -
From: "Rajani Karuturi" <raj...@apache.or
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/765#issuecomment-136962555
tested this on Xen 6.5 advanced zone with isolated and VPC. verified that
the default policies are set to drop.
I am not sure if its related
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/754#issuecomment-136981967
@bhaisaab There are 2 reviews already. @wido and @miguelaferreira gave :+1:
I think you can merge this and #753
---
If your project is set up for it, you can
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/755#issuecomment-136980464
users are added based on the username. So, in this case LDAP user wont be
added(it will error out). CS user will exist and will continue to work with
earlier
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38512420
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
---
@@ -0,0 +1,114
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38512312
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java
---
@@ -52,21 +58,71 @@ public LdapAuthenticator(final
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/755#issuecomment-137344109
@koushik-das I created two issue for the open items. I will track these
later
https://issues.apache.org/jira/browse/CLOUDSTACK-8797
https
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/765#issuecomment-137048186
Ok. Here is the new issue
https://issues.apache.org/jira/browse/CLOUDSTACK-8795
:+1: for this PR
---
If your project is set up for it, you can reply
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38513021
--- Diff: server/src/com/cloud/user/AccountManagerImpl.java ---
@@ -2145,14 +2145,10 @@ private UserAccount getUserAccount(String username,
String
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38513100
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
@@ -243,4 +263,22 @@ public boolean isLdapEnabled
whats the host and guest os?
~Rajani
On Wed, Sep 2, 2015 at 2:33 PM, anil lakineni <
anilkumar459.lakin...@gmail.com> wrote:
> Hi All,
>
> We are facing boot issues when VMs have DATA drives.
>
>
> *After VM was shut down we were unable to power on server unless we detach
> Data Drive.*
>
> We
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/762#issuecomment-136599746
@rafaelweingartner I see windows line endings in the new test file. Can you
fix that please?
Other than that, LGTM. once thats fixed I will merge
---
If your
Where did you give cloudstack apikey and secret?
Did you give AWS keys both at AWS configure and ec2-register?
~Rajani
On 01-Sep-2015, at 10:16 am, Rohit Yadav
<rohit.ya...@shapeblue.com<mailto:rohit.ya...@shapeblue.com>> wrote:
On 28-Aug-2015, at 4:34 pm, Rajani Karuturi
&
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/762#issuecomment-136640347
since this fixes slow build, I am going to merge this PR and push another
commit for line endings fix.
---
If your project is set up for it, you can reply
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38396925
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
---
@@ -0,0 +1,114
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38397250
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
@@ -189,6 +194,21 @@ public LdapUser getUser(final
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38399252
--- Diff: server/src/com/cloud/user/AccountManagerImpl.java ---
@@ -2145,14 +2145,10 @@ private UserAccount getUserAccount(String username,
String
:50 pm, sebgoa <run...@gmail.com> wrote:
>
> On Sep 1, 2015, at 9:17 AM, Rajani Karuturi <rajani.karut...@citrix.com>
> wrote:
>
>> Where did you give cloudstack apikey and secret?
>> Did you give AWS keys both at AWS configure and ec2-register?
>
> yes
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38396821
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
---
@@ -0,0 +1,114
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38396794
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
@@ -243,4 +263,22 @@ public boolean isLdapEnabled
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38397144
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java
---
@@ -52,21 +58,71 @@ public LdapAuthenticator(final
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38399524
--- Diff: server/src/com/cloud/user/AccountManagerImpl.java ---
@@ -2177,6 +2173,7 @@ private UserAccount getUserAccount(String username,
String
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38400365
--- Diff: server/src/com/cloud/user/AccountManagerImpl.java ---
@@ -2196,6 +2193,11 @@ private UserAccount getUserAccount(String username,
String
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38400169
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java
---
@@ -52,21 +58,71 @@ public LdapAuthenticator(final
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/762#issuecomment-136698602
cat -v filename will show you line endings.
I figured the timezone issue. didnt want to wait for another day with
broken build. hence pushed it.
The recent
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38410923
--- Diff: setup/db/db/schema-452to460.sql ---
@@ -399,3 +399,14 @@ CREATE TABLE `cloud`.`external_bigswitch_bcf_devices` (
CONSTRAINT
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack/pull/763
CLOUDSTACK-8725 RVR functionality is broken in case of isolated networks
conntrackd fails to start.
Rebased with master. This closes #692
You can merge this pull request into a Git
Yes. I did. Can you point me logs or a way to debug?
On Mon, Aug 31, 2015 at 18:46 PM, Sebastien Goasguen <run...@gmail.com>
wrote:
did you do the aws configure ?
aws cli needs to know your keys as well..
> On Aug 28, 2015, at 6:04 PM, Rajani Karuturi <raj...@apache.org
<javas
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack/pull/764
Fix findbugs issue: 76, DM_DEFAULT_ENCODING, Priority: High
ex.printStacktrace prints to System.err by default. Used it and removed
the printwriter which was causing the findbugs issue
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/763#issuecomment-136309843
Thanks @remibergsma. Since this isnt my code, LGTM from me as well(The
actual PR also has 2 LGTMs). merging now
---
If your project is set up for it, you can
rivial and there's always the risk it may not have
> been the java change at all doing this, but I do not know what else could
> have triggered it.
>
> --
> Sent from the Delta quadrant using Borg technology!
>
> Nux!
> www.nux.ro
>
> - Original Message -
>
The below pr would fix the findbugs issue.
https://github.com/apache/cloudstack/pull/764
~Rajani
On Sun, Aug 30, 2015 at 2:59 PM, Daan Hoogland
wrote:
> The job is removed after 10 others are run. Look at
> http://jenkins.buildacloud.org/job/build-master-slowbuild
>
sorry. I didnt see that. Will review 762 and close 764.
~Rajani
On 31-Aug-2015, at 4:21 pm, Daan Hoogland <daan.hoogl...@gmail.com> wrote:
> https://github.com/apache/cloudstack/pull/762 by Rafael, did as well. Let's
> have a run-off ;)
>
> On Mon, Aug 31, 2015 at 11:56 A
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/689#issuecomment-136326696
@bhaisaab lot of code :) .. I will review tomorrow.
Can you review 755 if possible? ;)
---
If your project is set up for it, you can reply to this email
Hi Lucian,
Can you share the point release numbers of java before and after the
upgrade? (May be that would help us find the issue.)
~Rajani
On Mon, Aug 31, 2015 at 3:42 PM, Nux! wrote:
> A downgrade of both java-1.6.0-openjdk and java-1.7.0-openjdk followed by
> a reboot of
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38383999
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
---
@@ -0,0 +1,114
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38384079
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
---
@@ -0,0 +1,114
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38384082
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java
---
@@ -39,6 +39,9 @@
private static final
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/755#issuecomment-136589494
updated the code
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38384161
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
@@ -243,4 +263,22 @@ public boolean isLdapEnabled
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38384124
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
@@ -243,4 +263,22 @@ public boolean isLdapEnabled
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38383968
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
---
@@ -0,0 +1,114
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38384030
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
---
@@ -0,0 +1,114
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38384040
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
---
@@ -0,0 +1,114
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38384226
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
@@ -243,4 +263,22 @@ public boolean isLdapEnabled
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38384216
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
@@ -243,4 +263,22 @@ public boolean isLdapEnabled
Github user karuturi closed the pull request at:
https://github.com/apache/cloudstack/pull/764
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
601 - 700 of 1399 matches
Mail list logo