Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1029#issuecomment-160332029
@ustcweizhou If you want this in 4.6.1, please quickly rebase and resolve
conflict. Then ping me so I can run the integration tests. Thanks!
---
If your
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1136#issuecomment-160332479
LGTM, since the change is in the UI I built that from this branch.
Two checks:
- The metrics feature still works properly
 we freeze for 4.7.0. That
would be a nice time to look back and see if the systemvm template needs to be
bumped
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1112#issuecomment-159179498
Pinging @pdion891 to have a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1109
CLOUDSTACK-9077 Fix injectkeys.sh to work on CentOS7
Fix regression from commit 3381154fafb7fa4f0a61d538f7c2550e48247787
The error seen on CentOS 7:
```
2015-11-20 21
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1051#issuecomment-158752800
LGTM, just to be sure run all integration tests against this branch. They
all passed.
https://cloud.githubusercontent.com/assets/1630096/11323652
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/768#issuecomment-158753409
@abhinandanprateek @bhaisaab @jburwell Hi guys, I want to run soms tests to
see if we can get this in 4.7. As master is on 4.7.0-SNAPSHOT now, please also
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1081#issuecomment-158752938
@DaanHoogland resizing the screen? I didn't test that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1058#issuecomment-158752169
LGTM, based on a set of tests that I run on this branch (which I rebased
myself first). Screenshot is from an experimental Jenkins job (that runs the
same
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1058#issuecomment-158752741
This was merged to 4.6, then to master as it is a security improvement that
applied cleanly.
@bhaisaab You may want to include this in the final 4.5
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1019#issuecomment-158753796
Since the commits changed I run the tests again. Still LGTM.
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1092#issuecomment-158791293
LGTM, all integration tests pass.
. Thanks!
---
If your project is set up
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1075#issuecomment-158668313
LGTM, based on a set of tests that I run on this branch. Screenshot is from
an experimental Jenkins job (that runs the same tests I did manually until
now
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/955#issuecomment-158673310
@SudharmaJain Any update on this? Please respond to the comments, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/944#issuecomment-158673838
Hi @pedro-martins I can run some tests but please remove the merge commit.
Thanks!
---
If your project is set up for it, you can reply to this email and have
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-158675017
Hi @rodrigo93 in the comments above it was suggested to change the commit
title, can you do that please? The commit title is the first line of the commit
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/886#issuecomment-158676481
@borisroman Can you have a look and resolve the conflict? When we find
another reviewer we can merge this in 4.7. Pinging @DaanHoogland @bhaisaab
---
If your
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/866#issuecomment-158676663
Pinging @wilderrodrigues to have a look.
@bvbharatk Is there any (integration) test to test this feature?
---
If your project is set up for it, you can
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1081#issuecomment-158678341
Thanks for the fix @nitin-maharana. Tried it and it works great! LGTM
https://cloud.githubusercontent.com/assets/1630096/11320287/64aad05a-9094-11e5
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/926#issuecomment-158676063
@wido I see some comments above. Not sure if they are all addressed. Can
you please review this and let us know if you are OK with merging? I'll run
soms tests
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1097#issuecomment-158613518
Pinging @milamberspace to have a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1095#issuecomment-158613584
@borisroman Did you build the packages from this branch? Can you share some
details to show it works properly now?
---
If your project is set up for it, you
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1057#issuecomment-158624231
@DaanHoogland It could be a result of another failure. On master this test
passes, so maybe you can run just this test yourself and look at the details
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1057#issuecomment-158613419
@DaanHoogland @rafaelweingartner Much better now, just one failed test to
resolve:
Failed test: `TestVPCRouterOneNetwork`
```
Execute cmd
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1057#issuecomment-158625241
:-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-158615300
Hi @wido can you review this again please? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-158334828
LGTM, based on a set of tests that I run on this branch (which I rebased
myself first). Screenshot is from an experimental Jenkins job (that runs the
same
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/924#issuecomment-158348133
I tried rebasing against current master but I run into build issues. Tried
again but same thing.
@nnesic Could you try rebasing the PR against master
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1089#issuecomment-158338131
@DaanHoogland the tests succeed for me:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true smoke
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1083#issuecomment-158341279
LGTM, based on a set of tests that I run on this branch (which I rebased
myself first). Screenshot is from an experimental Jenkins job (that runs the
same
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1058#issuecomment-158530260
I will run some tests on this branch and report back.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/commit/3381154fafb7fa4f0a61d538f7c2550e48247787#commitcomment-14536914
In scripts/vm/systemvm/injectkeys.sh:
In scripts/vm/systemvm/injectkeys.sh on line 89:
This breaks CentOS7, see
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1038#issuecomment-158021203
@bhaisaab I'm OK with merging this to master now, but that will also mean
it will not end up in 4.6. I think @DaanHoogland already said that no new
features
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1089#issuecomment-158144546
Before merge, I want to retry the two failed tests and see if they work for
me.
---
If your project is set up for it, you can reply to this email and have
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1057#issuecomment-158314116
FYI: @DaanHoogland My tests show 29 test failures. I will retest to be
sure, but please hold until this is done.
---
If your project is set up for it, you can
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1070#issuecomment-158116184
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1090#issuecomment-158117109
Merged to master, cannot merge to 4.6 as it would conflict when forward
merging. It will be in 4.7.
---
If your project is set up for it, you can reply
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1084#issuecomment-158117634
I also agree we shouldn't keep unused files in the active tree. We already
got some PRs against files that were not in use and that is a waste of time
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1072#issuecomment-158053349
LGTM, did an upgrade from `4.4.4` to `4.6.1-SNAPSHOT` and that worked now
with only the `4.6` template registered. This was done with XenServer
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-157680581
LGTM, based on a set of tests that I run on this branch (which I rebased
myself first now that master moved on):
```
nosetests --with-marvin
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-157701917
According to Jenkins the build was fine:
```
Maven: -B -f
/home/jenkins/jenkins-slave/workspace/cloudstack-pull-analysis/pom.xml
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-157681280
Congrats @nlivens @KrisSterckx this is now merged in master and will be
included in 4.7.0. Thanks for all the work to get this in :-)
---
If your project
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-157700801
@nvazquez Can you look at this build failure:
http://jenkins.buildacloud.org/job/build-master-noredist/4746/console
Does the slave need the 5.5 jar
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1079#issuecomment-157670606
Gave LGTM on #1062, extending it here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1060#issuecomment-157411442
@DaanHoogland FYI test results:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1038#issuecomment-157421614
@DaanHoogland Because @bhaisaab wants it in 4.5.3. Otherwise people will
upgrade from 4.5.3 to say 4.6.2 and lose a feature.
---
If your project is set up
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1062#issuecomment-157410651
LGTM, based on a set of tests that I run on this branch (which I rebased
myself first):
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1079#issuecomment-157421231
@wilderrodrigues I want to merge this to 4.6, so the one against master
should be closed. As we merge forward now, we need bug fixes against 4.6.
Otherwise
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1073#issuecomment-157409023
LGTM, based on a set of tests that I run on this branch (which I rebased
myself first):
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1076#issuecomment-157409637
Hi @nitin-maharana thanks for the fix! Please make this pull request
against 4.6, so it can be fixed there as well. Once merged, it will be forward
merged
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1076#issuecomment-157498727
@nitin-maharana You can close this one. When the 4.6 one is merged, it will
be forwarded merged to master automatically.
---
If your project is set up
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-157311229
@KrisSterckx @nlivens Guys, we are ready to merge this into master/4.7 now.
Since it was rebased last some weeks ago, I'll do a quick test run against
current
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/872#issuecomment-157313386
@jayapalu @karuturi Let's get this into 4.7! Can you respond to the
comments please @jayapalu ?
---
If your project is set up for it, you can reply
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/768#issuecomment-157311669
@bhaisaab @abhinandanprateek it would be great to include this in 4.7. Can
you guys rebase it and resolve the conflicts?
@jburwell Can you update your
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-157311867
Would be great to include this in 4.7, please ping me when you're ready!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1071#issuecomment-157168301
LGTM:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1071#issuecomment-157169270
@DaanHoogland @wilderrodrigues @miguelaferreira Can either of you review so
we can merge this and open master for new features?
---
If your project is set up
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1064#issuecomment-156960593
Please close this PR, as will get #1070 in now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1070#issuecomment-156960642
@wilderrodrigues Starting my tests..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1071#issuecomment-156980076
Thanks @karuturi will give it a test-drive soon!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1062#issuecomment-156984813
@dsclose Can you please make this PR against 4.6 branch? After merge it
will be fwd-merged to master. Thanks!
---
If your project is set up for it, you can
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1059#issuecomment-156985363
@ustcweizhou Can you please make this PR against 4.6 branch? After merge it
will be fwd-merged to master. Thanks!
---
If your project is set up for it, you
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1038#issuecomment-156986694
I've run this for some time and it is really cool, thanks @bhaisaab LGTM
If you consider back porting this to 4.5.3, then I think we should also
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1071#discussion_r44907228
--- Diff: build/replace.properties ---
@@ -26,4 +26,4 @@ AGENTLOG=logs/agent.log
MSMNTDIR=/mnt
COMPONENTS-SPEC=components.xml
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1061#issuecomment-156984574
@DaanHoogland Yes, please make this PR towards 4.6 please.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1067#issuecomment-156820839
This is an upgrade from 4.6.0 to 4.6.1:
```
INFO [o.a.c.s.l.CloudStackExtendedLifeCycle] (main:null) Running system
integrity checker
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1064#issuecomment-156827648
@wilderrodrigues Can you please make this PR against 4.6 instead of master?
It will then be included in 4.6.1 and also be merged forward to master
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1067#issuecomment-156812719
@DaanHoogland I rebased it, as it needs the `checkstyle` fix in 4.6.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1067#issuecomment-156821894
Yes, let's stick to the rules :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
501 - 600 of 1275 matches
Mail list logo
