Re: [CLOUDSTACK-212] [Review Request and Test]

2013-07-17 Thread Sebastien Goasguen
On Jul 17, 2013, at 6:13 AM, Dharmesh Kakadia dhkaka...@gmail.com wrote: Can someone commit the changes to namespacechanges branch ? Dharmesh, I tried this morning but there were several errors. I have not had time to look deeper into it. Maybe Chip and John will get to it faster than I

Re: [CLOUDSTACK-212] [Review Request and Test]

2013-07-17 Thread Dharmesh Kakadia
sure. You tried the files attached on reviewboard ? 0001*, 0002* and 0003* ? On Wed, Jul 17, 2013 at 4:04 PM, Sebastien Goasguen run...@gmail.comwrote: On Jul 17, 2013, at 6:13 AM, Dharmesh Kakadia dhkaka...@gmail.com wrote: Can someone commit the changes to namespacechanges branch ?

Re: [CLOUDSTACK-212] [Review Request and Test]

2013-07-17 Thread Sebastien Goasguen
On Jul 17, 2013, at 6:49 AM, Dharmesh Kakadia dhkaka...@gmail.com wrote: sure. You tried the files attached on reviewboard ? 0001*, 0002* and 0003* ? yes On Wed, Jul 17, 2013 at 4:04 PM, Sebastien Goasguen run...@gmail.com wrote: On Jul 17, 2013, at 6:13 AM, Dharmesh Kakadia

Re: [CLOUDSTACK-212] [Review Request and Test]

2013-07-17 Thread Dharmesh Kakadia
thats strange .. I have tried applying that on fresh namespacechanges checkout. On Wed, Jul 17, 2013 at 4:49 PM, Sebastien Goasguen run...@gmail.comwrote: On Jul 17, 2013, at 6:49 AM, Dharmesh Kakadia dhkaka...@gmail.com wrote: sure. You tried the files attached on reviewboard ? 0001*,

[CLOUDSTACK-212] [Review Request and Test]

2013-07-15 Thread Dharmesh Kakadia
Hi, I have completed the namespace changes to org.apache. A single patch was leaving some deleted files behind. I tried to figure out the problem for a day, but didn't get any issue. So I have created 3 different patches and uploaded to the reviewboard (https://reviews.apache.org/r/12198/). I

Re: [CLOUDSTACK-212] [Review Request and Test]

2013-07-15 Thread John Burwell
Dharnesh, I am placing a pre-emptive -1 on this patch merge because I don't feel adequate community awareness/coordination regarding the impact of this change. In particular, I want to make the sure the timing is appropriate since we doing a lot of master-4.2 merges at the moment. This patch

Re: [CLOUDSTACK-212] [Review Request and Test]

2013-07-15 Thread Chip Childers
On Mon, Jul 15, 2013 at 04:30:53PM -0400, John Burwell wrote: Dharnesh, I am placing a pre-emptive -1 on this patch merge because I don't feel adequate community awareness/coordination regarding the impact of this change. In particular, I want to make the sure the timing is appropriate

Re: [CLOUDSTACK-212] [Review Request and Test]

2013-07-15 Thread John Burwell
Chip, I apologize for my lack clarity. I am only -1 for master merge until the community has reviewed the changes and come to consensus on landing the change. I am +1 to push the changes into a dedicated feature branch within the ASF repo.. Thanks, -John On Jul 15, 2013, at 4:34 PM, Chip

Re: [CLOUDSTACK-212] [Review Request and Test]

2013-07-15 Thread Dharmesh Kakadia
juberwell and chip Sorry. I forgot to mention that this patches are for namespace branch. Is this the right way to push changes into feature branch for non-committers ? Thanks, Dharmesh On Tue, Jul 16, 2013 at 2:37 AM, John Burwell jburw...@basho.com wrote: Chip, I apologize for my lack