Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1669
@milamberspace I've started a new ticket to track progress on migration of
transifex to json format: https://issues.apache.org/jira/browse/CLOUDSTACK-9513
---
If your project is set up for it, yo
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1669
With the tests and lgtms, I'll go with merging this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1669
@milamberspace thanks, yes please proceed with changing transifex format
following merge of this PR. I lack experience with Transifex usage, but I can
help with transforming the current messages.p
Github user milamberspace commented on the issue:
https://github.com/apache/cloudstack/pull/1669
@rhtyd Yes LGTM.
Now (and in another PR), I would like work to try to use directly the json
key/value files from Transifex.
---
If your project is set up for it, you can reply to this
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1669
Thanks @milamberspace is that a LGTM?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user milamberspace commented on the issue:
https://github.com/apache/cloudstack/pull/1669
@rhtyd I've just tests successfully the last version of the PR. Now if the
value isn't translate, the default language is display.
---
If your project is set up for it, you can reply to
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1669
@jburwell @milamberspace with the current changes, no explicit change in
workflow is needed but may be change in future. Since the aim of the PR was to
get rid of jsps, I would like to avoid too m
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1669
@jburwell even with change in transifex format [1], some transformation and
conversion of json to a js dictionary would still be needed.
@milamberspace I've fixed the issues now. Please re
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1669
@milamberspace I agree because it appears to remove the need to maintain
the Python compilation script which reduces complexity and doesn't add any more
build time.
---
If your project is set
Github user milamberspace commented on the issue:
https://github.com/apache/cloudstack/pull/1669
@rhtyd in the normal case, if the key label.affinity.groups doesn't exists,
the default language is display ("Affinity Groups" in this case). The PR is a
regression for this case (vs the c
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1669
@rhtyd @milamberspace I have started a conversation on dev@ to discuss
transitioning to the JSON format. Is acceptable to hold this PR until we come
to consensus on that thread?
---
If your
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1669
@milamberspace I've fixed the issues that were raised and few other
unescaped characters I found from the generated l10n js files. The
`label.affinity.groups` translation does not exist in korean
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1669
Thanks @milamberspace I'll fix them, the issues come up due to differences
in how java/jsp urlencoded the translation strings and how the python based
messages.properties->l10n js file converter e
Github user milamberspace commented on the issue:
https://github.com/apache/cloudstack/pull/1669
Not look good to me, I've found these issues:
The quote ' in French UI (and other language using quote) is precede by a
backslash:
.
---
If your project is set up for it, you can reply to this ema
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1669
@milamberspace since this changes the way translations are consumed, would
you help review/test this? Thanks. FYI - this does not change how translation
workflow works.
---
If your project is se
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1669
(I checked debian pkg failed due to dns/name resolution issue).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1669
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you
posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1669
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1669
LGTM, I've checkout the PR, builded it and deployed a simulator zone, then
ran through a few localizations and did exploratory testing in the UI, all seem
to work fine.
---
If your proj
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1669
CloudStack UI used dictionary, dictionary2 and index jsp files.
The dictionary jsp files simply added a dictionary (java script object or
map) by reading through messages properties for va
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1669
LGTM on code review. Another disadvantage of jsp is the compilation. No jsp
will mean smoother transitions to newer java versions.
---
If your project is set up for it, you can reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1669
Thanks @milamberspace I've modified the build process to generate l10n
translation JS (dictionary) files when client/UI is built. I think if we use
json file, then also we will need some sort of t
Github user milamberspace commented on the issue:
https://github.com/apache/cloudstack/pull/1669
@rhtyd Probably the best way will be to change the Transifex L10N resources
files type from Unicode Properties to JSON Key/value
A sample are here:
https://www.transifex.com/ke
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1669
During build step, the l10n JS files are built:
> [INFO] --- exec-maven-plugin:1.2.1:exec (generate-sources) @
cloud-client-ui ---
> Exporting compiled dictionary:
/home/bhaisaab/Lab/
30 matches
Mail list logo
