Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1727
merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@karuturi sure, done! Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@nvazquez Can you resolve conflicts? It might be due to the merge of your
other PR #1747 :)
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@karuturi This one is ready for merging. Two LGTMs + tests passing on all 3
hypervisors
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1727
Trillian test result (tid-817)
Environment: vmware-60u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43428 seconds
Marvin logs:
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1727
Great, thanks @borisstoyanov!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1727
There you go @nvazquez, results should come up in 6-8 hours.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@blueorangutan test centos7 vmware-60u2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + vmware-60u2) has
been kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1727
Thanks @borisstoyanov! Can we test it against Vmware?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1727
Trillian test result (tid-811)
Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40396 seconds
Marvin logs:
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + xenserver-65sp1)
has been kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1727
Sure @serg38
@blueorangutan test centos7 xenserver-65sp1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@borisstoyanov @DaanHoogland @rhtyd KVM tests passed but key smoke test is
skipped
test_change_service_offering_for_vm_with_snapshots Skipped
To be on the safe side can we test it on
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1727
Trillian test result (tid-809)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31586 seconds
Marvin logs:
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has
been kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1727
Packaging result: âcentos6 âcentos7 âdebian. JID-477
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep
you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@DaanHoogland @borisstoyanov @rhtyd Guys can you kick off tests for this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@rafaelweingartner @koushik-das @karuturi
Great, I've re-targeted PR to master branch. Thanks for your help!
---
If your project is set up for it, you can reply to this email and have your
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1727
Perfect @nvazquez
Thanks for all of the hard work ð
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1727
Its an enhancement. It should be for the next major release which is
4.10(on master branch)
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@rafaelweingartner excellent, I added both test cases on
`VMSnapshotManagerTest`, thanks!
@koushik-das thanks for pointing that out, I agree with you that db changes
should be in
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1727
Great job.
I just noticed two possible cases that might be a good idea to write a test
case for.
Test case for method âcreateAndPersistVMSnapshotâ to check when an
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1727
Hi @rafaelweingartner! Thanks a lot for your review! As usual, your
comments are really valuable.
I agree with you on the points you've mentioned and I've refactored the PR
based on them,
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1727
Long time I do not review a PR here. I have to say, @nvazquez , great job!!
@serg38 you read my mind!! I had just started reading @nvazquez PR
description when you called me.
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@koushik-das @rhtyd @rafaelweingartner Can you review changes @nvazquez
put in place? CI tests are good.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1727
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@rhtyd @karuturi Can we run tests on this PR and merge on success ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@serg38 done, I reverted DB changes to `schema-490to4910.sql`, thanks!
@koushik-das thanks for reviewing! I refactored PR according to your review
---
If your project is set up for it, you
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@nvazquez Since 4.9.2 is already released and this is not a bugfix the DB
changes should go to schema-490to4910.sql
---
If your project is set up for it, you can reply to this email and have
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1727
Trillian test result (tid-778)
Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 51612 seconds
Marvin logs:
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been
kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@blueorangutan test centos7 vmware-55u3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1727
Trillian test result (tid-775)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36639 seconds
Marvin logs:
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been
kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1727
Packaging result: âcentos6 âcentos7 âdebian. JID-452
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you
posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@serg38 sure
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@koushik-das @rhtyd This PR now supports custom service offerings. Can you
review and kick off tests?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@koushik-das @rhtyd I pushed changes for supporting custom service
offerings the way @koushik-das and @serg38 proposed
---
If your project is set up for it, you can reply to this email and
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@rhtyd @koushik-das @serg38 thanks, I'll work on second option
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@nvazquez can you look at comments from @koushik-das @serg38 do we have
lgtms on this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1727
Option 2 is definitely better.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1727
Packaging result: âcentos6 âcentos7 âdebian. JID-225
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you
posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@rhtyd Sure, rebased
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@nvazquez can you rebase and fix conflicts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1727
Trillian test result (tid-320)
Environment: kvm-centos6 (x2), Advanced Networking with Mgmt server 7
Total time taken: 28892 seconds
Marvin logs:
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been
kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1727
Packaging result: âcentos6 âcentos7 âdebian. JID-150
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you
posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1727
Trillian test result (tid-294)
Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37155 seconds
Marvin logs:
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@rhtyd I refactored `test_vm_snapshots.py` file. As it is in the first
test, KVM, hyperv and lxc will be excluded for new test. Specifically about
running it on Vmware, most tests on this file
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been
kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@nvazquez thanks, I'll kick another one against vmware
@blueorangutan test centos7 vmware-55u3
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@rhtyd thanks for running tests. Looking at blueorangutan we realized that
new marvin test should exclude some hypervisors that don't allow vm snapshots,
in this case was KVM:
```
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1727
Trillian test result (tid-278)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 26230 seconds
Marvin logs:
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been
kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you
posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1727
Thanks @nvazquez I'll kick some tests
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@ustcweizhou @koushik-das thanks for your review! I refactored based on
your comments and tested everything is working as expected.
To test new marvin test introduced in
69 matches
Mail list logo
