Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/908#issuecomment-146758439
Nice test, @remibergsma ! Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/908
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/908#issuecomment-146717853
LGTM. Deployed an environment with this branch and it seems to work fine.
The same tests also pass here, then tried to test something different. Deployed
two VPC
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/908#issuecomment-146662704
Hey @remibergsma
Any news on the tests? Would be nice to get this PR through before I push
the next PR, that one that fix the
https://issues.apache
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/908#issuecomment-146543961
tl;dr LGTM :+1:
@wilderrodrigues @remibergsma @karuturi I have ran the tests overnight last
night. Same specs as Wilder, so I haven't tested xen, vmware,
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/908#issuecomment-146520030
ping @remibergsma @DaanHoogland @borisroman @wido @bvbharat @karuturi
@bhaisaab @miguelaferreira
Anyone that could give a second LGTM to this PR? We
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/908#issuecomment-146215230
Test environment:
* Management Server + MariaDB on CentOS 7.1
* 2 KVM hosts on CentOS 7.1
Tests results:
```
Test router int
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/908#issuecomment-146148340
Hi @remibergsma @bvbharat @karuturi @DaanHoogland @borisroman @wido
@miguelaferreira
The VRRP code is again compliant with RVR and r-VPC, I just ref
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/908#issuecomment-145473615
Hi @remibergsma and @bvbharat,
Please have a look at my comment from 2 days ago. I mentioned that indeed
the change would create a regression. So thi
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/908#issuecomment-145441458
@remibergsma
Hi,
I see that currently we invoke the main function of configure.py every time
we call the update_config when a new config to vr is pus
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/908#issuecomment-145237254
Guys,
There is also a glitch with the test_vpc_redundant.py: it was expected to
fail on the new test_routes, because the default route is broken on R
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/908#discussion_r41087982
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsRedundant.py ---
@@ -96,7 +96,8 @@ def _redundant_on(self):
d = s.repl
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/908#issuecomment-145233418
Hi @remibergsma @borisroman @DaanHoogland @miguelaferreira @wido @runseb ,
I did the following manual tests:
1. Create a redundant network of
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/908#issuecomment-145230344
Hi @remibergsma @borisroman @DaanHoogland @miguelaferreira
I executed the RVR test here, see results below:
```
Test redundant router in
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/908#issuecomment-145210488
Hi @borisroman
Yes, agree on the cleanup, I mentioned in the PR that it was broken.
Since I'm working on improving the tests, I will create
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/908#discussion_r41084587
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsRedundant.py ---
@@ -96,7 +96,8 @@ def _redundant_on(self):
d = s.
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/908#discussion_r4105
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsRedundant.py ---
@@ -96,7 +96,8 @@ def _redundant_on(self):
d = s.repl
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/908#issuecomment-145079681
@wilderrodrigues I've ran the same tests as you proposed. On Centos KVM
hosts. Resulting in success besides the same exceptions. So that's :+1: LGTM
Rega
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/908#issuecomment-144969500
Ping @remibergsma @DaanHoogland @karuturi @miguelaferreira @borisroman
@wido
Test environment:
* One ACS Management Server running on CentO
GitHub user wilderrodrigues opened a pull request:
https://github.com/apache/cloudstack/pull/908
CLOUDSTACK-8915 - Cannot SSH into VMs deployed Redundant VPC routers
In order to reproduce the problem, I did the following
* Create a Redundant VPC
* Add a tier
* Add a
20 matches
Mail list logo
