Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/960#issuecomment-151455578
@pvr9711 There are so many things to do for 4.6, do you really want _me_ to
send a PR for moving a file? Please send it yourself, and both @miguelaferreira
and
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/960#issuecomment-151584850
@nitt10prashant @pvr9711 please close this thread I will take care of
moving the file
---
If your project is set up for it, you can reply to this email and have
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/960#issuecomment-151720250
based on discussion closing the PR
Thanks @remibergsma @runseb @miguelaferreira @pvr9711 for great discussion
.
---
If your project is set up for it,
Github user nitt10prashant closed the pull request at:
https://github.com/apache/cloudstack/pull/960
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user pvr9711 commented on the pull request:
https://github.com/apache/cloudstack/pull/960#issuecomment-151071811
+1 move this test out of BVTs - this was brought up on almost 3-4 weeks
ago.
@runseb - I guess, my understanding is - we need 100% passrate on all BVTs
- we
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/960#issuecomment-150535530
Who's going to propose a PR that moves the test? Then we're done and can
focus on getting 4.6 released!
---
If your project is set up for it, you can reply to
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/960#issuecomment-150501158
@runseb
"I personally fail to see the benefit of skipped tests versus a failed test"
If i may ,
skip is a type of failure where you know in
Github user pvr9711 commented on the pull request:
https://github.com/apache/cloudstack/pull/960#issuecomment-150153497
LGTM - skipping testing is designed with a purpose and this is exactly we
should be using it for. As a as person running/maintaining the tests, someone
would have
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/960#issuecomment-150141365
We have had a lengthy discussion about this on the mailing list. I didn't'
agree that skipping tests is better than excluding them from a test run.
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/960#issuecomment-150178317
I think you guys agree on the problem but disagree on the solution.
To me 100% success on BVT, if it includes ~20% (or whatever percentage) of
skipped tests is
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/960#issuecomment-150185163
The directory in which a test lives is irrelevant to me, so I would also +1
a PR that moves this to another directory.
---
If your project is set up for
Github user pvr9711 commented on the pull request:
https://github.com/apache/cloudstack/pull/960#issuecomment-150168452
@miguelaferreira - we have discussed this on an earlier email. as Prashant
said, In this case a test case is skipped because the setup does not have the
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/960#issuecomment-150169879
Does 100% pass rate when some of the tests have been skipped mean more than
100% pass rate when the same tests have been excluded?
I only hear about
Github user pvr9711 commented on the pull request:
https://github.com/apache/cloudstack/pull/960#issuecomment-150171997
@miguelaferreira 100% passrate on the BVTs - if there are skipped cases you
should/want to find out why they are getting skipped and fix them. If you are
skipping
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/960#issuecomment-150161922
@miguelaferreira i was going though mail thread and found this
"I think the test should fail if the config is not right, or otherwise be
excluded if
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/960#issuecomment-150162817
@nitt10prashant I rather not skip at all. There are just too many examples
of tests being skipped and people not reviewing the output. And that's not even
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/960#issuecomment-150032083
pinging @miguelaferreira
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user nitt10prashant opened a pull request:
https://github.com/apache/cloudstack/pull/960
CLOUDSTACK-8975:skip test case if niciraNvp settings are not available in
config file
root/cloudstack/test/integration/smoke/test_nicira_controller.py is failing
if niciraNvp settings
18 matches
Mail list logo
