Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-170073454
Many thanks for the help everyone!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/943
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-161555776
LGTM, ran the tests as well and reviewed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-161552200
@DaanHoogland @rafaelweingartner The failed expunge test was a false alarm
due to our testing environment. It passes again now. Please ping me when
there's anoth
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-161551497
LGTM as these integration tests still pass:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/943#discussion_r46455242
--- Diff: server/test/async-job-component.xml ---
@@ -108,11 +108,7 @@
--- End diff --
@bhaisaab , p
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/943#discussion_r46436064
--- Diff: server/test/async-job-component.xml ---
@@ -108,11 +108,7 @@
--- End diff --
Not sure about this, a
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-161077855
I ran #942 with a slimmed down version of the test file containing only the
expunge test with a factor of 9. I will do some looking into 943 now and edit
the te
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-161066414
That is odd, because the log you sent me earlier, the VM was marked as
destroyed, so it was just a matter of executing the expunge thread. Is it
possible f
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-161060067
@rafaelweingartner I tested #942 with the setting of expunge * 6 but the
same test still failed on that PR. I am convinced it has nothing to do with the
code of
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-161048740
Oh sorry, I do not know why, but I thought it was perl.
Well, if those configurations parameter are being taken from the MS, they
are not importan
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-161045285
@rafaelweingartner it is python not perl :) it is being read from the ms,
and for the proper execution of the test it is not important what exactly it
is, is it
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-161043712
@DaanHoogland with your explanation I now understand that we want to test
if the expunge thread is being executed and if it is doing its job. Therefore,
I
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-161027097
@rafaelweingartner I agree with you in general lines. In this case the test
had not just succeeded so far, it also started failing a lot since a few days.
So so
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-160966699
@DaanHoogland,
I checked the logs you sent me.
The VMs were marked as destroyed, but it seems that they have not been
âdestroyedâ or remov
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-160895245
[943.vm.results.txt](https://github.com/apache/cloudstack/files/48256/943.vm.results.txt)
Here's the test that fails. It failed the second time as well. I wo
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-160884629
@rafaelweingartner @rodrigo93 my bad I was merging against 4.6, not master.
So far it has 0ne failure. I think it is a false positive so I am rerunning
that tes
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-160714102
@DaanHoogland Can you tell us where the conflict is? It seems ok to me.
---
If your project is set up for it, you can reply to this email and have your
reply appea
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-160705037
@DaanHoogland , where did you see the merge conflict Daan ? I did not find
it.
---
If your project is set up for it, you can reply to this email and have
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-160704405
there is a merge conflict @rodrigo93 . can you resolve it please?
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-160323858
Hi guys.
Sorry for the delay. Thank you all for helping me out. I had some personal
problems.
My bad.
Thanks once again! I hope this commit will help in
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-160321659
looks good, waiting on jenkins and will ask @remibergsma to schedule
integration tests.
---
If your project is set up for it, you can reply to this email and h
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-160297495
@Daanhooglan, I got your point.
So, what about if we just fix the reference for that class in
âasync-job-component.xmlâ. We could also remove the re
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-160294766
@rodrigo93 Jenkins can not merge this to master. please have a look.
---
If your project is set up for it, you can reply to this email and have your
reply appea
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-160294688
I am not sure if this allocator is used any where. As it is injected by
it's interface StoragePoolAllocator, it will be a choice to use from a list. It
is likel
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-160291603
PR rebased and commits squashed for @rodrigo93
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-158790894
Hi @remibergsma. Thanks for the reminding! I was merging that commit with
that actual master and I forgot to put the title in the commit.
I have fixed that alre
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-158675017
Hi @rodrigo93 in the comments above it was suggested to change the commit
title, can you do that please? The commit title is the first line of the commit
message
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-158671944
PR merged with master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
29 matches
Mail list logo
