Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-190330196
Hi @remibergsma no, I didn't try VPC. I meant to adjust shared network
handling, technically any isolated stuff including VPC would be affected. But I
can help you
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-190320208
Hi @nvazquez, when we run this in production weird stuff started to happen.
This happened with VPCs that have a private gateway attached. It seemed to get
confu
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1094
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-167536985
@miguelaferreira I see no issues so LGTM (no integration tests done!)
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-167517043
@DaanHoogland @remibergsma (cc @nvazquez) can we merge this PR before
master drifts away again?
---
If your project is set up for it, you can reply to this
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-167362106
@nvazquez the job has not rerun, but as far ad I can see it is alright.
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-167362000
@DaanHoogland I see that all checks have passed, what is it failing?
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-167352928
hm, that didn't work, strange it worked for me. another option would be to
force push. If you feel the extra run is needed you can try that. This looks
like a
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-167347304
@DaanHoogland Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user nvazquez closed the pull request at:
https://github.com/apache/cloudstack/pull/1094
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user nvazquez reopened a pull request:
https://github.com/apache/cloudstack/pull/1094
CLOUDSTACK-9074: Support shared networking in NiciraNVP Plugin
JIRA TICKET:
https://issues.apache.org/jira/browse/CLOUDSTACK-9074
Design Document:
https://cwiki.apache.org
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-167333295
@nvazquez If you open/close this PR it should build again at builds.a.o.
The job should now be fully functional.
---
If your project is set up for it, you can
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-167213650
btw the reason is that rat.txt was deleted if it succeeded by the next
build step (mvn clean)
---
If your project is set up for it, you can reply to this emai
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-167212533
@remibergsma (and others) I will continue to look at this. It has kind of a
long and irregular round trip sorry for the inconvenience.
---
If your project is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-167155923
@DaanHoogland Jenkins failed due to this (missing artifact). Any hint on
the cause?
```
Archiving artifacts
ERROR: No artifacts found that match the
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-167150961
@remibergsma Thanks a lot Remi! I rebased with master, moved sql to 4.8.0
schema and pushed it again.
@miguelaferreira Thanks a lot for your help and your effor
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-167149518
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-167148441
Nice work guys!
@nvazquez This will be merged to master, which is now at `4.8.0-SNAPSHOT`.
Can you please rebase with master, and move your SQL change t
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r48416674
--- Diff:
api/src/com/cloud/network/guru/NetworkGuruAdditionalFunctions.java ---
@@ -0,0 +1,12 @@
+package com.cloud.network.guru;
--- End diff
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r48415371
--- Diff:
api/src/com/cloud/network/guru/NetworkGuruAdditionalFunctions.java ---
@@ -0,0 +1,12 @@
+package com.cloud.network.guru;
--- End d
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-167114866
@miguelaferreira the report says
api/src/com/cloud/network/guru/NetworkGuruAdditionalFunctions.java doesn't
contain a known license
---
If your project is se
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-167111401
@DaanHoogland I can't figure out why the rats build is failing. Can you
please help us?
---
If your project is set up for it, you can reply to this email a
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-167105359
I've tested this PR with the additional
[commits](https://github.com/nvazquez/cloudstack/pull/1) that I've requested to
be merged here.
My environm
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r48408287
--- Diff: tools/marvin/marvin/lib/base.py ---
@@ -3876,7 +3876,12 @@ def add(cls, apiclient, services, physicalnetworkid,
else:
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r48029359
--- Diff: tools/marvin/marvin/lib/base.py ---
@@ -3876,7 +3876,12 @@ def add(cls, apiclient, services, physicalnetworkid,
else:
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-164169523
Thanks for the instructions @serg38
I will attempt to reproduce this early this week.
---
If your project is set up for it, you can reply to this
Github user serg38 commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-163684761
Assuming everything else is ready e.g. service controllers, transport zone,
management server, STT tunnels in-between then to create L2 gateway (page 89 of
the User
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-163586170
@nvazquez I suggested to add the config to the test itself, but I gave it
some more thought and I agree with you that the test should just assume the
config
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-163383576
@miguelaferreira configuration needed is very complicated, I could not be
able to include it on
test/integration/plugins/test_nicira_controller.py, tests added
as
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-163373604
ping @remibergsma would be great to test this new functionalities
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-163343002
@nvazquez OK, check! No problem. Just let me know when you're ready and
I'll run some more tests.
---
If your project is set up for it, you can reply to this e
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-162990802
@remibergsma my mistake, I meant to modify schema-460to470.sql
and schema-461to470.sql but not
setup/db/db/schema-410to420-cleanup.sql as I did.
I'll push some
Github user serg38 commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-162532791
This index comes from schema-40to410.sql:
CREATE TABLE `cloud`.`nicira_nvp_router_map` (
`id` bigint unsigned NOT NULL AUTO_INCREMENT COMMENT 'id',
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-162342223
Guys, I cannot build a cloud from this branch any more. The build itself
works, but the database deployment gives an SQL error: `Can't DROP
'logicalrouter_uuid'
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-162321883
@serg38 I will use CIDR 1 and disconnect the switch from the router, to se
if that works. I haven't' seen any think left behind after testing. That is,
the
Github user serg38 commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-162319994
Since you are testing L3 connectivity existing switch patch to router
shouldn't overlap an ip range used by the new subnet. Cidr #1 should work fine
. You might also
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-162302939
@nvazquez I've been able to verify that the existing tests did not break
with your PR, however I can't seem to get an NSX configuration for running the
two
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-162211138
I'm finishing my own test, and will test this PR asap.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-162187421
Hi @remibergsma @miguelaferreira
I've been working in marvin test file to cover this new features, those are
test03 y test04 in test/integration/smoke/tes
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-162054941
@nvazquez @miguelaferreira Hi Guys, do you think you can finish this PR on
Monday so we can include it in 4.7? Would be nice :-) Let me know if you need
help.
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-161320788
Sure, I couldn't find you mail address, mine is in my profile
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-161317452
I'm working on adding a new test case to the test file we already have, but
unfortunately I don't know how to cover your change. What I do know is how
marvi
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-161315034
Thanks @miguelaferreira I really appreciate that! Thanks a lot for your
help!
I'll try to make it before the deadline. I'm not that into Python but I'll
do my
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-161235643
@nvazquez I have one more request for you, and (if you agree, of course)
that should be the end of it on a code level. With the marvin test then this
would
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46392407
--- Diff:
plugins/network-elements/nicira-nvp/src/main/java/com/cloud/network/resource/wrapper/NiciraNvpConfigureSharedNetworkUuidCommandWrapper.java
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46391389
--- Diff:
plugins/network-elements/nicira-nvp/src/main/java/com/cloud/network/element/NiciraNvpElement.java
---
@@ -239,8 +244,51 @@ public bool
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-161048814
@miguelaferreira besides fixing these issues and writing marvin test, what
else would be needed to include this feature in version 4.7? Would it be
possible, or co
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46306167
--- Diff:
plugins/network-elements/nicira-nvp/src/main/java/com/cloud/network/element/NiciraNvpElement.java
---
@@ -239,8 +244,51 @@ public boolean imp
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46287923
--- Diff:
plugins/network-elements/nicira-nvp/src/main/java/com/cloud/network/resource/wrapper/NiciraNvpConfigureSharedNetworkUuidCommandWrapper.java
---
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46265732
--- Diff:
api/src/com/cloud/network/guru/NetworkGuruAdditionalFunctions.java ---
@@ -0,0 +1,12 @@
+package com.cloud.network.guru;
+
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46264185
--- Diff: api/src/com/cloud/network/Networks.java ---
@@ -251,6 +252,10 @@ public static URI fromString(String candidate) {
i
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46263781
--- Diff: api/src/com/cloud/network/Networks.java ---
@@ -251,6 +252,10 @@ public static URI fromString(String candidate) {
i
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46159749
--- Diff: api/src/com/cloud/network/Networks.java ---
@@ -251,6 +252,10 @@ public static URI fromString(String candidate) {
if
(com
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46148362
--- Diff: setup/db/db/schema-461to470.sql ---
@@ -18,3 +18,5 @@
--;
-- Schema upgrade from 4.6.1 to 4.7.0;
--;
+
+ALTER TABLE `clo
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46148337
--- Diff: setup/db/db/schema-460to470.sql ---
@@ -18,3 +18,5 @@
--;
-- Schema upgrade from 4.6.0 to 4.7.0;
--;
+
+ALTER TABLE `clo
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46148014
--- Diff:
api/src/com/cloud/network/guru/NetworkGuruAdditionalFunctions.java ---
@@ -0,0 +1,12 @@
+package com.cloud.network.guru;
+
+import
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-160636372
@miguelaferreira thanks for reviewing! Sure, would be great to discuss them
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46115019
--- Diff: setup/db/db/schema-460to470.sql ---
@@ -18,3 +18,5 @@
--;
-- Schema upgrade from 4.6.0 to 4.7.0;
--;
+
+ALTER TAB
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46115024
--- Diff: setup/db/db/schema-461to470.sql ---
@@ -18,3 +18,5 @@
--;
-- Schema upgrade from 4.6.1 to 4.7.0;
--;
+
+ALTER TAB
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-160545614
@nvazquez I've just read through you code and I made some comments that I
would be happy to discuss with you.
Nice to see effort being put in unit t
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46114822
--- Diff: setup/db/db/schema-460to470.sql ---
@@ -18,3 +18,5 @@
--;
-- Schema upgrade from 4.6.0 to 4.7.0;
--;
+
+ALTER TAB
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46114825
--- Diff: setup/db/db/schema-461to470.sql ---
@@ -18,3 +18,5 @@
--;
-- Schema upgrade from 4.6.1 to 4.7.0;
--;
+
+ALTER TAB
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46114748
--- Diff:
plugins/network-elements/nicira-nvp/src/main/java/com/cloud/network/resource/wrapper/NiciraNvpConfigureSharedNetworkVlanIdCommandWrapper.ja
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46114722
--- Diff:
plugins/network-elements/nicira-nvp/src/main/java/com/cloud/network/resource/wrapper/NiciraNvpConfigureSharedNetworkVlanIdCommandWrapper.ja
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46114716
--- Diff:
plugins/network-elements/nicira-nvp/src/main/java/com/cloud/network/resource/wrapper/NiciraNvpConfigureSharedNetworkUuidCommandWrapper.java
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46114701
--- Diff:
plugins/network-elements/nicira-nvp/src/main/java/com/cloud/network/resource/wrapper/NiciraNvpConfigureSharedNetworkUuidCommandWrapper.java
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46114646
--- Diff:
plugins/network-elements/nicira-nvp/src/main/java/com/cloud/network/guru/NiciraNvpGuestNetworkGuru.java
---
@@ -102,11 +112,11 @@ publ
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46114312
--- Diff:
plugins/network-elements/nicira-nvp/src/main/java/com/cloud/network/element/NiciraNvpElement.java
---
@@ -239,8 +244,51 @@ public bool
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46114230
--- Diff:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
---
@@ -671,8 +672,19 @@ public void
doI
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46114108
--- Diff: api/src/org/apache/cloudstack/api/response/NicResponse.java ---
@@ -102,6 +102,14 @@
@Param(description = "Id of the vm to whic
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46114122
--- Diff: api/src/org/apache/cloudstack/api/response/NicResponse.java ---
@@ -102,6 +102,14 @@
@Param(description = "Id of the vm to whic
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46114035
--- Diff:
api/src/com/cloud/network/guru/NetworkGuruAdditionalFunctions.java ---
@@ -0,0 +1,12 @@
+package com.cloud.network.guru;
+
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46113829
--- Diff:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
---
@@ -671,8 +672,19 @@ public void
doI
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46113758
--- Diff:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
---
@@ -671,8 +672,19 @@ public void
doI
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46113707
--- Diff: api/src/com/cloud/network/Networks.java ---
@@ -251,6 +252,10 @@ public static URI fromString(String candidate) {
i
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-160391354
@miguelaferreira @wilderrodrigues Can one of you review this? Once done, I
can run the integration tests again.Thanks!
---
If your project is set up for it, yo
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-159634391
@remibergsma thanks Remi, I rebased to master branch and resolved a few
conflicts
---
If your project is set up for it, you can reply to this email and have your
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-159592539
@nvazquez Ai, there is a conflict now. Could you please have a look?
---
If your project is set up for it, you can reply to this email and have your
reply appea
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-159007416
Thanks @remibergsma !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-158334828
LGTM, based on a set of tests that I run on this branch (which I rebased
myself first). Screenshot is from an experimental Jenkins job (that runs the
same tests
GitHub user nvazquez opened a pull request:
https://github.com/apache/cloudstack/pull/1094
CLOUDSTACK-9074: Support shared networking in NiciraNVP Plugin
JIRA TICKET:
https://issues.apache.org/jira/browse/CLOUDSTACK-9074
Design Document:
https://cwiki.apache.org/c
81 matches
Mail list logo
