[GitHub] cloudstack pull request: Load mysql driver before connecting to db

2015-11-03 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/950#issuecomment-153468603 @borisroman That's what I thought, but no, the `common.loader` property (in [0] is not what does the trick). I've tried that too and that did not work, not b

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

2015-11-03 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/950#issuecomment-153396280 @miguelaferreira Shame, though I understand ;). Just for reference; here it loads the mysql-connector-jar [0]. It is loaded before the main app because it's in th

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

2015-11-03 Thread miguelaferreira
Github user miguelaferreira closed the pull request at: https://github.com/apache/cloudstack/pull/950 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

2015-11-03 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/950#issuecomment-153390623 @remibergsma @borisroman I'm closing this PR since I've been able to figure out how the mysql driver is being loaded in the RPM install. It happens that it's

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

2015-11-03 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/950#issuecomment-153289366 I've searched the legal section of Apache's JIRA and found several posts about including GPL licensed products in builds and test runs. One in particular (ht

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

2015-11-03 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/950#issuecomment-153287336 That seems to be LGPL and as such not allowed by apache policy: http://www.apache.org/legal/resolved.html The issue to me is more on where do the res

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

2015-11-03 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/950#issuecomment-153286535 @miguelaferreira @remibergsma Would this be of any help? https://mariadb.com/kb/en/mariadb/about-mariadb-connector-j/ It has a GNU license. Are there any

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

2015-11-02 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/950#issuecomment-153259670 Hi @borisroman The travis buld fails ont he unit tests because it would need the developer profile (`-Pdeveloper`) in this line https://github.com/

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

2015-11-02 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/950#issuecomment-153174098 @miguelaferreira Could you look at this again? It would be nice to have it in! --- If your project is set up for it, you can reply to this email and have your re

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

2015-10-26 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/950#issuecomment-151057998 It's already included as a dependency in the `noredist` profile. This PR includes it as a dependency in the `developer` profile, and forces the MySQL driver

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

2015-10-26 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/950#issuecomment-151055701 Can't we include it as dependency? Or are there licencing issues? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

2015-10-26 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/950#issuecomment-151050165 The erros, travis and Jenkins report are due to missing mysql connector jar. Shall I make Travis build with the developer profile (i.e. `-Pdeveloper`)? Or ju

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

2015-10-25 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/950#issuecomment-151037118 @miguelaferreira Can you please have a look why both Travis and Jenkins are unhappy again? Thx! --- If your project is set up for it, you can reply to this emai

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

2015-10-25 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/950#issuecomment-150900045 @borisroman @remibergsma I've rebased on latest master and force pushed it --- If your project is set up for it, you can reply to this email and have your re

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

2015-10-23 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/950#issuecomment-150670213 @miguelaferreira Could you force push your commit again? So we're all green? :) --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

2015-10-23 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/950#issuecomment-150638411 LGTM, build several times and it succeeds. The resulting war now works in tomcat, which is awesome. --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

2015-10-23 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/950#issuecomment-150638131 @ke4qqq Are you OK with including it in the Developer profile as well. This obviously is not the default build. This would allow for war drop deployments in tomc

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

2015-10-21 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/950#issuecomment-149911276 Right. I'm including the dependency in the `developer` profile. And by the way the dependency is already included in the `noredist` profile. --- If your pro

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

2015-10-21 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/950#issuecomment-149839957 @miguelaferreira I think that is without specifying -P. You only include it in the developer profile, right? --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

2015-10-19 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/950#issuecomment-149296878 What do you mean by the default build? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

2015-10-19 Thread ke4qqq
Github user ke4qqq commented on the pull request: https://github.com/apache/cloudstack/pull/950#issuecomment-149296707 There's a reason why the MySQL connector is not a dependency - it is Cat-X licensed, which means we may not depend on it in the default build. --- If your project i

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

2015-10-19 Thread miguelaferreira
GitHub user miguelaferreira opened a pull request: https://github.com/apache/cloudstack/pull/950 Load mysql driver before connecting to db When deploying ACS as a WAR file in a vanilla tomcat installation, I always get an error reporting that the JDBC driver for MySQL can't be found