Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/233#issuecomment-102951817
Hi @kishankavala,
I will have a look at that, although that's pretty weird since I have
tested on a KVM environment as well. Don't see why the bean
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/233#issuecomment-102954888
Hi @karuturi,
I had a look and it has more to do with the hard coded paths in the code
(which were already present) and the setup of the machine
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/233
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/233#issuecomment-101586755
@wilderrodrigues thanks for sharing the test reports, while I've not
personally tested. Looks good, please go ahead.
---
If your project is set up for it, you can
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/233#issuecomment-101584743
Hi @bhaisaab ,
Is that okay if I merge the PR? It's been here for 7 days and has been
tested.
Cheers,
Wilder
---
If your project is
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/233#issuecomment-101918061
@wilderrodrigues Sorry, I could not test the PR earlier. I see the
following issues while trying to bring up my KVM setup:
1. LibvirtUtilitiesHelper NPE.
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/233#issuecomment-101917044
---
Test set: com.cloud.hypervisor.kvm.resource.LibvirtComputingResourceTest
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/233#issuecomment-101902069
@wilderrodrigues build-master-jdk18 is failing in jenkins.
http://jenkins.buildacloud.org/job/build-master-jdk18/38/
It fails on the below test
Github user serverchief commented on the pull request:
https://github.com/apache/cloudstack/pull/233#issuecomment-101157780
@mlsorensen
I got the server xml worked out but it couldn't connect to the db, 'access
denied for cloud@localhost'
I've seen this before as well
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/233#issuecomment-101235811
@wilderrodrigues any update on this PR, if it's well tested, let's merge it?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/233#issuecomment-101284578
@bhaisaab @mlsorensen
I just sent the test report to your emails.
I'm fully confident with the changes and would like to suggest a merge
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/233#issuecomment-101236981
@bhaisaab
I'm testing since yesterday. My KVM environment is a bit slow, but all the
tests are going okay.
Please check the partial report
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/233#issuecomment-100880515
Hi @mlsorensen @bhaisaab
Did you guys have time to test this PR?
My KVM environment is up and running and I just started testing. I will
Unfortunately, no. It seems the upgrade from 4.5 to this branch in my dev
environment has left the management server unstartable, presumably due to
systemd changes. I now have a broken link in
/etc/rc5.d/S80cloudstack-management, and systemd complaining:
Process /usr/sbin/cloudstack-management
Github user mlsorensen commented on the pull request:
https://github.com/apache/cloudstack/pull/233#issuecomment-100995179
Yeah, I got past tomcat and other systemd switchover issues on 4.5 code,
but then ran into other issues. The mgmt server configs got all messed up by
the new
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/233#issuecomment-100981255
Okay but thanks a lot for start looking into it, @mlsorensen.
My env was a bit bumpy today and I did no manage to do all I had planned
for, but
, Nux Ro n...@li.nux.ro, Andrija
Panic andrija.pa...@gmail.com, Wido den Hollander w...@widodh.nl
Sent: Thursday, 7 May, 2015 08:24:15
Subject: Re: [GitHub] cloudstack pull request: Refactor/libvirt resource
this to explicitly invite them to look.
Op do 7 mei 2015 om 00:57 schreef mlsorensen g
this to explicitly invite them to look.
Op do 7 mei 2015 om 00:57 schreef mlsorensen g...@git.apache.org:
Github user mlsorensen commented on the pull request:
https://github.com/apache/cloudstack/pull/233#issuecomment-99635718
Yeah, I think this is a big enough change that we
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/233#issuecomment-99761689
Thanks, guys.
Would be really nice to test it ASAP so we avoid another rebase.
Most of the changes are purely structural, I tried my best to
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/233#issuecomment-99857670
Looks good, I guess Travis is sort of green (with on failing test due to
timeout). I will help test it tonight or tomorrow.
---
If your project is set up for it,
Github user K0zka commented on the pull request:
https://github.com/apache/cloudstack/pull/233#issuecomment-99825704
looks nice :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user K0zka commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/233#discussion_r29843511
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtRequestWrapper.java
---
@@ -0,0 +1,184 @@
+//
+// Licensed
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/233#issuecomment-99867216
Thanks, @bhaisaab and @K0zka :)
Yep, linbvirt is a typo. :( When I apply the annotations (after the
merge) I will rename it. :)
Cheers,
Github user mlsorensen commented on the pull request:
https://github.com/apache/cloudstack/pull/233#issuecomment-99635718
Yeah, I think this is a big enough change that we should give all KVM
stakeholders an opportunity to review and test before merge. At least the
committers, but
GitHub user wilderrodrigues opened a pull request:
https://github.com/apache/cloudstack/pull/233
Refactor/libvirt resource
This PR contains the refactor of the LibvirtComputingResource. The
motivation behind this effort is to increase maintainability and testability of
the code.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/233#issuecomment-99553213
Please, do not merge it before I test it with a KVM hypervisor.
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email
26 matches
Mail list logo
