Re: Review Request: Finalize componentContext.xml/nonComponentContext.xml content organization to be plugin friendly

2013-04-05 Thread Hugo Trippaers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10292/#review18696 --- client/tomcatconf/componentContext.xml.in

RE: Review Request: Finalize componentContext.xml/nonComponentContext.xml content organization to be plugin friendly

2013-04-05 Thread Hugo Trippaers
Hey Kelven, I commented on your patch on the review board. Can you modify the patch so all Nicira and MidoNet stuff is also in? I fixed master so you should be able to use that. Cheers, Hugo > -Original Message- > From: Kelven Yang [mailto:nore...@reviews.apache.org] On Behalf Of > Ke

Re: Review Request: Finalize componentContext.xml/nonComponentContext.xml content organization to be plugin friendly

2013-04-05 Thread Chip Childers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10292/#review18706 --- Kelven, I'll wait to hear that you've addressed the issues that Hug

Re: Review Request: Finalize componentContext.xml/nonComponentContext.xml content organization to be plugin friendly

2013-04-05 Thread Kelven Yang
For some reason, the diff in the ticket about your change does not show up Nicira, MidoNet Network Guru. On quick question to confirm, Nicira/MidoNet are supposed to be available in non-OSS build, is that correct? Kelven On 4/5/13 5:35 AM, "Hugo Trippaers" wrote: >Hey Kelven, > >I commented on

Re: Review Request: Finalize componentContext.xml/nonComponentContext.xml content organization to be plugin friendly

2013-04-05 Thread Kelven Yang
Never mind, I found it in master. Chip, I'll put another patch to the same review ticket. Kelven On 4/5/13 10:47 AM, "Kelven Yang" wrote: >For some reason, the diff in the ticket about your change does not show up >Nicira, MidoNet Network Guru. >On quick question to confirm, Nicira/MidoNet are

Re: Review Request: Finalize componentContext.xml/nonComponentContext.xml content organization to be plugin friendly

2013-04-05 Thread Chip Childers
On Fri, Apr 05, 2013 at 10:47:39AM -0700, Kelven Yang wrote: > For some reason, the diff in the ticket about your change does not show up > Nicira, MidoNet Network Guru. > On quick question to confirm, Nicira/MidoNet are supposed to be available > in non-OSS build, is that correct? IIRC they are n

RE: Review Request: Finalize componentContext.xml/nonComponentContext.xml content organization to be plugin friendly

2013-04-05 Thread Hugo Trippaers
g > Cc: Hugo Trippaers; 'dev@cloudstack.apache.org' > Subject: Re: Review Request: Finalize > componentContext.xml/nonComponentContext.xml content organization to > be plugin friendly > > On Fri, Apr 05, 2013 at 10:47:39AM -0700, Kelven Yang wrote: > > For some reason,

Re: Review Request: Finalize componentContext.xml/nonComponentContext.xml content organization to be plugin friendly

2013-04-05 Thread Kelven Yang
Chip, Please go ahead to apply my patch first. I couldn't find MidoNet Network Guru in 4.1 branch, I think it's better for Hugo to apply his fix on top of my patch on 4.1 directly Kelven On 4/5/13 11:25 AM, "Chip Childers" wrote: >On Fri, Apr 05, 2013 at 10:47:39AM -0700, Kelven Yang wrote: >>

RE: Review Request: Finalize componentContext.xml/nonComponentContext.xml content organization to be plugin friendly

2013-04-06 Thread Hugo Trippaers
ers, Hugo > -Original Message- > From: Kelven Yang [mailto:kelven.y...@citrix.com] > Sent: zaterdag 6 april 2013 1:00 > To: Chip Childers > Cc: Hugo Trippaers; 'dev@cloudstack.apache.org' > Subject: Re: Review Request: Finalize > componentContext.xml/nonComponen

Re: Review Request: Finalize componentContext.xml/nonComponentContext.xml content organization to be plugin friendly

2013-04-08 Thread Chip Childers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10292/#review18776 --- This appears to have already been applied to 4.1. - Chip Childers

Re: Review Request: Finalize componentContext.xml/nonComponentContext.xml content organization to be plugin friendly

2013-04-08 Thread Chip Childers
> > From: Kelven Yang [mailto:kelven.y...@citrix.com] > > Sent: zaterdag 6 april 2013 1:00 > > To: Chip Childers > > Cc: Hugo Trippaers; 'dev@cloudstack.apache.org' > > Subject: Re: Review Request: Finalize > > componentContext.xml/nonComponentContext.xml c