---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20099/#review79043
---
Thank you for submitting your CloudStack contribution through review
ate: Thursday, June 26, 2014 at 1:53 PM
>
> To: Alena Prokharchyk
> Cc: Kishan Kavala , "dev@cloudstack.apache.org"
> , Murali Reddy , Ram
> Ganesh , Animesh Chaturvedi <
> animesh.chaturv...@citrix.com>
> Subject: Re: Review Request 20099: Domain-Account-User Sy
esh Chaturvedi
Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple
Regions (Core Changes)
Kishan,
1. Why Long instead of Integer : You replied that it should be Integer
2. @Encrypt : Does it both encrypt & decrypt? Is there anything necessary to
make it work bec
gh
> Date: Thursday, June 26, 2014 at 1:53 PM
>
> To: Alena Prokharchyk
> Cc: Kishan Kavala , "dev@cloudstack.apache.org"
> , Murali Reddy , Ram
> Ganesh , Animesh Chaturvedi <
> animesh.chaturv...@citrix.com>
> Subject: Re: Review Request 20099: Domain-Ac
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20099/
---
(Updated June 27, 2014, 5:02 p.m.)
Review request for cloudstack.
Repository:
gt;> alena.prokharc...@citrix.com> wrote:
>>
>> > I did logic review according to the FS assuming that the FS (and the
>> > design described there) was approved on the [PROPOSAL] stage, BEFORE the
>> > code was put it to the review board. Was it approved at
’s questions, please go over the plugin design once again.
>>
>> Thank you,
>> Alena.
>>
>> From: Alex Ough
>> Date: Thursday, June 26, 2014 at 11:32 AM
>>
>> To: Alena Prokharchyk
>> Cc: Kishan Kavala , "dev@cloudstack.apache.org"
na.
> >
> > From: Alex Ough
> > Date: Thursday, June 26, 2014 at 1:53 PM
> >
> > To: Alena Prokharchyk
> > Cc: Kishan Kavala , "dev@cloudstack.apache.org"
>
> > , Murali Reddy ,
> Ram
> > Ganesh , Animesh Chaturvedi <
> > animesh
e
> guys who have more expertise in Regions.
>
>
>
> Kishan, please help to do the final review the Alex’s plugin design
> https://reviews.apache.org/r/17790
>
>
>
> Thank you,
>
> Alena.
>
> *From: *Alex Ough
> *Date: *Wednesday, June 25, 2014 at 9:03 PM
>
rg<mailto:dev@cloudstack.apache.org>"
mailto:dev@cloudstack.apache.org>>, Murali Reddy
mailto:murali.re...@citrix.com>>, Ram Ganesh
mailto:ram.gan...@citrix.com>>, Animesh Chaturvedi
mailto:animesh.chaturv...@citrix.com>>
Subject: Re: Review Request 20099: Doma
Alex,
You are correct. It should be Integer and not Long.
> -Original Message-
> From: Alex Ough [mailto:alex.o...@sungardas.com]
> Sent: Thursday, 26 June 2014 8:09 PM
> To: Kishan Kavala
> Cc: cloudstack
> Subject: Re: Review Request 20099: Domain-Account-User Sync U
> Date: Thursday, June 26, 2014 at 1:53 PM
>
> To: Alena Prokharchyk
> Cc: Kishan Kavala , "dev@cloudstack.apache.org"
> , Murali Reddy , Ram
> Ganesh , Animesh Chaturvedi <
> animesh.chaturv...@citrix.com>
> Subject: Re: Review Request 20099
M
>
> To: Alena Prokharchyk
> Cc: Kishan Kavala , "dev@cloudstack.apache.org"
> , Murali Reddy , Ram
> Ganesh , Animesh Chaturvedi <
> animesh.chaturv...@citrix.com>
> Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among
> Multiple Regions (Cor
to:murali.re...@citrix.com>>, Ram Ganesh
mailto:ram.gan...@citrix.com>>, Animesh Chaturvedi
mailto:animesh.chaturv...@citrix.com>>
Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple
Regions (Core Changes)
Alena,
Didn't you say that you guys already "
rg"
> , Murali Reddy , Ram
> Ganesh , Animesh Chaturvedi <
> animesh.chaturv...@citrix.com>
> Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among
> Multiple Regions (Core Changes)
>
> Alena,
>
> It has been reduced almost twice be
vedi
mailto:animesh.chaturv...@citrix.com>>
Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple
Regions (Core Changes)
Alena,
It has been reduced almost twice because a lot has been separated from the CS
and moved to the plug-in not because they are 'unnecessa
king Kishan/Murali to look at it to see if anything is missing or
>> incorrect in the final review, not to make you override or change
>> everything you've already put in.
>>
>> Thank you,
>> Alena.
>>
>> From: Alex Ough
>> Date: Wednesday, June 25, 2014
k.apache.org<mailto:dev@cloudstack.apache.org>"
mailto:dev@cloudstack.apache.org>>, Murali Reddy
mailto:murali.re...@citrix.com>>, Ram Ganesh
mailto:ram.gan...@citrix.com>>, Animesh Chaturvedi
mailto:animesh.chaturv...@citrix.com>>
Subject: Re: Review Request 20099: Domain-
Kishan,
The type of region id is Integer, not Long, so I'm wondering why it
should be Long.
Alex Ough
On Thu, Jun 26, 2014 at 2:08 AM, Kishan Kavala
wrote:
>This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20099/
>
> Alex,
> As discussed on the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20099/#review46720
---
engine/schema/src/org/apache/cloudstack/region/RegionVO.java
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20099/#review46719
---
Alex,
As discussed on the mailing list, ORIGINATEDREGIONUUID should
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20099/#review46718
---
Alex,
As discussed on the mailing list, ORIGINATEDREGIONUUID should
and point to the items that other reviewers
>> might have missed.
>>
>> Thank you,
>> Alena.
>>
>> From: Alex Ough
>> Date: Wednesday, June 25, 2014 at 6:33 PM
>> To: Alena Prokharchyk
>> Cc: Kishan Kavala , "dev@cloudstack.apache.org&quo
am Ganesh
mailto:ram.gan...@citrix.com>>, Animesh Chaturvedi
mailto:animesh.chaturv...@citrix.com>>
Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple
Regions (Core Changes)
Alena,
Don't get me wrong. What I'm saying is that it would have been better if you
oth of you, guys.
>>
>> Thanks,
>> Alena.
>> From: Alex Ough
>> Date: Wednesday, June 25, 2014 at 4:02 PM
>> To: Kishan Kavala
>> Cc: Alena Prokharchyk , "
>> dev@cloudstack.apache.org" , Murali Reddy <
>> murali.re...@citrix
k.apache.org>"
mailto:dev@cloudstack.apache.org>>, Murali Reddy
mailto:murali.re...@citrix.com>>, Ram Ganesh
mailto:ram.gan...@citrix.com>>, Animesh Chaturvedi
mailto:animesh.chaturv...@citrix.com>>
Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Mu
k/vpc/vm by name just because
>> its more human readable. The id is used by Api layer when parameter
>> validation is done, by lots of Dao methods (findById is one of them), etc.
>> Even look at updateRegion/deleteRegion – we don’t refer to them by name,
>> but by the id.
&g
>>, Murali Reddy
mailto:murali.re...@citrix.com>>, Ram Ganesh
mailto:ram.gan...@citrix.com>>, Animesh Chaturvedi
mailto:animesh.chaturv...@citrix.com>>
Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple
Regions (Core Changes)
Hi Alena,
Ca
leName);*
>
>
>
> *From:* Alex Ough [mailto:alex.o...@sungardas.com]
> *Sent:* Wednesday, 25 June 2014 4:31 PM
> *To:* Kishan Kavala
> *Cc:* Alena Prokharchyk; dev@cloudstack.apache.org; Murali Reddy; Ram
> Ganesh; Animesh Chaturvedi
>
> *Subject:* Re: Review Request 20099: Domain-Ac
Kavala
Cc: Alena Prokharchyk; dev@cloudstack.apache.org; Murali Reddy; Ram Ganesh;
Animesh Chaturvedi
Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple
Regions (Core Changes)
Thanks Kishan, but there seems to be lots of 'db.properties' files, so which
one
.o...@sungardas.com]
> *Sent:* Wednesday, 25 June 2014 8:18 AM
> *To:* Alena Prokharchyk
> *Cc:* dev@cloudstack.apache.org; Kishan Kavala; Murali Reddy; Ram Ganesh;
> Animesh Chaturvedi
>
> *Subject:* Re: Review Request 20099: Domain-Account-User Sync Up Among
> Multiple Regions (Core
: Wednesday, 25 June 2014 8:18 AM
To: Alena Prokharchyk
Cc: dev@cloudstack.apache.org; Kishan Kavala; Murali Reddy; Ram Ganesh; Animesh
Chaturvedi
Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple
Regions (Core Changes)
There is one thing that was not mentioned, which is
*Using addRegion API, add region 1 to region 2 and also region 2 to
>>> region 1.*
>>>
>>>
>>> I assume that we expect the admin to add the region with the same name
>>> and the same id to ALL regions Dbs (both id and name should be passed to
>>> createRe
y, June 24, 2014 at 5:41 PM
>
> To: Alena Prokharchyk
> Cc: "dev@cloudstack.apache.org" , Kishan
> Kavala , Murali Reddy ,
> Ram Ganesh , Animesh Chaturvedi <
> animesh.chaturv...@citrix.com>
> Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among
&
t;>, Murali Reddy
mailto:murali.re...@citrix.com>>, Ram Ganesh
mailto:ram.gan...@citrix.com>>, Animesh Chaturvedi
mailto:animesh.chaturv...@citrix.com>>
Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple
Regions (Core Changes)
What I'm trying t
ted in other region’s Dbs – by
>> its id that is unique across the regions. Kishan/Murali, please confirm.
>>
>> Thank you,
>> Alena.
>>
>> From: Alex Ough
>> Date: Tuesday, June 24, 2014 at 4:22 PM
>> To: "dev@cloudstack.apache.org"
>&g
API:
http://localhost:8096/?command=listRegions
1
Local
http://localhost:8080/client/
true
false
Please correct if I miss something.
-Alena.
From: Alex Ough mailto:alex.o...@sungardas.com>>
Date: Tuesday, June 24, 2014 at 2:33 PM
To: Alena Prokharchyk
mailto:alena.prokharc...@citrix.
t;, Murali Reddy , Ram
> Ganesh , Animesh Chaturvedi <
> animesh.chaturv...@citrix.com>
>
> Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among
> Multiple Regions (Core Changes)
>
> All,
>
> There is one open question in this topic, which is to fi
che.org/r/17790/diff/?page=1#0 as well as refer to this
email thread for the context.
-Alena.
From: Alena Prokharchyk
mailto:alena.prokharc...@citrix.com>>
Date: Tuesday, June 24, 2014 at 2:54 PM
To: Alex Ough mailto:alex.o...@sungardas.com>>
Subject: Re: Review Request 20099: Do
ons. I’ve reviewed the rest of
> the feature, just this one item is open. See my latest comment to the
> https://reviews.apache.org/r/17790/diff/?page=1#0 as well as refer to
> this email thread for the context.
>
>
>
> -Alena.
>
>
>
> *From: *Alena Prokharchyk
>
>, Kishan
Kavala mailto:kishan.kav...@citrix.com>>, Murali
Reddy mailto:murali.re...@citrix.com>>
Cc: Animesh Chaturvedi
mailto:animesh.chaturv...@citrix.com>>, Ram
Ganesh mailto:ram.gan...@citrix.com>>
Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Mult
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20099/#review46557
---
Alex, one small thing.
Just noticed that in the API commands you pa
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20099/
---
(Updated June 24, 2014, 3:54 p.m.)
Review request for cloudstack.
Changes
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20099/
---
(Updated June 20, 2014, 3:06 p.m.)
Review request for cloudstack.
Changes
---
> On June 17, 2014, 5:06 p.m., Alena Prokharchyk wrote:
> > One more comment regarding spring-server-core-managers-context.xml. As your
> > code comes as a CS plugin, all the managers of your plugin should be
> > defined in your plugin's *-context.xml file, not
> > spring-server-core-managers-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20099/#review45955
---
One more comment regarding spring-server-core-managers-context.xml.
On 6/16/14, 4:13 PM, "Alex Ough" wrote:
>On Mon, Jun 16, 2014 at 7:07 PM, Alena Prokharchyk <
>alena.prokharc...@citrix.com> wrote:
>
>>
>> ---
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/
On Mon, Jun 16, 2014 at 7:07 PM, Alena Prokharchyk <
alena.prokharc...@citrix.com> wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20099/#review45853
> --
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20099/#review45853
---
Alex,
* add "since=version" attribute to all new parameters you've
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20099/
---
(Updated June 15, 2014, 9:40 p.m.)
Review request for cloudstack.
Changes
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20099/
---
(Updated May 7, 2014, 10:47 p.m.)
Review request for cloudstack.
Repository:
> On May 5, 2014, 6:27 p.m., Alena Prokharchyk wrote:
> > Alex, generic logic looks good to me. But still some things need to be
> > fixed.
> >
> > 1) RegionVO
> >
> > @Column(name = "active")
> > private boolean active;
> >
> > Explicitly set it to be active by default. Just setting it i
> On May 5, 2014, 6:27 p.m., Alena Prokharchyk wrote:
> > Alex, generic logic looks good to me. But still some things need to be
> > fixed.
> >
> > 1) RegionVO
> >
> > @Column(name = "active")
> > private boolean active;
> >
> > Explicitly set it to be active by default. Just setting it i
> On May 5, 2014, 6:27 p.m., Alena Prokharchyk wrote:
> > Alex, generic logic looks good to me. But still some things need to be
> > fixed.
> >
> > 1) RegionVO
> >
> > @Column(name = "active")
> > private boolean active;
> >
> > Explicitly set it to be active by default. Just setting it i
> On May 5, 2014, 6:27 p.m., Alena Prokharchyk wrote:
> > Alex, generic logic looks good to me. But still some things need to be
> > fixed.
> >
> > 1) RegionVO
> >
> > @Column(name = "active")
> > private boolean active;
> >
> > Explicitly set it to be active by default. Just setting it i
> On May 5, 2014, 6:27 p.m., Alena Prokharchyk wrote:
> > Alex, generic logic looks good to me. But still some things need to be
> > fixed.
> >
> > 1) RegionVO
> >
> > @Column(name = "active")
> > private boolean active;
> >
> > Explicitly set it to be active by default. Just setting it i
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20099/#review42175
---
Alex, generic logic looks good to me. But still some things need to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20099/
---
(Updated May 4, 2014, 9:12 p.m.)
Review request for cloudstack.
Changes
-
What is your timezone?
Can we have it tomorrow morning?
On Mon, Apr 28, 2014 at 3:19 PM, Alena Prokharchyk <
alena.prokharc...@citrix.com> wrote:
> We can discuss it today at 3pm, Alex, if the time works for you. WebEx is
> fine, but we should make sure to record the session + share follow up
>
We can discuss it today at 3pm, Alex, if the time works for you. WebEx is
fine, but we should make sure to record the session + share follow up
notes with the community. The best approach would be - to update the FS
with the design changes for this particular part of the code.
Will be waiting for
what do have any web conferencing app?
If not, we can use the webex.
Let me know what time is convenient for you.
On Mon, Apr 28, 2014 at 1:46 PM, Alena Prokharchyk <
alena.prokharc...@citrix.com> wrote:
> Alex, that is totally up to you. I'm ready to review/talk any time.
>
> -alena.
>
> On 4/2
Alex, that is totally up to you. I’m ready to review/talk any time.
-alena.
On 4/28/14, 10:35 AM, "Alex Ough" wrote:
>when & how do you want to have it?
>
>
>On Mon, Apr 28, 2014 at 1:18 PM, Alena Prokharchyk <
>alena.prokharc...@citrix.com> wrote:
>
>> Alex, please see the answers inline. May
when & how do you want to have it?
On Mon, Apr 28, 2014 at 1:18 PM, Alena Prokharchyk <
alena.prokharc...@citrix.com> wrote:
> Alex, please see the answers inline. May be it would be a good idea if we
> discuss the high level architecture - what DB changes you are going to
> make, how CS apis wo
Alex, please see the answers inline. May be it would be a good idea if we
discuss the high level architecture - what DB changes you are going to
make, how CS apis would or wouldn¹t get affected - before you do the
coding? It would definitely save us time, and won¹t lead to further
frustration. I¹m
> On April 17, 2014, 8:10 p.m., Alena Prokharchyk wrote:
> > 1) Alex, I don't quite approve the fact that the responses were modified
> > just to support your feature. User/account of region1 has absolutely no
> > idea of syncing that your plugin is doing as well as he has 0 idea that it
> > e
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20099/#review40690
---
1) Alex, I don't quite approve the fact that the responses were modi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20099/
---
(Updated April 16, 2014, 7:06 p.m.)
Review request for cloudstack.
Changes
--
dified/removed
>> >> get modified directly - from the very start, and only by reviewing
>>the
>> >>review board ticket you could see it. Hopefully the next time the
>> >>experience will be more smooth for both parties. Meanwhile I¹m ready
>>to
>> >&g
gt;Make sure your component injects the global config variable if you decide
> >>to make a switch via global config. For that, your class has to implement
> >>Configurable interface. You can
> >> find examples of how this interface is utilized by existing CS
> >>
/confluence/display/CLOUDSTACK/Configuration
>>
>>
>>For #1 I don¹t think you need to keep track of Removed date times. Once
>>the removed field is set in Region1, its safe to just go ahead and remove
>>the entry in all the rest of the regions. You can¹t (and don¹t need to)
>>per
ed to keep track of Removed date times. Once
> >the removed field is set in Region1, its safe to just go ahead and remove
> >the entry in all the rest of the regions. You can¹t (and don¹t need to)
> >perform any other operation on the
> > resource if its removed in one of t
;
>The one way I can think of you can create a helper table where you
>store the ref UUID->Region->UpdatedTime stamps for all Local/Remote
>regions, and you update/compare those fields. Your component is a
>business logic component, and it shouldn¹t modify
> the fields ori
e where you
>> store the ref UUID->Region->UpdatedTime stamps for all Local/Remote
>> regions, and you update/compare those fields. Your component is a business
>> logic component, and it shouldn't modify the fields originally set by
>> GenericDao (Removed/Creat
dstack.apache.org<mailto:dev@cloudstack.apache.org>"
mailto:dev@cloudstack.apache.org>>, Alex Huang
mailto:alex.hu...@citrix.com>>
Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple
Regions (Core Changes)
Alena,
It would be really nice if I had th
coming through the APIs.
>
> -Alena.
>
> From: Alex Ough
> Date: Monday, April 7, 2014 at 9:16 PM
> To: "dev@cloudstack.apache.org" , Alena
> Prokharchyk , Alex Huang <
> alex.hu...@citrix.com>
> Subject: Re: Review Request 20099: Domain-Account-User Sync
.com>>, Alex Huang
mailto:alex.hu...@citrix.com>>
Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple
Regions (Core Changes)
And all 4 of the recommendations Alex Hwang gave were already implemented to
support the real time synchronization (#1),
but like I
And all 4 of the recommendations Alex Hwang gave were already implemented
to support the real time synchronization (#1),
but like I said in the previous email, we need to support the full scan
(#2) to cover any failures during the synchronization.
Thanks
Alex Ough
On Tue, Apr 8, 2014 at 12:10 A
Alena/Alex,
I think I need to give some explanation how this works.
There are 2 ways of sync.
1. The real time sync : Whenever a resource is create/updated/removed, each
region gets the event of that and requests the same job to all remote
regions using API interfaces, which will create/update/r
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20099/#review39753
---
Alex, just discussed your changes to existing CS code
(Account/Dom
yes, that is correct.
On Mon, Apr 7, 2014 at 3:27 PM, Alena Prokharchyk <
alena.prokharc...@citrix.com> wrote:
> Alex, one more question. Is this patch meant to be a part of master branch
> only (4.5)? I guess so as your changes affect 4.4-4.5 db upgrade path.
>
> Please confirm,
> Alena.
>
> On
Alex, one more question. Is this patch meant to be a part of master branch
only (4.5)? I guess so as your changes affect 4.4-4.5 db upgrade path.
Please confirm,
Alena.
On 4/7/14, 12:13 PM, "Alex Ough" wrote:
>
>---
>This is an automatical
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20099/
---
(Updated April 7, 2014, 7:13 p.m.)
Review request for cloudstack.
Changes
---
82 matches
Mail list logo