Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2015-04-06 Thread Sebastien Goasguen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20099/#review79043 --- Thank you for submitting your CloudStack contribution through review

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-07-03 Thread John Burwell
ate: Thursday, June 26, 2014 at 1:53 PM > > To: Alena Prokharchyk > Cc: Kishan Kavala , "dev@cloudstack.apache.org" > , Murali Reddy , Ram > Ganesh , Animesh Chaturvedi < > animesh.chaturv...@citrix.com> > Subject: Re: Review Request 20099: Domain-Account-User Sy

RE: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-29 Thread Kishan Kavala
esh Chaturvedi Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes) Kishan, 1. Why Long instead of Integer : You replied that it should be Integer 2. @Encrypt : Does it both encrypt & decrypt? Is there anything necessary to make it work bec

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-27 Thread John Burwell
gh > Date: Thursday, June 26, 2014 at 1:53 PM > > To: Alena Prokharchyk > Cc: Kishan Kavala , "dev@cloudstack.apache.org" > , Murali Reddy , Ram > Ganesh , Animesh Chaturvedi < > animesh.chaturv...@citrix.com> > Subject: Re: Review Request 20099: Domain-Ac

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-27 Thread Alex Ough
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20099/ --- (Updated June 27, 2014, 5:02 p.m.) Review request for cloudstack. Repository:

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-27 Thread Alex Ough
gt;> alena.prokharc...@citrix.com> wrote: >> >> > I did logic review according to the FS assuming that the FS (and the >> > design described there) was approved on the [PROPOSAL] stage, BEFORE the >> > code was put it to the review board. Was it approved at

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-27 Thread John Burwell
’s questions, please go over the plugin design once again. >> >> Thank you, >> Alena. >> >> From: Alex Ough >> Date: Thursday, June 26, 2014 at 11:32 AM >> >> To: Alena Prokharchyk >> Cc: Kishan Kavala , "dev@cloudstack.apache.org"

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-27 Thread Alex Ough
na. > > > > From: Alex Ough > > Date: Thursday, June 26, 2014 at 1:53 PM > > > > To: Alena Prokharchyk > > Cc: Kishan Kavala , "dev@cloudstack.apache.org" > > > , Murali Reddy , > Ram > > Ganesh , Animesh Chaturvedi < > > animesh

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-27 Thread Alex Ough
e > guys who have more expertise in Regions. > > > > Kishan, please help to do the final review the Alex’s plugin design > https://reviews.apache.org/r/17790 > > > > Thank you, > > Alena. > > *From: *Alex Ough > *Date: *Wednesday, June 25, 2014 at 9:03 PM >

RE: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-27 Thread Kishan Kavala
rg<mailto:dev@cloudstack.apache.org>" mailto:dev@cloudstack.apache.org>>, Murali Reddy mailto:murali.re...@citrix.com>>, Ram Ganesh mailto:ram.gan...@citrix.com>>, Animesh Chaturvedi mailto:animesh.chaturv...@citrix.com>> Subject: Re: Review Request 20099: Doma

RE: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-26 Thread Kishan Kavala
Alex, You are correct. It should be Integer and not Long. > -Original Message- > From: Alex Ough [mailto:alex.o...@sungardas.com] > Sent: Thursday, 26 June 2014 8:09 PM > To: Kishan Kavala > Cc: cloudstack > Subject: Re: Review Request 20099: Domain-Account-User Sync U

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-26 Thread John Burwell
> Date: Thursday, June 26, 2014 at 1:53 PM > > To: Alena Prokharchyk > Cc: Kishan Kavala , "dev@cloudstack.apache.org" > , Murali Reddy , Ram > Ganesh , Animesh Chaturvedi < > animesh.chaturv...@citrix.com> > Subject: Re: Review Request 20099

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-26 Thread Alex Ough
M > > To: Alena Prokharchyk > Cc: Kishan Kavala , "dev@cloudstack.apache.org" > , Murali Reddy , Ram > Ganesh , Animesh Chaturvedi < > animesh.chaturv...@citrix.com> > Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among > Multiple Regions (Cor

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-26 Thread Alena Prokharchyk
to:murali.re...@citrix.com>>, Ram Ganesh mailto:ram.gan...@citrix.com>>, Animesh Chaturvedi mailto:animesh.chaturv...@citrix.com>> Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes) Alena, Didn't you say that you guys already "

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-26 Thread Alex Ough
rg" > , Murali Reddy , Ram > Ganesh , Animesh Chaturvedi < > animesh.chaturv...@citrix.com> > Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among > Multiple Regions (Core Changes) > > Alena, > > It has been reduced almost twice be

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-26 Thread Alena Prokharchyk
vedi mailto:animesh.chaturv...@citrix.com>> Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes) Alena, It has been reduced almost twice because a lot has been separated from the CS and moved to the plug-in not because they are 'unnecessa

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-26 Thread Alex Ough
king Kishan/Murali to look at it to see if anything is missing or >> incorrect in the final review, not to make you override or change >> everything you've already put in. >> >> Thank you, >> Alena. >> >> From: Alex Ough >> Date: Wednesday, June 25, 2014

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-26 Thread Alena Prokharchyk
k.apache.org<mailto:dev@cloudstack.apache.org>" mailto:dev@cloudstack.apache.org>>, Murali Reddy mailto:murali.re...@citrix.com>>, Ram Ganesh mailto:ram.gan...@citrix.com>>, Animesh Chaturvedi mailto:animesh.chaturv...@citrix.com>> Subject: Re: Review Request 20099: Domain-

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-26 Thread Alex Ough
Kishan, The type of region id is Integer, not Long, so I'm wondering why it should be Long. Alex Ough On Thu, Jun 26, 2014 at 2:08 AM, Kishan Kavala wrote: >This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20099/ > > Alex, > As discussed on the

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-25 Thread Kishan Kavala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20099/#review46720 --- engine/schema/src/org/apache/cloudstack/region/RegionVO.java

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-25 Thread Kishan Kavala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20099/#review46719 --- Alex, As discussed on the mailing list, ORIGINATEDREGIONUUID should

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-25 Thread Kishan Kavala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20099/#review46718 --- Alex, As discussed on the mailing list, ORIGINATEDREGIONUUID should

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-25 Thread Alex Ough
and point to the items that other reviewers >> might have missed. >> >> Thank you, >> Alena. >> >> From: Alex Ough >> Date: Wednesday, June 25, 2014 at 6:33 PM >> To: Alena Prokharchyk >> Cc: Kishan Kavala , "dev@cloudstack.apache.org&quo

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-25 Thread Alena Prokharchyk
am Ganesh mailto:ram.gan...@citrix.com>>, Animesh Chaturvedi mailto:animesh.chaturv...@citrix.com>> Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes) Alena, Don't get me wrong. What I'm saying is that it would have been better if you

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-25 Thread Alex Ough
oth of you, guys. >> >> Thanks, >> Alena. >> From: Alex Ough >> Date: Wednesday, June 25, 2014 at 4:02 PM >> To: Kishan Kavala >> Cc: Alena Prokharchyk , " >> dev@cloudstack.apache.org" , Murali Reddy < >> murali.re...@citrix

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-25 Thread Alena Prokharchyk
k.apache.org>" mailto:dev@cloudstack.apache.org>>, Murali Reddy mailto:murali.re...@citrix.com>>, Ram Ganesh mailto:ram.gan...@citrix.com>>, Animesh Chaturvedi mailto:animesh.chaturv...@citrix.com>> Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Mu

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-25 Thread Alex Ough
k/vpc/vm by name just because >> its more human readable. The id is used by Api layer when parameter >> validation is done, by lots of Dao methods (findById is one of them), etc. >> Even look at updateRegion/deleteRegion – we don’t refer to them by name, >> but by the id. &g

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-25 Thread Alena Prokharchyk
>>, Murali Reddy mailto:murali.re...@citrix.com>>, Ram Ganesh mailto:ram.gan...@citrix.com>>, Animesh Chaturvedi mailto:animesh.chaturv...@citrix.com>> Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes) Hi Alena, Ca

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-25 Thread Alex Ough
leName);* > > > > *From:* Alex Ough [mailto:alex.o...@sungardas.com] > *Sent:* Wednesday, 25 June 2014 4:31 PM > *To:* Kishan Kavala > *Cc:* Alena Prokharchyk; dev@cloudstack.apache.org; Murali Reddy; Ram > Ganesh; Animesh Chaturvedi > > *Subject:* Re: Review Request 20099: Domain-Ac

RE: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-25 Thread Kishan Kavala
Kavala Cc: Alena Prokharchyk; dev@cloudstack.apache.org; Murali Reddy; Ram Ganesh; Animesh Chaturvedi Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes) Thanks Kishan, but there seems to be lots of 'db.properties' files, so which one

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-25 Thread Alex Ough
.o...@sungardas.com] > *Sent:* Wednesday, 25 June 2014 8:18 AM > *To:* Alena Prokharchyk > *Cc:* dev@cloudstack.apache.org; Kishan Kavala; Murali Reddy; Ram Ganesh; > Animesh Chaturvedi > > *Subject:* Re: Review Request 20099: Domain-Account-User Sync Up Among > Multiple Regions (Core

RE: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-24 Thread Kishan Kavala
: Wednesday, 25 June 2014 8:18 AM To: Alena Prokharchyk Cc: dev@cloudstack.apache.org; Kishan Kavala; Murali Reddy; Ram Ganesh; Animesh Chaturvedi Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes) There is one thing that was not mentioned, which is

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-24 Thread Alex Ough
*Using addRegion API, add region 1 to region 2 and also region 2 to >>> region 1.* >>> >>> >>> I assume that we expect the admin to add the region with the same name >>> and the same id to ALL regions Dbs (both id and name should be passed to >>> createRe

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-24 Thread Alex Ough
y, June 24, 2014 at 5:41 PM > > To: Alena Prokharchyk > Cc: "dev@cloudstack.apache.org" , Kishan > Kavala , Murali Reddy , > Ram Ganesh , Animesh Chaturvedi < > animesh.chaturv...@citrix.com> > Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among &

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-24 Thread Alena Prokharchyk
t;>, Murali Reddy mailto:murali.re...@citrix.com>>, Ram Ganesh mailto:ram.gan...@citrix.com>>, Animesh Chaturvedi mailto:animesh.chaturv...@citrix.com>> Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes) What I'm trying t

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-24 Thread Alex Ough
ted in other region’s Dbs – by >> its id that is unique across the regions. Kishan/Murali, please confirm. >> >> Thank you, >> Alena. >> >> From: Alex Ough >> Date: Tuesday, June 24, 2014 at 4:22 PM >> To: "dev@cloudstack.apache.org" >&g

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-24 Thread Alena Prokharchyk
API: http://localhost:8096/?command=listRegions 1 Local http://localhost:8080/client/ true false Please correct if I miss something. -Alena. From: Alex Ough mailto:alex.o...@sungardas.com>> Date: Tuesday, June 24, 2014 at 2:33 PM To: Alena Prokharchyk mailto:alena.prokharc...@citrix.

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-24 Thread Alex Ough
t;, Murali Reddy , Ram > Ganesh , Animesh Chaturvedi < > animesh.chaturv...@citrix.com> > > Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among > Multiple Regions (Core Changes) > > All, > > There is one open question in this topic, which is to fi

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-24 Thread Alena Prokharchyk
che.org/r/17790/diff/?page=1#0 as well as refer to this email thread for the context. -Alena. From: Alena Prokharchyk mailto:alena.prokharc...@citrix.com>> Date: Tuesday, June 24, 2014 at 2:54 PM To: Alex Ough mailto:alex.o...@sungardas.com>> Subject: Re: Review Request 20099: Do

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-24 Thread Alex Ough
ons. I’ve reviewed the rest of > the feature, just this one item is open. See my latest comment to the > https://reviews.apache.org/r/17790/diff/?page=1#0 as well as refer to > this email thread for the context. > > > > -Alena. > > > > *From: *Alena Prokharchyk >

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-24 Thread Alena Prokharchyk
>, Kishan Kavala mailto:kishan.kav...@citrix.com>>, Murali Reddy mailto:murali.re...@citrix.com>> Cc: Animesh Chaturvedi mailto:animesh.chaturv...@citrix.com>>, Ram Ganesh mailto:ram.gan...@citrix.com>> Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Mult

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-24 Thread Alena Prokharchyk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20099/#review46557 --- Alex, one small thing. Just noticed that in the API commands you pa

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-24 Thread Alex Ough
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20099/ --- (Updated June 24, 2014, 3:54 p.m.) Review request for cloudstack. Changes ---

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-20 Thread Alex Ough
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20099/ --- (Updated June 20, 2014, 3:06 p.m.) Review request for cloudstack. Changes ---

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-18 Thread Alex Ough
> On June 17, 2014, 5:06 p.m., Alena Prokharchyk wrote: > > One more comment regarding spring-server-core-managers-context.xml. As your > > code comes as a CS plugin, all the managers of your plugin should be > > defined in your plugin's *-context.xml file, not > > spring-server-core-managers-

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-17 Thread Alena Prokharchyk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20099/#review45955 --- One more comment regarding spring-server-core-managers-context.xml.

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-16 Thread Alena Prokharchyk
On 6/16/14, 4:13 PM, "Alex Ough" wrote: >On Mon, Jun 16, 2014 at 7:07 PM, Alena Prokharchyk < >alena.prokharc...@citrix.com> wrote: > >> >> --- >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.apache.org/r/

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-16 Thread Alex Ough
On Mon, Jun 16, 2014 at 7:07 PM, Alena Prokharchyk < alena.prokharc...@citrix.com> wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20099/#review45853 > --

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-16 Thread Alena Prokharchyk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20099/#review45853 --- Alex, * add "since=version" attribute to all new parameters you've

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-15 Thread Alex Ough
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20099/ --- (Updated June 15, 2014, 9:40 p.m.) Review request for cloudstack. Changes ---

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-05-11 Thread Alex Ough
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20099/ --- (Updated May 7, 2014, 10:47 p.m.) Review request for cloudstack. Repository:

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-05-05 Thread Alena Prokharchyk
> On May 5, 2014, 6:27 p.m., Alena Prokharchyk wrote: > > Alex, generic logic looks good to me. But still some things need to be > > fixed. > > > > 1) RegionVO > > > > @Column(name = "active") > > private boolean active; > > > > Explicitly set it to be active by default. Just setting it i

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-05-05 Thread Alena Prokharchyk
> On May 5, 2014, 6:27 p.m., Alena Prokharchyk wrote: > > Alex, generic logic looks good to me. But still some things need to be > > fixed. > > > > 1) RegionVO > > > > @Column(name = "active") > > private boolean active; > > > > Explicitly set it to be active by default. Just setting it i

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-05-05 Thread Alex Ough
> On May 5, 2014, 6:27 p.m., Alena Prokharchyk wrote: > > Alex, generic logic looks good to me. But still some things need to be > > fixed. > > > > 1) RegionVO > > > > @Column(name = "active") > > private boolean active; > > > > Explicitly set it to be active by default. Just setting it i

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-05-05 Thread Alena Prokharchyk
> On May 5, 2014, 6:27 p.m., Alena Prokharchyk wrote: > > Alex, generic logic looks good to me. But still some things need to be > > fixed. > > > > 1) RegionVO > > > > @Column(name = "active") > > private boolean active; > > > > Explicitly set it to be active by default. Just setting it i

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-05-05 Thread Alex Ough
> On May 5, 2014, 6:27 p.m., Alena Prokharchyk wrote: > > Alex, generic logic looks good to me. But still some things need to be > > fixed. > > > > 1) RegionVO > > > > @Column(name = "active") > > private boolean active; > > > > Explicitly set it to be active by default. Just setting it i

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-05-05 Thread Alena Prokharchyk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20099/#review42175 --- Alex, generic logic looks good to me. But still some things need to

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-05-04 Thread Alex Ough
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20099/ --- (Updated May 4, 2014, 9:12 p.m.) Review request for cloudstack. Changes -

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-04-28 Thread Alex Ough
What is your timezone? Can we have it tomorrow morning? On Mon, Apr 28, 2014 at 3:19 PM, Alena Prokharchyk < alena.prokharc...@citrix.com> wrote: > We can discuss it today at 3pm, Alex, if the time works for you. WebEx is > fine, but we should make sure to record the session + share follow up >

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-04-28 Thread Alena Prokharchyk
We can discuss it today at 3pm, Alex, if the time works for you. WebEx is fine, but we should make sure to record the session + share follow up notes with the community. The best approach would be - to update the FS with the design changes for this particular part of the code. Will be waiting for

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-04-28 Thread Alex Ough
what do have any web conferencing app? If not, we can use the webex. Let me know what time is convenient for you. On Mon, Apr 28, 2014 at 1:46 PM, Alena Prokharchyk < alena.prokharc...@citrix.com> wrote: > Alex, that is totally up to you. I'm ready to review/talk any time. > > -alena. > > On 4/2

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-04-28 Thread Alena Prokharchyk
Alex, that is totally up to you. I’m ready to review/talk any time. -alena. On 4/28/14, 10:35 AM, "Alex Ough" wrote: >when & how do you want to have it? > > >On Mon, Apr 28, 2014 at 1:18 PM, Alena Prokharchyk < >alena.prokharc...@citrix.com> wrote: > >> Alex, please see the answers inline. May

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-04-28 Thread Alex Ough
when & how do you want to have it? On Mon, Apr 28, 2014 at 1:18 PM, Alena Prokharchyk < alena.prokharc...@citrix.com> wrote: > Alex, please see the answers inline. May be it would be a good idea if we > discuss the high level architecture - what DB changes you are going to > make, how CS apis wo

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-04-28 Thread Alena Prokharchyk
Alex, please see the answers inline. May be it would be a good idea if we discuss the high level architecture - what DB changes you are going to make, how CS apis would or wouldn¹t get affected - before you do the coding? It would definitely save us time, and won¹t lead to further frustration. I¹m

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-04-28 Thread Alex Ough
> On April 17, 2014, 8:10 p.m., Alena Prokharchyk wrote: > > 1) Alex, I don't quite approve the fact that the responses were modified > > just to support your feature. User/account of region1 has absolutely no > > idea of syncing that your plugin is doing as well as he has 0 idea that it > > e

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-04-17 Thread Alena Prokharchyk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20099/#review40690 --- 1) Alex, I don't quite approve the fact that the responses were modi

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-04-16 Thread Alex Ough
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20099/ --- (Updated April 16, 2014, 7:06 p.m.) Review request for cloudstack. Changes --

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-04-08 Thread Alena Prokharchyk
dified/removed >> >> get modified directly - from the very start, and only by reviewing >>the >> >>review board ticket you could see it. Hopefully the next time the >> >>experience will be more smooth for both parties. Meanwhile I¹m ready >>to >> >&g

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-04-08 Thread Alex Ough
gt;Make sure your component injects the global config variable if you decide > >>to make a switch via global config. For that, your class has to implement > >>Configurable interface. You can > >> find examples of how this interface is utilized by existing CS > >>

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-04-08 Thread Alena Prokharchyk
/confluence/display/CLOUDSTACK/Configuration >> >> >>For #1 ­ I don¹t think you need to keep track of Removed date times. Once >>the removed field is set in Region1, its safe to just go ahead and remove >>the entry in all the rest of the regions. You can¹t (and don¹t need to) >>per

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-04-08 Thread Alex Ough
ed to keep track of Removed date times. Once > >the removed field is set in Region1, its safe to just go ahead and remove > >the entry in all the rest of the regions. You can¹t (and don¹t need to) > >perform any other operation on the > > resource if its removed in one of t

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-04-08 Thread Alena Prokharchyk
; >The one way I can think of ­ you can create a helper table where you >store the ref UUID->Region->UpdatedTime stamps for all Local/Remote >regions, and you update/compare those fields. Your component is a >business logic component, and it shouldn¹t modify > the fields ori

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-04-08 Thread Alex Ough
e where you >> store the ref UUID->Region->UpdatedTime stamps for all Local/Remote >> regions, and you update/compare those fields. Your component is a business >> logic component, and it shouldn't modify the fields originally set by >> GenericDao (Removed/Creat

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-04-08 Thread Alena Prokharchyk
dstack.apache.org<mailto:dev@cloudstack.apache.org>" mailto:dev@cloudstack.apache.org>>, Alex Huang mailto:alex.hu...@citrix.com>> Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes) Alena, It would be really nice if I had th

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-04-08 Thread Alex Ough
coming through the APIs. > > -Alena. > > From: Alex Ough > Date: Monday, April 7, 2014 at 9:16 PM > To: "dev@cloudstack.apache.org" , Alena > Prokharchyk , Alex Huang < > alex.hu...@citrix.com> > Subject: Re: Review Request 20099: Domain-Account-User Sync

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-04-08 Thread Alena Prokharchyk
.com>>, Alex Huang mailto:alex.hu...@citrix.com>> Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes) And all 4 of the recommendations Alex Hwang gave were already implemented to support the real time synchronization (#1), but like I

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-04-07 Thread Alex Ough
And all 4 of the recommendations Alex Hwang gave were already implemented to support the real time synchronization (#1), but like I said in the previous email, we need to support the full scan (#2) to cover any failures during the synchronization. Thanks Alex Ough On Tue, Apr 8, 2014 at 12:10 A

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-04-07 Thread Alex Ough
Alena/Alex, I think I need to give some explanation how this works. There are 2 ways of sync. 1. The real time sync : Whenever a resource is create/updated/removed, each region gets the event of that and requests the same job to all remote regions using API interfaces, which will create/update/r

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-04-07 Thread Alena Prokharchyk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20099/#review39753 --- Alex, just discussed your changes to existing CS code (Account/Dom

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-04-07 Thread Alex Ough
yes, that is correct. On Mon, Apr 7, 2014 at 3:27 PM, Alena Prokharchyk < alena.prokharc...@citrix.com> wrote: > Alex, one more question. Is this patch meant to be a part of master branch > only (4.5)? I guess so as your changes affect 4.4-4.5 db upgrade path. > > Please confirm, > Alena. > > On

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-04-07 Thread Alena Prokharchyk
Alex, one more question. Is this patch meant to be a part of master branch only (4.5)? I guess so as your changes affect 4.4-4.5 db upgrade path. Please confirm, Alena. On 4/7/14, 12:13 PM, "Alex Ough" wrote: > >--- >This is an automatical

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-04-07 Thread Alex Ough
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20099/ --- (Updated April 7, 2014, 7:13 p.m.) Review request for cloudstack. Changes ---