Re: Review Request: Automation: CPU limits tests from Resource Limits Tests

2013-05-27 Thread Prasanna Santhanam
> On April 29, 2013, 8:30 a.m., Prasanna Santhanam wrote: > > test/integration/component/test_cpu_limits.py, line 405 > > > > > > Should these utility methods be included in every test class? Can we > > not include th

Re: Review Request: Automation: CPU limits tests from Resource Limits Tests

2013-05-27 Thread Gaurav Aradhye
> On April 29, 2013, 8:30 a.m., Prasanna Santhanam wrote: > > test/integration/component/test_cpu_limits.py, line 405 > > > > > > Should these utility methods be included in every test class? Can we > > not include th

Re: Review Request: Automation: CPU limits tests from Resource Limits Tests

2013-05-27 Thread Gaurav Aradhye
> On April 29, 2013, 8:30 a.m., Prasanna Santhanam wrote: > > test/integration/component/test_cpu_limits.py, line 417 > > > > > > method name doesn't reflect intent. you are doing a checkResourceCount > > but doing an

Re: Review Request: Automation: CPU limits tests from Resource Limits Tests

2013-05-27 Thread Gaurav Aradhye
> On April 29, 2013, 8:30 a.m., Prasanna Santhanam wrote: > > test/integration/component/test_cpu_limits.py, line 527 > > > > > > There's some confusion I have here: > > > > 1. you are using the apiClient of t

Re: Review Request: Automation: CPU limits tests from Resource Limits Tests

2013-05-27 Thread Prasanna Santhanam
> On April 29, 2013, 8:30 a.m., Prasanna Santhanam wrote: > > test/integration/component/test_cpu_limits.py, line 527 > > > > > > There's some confusion I have here: > > > > 1. you are using the apiClient of t

Re: Review Request: Automation: CPU limits tests from Resource Limits Tests

2013-05-27 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10828/#review21051 --- test/integration/component/test_cpu_limits.py

Re: Review Request: Automation: CPU limits tests from Resource Limits Tests

2013-05-27 Thread Gaurav Aradhye
> On April 29, 2013, 8:30 a.m., Prasanna Santhanam wrote: > > test/integration/component/test_cpu_limits.py, line 186 > > > > > > `delete` is not handled? Hi Prasanna, Can you please elaborate this? Delete condition s

Re: Review Request: Automation: CPU limits tests from Resource Limits Tests

2013-04-29 Thread sailaja mada
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10828/#review19861 --- test/integration/component/test_cpu_limits.py

Re: Review Request: Automation: CPU limits tests from Resource Limits Tests

2013-04-29 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10828/ --- (Updated April 29, 2013, 8:36 a.m.) Review request for cloudstack, Prasanna San

Re: Review Request: Automation: CPU limits tests from Resource Limits Tests

2013-04-29 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10828/#review19846 --- test/integration/component/test_cpu_limits.py

Re: Review Request: Automation: CPU limits tests from Resource Limits Tests

2013-04-28 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10828/#review19844 --- test/integration/component/test_cpu_limits.py

Review Request: Automation: CPU limits tests from Resource Limits Tests

2013-04-28 Thread Chirag Jog
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10828/ --- Review request for cloudstack, Prasanna Santhanam and Girish Shilamkar. Descrip